Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded tests for lib/utils/queries.dart #2184

Merged
merged 7 commits into from
Dec 1, 2023

Conversation

cmaustQA
Copy link
Contributor

What kind of change does this PR introduce?
added test for updateUserProfile() in lib/utils/queries.dart, achieving 100% coverage for this file

Issue Number:

Fixes #2166

Did you add tests for your changes?
N/A

Snapshots/Videos:
image

If relevant, did you update the documentation?
N/A

Summary
Added test for updateUserProfile() in lib/utils/queries.dart to achieve 100% coverage for this file

Does this PR introduce a breaking change?
No

Other information
N/A

Have you read the contributing guide?
Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d0ebc5d) 79.90% compared to head (91e9fc8) 79.92%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2184      +/-   ##
===========================================
+ Coverage    79.90%   79.92%   +0.01%     
===========================================
  Files          149      149              
  Lines         6973     6973              
===========================================
+ Hits          5572     5573       +1     
+ Misses        1401     1400       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palisadoes palisadoes merged commit 004b014 into PalisadoesFoundation:develop Dec 1, 2023
7 checks passed
palisadoes pushed a commit to palisadoes/talawa that referenced this pull request Jan 10, 2024
* Update queries_test.dart

* Revert "Update queries_test.dart"

This reverts commit c455d60.

* Revert "Revert "Update queries_test.dart""

This reverts commit 659845d.

* Update queries_test.dart

* correcting formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for lib/utils/queries.dart
3 participants