-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
firebase_messaging updated from 14.7.3 to 14.7.4 #2123
firebase_messaging updated from 14.7.3 to 14.7.4 #2123
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2123 +/- ##
========================================
Coverage 77.29% 77.29%
========================================
Files 152 152
Lines 7456 7456
========================================
Hits 5763 5763
Misses 1693 1693 ☔ View full report in Codecov by Sentry. |
2476f3f
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
This PR updates firebase_messaging package from 14.7.3 to 14.7.4
Issue Number:
Fixed: #2097
Did you add tests for your changes?
No addtional test was required.
Summary
in issue #2097 , it was asked to upgrade the firebase_messaging package to the latest version (14.7.4) . So after cloning the project and getting all dependencies, I upgraded the required package.
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes