-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2098 Fix:Overflow Error on PostWideget #2104
Fixes #2098 Fix:Overflow Error on PostWideget #2104
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
@AyushRaghuvanshi Please fix the failing test. |
…into overflowError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reduce the size of like and comment icon as per screen size.
Ohkay working on it. |
Thanks. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2104 +/- ##
===========================================
+ Coverage 76.43% 76.94% +0.51%
===========================================
Files 152 152
Lines 7438 7456 +18
===========================================
+ Hits 5685 5737 +52
+ Misses 1753 1719 -34 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
…lisadoesFoundation#2104) * Fix:Overflow Error on PostWideget * Remove:Unused Hive Boxes * Fix:Responsiveness on Icons
What kind of change does this PR introduce?
Previously Post Widget was showing overflow error on phones with smaller width. This PR makes the Post Widget Dynamic. so that it is compatible with all the phone sizes
Issue Number:
Fixes #2098
Did you add tests for your changes?
No, There was no need
Snapshots/Videos:
Previously
Now
Does this PR introduce a breaking change?
No,
Have you read the contributing guide?
Yes