-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification Related Implementation Removed #2089
Notification Related Implementation Removed #2089
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
Please complete the checks @andoriyaprashant |
Codecov Report
@@ Coverage Diff @@
## develop #2089 +/- ##
========================================
Coverage 76.39% 76.39%
========================================
Files 152 152
Lines 7442 7442
========================================
Hits 5685 5685
Misses 1757 1757 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Done @Ayush0Chaudhary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ayush0Chaudhary Is there anything else that needs to be commented?
@Ayush0Chaudhary Please have a look. |
* Notification Related Implementation Removed * Dart formatting changes * Analyzing talawa * login_view_model file fixed * Dart formatting changes * Gitub workflow * unauthorized file changes * app_setting_page_test.dart * Update app_setting_page_test.dart * Update app_setting_page_test.dart file
What kind of change does this PR introduce?
Issue Number:
Fixes #2086
Did you add tests for your changes?
Summary
This pull request addresses the removal of notification-related logic in the app to make it compatible with the MVP phase.
Have you read the contributing guide?