Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Related Implementation Removed #2089

Merged
merged 10 commits into from
Nov 17, 2023

Conversation

andoriyaprashant
Copy link
Contributor

What kind of change does this PR introduce?

  • Notification Related Implementation Removed

Issue Number:

Fixes #2086

Did you add tests for your changes?

  • Yes

Summary

This pull request addresses the removal of notification-related logic in the app to make it compatible with the MVP phase.

Have you read the contributing guide?

  • Yes

Copy link

github-actions bot commented Nov 7, 2023

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

@Ayush0Chaudhary
Copy link
Contributor

Please complete the checks @andoriyaprashant

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #2089 (bb69a9a) into develop (e9b0103) will not change coverage.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2089   +/-   ##
========================================
  Coverage    76.39%   76.39%           
========================================
  Files          152      152           
  Lines         7442     7442           
========================================
  Hits          5685     5685           
  Misses        1757     1757           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@andoriyaprashant
Copy link
Contributor Author

Please complete the checks @andoriyaprashant

Done @Ayush0Chaudhary

Copy link
Member

@noman2002 noman2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ayush0Chaudhary Is there anything else that needs to be commented?

@noman2002
Copy link
Member

@Ayush0Chaudhary Please have a look.

@palisadoes palisadoes merged commit f3fd1ae into PalisadoesFoundation:develop Nov 17, 2023
7 checks passed
palisadoes pushed a commit to palisadoes/talawa that referenced this pull request Jan 10, 2024
* Notification Related Implementation Removed

* Dart formatting changes

* Analyzing talawa

* login_view_model file fixed

* Dart formatting changes

* Gitub workflow

* unauthorized file changes

* app_setting_page_test.dart

* Update app_setting_page_test.dart

* Update app_setting_page_test.dart file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Remove notification related implementation
4 participants