Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keys and encryption #2027

Merged
merged 10 commits into from
Oct 2, 2023
Merged

Keys and encryption #2027

merged 10 commits into from
Oct 2, 2023

Conversation

literalEval
Copy link
Member

@literalEval literalEval commented Sep 22, 2023 •
edited
Loading

Issue Number
Fixes: #2032

What kind of change does this PR introduce?

Increases functionality of the Encryptor class to:

  1. Generate Keys
  2. Store Keys
  3. Encrypt / Decrypt messages with keys.
  4. Upgrade packages in talawa_lint package.

Moreover

  1. Some previous PRs have introduced changes without documentation, which is causing workflow checks to fail. I have added ignore statements to those files and expect the original author to write documentations.
  2. Flutter migration to latest version had caused talawa_lint to fail. It has been fixed in this PR.

Did you add tests for your changes?

Not yet. Will be added later.

@github-actions
Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

@literalEval
Copy link
Member Author

@noman2002 @palisadoes

@noman2002
Copy link
Member

@literalEval There is no issue linked to this PR.

@literalEval
Copy link
Member Author

I've not created issues for GSoC related work. Do I need to create one ?

@noman2002
Copy link
Member

Yes, every PR needs to have an issue linked to it.

@noman2002
Copy link
Member

@literalEval Also create issues for documentation of left over files. so that we can have a track of which files are left.

@literalEval
Copy link
Member Author

@noman2002 opened the issue. Please approve.

@literalEval literalEval mentioned this pull request Sep 27, 2023
Closed
@literalEval
Copy link
Member Author

@noman2002 @nishnatadebnath @palisadoes please merge so that we don't face merge conflicts; and I can open new PRs. Thanks.

nishnatadebnath
nishnatadebnath approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@nishnatadebnath nishnatadebnath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @palisadoes @noman2002

@palisadoes
Copy link
Contributor

@literalEval Please fix the failing tests. We need the automated documentation.

@literalEval
Copy link
Member Author

@palisadoes @Ayush0Chaudhary is writing tests for the files he has created/changed in his new PRs. I've already documented mine's.

Please merge this PR.

@palisadoes palisadoes merged commit 4ac38dc into PalisadoesFoundation:develop Oct 2, 2023
palisadoes pushed a commit to palisadoes/talawa that referenced this pull request Jan 10, 2024
@literalEval
Keys and encryption (PalisadoesFoundation#2027)
821d587 
* add crypto package and password encryption

* add doc for Encryptor class

* merge with develop

* add key generation

* write docs and suppress some warnings

* fix formatting of lib/views/pre_auth_screens/login.dart
@literalEval literalEval deleted the keys_and_encryption branch January 22, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishnatadebnath nishnatadebnath nishnatadebnath approved these changes

@palisadoes palisadoes palisadoes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GSoC] Implement Key Generation and Storage
4 participants
@literalEval @noman2002 @palisadoes @nishnatadebnath