Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: ViewModel should not have code for View. #2303

Closed
Abhisheksainii opened this issue Jan 2, 2024 · 6 comments · Fixed by #2306
Closed

Bug Report: ViewModel should not have code for View. #2303

Abhisheksainii opened this issue Jan 2, 2024 · 6 comments · Fixed by #2306
Assignees
Labels
bug Something isn't working feature request

Comments

@Abhisheksainii
Copy link
Contributor

Describe the bug
The logout dialog has not called as before. The profile page view model contains the code for profile view (the logout one). It needs to be moved to the respective widget's page. View model should not have code for view.

To Reproduce
Steps to reproduce the behavior:

  1. Go to profile_page_view_model.dart file
  2. You would see logout function on line no. 90

Expected behavior
Move the logout code to somewhere in the profile page

Actual behavior
The profile page view model contains the code for logout.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional details
Add any other context or screenshots about the feature request here.

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship #359

@Abhisheksainii Abhisheksainii added the bug Something isn't working label Jan 2, 2024
Copy link

github-actions bot commented Jan 2, 2024

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@AVtheking
Copy link
Contributor

I would Like to work on this issue please assign me

@Dante291
Copy link
Contributor

Dante291 commented Jan 3, 2024

@Abhisheksainii Are you gonna work on this? If not I would like work on this

@Dante291
Copy link
Contributor

Dante291 commented Jan 3, 2024

@noman2002 @Cioppolo14 @Kevoniat please assign me this, its a quick fix

@Abhisheksainii
Copy link
Contributor Author

Anyone of you can work on this

@Kevoniat
Copy link

Kevoniat commented Jan 4, 2024

@Dante291 assigned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants