Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action Required for Translation Files #2242

Closed
palisadoes opened this issue Dec 12, 2023 · 12 comments · Fixed by #2275 or #2281
Closed

GitHub Action Required for Translation Files #2242

palisadoes opened this issue Dec 12, 2023 · 12 comments · Fixed by #2275 or #2281
Assignees
Labels

Comments

@palisadoes
Copy link
Contributor

We need to create a GitHub action that during the PR process checks all the translation files to make sure that there are translations in all the non-default languages for each English default language entry.

As part of the PR for this issue, all the translations must be correctly present

  • NOTE: Please watch this video on how to proceed.
    Click me to start video
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Dec 12, 2023
@Dante291
Copy link
Contributor

@palisadoes I can work on this.

@ibishal
Copy link

ibishal commented Dec 12, 2023

can i try this?

@Dante291
Copy link
Contributor

Also I just checked there are so many words that should be manually added into these translation files of different languages, because currently the text in talawaErrorDialogBox, Snackbar etc. show text in default language even though when different language is selected.

This will require testing of correct translation of words through out the app, I'm planning to add this testing and adding of the words to ensure that translation works properly throughout the app in this issue only.

Or should I just focus on only this issue and later add these parts by making new issue?

@noman2002 noman2002 removed the unapproved Unapproved, needs to be triaged label Dec 13, 2023
@noman2002
Copy link
Member

@Dante291 Assigned to @ibishal as he is new here, let him work on this one. If he is not able to do it then I'll assign it to you. Also you can help him in the slack if anything.

@Dante291
Copy link
Contributor

@Dante291 Assigned to @ibishal as he is new here, let him work on this one. If he is not able to do it then I'll assign it to you. Also you can help him in the slack if anything.

Roger that sir.

@Dante291
Copy link
Contributor

@ibishal are you still working on this?

@ibishal ibishal removed their assignment Dec 22, 2023
@Dante291
Copy link
Contributor

@noman2002 i could work on this now

@Cioppolo14
Copy link
Contributor

@Dante291 Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

@rahularora27
Copy link

Can I work on this?

@AVtheking
Copy link
Contributor

Can I work on this ?

@rahularora27 rahularora27 removed their assignment Dec 25, 2023
@AVtheking
Copy link
Contributor

hi the video link you have provided has no video ,please provide correct link

@palisadoes
Copy link
Contributor Author

  1. Please resubmit an updated PR for this issue where you specify the directory to be checked using ArgParse. That way we can use it with other repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants