Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the documentation with a new figma file #718

Merged
merged 3 commits into from
Dec 26, 2023

Conversation

aashimawadhwa
Copy link
Member

What kind of change does this PR introduce?
updated the documentation with the new figma file

Issue Number:

Fixes #695

Did you add tests for your changes?
not required

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests and there are no merge conflicts.

The process helps maintain accurate and well-formatted documentation and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

@aashimawadhwa
Copy link
Member Author

@palisadoes @noman2002 @tasneemkoushar please look into it and merge it.

@palisadoes
Copy link
Contributor

@aashimawadhwa merge with the latest upstream. I think that will fix the errors

@aashimawadhwa
Copy link
Member Author

aashimawadhwa commented Dec 25, 2023

@aashimawadhwa merge with the latest upstream. I think that will fix the errors

I am already up to date.

@palisadoes
Copy link
Contributor

palisadoes commented Dec 25, 2023

It's because of our upgrade to Docusaurus v3 and our Admin documentation workflow doesn't support the new markdown standard

  1. Run this command in the root directory
    1. npx docusaurus-mdx-checker
  2. Then add a \ character in front of every <, >, } and } to every reported file. It's about 30 files. I'll send you a spreadsheet to make it faster
  3. We have an issue to fix this.
    1. Fix Documention Workflow - Talawa-Admin talawa-admin#1279

@palisadoes palisadoes merged commit 0a9778e into develop Dec 26, 2023
2 of 3 checks passed
@palisadoes palisadoes deleted the Updated_Figma_Designs branch December 29, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants