Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Twitter Logo #682

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Changing Twitter Logo #682

merged 1 commit into from
Oct 23, 2023

Conversation

DhairyaMajmudar
Copy link
Contributor

Changing the old Twitter bird logo to its new twitter X logo

Bug Report: Request to Update Twitter Icon to X #676

Fixes #676

Did you add tests for your changes?
NO

Snapshots/Videos:

Before
image

After
image

If relevant, did you update the documentation?

Summary

Twitter's old bird logo is changed to its new X logo in the footer section of the website.

Does this PR introduce a breaking change?
NO

Other information

Have you read the contributing guide?
YES

@github-actions
Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests and there are no merge conflicts.

The process helps maintain accurate and well-formatted documentation and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

@DhairyaMajmudar
Copy link
Contributor Author

@palisadoes pls. review my PR and merge in the codebase.

@palisadoes palisadoes merged commit f05f979 into PalisadoesFoundation:develop Oct 23, 2023
2 of 3 checks passed
@DhairyaMajmudar
Copy link
Contributor Author

DhairyaMajmudar commented Oct 24, 2023

Thank you @palisadoes for merging my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Request to Update Twitter Icon to X
2 participants