Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongoose upgraded to v8.2.0 #1972

Closed
wants to merge 5 commits into from
Closed

Mongoose upgraded to v8.2.0 #1972

wants to merge 5 commits into from

Conversation

gautam-divyanshu
Copy link
Member

@gautam-divyanshu gautam-divyanshu commented Mar 10, 2024

Mongoose upgraded to version v8.2.0 from v5.13.21

Fixes: #1695

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@gautam-divyanshu
Copy link
Member Author

@palisadoes eslint errors and warnings removed, please take a look

@palisadoes
Copy link
Contributor

Create the small one line for this issue PR as requested before. As this is your first PR in the repo we have to manually approve running every GitHub action after every one of your commits. This is time consuming and therefore causes delays.

By creating the small PR and merging it, this PR will not have to be manually run each time.

Please create the other PR now

@gautam-divyanshu
Copy link
Member Author

@palisadoes like this

image

It's my first time , so I am not getting it properly

@palisadoes
Copy link
Contributor

  1. Create another API PR, some minor change. Use the same issue number
  2. Leave this one open

@palisadoes
Copy link
Contributor

  1. Please create a brand new PR with only one file in it. A minor file change for example
  2. We will merge it to prevent us having to manually activate the GitHub action's with each of your commits on this one.

@palisadoes
Copy link
Contributor

  1. Please also close this PR and use a branch name that doesn't match that of the target branch
  2. We won't be able to checkout the local branch from the PR to verify your changes otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants