Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: linting using changed-files gh action #1799

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

NamitBhutani
Copy link
Contributor

What kind of change does this PR introduce?

Issue Number:

Fixes #1548

Did you add tests for your changes?

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?

Copy link

github-actions bot commented Feb 5, 2024

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@NamitBhutani
Copy link
Contributor Author

@palisadoes this method works, but we should wait for a bit before merging so that we are able to check against all changes to develop branch, them being - 1, someone else's commits getting merged in develop
2. Me merging updated develop in this branch

@palisadoes
Copy link
Contributor

The files in this PR will not be applied to other PRs until this PR is merged.

I don't understand why we need to wait

@NamitBhutani
Copy link
Contributor Author

The files in this PR will not be applied to other PRs until this PR is merged.

I don't understand why we need to wait

I wanted to wait so that we can test out all cases to prevent errors like before happening yet again.
But I guess it would be faster to recognise errors that way then, let's merge it then!

@palisadoes
Copy link
Contributor

Please fix the failing test before I merge

@NamitBhutani
Copy link
Contributor Author

Please fix the failing test before I merge

That failing test is the one I made on purpose, I just removed space from one of the files, I didn't change any code there.

@palisadoes
Copy link
Contributor

Please fix it, so that we can see whether it passes as part of the approval process for the merge.

@palisadoes palisadoes merged commit e69119f into PalisadoesFoundation:develop Feb 6, 2024
7 of 9 checks passed
@NamitBhutani
Copy link
Contributor Author

Please fix it, so that we can see whether it passes as part of the approval process for the merge.

Extremely sorry! I had gone to bed, rest assured those changes will not change how the api works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants