-
-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: linting using changed-files gh action #1799
feat: linting using changed-files gh action #1799
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
@palisadoes this method works, but we should wait for a bit before merging so that we are able to check against all changes to develop branch, them being - 1, someone else's commits getting merged in develop |
The files in this PR will not be applied to other PRs until this PR is merged. I don't understand why we need to wait |
I wanted to wait so that we can test out all cases to prevent errors like before happening yet again. |
Please fix the failing test before I merge |
That failing test is the one I made on purpose, I just removed space from one of the files, I didn't change any code there. |
Please fix it, so that we can see whether it passes as part of the approval process for the merge. |
Extremely sorry! I had gone to bed, rest assured those changes will not change how the api works. |
What kind of change does this PR introduce?
Issue Number:
Fixes #1548
Did you add tests for your changes?
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?