Lint only updated files with stricter linting

[NamitBhutani]

What kind of change does this PR introduce?

Feature

Issue Number:

Fixes #1548

Did you add tests for your changes?

No

If relevant, did you update the documentation?

No

Summary

Run linting only for changed files for each commit and introduce stronger linting rules to slowly improve code integrity.

Does this PR introduce a breaking change?

No

Have you read the contributing guide?

Yes

[github-actions]

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

1. The overall code coverage drops below the target threshold of the repository
2. Any file in the pull request has code coverage levels below the repository threshold
3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

1. comments in this PR or
2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

1. arbitrators of future discussions with other contributors about the validity of your changes
2. point of contact for evaluating the validity of your work
3. person who verifies matching issues by others that should be closed.
4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

1. PRs with issues not assigned to you will be closed by the reviewer
2. Fix the first comment in the PR so that each issue listed automatically closes

Other

1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
2. Read the CONTRIBUTING.md file make

[palisadoes]

@NamitBhutani

1. Please fix the conflicting files.
2. This will greatly help the consistence of our code and is long overdue.

[xoldd]

@palisadoes as i understand the problem is that there are lint issues in codebase, but turning lint rules from warn to error would result in too many errors at once.

if i'm correct in my assumption then the best way to deal with this would be to ignore all the codebase files in eslintrc.json file and then create many smaller issues to resolve the lint issues in a particular directory/file

each PR associated to a particular issue would remove the corresponding directory/file from the list of files eslint is ignoring and fix the lint issues within that directory/file

there isn't a need to make it per file as that would create too many atomic issues, instead directory based approach is better, assign a contributor to fix lint issues in a directory, remove the directory from eslint's ignore list and make a PR to be merged

eventually all the ignored codebase files would be removed from eslint's ignore list, after that the PR workflows can simply detect new lint issues and error out if they are found

[palisadoes]

@xoldyckk

We were trying the incremental linting approach and it was too difficult to manage.

This will just lint files committed in the local repo of the developer.

We already have a GitHub action to lint files submitted in the PR as a verifier

[palisadoes]

@NamitBhutani Please fix the failing tests

[palisadoes]

@EshaanAgg Your thoughts on this will be helpful too

[EshaanAgg]

Please refer to this PR.

[NamitBhutani]

@NamitBhutani Please fix the failing tests

I think one of the tests will fail, because I have to edit eslintrc.json and .husky/pre-commit which come under unauthorized changes.
I have hopefully fixed the other failing test.

[NamitBhutani]

The lockfile got messed up, extremely sorry for that, I have pushed a new commit that should hopefully fix it, if it does not I'll make another pull request and close this one.

[palisadoes]

Don't create another PR. Only use this one.

[NamitBhutani]

Don't create another PR. Only use this one.

I think all the issues have been fixed! The lint errors are due to the change in eslintrc.

[palisadoes]

Are the linting errors expected for only this PR and will work satisfactorily from the CLI?

[NamitBhutani]

Are the linting errors expected for only this PR and will work satisfactorily from the CLI?

Yes, they will! as in the workflow, lint check is ran for every file, that's why there are errors.