-
-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix md_mpx_format_adjuster.py script #1594
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- See comment.
- Have you discovered why this workflow isn't' communicating with Talawa Docs? We'll need to know fairly certainly that this will work before we deploy it.
Please work with @noman2002 on this. He'll be taking over the review of this PR |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1594 +/- ##
===========================================
- Coverage 98.17% 97.45% -0.73%
===========================================
Files 184 214 +30
Lines 10767 12949 +2182
Branches 835 1042 +207
===========================================
+ Hits 10571 12620 +2049
- Misses 186 299 +113
- Partials 10 30 +20 ☔ View full report in Codecov by Sentry. |
@Nitya-Pasrija Please be aware of this PR |
Please fix the conflicting file |
On it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- See comment
- Have you determined whether the API workflow is updating the Talawa-Docs repository?
INSTALLATION.md
Outdated
@@ -6,42 +6,46 @@ This document provides instructions on how to set up and start a running instanc | |||
|
|||
<!-- TOC --> | |||
|
|||
- [Talawa-API Installation](#talawa-api-installation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file must not be included in this PR
Please fix the conflicting files |
|
I've changed destination_branch to |
Please reach out to Noman on Slack to schedule a time over the weekend for both of you to troubleshoot this. He's very busy during the week. Both of you are in the same time zone so it will be easier to fix it quickly. Try to get both related PRs solved and merged. |
Okay, thanks |
|
Yes, I messaged him on slack waiting for his reply |
Till now I would like to contribute to other issues, can you assign them to me? |
I've assigned the original issue to myself |
This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work. |
What kind of change does this PR introduce?
npm
for bothtalawa-api
andtalawa-admin
.md_mpx_format_adjuster.py
) to ensure Markdown files are MPX compatible.Issue Number: #1559
Did you add tests for your changes?
If relevant, did you update the documentation?
script.py
.Summary
script.py
for Typedoc-generated Markdown files.Does this PR introduce a breaking change?
Have you read the contributing guide?