BugFixes : Fixed Minor Bugs on Advertisement Page and Advertisement Post Cards

[yugal07]

What kind of change does this PR introduce?

Fixes Multiple bugs

Issue Number:

Fixes #3253

Snapshots/Videos:

If relevant, did you update the documentation?

No

Summary

1. Added MUI Components instead of basic react form components so that they can match the theme
2. added styling for the close button
3. Added padding in the completed campaigns section
4. Added proper spacing instead of camel cased "endOfResult"

Does this PR introduce a breaking change?

No

Checklist

CodeRabbit AI Review

• I have reviewed and addressed all critical issues flagged by CodeRabbit AI
• I have implemented or provided justification for each non-critical suggestion
• I have documented my reasoning in the PR comments where CodeRabbit AI suggestions were not implemented

Test Coverage

• I have written tests for all new changes/features
• I have verified that test coverage meets or exceeds 95%
• I have run the test suite locally and all tests pass

Have you read the contributing guide?

Yes

Summary by CodeRabbit

Release Notes

• New Features

  • Enhanced advertisement registration interface with improved date and type selection
  • Added Material-UI components for more interactive form controls

• UI/UX Improvements

  • Refined styling for close buttons, select dropdowns, and date inputs
  • Improved visual consistency across advertisement management components
  • Added hover and focus effects for better user interaction

• Translation

  • Updated translation handling for end-of-results messages

The updates provide a more intuitive and visually appealing experience for managing advertisements.

[coderabbitai]

Walkthrough

The pull request introduces improvements to the Advertisements component by enhancing the user interface and styling. The changes focus on updating the AdvertisementRegister component with Material-UI components like DatePicker and Select, replacing traditional form elements. The CSS styles have been refined to improve visual consistency, particularly for buttons, select boxes, and date inputs. The modifications aim to address layout inconsistencies and improve the overall user experience of the advertisement registration and display process.

Changes

File	Change Summary
src/components/Advertisements/Advertisements.tsx	- Added className for "archievedAds" with "pt-4 m-2" styling - Updated translation context for end message from t() to tCommon()
src/components/Advertisements/core/AdvertisementRegister/AdvertisementRegister.tsx	- Added Material-UI imports (DatePicker, Select, etc.) - Replaced Form.Select with Select and FormControl - Implemented DatePicker for start and end dates with date constraints
src/style/app.module.css	- Updated .closeButtonAdvertisementRegister styling - Added .selectboxAdvertisementRegister for select components - Added .dateboxAdvertisementRegister for date inputs

Assessment against linked issues

Objective	Addressed	Explanation
Consistent padding	✅
Proper close button styling	✅
Theme-matching form elements	✅
Improved visual alignment	✅

Possibly related PRs

• Plugin and advertisement screen revamp #2006: Changes to translation context for advertisements
• BugFix : Fixed Overflow of images in Advertisement and Venue Post modals #3204: Styling improvements for modal components

Suggested labels

ignore-sensitive-files-pr

Suggested reviewers

• palisadoes
• rishav-jha-mech

Poem

🐰 Hop, hop, through code so bright,
Material UI takes flight!
Dates and selects, now refined,
User experience redesigned!
A rabbit's touch of pixel delight 🎨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 018155d and af1d993.

📒 Files selected for processing (3)

• src/components/Advertisements/Advertisements.tsx (2 hunks)
• src/components/Advertisements/core/AdvertisementRegister/AdvertisementRegister.tsx (2 hunks)
• src/style/app.module.css (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Test Application
• GitHub Check: Analyse Code With CodeQL (javascript)

🔇 Additional comments (6)

src/components/Advertisements/Advertisements.tsx (1)

226-226: LGTM! Translation function update looks good.

The change from t('endOfResults') to tCommon('endOfResults') ensures consistent translation context usage.

src/components/Advertisements/core/AdvertisementRegister/AdvertisementRegister.tsx (2)

363-381: LGTM! Material-UI Select component implementation looks good.

The Form.Select replacement with Material-UI's Select component:

• Maintains theme consistency
• Provides better user experience with proper labeling
• Includes proper value handling and type safety

---

385-417: LGTM! DatePicker implementation with validation looks good.

The DatePicker components include:

• Proper date validation ensuring end date is not before start date
• Consistent theme styling
• Clear labeling and error handling

src/style/app.module.css (3)

5121-5155: LGTM! Enhanced close button styling with proper interactions.

The close button styling improvements include:

• Clear visual feedback with hover and focus states
• Smooth transitions for interactions
• Proper contrast for accessibility

---

5167-5206: LGTM! Select component styling maintains theme consistency.

The Material-UI Select styling:

• Matches the application's theme
• Includes proper hover and focus states
• Maintains visual hierarchy with proper spacing

---

5212-5237: LGTM! DatePicker styling ensures consistent theme.

The DatePicker styling:

• Matches the Material-UI theme
• Includes proper input area styling
• Maintains icon color consistency

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Our Pull Request Approval Process

Thanks for contributing!

Testing Your Code

Remember, your PRs won't be reviewed until these criteria are met:

1. We don't merge PRs with poor code quality.
   1. Follow coding best practices such that CodeRabbit.ai approves your PR.
2. We don't merge PRs with failed tests.
   1. When tests fail, click on the Details link to learn more.
   2. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
   3. Tests may fail if you edit sensitive files. Ask to add the ignore-sensitive-files-pr label if the edits are necessary.
3. We cannot merge PRs with conflicting files. These must be fixed.

Our policies make our code better.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

1. comments in this PR or
2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

1. arbitrators of future discussions with other contributors about the validity of your changes
2. point of contact for evaluating the validity of your work
3. person who verifies matching issues by others that should be closed.
4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

1. PRs with issues not assigned to you will be closed by the reviewer
2. Fix the first comment in the PR so that each issue listed automatically closes

Other

1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
2. Read the CONTRIBUTING.md file make