[NoMongo] : Restore the GraphQL Introspection GitHub Action Test (Fixes #3235) #3250
Conversation
WalkthroughThe pull request activates the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/pull-request.yml(1 hunks)
🧰 Additional context used
🪛 yamllint (1.35.1)
.github/workflows/pull-request.yml
[error] 306-306: trailing spaces
(trailing-spaces)
[error] 312-312: trailing spaces
(trailing-spaces)
[error] 314-314: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Test Application
- GitHub Check: Analyse Code With CodeQL (javascript)
🔇 Additional comments (1)
.github/workflows/pull-request.yml (1)
291-294: LGTM! Job definition is clear and well-structured.The job definition follows the workflow conventions and has appropriate conditions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #3250 +/- ##
=====================================================
+ Coverage 10.74% 90.17% +79.43%
=====================================================
Files 309 330 +21
Lines 7802 8491 +689
Branches 1729 1934 +205
=====================================================
+ Hits 838 7657 +6819
+ Misses 6900 604 -6296
- Partials 64 230 +166 ☔ View full report in Codecov by Sentry. |
|
@coderabbitai resolve |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/pull-request.yml (1)
306-306: Remove trailing spaces.There are trailing spaces on lines 306, 312, and 318 that should be removed for consistent formatting.
Also applies to: 312-312, 318-318
🧰 Tools
🪛 yamllint (1.35.1)
[error] 306-306: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/pull-request.yml(1 hunks)package.json(1 hunks)
🧰 Additional context used
🪛 yamllint (1.35.1)
.github/workflows/pull-request.yml
[error] 306-306: trailing spaces
(trailing-spaces)
[error] 312-312: trailing spaces
(trailing-spaces)
[error] 318-318: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Test Application
- GitHub Check: Analyse Code With CodeQL (javascript)
🔇 Additional comments (5)
package.json (1)
116-116: LGTM! Implementation of local @graphql-inspector/cli package.The addition of
@graphql-inspector/clias a local dev dependency aligns with best practices for CI/CD environments..github/workflows/pull-request.yml (4)
291-294: LGTM! Well-structured job configuration.The job is properly configured with:
- Appropriate condition to exclude dependabot
- Clear descriptive name
- Correct runner specification
299-302: LGTM! Appropriate Node.js version selection.Using Node.js 20.x LTS version aligns with the package.json requirements while ensuring better stability.
307-322: LGTM! Robust error handling for repository cloning.The implementation includes proper error handling for:
- Branch existence verification
- Clone operation failure
- Clear error messages
🧰 Tools
🪛 yamllint (1.35.1)
[error] 312-312: trailing spaces
(trailing-spaces)
[error] 318-318: trailing spaces
(trailing-spaces)
324-335: LGTM! Comprehensive document validation with proper error handling.The validation step includes thorough checks for:
- schema.graphql file existence
- GraphQL TypeScript files presence
- Clear error messaging
✅ Actions performedComments resolved and changes approved. |
|
@palisadoes review |
palisadoes
changed the title
palisadoes
added
the
ignore-sensitive-files-pr
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/pull-request.yml (1)
307-322: Remove trailing spaces.The cloning logic is robust with proper error handling, but there are trailing spaces that should be removed.
Apply this diff to fix the formatting:
- name: Clone API Repository run: | # Retrieve the complete branch name directly from the GitHub context FULL_BRANCH_NAME=${{ github.base_ref }} echo "FULL_BRANCH_NAME: $FULL_BRANCH_NAME" - + # Clone the specified repository using the extracted branch name if ! git ls-remote --heads https://github.com/PalisadoesFoundation/talawa-api.git $FULL_BRANCH_NAME | grep -q .; then echo "Error: Branch $FULL_BRANCH_NAME does not exist in talawa-api repository" exit 1 fi - + if ! git clone --branch $FULL_BRANCH_NAME --depth 1 https://github.com/PalisadoesFoundation/talawa-api; then echo "Error: Failed to clone talawa-api repository" exit 1 fi - +🧰 Tools
🪛 yamllint (1.35.1)
[error] 312-312: trailing spaces
(trailing-spaces)
[error] 318-318: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/pull-request.yml(1 hunks)
🧰 Additional context used
🪛 yamllint (1.35.1)
.github/workflows/pull-request.yml
[error] 306-306: trailing spaces
(trailing-spaces)
[error] 312-312: trailing spaces
(trailing-spaces)
[error] 318-318: trailing spaces
(trailing-spaces)
[error] 323-323: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Test Application
- GitHub Check: Analyse Code With CodeQL (javascript)
🔇 Additional comments (4)
.github/workflows/pull-request.yml (4)
291-294: LGTM! Clear job definition with appropriate conditions.The job is well-defined with a descriptive name and includes proper conditions to prevent running for dependabot PRs.
299-303: LGTM! Using recommended Node.js LTS version.Good job implementing the recommended Node.js 20.x LTS version for better stability and ecosystem compatibility.
324-326: Switch to local installation of @graphql-inspector/cli.The GraphQL Inspector is still being installed globally despite previous recommendations to use local installation.
Apply this diff to use local installation:
- - name: Install GraphQL Inspector - run: | - npm install -g @graphql-inspector/cliThe package should be added to
package.jsoninstead:{ "devDependencies": { + "@graphql-inspector/cli": "^5.0.0" } }
328-339: LGTM! Robust validation with proper error handling.The validation step includes proper error handling for:
- Missing schema.graphql file
- Missing GraphQL TypeScript files
varshith257
changed the title
✅ Actions performedReview triggered.
|
|
What kind of change does this PR introduce?
Functionality restored by uncommenting the part of code asked in the issue
ie.
Issue Number:
Fixes #3235
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Checklist
CodeRabbit AI Review
Test Coverage
Other information
Have you read the contributing guide?
Summary by CodeRabbit
Workflow Enhancement
New Dependencies
@graphql-inspector/clito development dependencies.@testing-library/domdependency version.