-
-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refacted: src/setup/askForTalawaApiUrl/askForTalawaApiUrl.test.ts from Jest to Vitest #3053
Refacted: src/setup/askForTalawaApiUrl/askForTalawaApiUrl.test.ts from Jest to Vitest #3053
Conversation
Updated CONTRIBUTING.md with new branching strategy
Bumps [dns-packet](https://github.com/mafintosh/dns-packet) from 1.3.1 to 1.3.4. - [Release notes](https://github.com/mafintosh/dns-packet/releases) - [Changelog](https://github.com/mafintosh/dns-packet/blob/master/CHANGELOG.md) - [Commits](mafintosh/dns-packet@v1.3.1...v1.3.4) Signed-off-by: dependabot[bot] <[email protected]>
…dependabot/npm_and_yarn/dns-packet-1.3.4 Bump dns-packet from 1.3.1 to 1.3.4
* Update authorized-changes-detection.yml * Code Coverage @ 87.1% * Update .gitignore * Delete codecov This executable should not be in the repo * added translation hint text in placeholders (#487) * Update pull-requests.yml * Create DOCUMENTATION.md * Rename issue-guidelines.md to ISSUE_GUIDELINES.md * Update CONTRIBUTING.md * Update issue.yml * Rename PR-guidelines.md to PR_GUIDELINES.md * Update CONTRIBUTING.md * Update pull-request-target.yml * Delete PULL_REQUEST_TEMPLATE.md * Delete ISSUE_TEMPLATE.md * Rename Code_Style.md to CODE_STYLE.md * added removeMember mutation (#491) * added removeMember mutation * changed mutation name * remove contributions from router (#502) * Fixed Settings page Header (#501) * fixed cani-use lite warning * fixed the alignments for smaller screens and also added spacing on places where it was needed * fixed the linting errors * ran prettier to remove styling errors * made the orgSetting title dynamic * linted the code and made the settings header as required and also made the settings page navbar responsive * linted code and made necessary changes * errors fixed * Added dropdown for Applanguage in UserUpdation form (#498) * Added dropdown for Applanguage in UserUpdation form * App language code changed to Default language * Change the Scalar Types [Provides relevant client side changes for #1085 in Talawa-API] (#500) * Change typedefs * Fix date parsing * Move ID to ObjectID scalar * Client changes for Adding GraphQL Scalars (#511) * Change typedefs * Fix date parsing * Move ID to ObjectID scalar * Revert ObjectID to ID * Change ObjectID to ID * modal closed after organization creation (#516) * most recently added Org displays at the top (#515) * Add Husky (#520) * updated contributing (#521) * Display and choose Organisation image (#512) * upload image working for createOrganisation * Organisation image showing everywhere * Testcase failure fixed * Linting fixed * convertToBase64 func made and tests for it * CI/CD error fixed * tests added for AdminNavbar & OrganisationDashboard * Linting fixed * fixed translation on the plugin tab (#510) * added OrgName to the Navbar (#525) * Fix create event mutation [Fixes part of #1101 in Talawa-API] (#523) * Add format fix * Fix updation of posts * Test coverage improved for organizationPeople.tsx (#526) * Update INSTALLATION.md * Update INSTALLATION.md * Update INSTALLATION.md * Update stale.yml * Remove tags (#532) * Fixed navbar added tests (#534) * Fixed navbar added tests * Fixed the translation of All orgnaizations btn in AdminNavbar * Fix the updateOrg page, and made it to create mutation request [Fixes #531] (#536) * fix orgUpdate system * fix translations * Update CONTRIBUTING.md * Code Coverage @ 88% * Fixes #478 : Implemeneted calendar to the Event tab (#537) * calendar-implemented * calendar-implemented * fixed tests * Added post-merge hook using husky (#541) * Added post-merge hook using husky * made required changes to installation.md * make changes to documentation for husky * made the required changes in installation guide * Update pull-requests.yml * Fixed yarn installation instructions (#584) * organization sorting for all organization (#619) * removed redundant notification (#577) * Profile Page for Members (#543) * Initial member page made * Changed query added Org and Events section * Homescreen ready * initial translation added for Profile * initial translation added for Profile * Added translations * Added translations * Revised translation * Fixed failing tests for components * Link added to OrgAdminListCard * Linting fixed for OrgPeopleListCard * Added tests, removed logs * Uniform design * Fix:routing issue for orgdash page (#580) * Fix:routing issue for orgdash page * fix:failing test of SuperDashListCard * Rectify Warnings: EventListCard.test.tsx (#595) * Added logic to close modal after successful submission (#623) * Feature Request: Position of the search bar. (#631) * Feature Request: Position of the search bar #614 resolved * Feature Request: Position of the search bar #614 resolved * fixes: #550 added test for the calendar (#552) * added test for the calendar * updates mocks * Update Router Function [Fixes #636] (#638) * Update Router Function * Empty commit * Fix about content overflow (#632) Signed-off-by: Ekene Nwobodo <[email protected]> * removed duplicate rows per page section in orgposts (#648) * fixed :made card in organization dashboard interactive (#620) * Implemented manage functionality for admin and super admin after login (#539) * Implememnted manage functinality for admin/superadmin after login * Update AdminDashListCard.module.css * Some formatting issues with module file * resolved workflow issues * Added folding feature to posts (#581) * added folding feature to posts * added fold feature to posts * brought code under code coverage * added tests * added tests for remainging uncovered lines * brought code coverage to 100% for the changes * Code coverage @87.2% * Fix User Update Details Page and Add Update Password Page [Fixes #530] (#657) * fixed updateuser logic * update translations * fix lint * lint fix 2 * fix tests * fixed:move orgLocation & remove duplicate orgName (#655) * fixed:move orgLocation & remove duplicate orgName * Dummy commit * fixes - [#597] - Navbar navlinks hover and button styles (#603) * fixed: #585 - Password error showing. Tested * fix: #590 - fixed navbar hover issues * fix: #590 - fixed navbar hover issues * Code Coverage 87.4% * fixes 599 (#653) * fixed errors and removed window.replace * written test case for ensure window.location.replace * written test case for ensure window.location.replace * added useHistory to keep track of routing behind the scenes * fixed merge conflicts and errors * updated comments for file changes * Added warning comments for routing --------- Co-authored-by: Adepeju <adepeju.kayode@gmail> * fix org search location (#682) Signed-off-by: Ekene Nwobodo <[email protected]> * fixed the issue of validate the input before submit #674 (#678) * Adds required tests for OrganizationEvents.tsx and Fixes a minor bug in Calendar (#527) * adds tests for organization events * removes the unrequired branch from OrganizationEvents.tsx * fixes failing tests * fixes failing lint tests * Update password preview feature with coverage tests (#629) * Fix to the issue #585 (#607) * [fix]- fixed the password error warning * [fix]- fixed the password error warning * [fix]- fixed the password error warning * [fix]-fixed the password error warning * [fix]-fixed the password error warning * [fix]-fixed the password error warning * [fix]-fixed the password error warning * [feat]-added test cases for password error warning * [feat]- added test cases for password error warning * [feat]- added test cases for password error warning * [fix]- fixed the linting * Improve test coverage for calendar.tsx (#679) * Improve test coverage for calendar.tsx * Restore previous tests * remove --coverage * i rebased my codebase and resolved the initial issue (#669) * fixed the issue use of toast in place of window.alert #645 (#687) * Update ISSUE_GUIDELINES.md * fixed the static time data under Organization card in the Organization List tab (#689) * fixed the static time in org card * formatted the date to MM D, YYYY --------- Co-authored-by: thesaaddevloper <[email protected]> * Fixed the pagination alignment issue (#702) * [fix]- fixed the password error warning * [fix]- fixed the password error warning * [fix]- fixed the password error warning * [fix]-fixed the password error warning * [fix]-fixed the password error warning * [fix]-fixed the password error warning * [fix]-fixed the password error warning * [feat]-added test cases for password error warning * [feat]- added test cases for password error warning * [feat]- added test cases for password error warning * [fix]- fixed the linting * [fix]- fixed the pagination alignment issue * [fix]- fixed the pagination alignment issue * [fix]- fixed the pagination alignment issue * Removed overlapping (#675) * changes input element to textarea and changes in test (#710) * Code Coverage @90.7% * Indicating active tabs (#691) * added underline to active links in navbar * fixed lint error * fixed the org default image #688 and removed stock image (#695) * fixed the org default image #688 and removed stock image * removed eslint warning * added new img as default org img * Update INSTALLATION.md * Added Clear Error and Warn Messages when API is unavailable (#670) * Added error and warn messages * Added tests & fixed inconsistency in mocks * Lint fix LoginPage * Lint Fix LoginPage.test * minor fix * Minor update to LoginPage * Minor change to LoginPage.test * Replaced toast.warn() with toast.error() * Fixed test accordingly * Lint Fix * Minor fix * Extra edge case handled * code coverage fix * Lint fix * Update LoginPage * Update LoginPage.test * Lint fix * improve test coverage for orgpost.tsx (#718) * Improve test coverage for calendar.tsx * Restore previous tests * remove --coverage * improve test for orgpost.tsx * Implemented Proper Error Handling for all Screens [Fixes: #535] (#731) * Handled error cases for all screens * Some more fixes * Some more fixes * Added StaticMockLink to use Mocks multiple times [Fixes Multiple Issues] (#745) * add StaticMockLink * lint fix * remove showWarning * Added prompt to Register on Login Page (#628) * Add prompt to Login page - Add prompt in other languages: fr, sp, hi, zh. - switch styling of Login Button with Reg Button * format with prettier * fixed event checkboxes to update (#707) * Block/Unblock functionality for only members of the organization (#690) * Implememnted manage functinality for admin/superadmin after login * Update AdminDashListCard.module.css * Some formatting issues with module file * resolved workflow issues * Updated block/unblock page preventing users who are not members of organiztion * Update BlockUser.test.tsx to resolve failing tests Modified the mocks fields according to the corresponding changes in BlockUser.tsx file. * created a reusable postNotFound Component with responsive UI (#717) * created a reusable postNotFound Component with responsive UI * run test error solved * added translation to the component and also created the test.tsx for the error component * fixed the failing test and added the postNotFound reusable component for OrgList --------- Co-authored-by: thesaaddevloper <[email protected]> * fix: #601 modal responsive width (#621) * added dynamic title to OrgPeople section (#704) * added dynamic title to OrgPeople section * fixed code coverage * fixed code coverage * uncommented the mistakenly added code * Delete er * Updated session timeout notification toast with already existing one (#734) * Added a toast to notify users that session has expired and redirects to the login page * Updated toast notification on session timeout with already existing one * eliminated the use of magic numbers * minor error correction on the timeout minutes --------- Co-authored-by: TheoCathy <[email protected]> * Fixed the empty space in the OrgList (#751) * created a reusable postNotFound Component with responsive UI * run test error solved * added translation to the component and also created the test.tsx for the error component * fixed the failing test and added the postNotFound reusable component for OrgList * fixed the empty space in orgList * fixed the failing test * removed the unwanted files --------- Co-authored-by: thesaaddevloper <[email protected]> * align navbar items (#755) * align navbar items * replace More with a hamburger icon * replace More with a hamburger icon to fix workflow error * replace More with a hamburger icon to fix workflow error * Fixes: toggle password for registration (#758) * added toggle-password * updated * formatting * added icon for toggle password * Super Admin Dashboard Error When Organizations Absent (#754) * No Organization Warning on OrgList * Minor Fix * Fixed failing tests * Added Warning on Roles and Request Pages * Added Tests for OrgList * Testing Fixes * Added more tests * Added Tests for Roles and Request Pages * Code Coverage @ 91.0% * Add link to dashboard admin card (#760) * image upload made functional (#677) * image upload made functional * lint * fixed failing test * linting * re run test , remove yarn.lock changes * updateUser test cov * OrgPost * rerun tests * Empty commit * reverted last 2 commits changes * re run code cov * update userUpdate * rerun code cov again * revert last commit * Update PR_GUIDELINES.md * Implemented Search bar and the radio buttons in orgPost page that searches both title and text of post (#770) * created a reusable postNotFound Component with responsive UI * run test error solved * added translation to the component and also created the test.tsx for the error component * fixed the failing test and added the postNotFound reusable component for OrgList * fixed the empty space in orgList * fixed the failing test * removed the unwanted files * the one search bar which searches both text and title of post * testing file * orpost file testing * code coverage is increased * fixed the failing test --------- Co-authored-by: thesaaddevloper <[email protected]> Co-authored-by: saadabban76 <�[email protected]> * center org image on mobile (#778) Signed-off-by: Ekene Nwobodo <[email protected]> * removed link for plugin dropdown toggle (#781) * removed link for plugin dropdown toggle * added id * align superadmin nav items and fix failed tests (#766) * changed the handleSearchByName function in searchByName in Roles page (#735) * changed the handleSearchByName function to search using target's value instead of searchByName variable * updated the file Roles.tsx to take care of useState lag * changed tests for suiting searchByName * changed tests for searchByName including backspaces * added tests for paginationList and changing rowsPerPage * added tests to increase coverage in Roles.tsx * changed the package.json file's test command * removed extra scrollbars (#800) * Recently added Post displays at top (#773) * Recently added Post displays at top * reversed the posts as required in the query * Increased the OrgList Code Coverage (#786) * increased the orgList coverage to 95$ * increased the orgList Code Coverage * increased the orgList Code Coverage * increased the orgList Code Coverage * fixed image rendering in orgPost page * increased the code coverage for orgList Component * increased code coverage to 97% in orgList Component --------- Co-authored-by: saadabban76 <�[email protected]> * Modify event visibility for non-admins (#796) * Modify event visibility for non-admins Signed-off-by: Ekene Nwobodo <[email protected]> * Add test suites for events visibilty --------- Signed-off-by: Ekene Nwobodo <[email protected]> * Bug Fix: Drawer menu visibility (#794) * Remove filter by event field (#807) * increased the orgList coverage to 95$ * increased the orgList Code Coverage * increased the orgList Code Coverage * increased the orgList Code Coverage * fixed image rendering in orgPost page * increased the code coverage for orgList Component * increased code coverage to 97% in orgList Component * removed the filter by event section in orgPeople's component * fixed the failing test --------- Co-authored-by: saadabban76 <�[email protected]> * Add image to post (#804) * increased the orgList coverage to 95$ * increased the orgList Code Coverage * increased the orgList Code Coverage * increased the orgList Code Coverage * fixed image rendering in orgPost page * increased the code coverage for orgList Component * increased code coverage to 97% in orgList Component * added Image to the post's card * replaced external links with codebase default image * replaced external links with codebase default image * replaced blank image with the default image * fixed the failing test --------- Co-authored-by: saadabban76 <�[email protected]> * Update pull-request-target.yml * Update pull-request-target.yml * Update pull-request-target.yml * Update pull-request-target.yml * Update pull-request-target.yml * Update pull-request-target.yml * Upgrade Yarn to NPM in Talawa Admin Project (#802) * npm upgrade * remove package lock * Update push.yml * empty * upgrade yarn to npm * fix docs * fix scripts * empty * stop watch mode * fix ymls * empty * fix scripts * empty commit * update scripts * Redirect to dashboard on organization update (#816) * Redirect to dashboard on organization update * Minor Change * Proper Testing Of Pagination In All List Views (#797) * install faker package used for mocks in tests * Test init for pagination * install dependencies needed to implement certain tests * add a data-testid attribute to their markup for use in tests * add data-testid attributes to its markup being referenced from tests * add test to ensure the number of organization displayed on the page corresponds to the option selected from rowsPerPage * add prop to allow rendering of component in test environment * add data-testid attributes to their markup being referenced from tests * add data-testid attributes to its markup being referenced from tests * add test to affirm that the number of persons displayed on the webpage is same with the selected option from rowsPerPage * install dependencies for certain tests * fix lint errors * tests fix * remove unnecessary dependencies * lint fix * tests fix update * restore file to previous state * empty commit * tests fix update * lint fix * Conditional Usage of Google reCAPTCHA [Fixes #798] (#820) * conditonal recaptcha * Update INSTALLATION.md * add tests * fixed the issue of Mismatched passwords validation #722 (#824) * fixed the issue of Mismatched passwords validation #722 * fixed lint code error * Code Coverage @ 92% * Replace Talawa Portal with Talawa Admin Portal #817 (#821) * Update website title to Talawa Admin Portal in en * Update website title in fr json file * Update website title in sp json file * Update website title in zh json file * Update website title in hi json file * Update the test in ListNavbar file * Update the test in LoginPage.test file * Create a function for the tex macher to make test * Fix lint errors in the LandingPage test file * Remove console.log in LandingPage test file * Upgrade to use npm instead of yarn * Delete yarn.lock file * Fix lint errors * Fix lint errors * Update the heading in hi.json file * Remove unused codes * Fix lint error in LanfingPage file * Correct the talawa_portal value in Fr json file * Correct the talawa_portal value in sp json file * Remove anused package in package.json file * Organization Form Redirect Issue Prevents User Navigation, Affecting User Experience. Issue #808 (#815) * addressing issue #808 * finished - requested changes * addressing warning * Added: event preview modal to view event details (#772) * added event preview model * added event preview model * fixed formatting * added test * added test * added test * failing tests * test * tests * Update workflow (#832) * Workflow fix (#833) * Update pull-requests.yml * Update pull-requests.yml * Update pull-requests.yml * Code Coverage @ 91.0% * Feature: Separation of ADMIN and SUPERADMIN functionalities (#826) * Initial changes * Commit to sync repo * Made changes to OrgList * Some fixes * Minor fix * Added tests for OrgList * Added tests for OrgList * Coverage fix * Required changes added * Made changes to OrgList * Some fix * Some fixes * fixes test for OrgList * Some more fixes * Empty commit * Lint fix * Fixed test * Lint fix * Added Whitespace Validation to Organization and Post create forms (#838) * Added whitespace check in Org Create form * Added Tests * Added Empty String check to OrgPost Form * Added Tests for OrgPost * fixed the issue of Toast msg is not available in all languages #740 (#845) * fixed the issue of Toast msg is not available in all languages #740 * format issue * Empty-Commit * Fixed Org Update (#843) * Prevent Admins and Super Admins from downgrading their own roles (#840) * Code Cleanup * Disabled Super Admins from changing their roles * Added Tests * Added more tests * Improved Code Quality * Revert "Fixed Org Update (#843)" (#847) This reverts commit 53c3fef28ef986d63b1eec45663acb7d07cf1b8d. * Fixed Organization Update and Translation (#849) * Fixed Organization Update * Minor Changes * Success message updated * Fail tests on warning [Priority Needed] (#856) * fix warnings Signed-off-by: Ansh Goyal <[email protected]> * fix warnings Signed-off-by: Ansh Goyal <[email protected]> * fix warnings Signed-off-by: Ansh Goyal <[email protected]> * fix warnings Signed-off-by: Ansh Goyal <[email protected]> * fix warnings Signed-off-by: Ansh Goyal <[email protected]> * restore addonregister Signed-off-by: Ansh Goyal <[email protected]> --------- Signed-off-by: Ansh Goyal <[email protected]> * Code duplicacy removed (#852) * Code duplicacy removed * Tests added * Added comments * Fixed failing tests * Code formatted * Unused packages removed, flag icons package updated to latest version (#860) * Unused packages removed, flag icons updated to latest version * Empty commit * Changes in package-lock.json * Fixes #848: limiting mulitple toast (#851) * limiting-toast * added test * Organization People Filters Improved (#855) * Added Filters to Users and Organizations Query * Added Last Name Filter on User, Member and Admin * Added Translation * Fixed Failing Tests * Added Tests for Filters * Fixed Failing Tests * Code Cleanup * Fixed Tests * Added Translation * remove graphql-boost dep (#866) Signed-off-by: Ansh Goyal <[email protected]> * added UserNotFound component to the Roles page and improved the search (#865) * changed the handleSearchByName function to search using target's value instead of searchByName variable * updated the file Roles.tsx to take care of useState lag * changed tests for suiting searchByName * changed tests for searchByName including backspaces * added tests for paginationList and changing rowsPerPage * added tests to increase coverage in Roles.tsx * changed the package.json file's test command * changed PostNotFound component to be used as a reusable one and added it in Roles section and set languages option in locales folder * changed formatting in locales changed files * removed comments in Roles.tsx * Empty commit * renamed the PostNotFound component and modifiied relevant files * changed Roles.tsx filtering * empty commit * reverted changes in package.json * Improved signupform validations (#828) * Improved signupform validations * updated signup form validation to show all messages at once * improved test coverage for LoginPage * Fixed failing test --------- Co-authored-by: Joyce Malicha <[email protected]> * added tests for Search Bar in the Organization List Page of SUPERADMIN #827 (#867) * added tests for Search Bar in the Organization List Page of SUPERADMIN #827 * added tests for Search Bar in the Organization List Page of SUPERADMIN #827 * Added Tests Previews (#868) * Installed jest-preview * Automatic Setup * Fiixed Failing Test Command * Added Basic CSS * Added PostCSS Module * Fixed MUI Styling * Minor Changes * Added cross-env to support windows * Adaptar for React 17 and CSS Modules Mock * Added Mocked Styles to Tests * Documentatin Updated * Fixed Failing Tests * Minorr change in documentation * Jest is now Dev Dependency * Workflow Test * Jest Module Path Updates * Module Path Tese 2 * Github Workflow Fixed * Removed Legacy Test Command * Added Documentation to Debug Tests * Fixed Documentation * Docs Image Added To Repo * Images Reorganization * Organized Images * Revert "Improved signupform validations (#828)" (#875) This reverts commit 5820dd9ec05256551b48470c8880fcdc05452fda. * Restored SearchBar Test for OrgList Page (#878) * Restored searchBar test * Lint fix * Coverage fix * Lint fix * Some fixes * Some fixes * fixed the issue of Users filter to fetch corresponding Users to Organisation #701 (#853) * fixed the issue of Users filter to fetch corresponding Users to Organisation #701 * removedd uunused variable * fixed failing text * fixed merged issue * fixed lint error * swap variable * Revert "Restored SearchBar Test for OrgList Page (#878)" (#879) This reverts commit 3d39c524d54e81853490d2d8a1f844ce67252365. * Fixed crashing on error in Block/Unblock page (#862) * Website crash fixed * lint fixed * Added tests for empty response from server * More tests added * Rerun tests empty commit * Redirect on error functioning * Fixed failing tests * Testcase and Title added when users not found * Linting fixed * Typo fixed * Fixed failing tests * Linting fixed * Added NotFound component in OrgPeople and changed Roles.tsx (#882) * changed the handleSearchByName function to search using target's value instead of searchByName variable * updated the file Roles.tsx to take care of useState lag * changed tests for suiting searchByName * changed tests for searchByName including backspaces * added tests for paginationList and changing rowsPerPage * added tests to increase coverage in Roles.tsx * changed the package.json file's test command * changed PostNotFound component to be used as a reusable one and added it in Roles section and set languages option in locales folder * changed formatting in locales changed files * removed comments in Roles.tsx * Empty commit * renamed the PostNotFound component and modifiied relevant files * changed Roles.tsx filtering * empty commit * reverted changes in package.json * added NotFound component in OrgPeople, made changes in the locales files and made some changes to Roles too * added NotFound component to OrgPeople, changerd locales files and changed Roles.tsx * minor change * Restored Search-Bar Test for OrgList Page (#880) * Restored searchBar test * Lint fix * Coverage fix * Lint fix * Some fixes * Some fixes * Fixed Org Dashboard Error (#873) * Fixed TypeError * Minor Change * Fixed Tests * Added back logo512 * Fixed auth header getting copied on login (#890) * fix user update (#876) * fix user detials update * remove userType from update-user page * fix failed test for userUpdate.test.tsx * Removed and Replaced Ant Design from the project (#891) * Fixed auth header getting copied on login * Removed/Replaced Ant Design from the project * Fixed failing tests * Removed comment * Add today functionality in calendar (#897) * Update countline.py * Update pull-requests.yml * Updated countlines.py to cover .spec. files (#900) Co-authored-by: Peter Harrison <[email protected]> * fixed the Inability to set user roles for specific organizations #556 (#898) * fixed the Inability to set user roles for specific organizations #556 * added all language translation * Revert "fixed the Inability to set user roles for specific organizations #556 (#898)" (#901) This reverts commit 891d898eb5543116bb9042a6386b5a12e474159c. * Documentation updated, Redundant css files removed (#896) * Doc updated unused files removed * Removed unused css files from setup tests * Added small calendar in the events #887 (#903) * added small clanedar * added small clanedar * fixed Code Coverage: Create tests for OrgSettings.tsx #396 (#905) * remove redundancy from orgPostCard (#906) * Revert "remove redundancy from orgPostCard (#906)" (#910) This reverts commit d5ce4aa27ee241b0687f7db3d6acd1b62339562f. * Block/Unblock Page Improvements (#885) * Added Radio Buttons * Optimized Queries * Optimized Query and Added Last Name Filter * Radio Button Working * Added Translations * Fixed Filter Name * Fixed Debounce * Fixed Asynchronous Debounce * Added Tests * Better Error and Loading State Handline * Fixed Loader * Fixed Loader * Modulrised Mock Data * Minor Change * Fixed Tests * Increase Coverage * User query replaced with OrgMemberConnection * Fixed Tests * Code Coverage Increase * Code Cov * Fixed Translations * Fixed Failing Tests * fix in failing test (#913) * Improve and Standardize Automated Linting Tests (#916) * added linting rules * added linting rules * added linting rules * Rename `data` variables to more readable name [Fixes #829] (#835) * Refactor screens * Update components * Fix test * Fix typecheck errors * Increase test coverage * Merge latest adminUI-Redesign into Develop (#927) * Updated CODE_STYLE.md * Updated CODE_STYLE.md (#917) * Updated CODE_STYLE.md * Import section update * Upgrade and Migrate from Bootstrap 4 to Bootstrap 5 (#925) * Updated CODE_STYLE.md * Latest Boostrap v5.3.0 & react-bootstrap v2.7.4 installed * Buttons replaced from normal ones to Bootstrap ones * Import section update * Error fixed for Buttons * Language dropdowns and Change language * InputBoxes & Checkboxes fixed and imported from BS * Removed unused package popper.js * Replaced react-modal with Bootstrap one in Login Page * Modals converted to React Bootstrap one * Completely replaced react-modal with react-bootstrap/Modal from the project * Removed react-modal from the project * Removed classbased modal and unused images * Notification navbar migrated * Modal migration * Modal migration * Modal migration done for OrgPostCard * Empty commit to make workflow run * Empty commit to make workflow run * Empty commit to run the workflow --------- Co-authored-by: Anwer Sayeed <[email protected]> * Introduces API versioning check in CI/CD (#924) * a random change * husky precommit * one more try * one more try * one more try * one more try * one more try * one more try * second try * removed unwanted deps * removed unwanted deps * resolved the error * updated variable name * rerun test * rerun test * added test to pull.yml * removed push check * resolved conflict * Update stale.yml * Update CONTRIBUTING.md * Merge talawa-user-portal into develop (#935) * Create login and register page for user portal * Lint public locales * Create tests for login page components * Add react import in tests * Create organizations screen for user portal * Fix failing tests and lint code * fix failing tests * Add tests for organization screen and componenets * Fix non-null assertions * Fix non-null assertions in organizations test * Fix bootstrap migration changes * Merge latest Admin UI Redesign into Develop (#934) * Updated CODE_STYLE.md * Updated CODE_STYLE.md (#917) * Updated CODE_STYLE.md * Import section update * Upgrade and Migrate from Bootstrap 4 to Bootstrap 5 (#925) * Updated CODE_STYLE.md * Latest Boostrap v5.3.0 & react-bootstrap v2.7.4 installed * Buttons replaced from normal ones to Bootstrap ones * Import section update * Error fixed for Buttons * Language dropdowns and Change language * InputBoxes & Checkboxes fixed and imported from BS * Removed unused package popper.js * Replaced react-modal with Bootstrap one in Login Page * Modals converted to React Bootstrap one * Completely replaced react-modal with react-bootstrap/Modal from the project * Removed react-modal from the project * Removed classbased modal and unused images * Notification navbar migrated * Modal migration * Modal migration * Modal migration done for OrgPostCard * Empty commit to make workflow run * Empty commit to make workflow run * Empty commit to run the workflow * Sass filed added with documentation * Linting fixed * Fixed the folder structure and naming convention * Customised Bootstrap (#929) * Sass filed added with documentation * Linting fixed * Fixed the folder structure and naming convention * Assets typo fixed * Typo fix * Merge conflict error fixed --------- Co-authored-by: Anwer Sayeed <[email protected]> * test PR for API versioning check (#932) * testPR * test2 * testing the change * testing it again * test--no-verify * test--no-verify * echo token * test-again * test-again * test * test * read-only * clone * clone * redesigned newsfeed (#939) * Revert "redesigned newsfeed (#939)" (#943) This reverts commit a645eca7cf2ce1335374f48b52335a293e344580. * Make Talawa-Admin mutations in sync with the backend (#946) * Initial change * Redundant Notification removed * Fixed linting and other issues * Tests fixed * Add Home Screen And People Screen along with other components (#940) * Create login and register page for user portal * Lint public locales * Create tests for login page components * Add react import in tests * Create organizations screen for user portal * Fix failing tests and lint code * fix failing tests * Add tests for organization screen and componenets * Fix non-null assertions * Fix non-null assertions in organizations test * Fix bootstrap migration changes * Add Home Screen along with other components * Fix failing tests * Add required tests and Offcanvas navbar * Remove unused variables from tests * Sync the Mutations with talawa-api * Merge AdminUI-Redesign into Develop (#947) * Updated CODE_STYLE.md * Updated CODE_STYLE.md (#917) * Updated CODE_STYLE.md * Import section update * Upgrade and Migrate from Bootstrap 4 to Bootstrap 5 (#925) * Updated CODE_STYLE.md * Latest Boostrap v5.3.0 & react-bootstrap v2.7.4 installed * Buttons replaced from normal ones to Bootstrap ones * Import section update * Error fixed for Buttons * Language dropdowns and Change language * InputBoxes & Checkboxes fixed and imported from BS * Removed unused package popper.js * Replaced react-modal with Bootstrap one in Login Page * Modals converted to React Bootstrap one * Completely replaced react-modal with react-bootstrap/Modal from the project * Removed react-modal from the project * Removed classbased modal and unused images * Notification navbar migrated * Modal migration * Modal migration * Modal migration done for OrgPostCard * Empty commit to make workflow run * Empty commit to make workflow run * Empty commit to run the workflow * Sass filed added with documentation * Linting fixed * Fixed the folder structure and naming convention * Customised Bootstrap (#929) * Sass filed added with documentation * Linting fixed * Fixed the folder structure and naming convention * Assets typo fixed * Typo fix * Initial login page work * Merge conflict error fixed * Theming modified and Added Loader over every screen * Fixed UI issue for navbar and login * Fixed production bug * Removed unused variable * Tests fixed * Added Change Language Btn dropdown * Merge conflict fixed, merge latest develop into adminUI-redesign (#938) * Merge latest adminUI-Redesign into Develop (#927) * Updated CODE_STYLE.md * Updated CODE_STYLE.md (#917) * Updated CODE_STYLE.md * Import section update * Upgrade and Migrate from Bootstrap 4 to Bootstrap 5 (#925) * Updated CODE_STYLE.md * Latest Boostrap v5.3.0 & react-bootstrap v2.7.4 installed * Buttons replaced from normal ones to Bootstrap ones * Import section update * Error fixed for Buttons * Language dropdowns and Change language * InputBoxes & Checkboxes fixed and imported from BS * Removed unused package popper.js * Replaced react-modal with Bootstrap one in Login Page * Modals converted to React Bootstrap one * Completely replaced react-modal with react-bootstrap/Modal from the project * Removed react-modal from the project * Removed classbased modal and unused images * Notification navbar migrated * Modal migration * Modal migration * Modal migration done for OrgPostCard * Empty commit to make workflow run * Empty commit to make workflow run * Empty commit to run the workflow --------- Co-authored-by: Anwer Sayeed <[email protected]> * Introduces API versioning check in CI/CD (#924) * a random change * husky precommit * one more try * one more try * one more try * one more try * one more try * one more try * second try * removed unwanted deps * removed unwanted deps * resolved the error * updated variable name * rerun test * rerun test * added test to pull.yml * removed push check * resolved conflict * Sass filed added with documentation * Linting fixed * Fixed the folder structure and naming convention * Update stale.yml * Typo fix * Update CONTRIBUTING.md * Merge talawa-user-portal into develop (#935) * Create login and register page for user portal * Lint public locales * Create tests for login page components * Add react import in tests * Create organizations screen for user portal * Fix failing tests and lint code * fix failing tests * Add tests for organization screen and componenets * Fix non-null assertions * Fix non-null assertions in organizations test * Fix bootstrap migration changes * Merge conflict error fixed --------- Co-authored-by: Anwer Sayeed <[email protected]> Co-authored-by: Kanishka Bansode <[email protected]> Co-authored-by: Peter Harrison <[email protected]> Co-authored-by: Noble Mittal <[email protected]> * Random checkout * Design ready for homescreen * Login page 100% code c=coverage * Login page icon adjustment * Added translations * Fixed the failing tests * Revert to older version of loader * Animation added fixed warnings * Fixed accessability * Mutations and Tests foxed * Fixed coloring in UserPortal * Tests fixed and ChangeLanguageDropdown used in UserLoginPage * Linting Fixed --------- Co-authored-by: Anwer Sayeed <[email protected]> Co-authored-by: Kanishka Bansode <[email protected]> Co-authored-by: Peter Harrison <[email protected]> Co-authored-by: Noble Mittal <[email protected]> * Merge latest adminUI-Redesign (#950) * Initial Organizations screen done * Removed yellow scrollbar * Linting fixed * Replaced images with svgs for logos * Styling done for btnsContainer * Better typechecking and readability * Animated Drawer working * Responsive page ready * OrgCard responsive * Fixed navbar issue and added webkit keyframes * LeftDrawer ready * Translations added * Added shimmer loading effect * Styling issue fixed * Failing tests fixed for OrgList * Removed unused vars * Tests done for LeftDrawer * Succesfully made component without causing any breaking change * 100% Code coverage achieved for Requests Screen * Fix alignment * Roles screen UI done * Role screen fixed with 100% test coverage * Changing screen activeness fixed * Unused vars and Typos fixed * Language support added * Linting and typos fixed * Fixed failing tests for LeftDrawer * Completed tests of AdminDashListCard with 100% code coverage * OrgListCard done * Finalised tests * Requests user search made functional again ! * Fixed loading on refetch and UX on all screens * OrgList failing errors fixed * Fixed all failing tests * Achieved 100% code coverage for OrgList.tsx * Wrote tests and mod LeftDrawer for admins * Minor ui issue fixed * Fixed failing test * UI bug dropdown * Frontend insync with Backend attempt 1 * Introspection fail fix 1 * Introspection error fix 3 * Introspection error fix another attempt * Another attempt * [Talawa-user-portal] Add Settings and Donate Screen, along with other UI fixes (#953) * Create login and register page for user portal * Lint public locales * Create tests for login page components * Add react import in tests * Create organizations screen for user portal * Fix failing tests and lint code * fix failing tests * Add tests for organization screen and componenets * Fix non-null assertions * Fix non-null assertions in organizations test * Fix bootstrap migration changes * Add Home Screen along with other components * Fix failing tests * Add required tests and Offcanvas navbar * Remove unused variables from tests * Sync the Mutations with talawa-api * Add Settings and Donate Screen * Add multilingual support for the screens * Add Event Project and Volunteer Management (#961) * Add screens for adding and updating event projects * Add delete operation for event projects and debug update * Remove yarn.lock * Begin testing * Add display of tasks and functionality to add tasks * Add modal for edit task * Add UpdateTaskModal * Add Delete Task Modal and volunteers display * Add test for DeleteEventProjectModal.tsx * Add tests for add and update event project modal * Add screen for managing volunteers * Add option to assign and remove volunteers * Add tests for AddTaskModal.tsx * Add tests for TaskListItem.tsx and DeleteTaskModal.tsx * Complete testing for all Task Modals * Add completed display to tasks * Add tests for event dashboard * Restructure files * Add attendee management modal * Add testing for EventAttendeeModal * Move to 100% testing and wrapper for attendees modal * Add basic checkIn functionality for users * Add testing for CheckIn modals * Introduce the tag generation into the repository * Update linting rule and fix errors * Remove alloted seat and alloted room * Fix testing * Correct some tests * Migrate from attendees to registrants * Migrate Event Project modals to new design * Migrate registrants modals and checkin modals to new design with 100% test coverage * Move task modals to new styles * Move to 100% test coverage * Admin workflow completed with updated package.json (#960) * Merge latest AdminUI Redesign into develop (#956) * Initial Organizations screen done * Removed yellow scrollbar * Linting fixed * Replaced images with svgs for logos * Styling done for btnsContainer * Better typechecking and readability * Animated Drawer working * Responsive page ready * OrgCard responsive * Fixed navbar issue and added webkit keyframes * LeftDrawer ready * Translations added * Added shimmer loading effect * Styling issue fixed * Failing tests fixed for OrgList * Removed unused vars * Tests done for LeftDrawer * Succesfully made component without causing any breaking change * 100% Code coverage achieved for Requests Screen * Fix alignment * Roles screen UI done * Role screen fixed with 100% test coverage * Changing screen activeness fixed * Unused vars and Typos fixed * Language support added * Linting and typos fixed * Fixed failing tests for LeftDrawer * Completed tests of AdminDashListCard with 100% code coverage * OrgListCard done * Finalised tests * Requests user search made functional again ! * Fixed loading on refetch and UX on all screens * OrgList failing errors fixed * Fixed all failing tests * Achieved 100% code coverage for OrgList.tsx * Wrote tests and mod LeftDrawer for admins * Minor ui issue fixed * Fixed failing test * UI bug dropdown * Frontend insync with Backend attempt 1 * Introspection fail fix 1 * Introspection error fix 3 * Introspection error fix another attempt * Another attempt * Fixed Default Animation on Organizations Screen * Fixed typo * Loading data from localstorage functional * Fixed name conventions * Fixed typo * UI Fix * Changed screen name * Table Loader added * Added LeftOrg drawer and Organization screen comp to Screens * routesReducer tests fixed * Redundant adminNavbar removed from project * MemberDetail issue fixed * Achieved 100% code coverage for LeftDrawerOrg, Added Empty div in images * Fixed failing tests * Fix tests * Fixed warnings * Linting fixes * Linting issues fixed * Achieved 100% code coverage for CollapsibleDropdown * Achieved 100% CC on IconComponent and removed useless imports * Achieved 100% cc for LeftDrawer Component * Achieved 100% CC on SuperAdminScreen Component * Fixed typo * Integrated Event Dashboard * Failing tests for LeftDrawer LeftDrawerOrg OrgList screen fixed * Removed redundant code * Removed useless imports * Linting fixed * Removed LeftDrawerOrg * Update documentation * copy-docs -to-talawa branch update to develop * removed dependance of code copying from generate segment * Update push.yml (#969) * Update push.yml (#970) * Feature Request: Adding a dialog to go to plugin store after an organization is created by the admin (#951) * Add/ test for OrgPost.tsx * fix: org post back to default * Added Dialog 2 * Updated Dialog UI * Removed Extra code * Updated Plugin store * fix: warnings and solves #951 & #948 * fix: warnings and solves #951 & #948 * fix: warnings and solves #951 & #948 * Fix: UI Redesign * fix: merge * fix * Update AddOnStore.tsx * Fixed Merge Errors * Add test: for OrgEntry * Test 3 * fix test 4 * Merge latest AdminUI Redesign into develop (#972) * Initial Organizations screen done * Removed yellow scrollbar * Linting fixed * Replaced images with svgs for logos * Styling done for btnsContainer * Better typechecking and readability * Animated Drawer working * Responsive page ready * OrgCard responsive * Fixed navbar issue and added webkit keyframes * LeftDrawer ready * Translations added * Added shimmer loading effect * Styling issue fixed * Failing tests fixed for OrgList * Removed unused vars * Tests done for LeftDrawer * Succesfully made component without causing any breaking change * 100% Code coverage achieved for Requests Screen * Fix alignment * Roles screen UI done * Role screen fixed with 100% test coverage * Changing screen activeness fixed * Unused vars and Typos fixed * Language support added * Linting and typos fixed * Fixed failing tests for LeftDrawer * Completed tests of AdminDashListCard with 100% code coverage * OrgListCard done * Finalised tests * Requests user search made functional again ! * Fixed loading on refetch and UX on all screens * OrgList failing errors fixed * Fixed all failing tests * Achieved 100% code coverage for OrgList.tsx * Wrote tests and mod LeftDrawer for admins * Minor ui issue fixed * Fixed failing test * UI bug dropdown * Frontend insync with Backend attempt 1 * Introspection fail fix 1 * Introspection error fix 3 * Introspection error fix another attempt * Another attempt * Fixed Default Animation on Organizations Screen * Fixed typo * Loading data from localstorage functional * Fixed name conventions * Fixed typo * UI Fix * Changed screen name * Table Loader added * Added LeftOrg drawer and Organization screen comp to Screens * routesReducer tests fixed * Redundant adminNavbar removed from project * MemberDetail issue fixed * Achieved 100% code coverage for LeftDrawerOrg, Added Empty div in images * Fixed failing tests * Fix tests * Fixed warnings * Linting fixes * Linting issues fixed * Achieved 100% code coverage for CollapsibleDropdown * Achieved 100% CC on IconComponent and removed useless imports * Achieved 100% cc for LeftDrawer Component * Achieved 100% CC on SuperAdminScreen Component * Fixed typo * Integrated Event Dashboard * Failing tests for LeftDrawer LeftDrawerOrg OrgList screen fixed * Removed redundant code * Removed useless imports * Linting fixed * Removed LeftDrawerOrg * Dashboard screen ui almost ready * Org Dash ready * Block/Unblock screen ready * Organization settings page ready * Lang changes * Page refresh on updating org removed * OrgUpdate tests done * OrgUpdate 100% test coverage achieved * OrgSettings Tests done * Organization Dashboard Cards done * Organization Dashboard achieved 100% CC * 100% CC achieved for BlockUser screen * Finalised changes * Small change * Tests fixed * Separate OrgSettings component made * Linting fixed * Formatting fixed * Events screen and Post Comment Modal for Talawa-user-portal (#963) * Create login and register page for user portal * Lint public locales * Create tests for login page components * Add react import in tests * Create organizations screen for user portal * Fix failing tests and lint code * fix failing tests * Add tests for organization screen and componenets * Fix non-null assertions * Fix non-null assertions in organizations test * Fix bootstrap migration changes * Add Home Screen along with other components * Fix failing tests * Add required tests and Offcanvas navbar * Remove unused variables from tests * Sync the Mutations with talawa-api * Add Settings and Donate Screen * Add multilingual support for the screens * Add events screen without calendar view * Add multilingual support to Events screen * Fix failing tests due to merge * Add Post Comment functionality * Refactor Events tests * Deprecate event registrants from query * Update README.md * Add My Tasks screen and Fix UI bugs [User Portal] (#978) * Create login and register page for user portal * Lint public locales * Create tests for login page components * Add react import in tests * Create organizations screen for user portal * Fix failing tests and lint code * fix failing tests * Add tests for organization screen and componenets * Fix non-null assertions * Fix non-null assertions in organizations test * Fix bootstrap migration changes * Add Home Screen along with other components * Fix failing tests * Add required tests and Offcanvas navbar * Remove unused variables from tests * Sync the Mutations with talawa-api * Add Settings and Donate Screen * Add multilingual support for the screens * Add events screen without calendar view * Add multilingual support to Events screen * Fix failing tests due to merge * Add Post Comment functionality * Refactor Events tests * Deprecate event registrants from query * Add my tasks screen for user portal * Remove unnecessary comments from test files * Add Feedback UI Components to Talawa Admin (#980) * Add feedback component * Add tests for feedback modal * Add handling for empty feedback * Add Average Rating and Reviews component * Add testing for all the added cards * Fix tests and move to 100% coverage * Add bugfix * Add merge function to fix failing tests * Add key definitons * Change merge policy * Add custom merge policy to all the Event Stat tests * remove cache * Migrate to a single query in the parent * Adding Plugin Logic to the Talawa Mobile Web App (#976) * Add/ test for OrgPost.tsx * fix: org post back to default * Added Dialog 2 * Updated Dialog UI * Removed Extra code * Updated Plugin store * fix: warnings and solves #951 & #948 * fix: warnings and solves #951 & #948 * fix: warnings and solves #951 & #948 * Fix: UI Redesign * fix: merge * fix * Update AddOnStore.tsx * Fixed Merge Errors * Add test: for OrgEntry * Test 3 * fix test 4 * chores: version changes * Add: Initial Websocket setup on talawa mobile web * Add: plugin logic * Add: plugin logic * removed extra * removed extra * Added: Tests * fix * Add Side Navigation to Event Dashboard (#981) * Create left drawer for event dashboard * Add basic styles to the event dashboard * Fix button styling * Add testing * Add testing for the left event drawer * Add 100% line coverage for all components * Increase timeout for tests * Move maximum rating in feedback from 10 to 5 [Fixes #990] (#987) * Move maximum rating in feedbacks from 10 to 5 * Fix failing tests * Add chat screen to talawa-user-portal (#986) * Create login and register page for user portal * Lint public locales * Create tests for login page components * Add react import in tests * Create organizations screen for user portal * Fix failing tests and lint code * fix failing tests * Add tests for organization screen and componenets * Fix non-null assertions * Fix non-null assertions in organizations test * Fix bootstrap migration changes * Add Home Screen along with other components * Fix failing tests * Add required tests and Offcanvas navbar * Remove unused variables from tests * Sync the Mutations with talawa-api * Add Settings and Donate Screen * Add multilingual support for the screens * Add events screen without calendar view * Add multilingual support to Events screen * Fix failing tests due to merge * Add Post Comment functionality * Refactor Events tests * Deprecate event registrants from query * Add my tasks screen for user portal * Remove unnecessary comments from test files * Add chat screen along with components * Add mui/system package for x-chart support * Add chat screen tests and fix other bugs * Update issue.yml * Update stale.yml * Merge latest AdminUI Redesign into Master (#1006) * Pagination Done for Orglist * Fixed warnings * Infinite scroll and search working for Requests screen * Simplified the code * Infinite scroll enabled and functioning on OrgList Requests and Users screen * FIxed warning * Fixed typo * Fixed bug * Joined and Blockedbyorgs screen and mdoal ready * Tables ready ! * Remove user from organization functionality working well * Update user role in organization feature ready * Minor changes * Done with tests on OrgList * Done with testss of Requests screen * 100% CC achieved for Users screen * Main tests done for UserTableItem * 100% Code Coverage Achieved for UserTableItem * Removed Redundant Landing Page * 100% CC achieved for TableLoader * Translation added for Users Screen * Translation done for Requests screen * Translation done for dashboard screen * Linting and warnings fixed * Improved login page * UI Done for Forgot Password Screen * Forgot Password Screen Tests done! * Fixed all pending tests * Better message for btns and coloring * Linting issues fixed * Fixed code styles * SUPPRESSED UNKNOWN ERROR * Fixed formatting * Updated typoed message * Fixed failing tests accompanying typo * fix createEvent to close modal and show events without refresh (#1014) * fix: Ensure Full Visibility of Logo on 404 Error Page (#1018) - Adjusted the positioning of the logo on the 404 error page to ensure full visibility. - Implemented CSS modifications to prevent the logo from being covered or cut off. - Tested the changes by navigating to various undefined endpoints, confirming that the logo is now displayed correctly on the 404 error page. This commit addresses the bug by ensuring the proper display of the logo on the 404 error page, enhancing the user experience. Fixes #1016 Signed-off-by: Akhilender <[email protected]> * Implemented featurs for Postfeed Management (#982) * redesigned newsfeed * added test * newsfeed management * pinned post * postfeed management * pin unpin tag and video control * changes part 2 * newsfeed changes * changes in Card Preview of newsfeed * changes in Card Preview of newsfeed * testing phase 1 * translation * tests * tests * merged intto develop * test * Added query * Update pull-requests.yml * update and delete buttons of event modal are now working (#1051) * update and delete buttons of event modal are now working * fixed the naming conventions and style of the modal * Dynamic dashboard Enhancements (#979) * Dynamic Organization Dashboard * Dynamic Organization Dashboard * refined organization dashboard * Update src/utils/handleLatestFeed.ts Co-authored-by: Noble Mittal <[email protected]> * fixed inconsistent casing * fixed org dashboard test * fixed org dashboard test * revert previous commit * final changes * final changes --------- Co-authored-by: Noble Mittal <[email protected]> * Fix dashboard items (#1007) * Dashboard items are working now. * added variables for links -fix dashboard items * Added variables for links -fix dashboard items. * made the changes as said * Removed : string from variable assignment. * remove repititive code and resolved falling tests * Fix repeating code and falling tests. * Resolved some more falling tests * write test for missed lines * Fix event creation issue with white spaces. (#1025) * fix event creation with white spaces * Add test for empty input values * chore: fix unit test (#1052) * Fix layout distortion due to untruncated title description of events. (#1049) * Fix layout distortion due to untruncated title description of events * Add test * add test for LeftDrawerEvent.tsx * fixed some tests * add test complete * test: SecuredRouteForUser component 100% Test Coverage and fixed uncovered lines (#1048) * SecuredRouteForUser test case added * Fixed Linting Errors * Update SecuredRouteForUser.test.tsx * Update SecuredRouteForUser.test.tsx * linting fix * Update SecuredRouteForUser.test.tsx * Update SecuredRouteForUser.test.tsx * Fix incorrect toast Notification. (#1053) * correct toast notification for TableRow.tsx with full test coverage * Add correct toast with full code coverage * Add correct toast for deleteEventProjectModal.tsx with full test coverage * Add correct toast for UpdateEventProjectModal.tsx with full test coverage * Add correct toast for EventRegistrantsModal.tsx and full test coverage. * Add correct toast for AddTaskModal.tsx with full test coverage * Add correct toast for UpdateTaskModal.tsx with full test coverage * minor fix * Add correct toast to EventRegistrantsModal.tsx * fix EventRegitrantsModal.tsx * created a return button on event dashboard (#1057) * test: Loader Component 100% Test Coverage and Fix Uncovered Lines (#1047) * test: Achieve 100% Test Coverage and Fix Uncovered Lines - Improved the test coverage for the Loader component, addressing the previously uncovered lines and ensuring that all tests pass successfully. - Added a test to ensure that the component renders correctly with a custom 'sm' size. I verified that both the spinner-wrapper and spinner elements are present and that the correct class is applied. - Added a test to ensure that the component renders correctly with a 'lg' size. I verified that the spinner element has the appropriate class. - Added a test to ensure that the component renders correctly with an 'xl' size. I verified that the spinner element has the correct class. With these new tests, I now have 100% test coverage, and there are no more uncovered lines. The Loader component is thoroughly tested for different size scenarios, and all tests pass successfully. Signed-off-by: Akhilender <[email protected]> * Fixed linting in Loader component Signed-off-by: Akhilender <[email protected]> * Test: Increasing the test level - Trying to meet the code coverage level for Loader component. Signed-off-by: Akhilender <[email protected]> * Fixed Linting Signed-off-by: Akhilender <[email protected]> * fix: Linting Signed-off-by: Akhilender <[email protected]> * Improving test coverage for Loader Component - Fixed lint errors Signed-off-by: Akhilender <[email protected]> * test: Improving the tests on the Loader Component - Added a new aspect in the test-case1 Signed-off-by: Akhilender <[email protected]> * Fixed: Removed runtime-generated classes from testing - Eliminated all checks for classes associated with bootstrap components assigned at runtime. - Recognized that validating classes assigned during runtime is inappropriate. Signed-off-by: Akhilender <[email protected]> --------- Signed-off-by: Akhilender <[email protected]> * Simulated Test Database (#984) * Dynamic Organization Dashboard * Dynamic Organization Dashboard * Sample Org Implementation * removed unnecessary changes * removed unnecessary svgs * removed unnecessary import * added appropriate button style * fixed OrgListCard tests * Fixed OrgList and OrgListCard Tests * Removed Unnecessary 'container' Variable * Added Missing Translations and removed unused variable * Fixed event check in management not updating automatically bug (#1062) * fixed the event checkIn bug * fixed the failing test * fixed the CheckInWrapper test * Fix user profile buttons layout and added form validation (#1064) * Fix user profile buttons layout and added form validation * Fix falling tests and warnings * Add test for missed lines * fix falling tests * test: Achieved 100% test coverage and fixed uncovered lines (#1068) * test: Achieved 100% test coverage and fixed uncovered lines - Improved the test coverage for the User-Password-Update component, addressing the previously uncovered lines and ensuring that all tests pass successfully. - Added two new tests 1. Empty Password Field Test: - The first test ensures that an error is displayed when attempting to save changes with an empty password field. 2. Mismatched New and Confirm Passwords Test - The second test covers the scenario where the new and confirm password fields do not match. With these new tests, I now have 100% test coverage, and there are no more uncovered lines. Signed-off-by: Akhilender <[email protected]> * Altered the formData - Altered the formData to make sure all are related to the organization name. Signed-off-by: Akhilender <[email protected]> --------- Signed-off-by: Akhilender <[email protected]> * created test for src/components/UserPortal/EventCard/EventCard.tsx (#1079) * created test for eventCard of User portal * corrected the start and end time * Feature request: Adding advertisement screen (#994) * Add/ test for OrgPost.tsx * fix: org post back to default * Added Dialog 2 * Updated Dialog UI * Removed Extra code * Updated Plugin store * fix: warnings and solves #951 & #948 * fix: warnings and solves #951 & #948 * fix: warnings and solve…
…ations" button (PalisadoesFoundation#1124) * Changes position and text of all organization button * Made changes to the routesReducer.test file * Made changes in IconComponent.test file * Fetched changes from main repo * Fixed unnecessary changes --------- Co-authored-by: Aditya Agarwal <[email protected]>
… Organizations" button (PalisadoesFoundation#1124)" (PalisadoesFoundation#1183) This reverts commit 1fd4105.
* Added Base branch check to main * Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop to main * Deleted all main files * Merged develop into main
* Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop into main
* Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop into main * Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop into main
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.5 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.5...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.15 to 6.2.1. - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.1.15...v6.2.1) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…lisadoesFoundation#1961) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 40 to 41. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v40...v41) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.2...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ejs](https://github.com/mde/ejs) from 3.1.9 to 3.1.10. - [Release notes](https://github.com/mde/ejs/releases) - [Commits](mde/ejs@v3.1.9...v3.1.10) --- updated-dependencies: - dependency-name: ejs dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…tion#2020) * Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop into main --------- Co-authored-by: Peter Harrison <[email protected]>
* 20240727112607 Deleted all files in the main branch in anticipation of merging develop into main cleanly * 20240727112842 Merge develop into main
* 20240929102850 Deleted all files in the main branch in anticipation of merging develop into main cleanly * 20240929103238 Merge develop into main
…lisadoesFoundation#2307) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 40 to 41. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v40...v41) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [rollup](https://github.com/rollup/rollup) from 4.21.3 to 4.22.5. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v4.21.3...v4.22.5) --- updated-dependencies: - dependency-name: rollup dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* 20241114065242 Deleted all files in the main branch in anticipation of merging develop into main cleanly * 20241114065332 Merge develop into main
WalkthroughThis pull request introduces comprehensive changes to the Talawa Admin project, focusing on configuration, localization, testing infrastructure, and development workflows. The modifications span multiple areas including environment setup, GitHub Actions workflows, linting configurations, localization files, and testing frameworks. The changes aim to enhance code quality, improve developer experience, and provide multi-language support for the application. Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewersPoem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #3053 +/- ##
=====================================================
+ Coverage 29.13% 88.95% +59.81%
=====================================================
Files 300 321 +21
Lines 7568 8409 +841
Branches 1652 1894 +242
=====================================================
+ Hits 2205 7480 +5275
+ Misses 5177 686 -4491
- Partials 186 243 +57 ☔ View full report in Codecov by Sentry. |
The test failure cause is that you have not merged your code with the latest upstream. In this case, merge your local branch with the latest upstream, commit and then push to your origin. |
sir , do i need to merge develop-postgres in my branch and then pushing my branch to the origin ? |
Please merge your local branch with the latest upstream, commit and then push to your origin. The tests should pass then |
b3149ba
to
3d1f1f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 29
🧹 Nitpick comments (52)
.github/workflows/stale.yml (2)
1-11
: Consider enhancing the header documentationThe header references a README.md file but doesn't provide immediate context about the workflow's purpose. Consider adding a brief description of the workflow's functionality directly in the header for better maintainability.
############################################################################## ############################################################################## # # NOTE! # # Please read the README.md file in this directory that defines what should # be placed in this file +# Purpose: This workflow automatically manages stale issues and pull requests +# by marking them as stale after 10 days of inactivity and closing them +# after 180 days of inactivity. # ############################################################################## ##############################################################################🧰 Tools
🪛 yamllint (1.35.1)
[error] 6-6: trailing spaces
(trailing-spaces)
18-21
: Remove trailing spacesThe permissions configuration is correct, but there are trailing spaces that should be removed.
permissions: issues: write - pull-requests: write - + pull-requests: write🧰 Tools
🪛 yamllint (1.35.1)
[error] 20-20: trailing spaces
(trailing-spaces)
[error] 21-21: trailing spaces
(trailing-spaces)
public/locales/en/errors.json (3)
2-2
: Fix double punctuation in error messageThe message has both "!" and "." at the end which is redundant.
- "talawaApiUnavailable": "Talawa-API service is unavailable!. Is it running? Check your network connectivity too.", + "talawaApiUnavailable": "Talawa-API service is unavailable! Is it running? Check your network connectivity too.",
5-5
: Fix capitalization in error message"Authorised" should not be capitalized in the middle of a sentence.
- "notAuthorised": "Sorry! you are not Authorised!", + "notAuthorised": "Sorry! You are not authorised!",
10-10
: Fix typo in error message"occured" should be "occurred".
- "errorLoading": "Error occured while loading {{entity}} data" + "errorLoading": "Error occurred while loading {{entity}} data"public/locales/en/translation.json (1)
14-88
: Consider consolidating duplicate translationsThe
loginPage
anduserLoginPage
sections contain many identical translations. Consider creating a common section for shared translations to improve maintainability and reduce duplication.Example of duplicated strings:
- "atleast_8_char_long"
- "Password_and_Confirm_password_mismatches"
- "captchaError"
And many more...Also applies to: 57-88
.github/workflows/pull-request-target.yml (1)
1-77
: Clean up trailing spacesMultiple lines contain trailing spaces. While this doesn't affect functionality, it's good practice to remove them for consistency.
Use your editor's trailing space removal feature or run the following command:
sed -i 's/[[:space:]]*$//' .github/workflows/pull-request-target.yml
🧰 Tools
🪛 yamllint (1.35.1)
[error] 6-6: trailing spaces
(trailing-spaces)
[error] 13-13: trailing spaces
(trailing-spaces)
[error] 15-15: trailing spaces
(trailing-spaces)
[error] 27-27: trailing spaces
(trailing-spaces)
[error] 28-28: trailing spaces
(trailing-spaces)
[error] 29-29: trailing spaces
(trailing-spaces)
[error] 31-31: trailing spaces
(trailing-spaces)
[error] 33-33: trailing spaces
(trailing-spaces)
[error] 34-34: trailing spaces
(trailing-spaces)
[error] 36-36: trailing spaces
(trailing-spaces)
[error] 41-41: trailing spaces
(trailing-spaces)
[error] 46-46: trailing spaces
(trailing-spaces)
[error] 71-71: trailing spaces
(trailing-spaces)
scripts/githooks/check-localstorage-usage.js (1)
87-93
: Use trailing commas if your lint/prettier config requires them.Your static-analysis hints suggest adding trailing commas at lines 89 and 92. This is likely a code-style preference from your Prettier configuration. If you adopt trailing commas, you can fix it by adding a comma before the closing parenthesis.
console.info( '\x1b[34m%s\x1b[0m', - '\nInfo: Consider using custom hook functions.' + '\nInfo: Consider using custom hook functions.', ); console.info( 'Please use the getItem, setItem, and removeItem functions provided by the custom hook useLocalStorage.\n' -); +);🧰 Tools
🪛 eslint
[error] 89-89: Insert
,
(prettier/prettier)
[error] 92-92: Insert
,
(prettier/prettier)
schema.graphql (5)
32-41
: Add validation for Address fields.The Address type and its input should include validation for postal codes and country codes.
type Address { city: String - countryCode: String + countryCode: CountryCode! dependentLocality: String line1: String line2: String - postalCode: String + postalCode: String @constraint( + pattern: "^[0-9A-Z]{3,10}$" + ) sortingCode: String state: String }Also applies to: 43-52
915-930
: Add moderation capabilities to Post type.Posts should include moderation status and reporting functionality.
type Post { # ... existing fields ... + moderationStatus: ModerationStatus! + reports: [Report!] updatedAt: DateTime! } +enum ModerationStatus { + APPROVED + PENDING + REJECTED + FLAGGED +} +type Report { + _id: ID! + reporter: User! + reason: String! + createdAt: DateTime! +}
861-876
: Standardize pagination implementation.The schema uses different pagination patterns (offset-based and cursor-based). Standardize on cursor-based pagination for better scalability.
Use the
ConnectionPageInfo
type consistently across all paginated queries instead of mixing withPageInfo
.Also applies to: 1433-1436
103-103
: Add descriptions for scalar types.Scalar types lack descriptions explaining their format and validation rules.
Add descriptions for all scalar types, for example:
-scalar DateTime +""" +An ISO-8601 encoded UTC date string. +Format: YYYY-MM-DDTHH:mm:ss.sssZ +""" +scalar DateTimeAlso applies to: 209-209, 211-211, 263-263, 459-459, 883-883, 913-913, 1119-1119, 1138-1138, 1292-1292
1449-1454
: Standardize enum naming conventions.The
UserType
enum uses inconsistent naming patterns. Consider using snake_case for all enum values.enum UserType { - ADMIN - NON_USER - SUPERADMIN - USER + ADMIN_USER + NON_USER + SUPER_ADMIN + REGULAR_USER }public/locales/hi/common.json (3)
9-10
: Consider differentiating between singular and plural forms of "admin"The same word "व्यवस्थापक" is used for both "admin" and "admins". Consider using "व्यवस्थापकगण" for the plural form to better distinguish between singular and plural.
79-79
: Review placeholder positioning for better Hindi readabilityIn Hindi, the natural sentence structure might be different from English. Consider:
- For "searchResultsFor": Move "के लिए" before {{text}} for better flow
- For success messages: Move {{item}} to the beginning of the sentence
Example improvements:
- "searchResultsFor": "{{text}} के लिए खोज परिणाम", + "searchResultsFor": "के लिए {{text}} खोज परिणाम", - "addedSuccessfully": "{{item}} सफलतापूर्वक जोड़ा गया", + "addedSuccessfully": "{{item}} को सफलतापूर्वक जोड़ा गया",Also applies to: 83-85
86-87
: Consider shorter translations for session messagesThe current translations, while accurate, are quite lengthy. Consider more concise versions while maintaining clarity:
- "sessionWarning": "आपका सत्र निष्क्रियता के कारण जल्द ही समाप्त हो जाएगा। कृपया अपने सत्र को बढ़ाने के लिए पृष्ठ के साथ बातचीत करें।", + "sessionWarning": "निष्क्रियता के कारण सत्र समाप्त होने वाला है। कृपया पृष्ठ का उपयोग जारी रखें।", - "sessionLogOut": "निष्क्रियता के कारण आपका सत्र समाप्त हो गया है। कृपया जारी रखने के लिए पुनः लॉगिन करें।", + "sessionLogOut": "सत्र समाप्त। कृपया पुनः लॉगिन करें।",.husky/post-merge (1)
4-4
: Consider more robust error handling fornpm install
.
Ifnpm install
fails, the hook will continue, potentially causing an inconsistent local environment. You might want to check the exit status ofnpm install
and abort the merge if the installation fails.git diff HEAD^ HEAD --exit-code -- ./package.json || npm install +if [ $? -ne 0 ]; then + echo "npm install encountered an error. Please fix and re-run." + exit 1 +fi.husky/pre-commit (2)
5-5
: Clarify whether lint fixes should run automatically.
You’ve commented outnpm run lint:fix
. If you do want to auto-fix lint errors on commit, uncomment it. Otherwise, it might be best to remove it for clarity.-# npm run lint:fix +npm run lint:fix
10-10
: Avoid staging all changes automatically.
Runninggit add .
can stage changes not previously staged. Consider only re-staging the files fixed by these commands to avoid unintended commits.- git add . + # Consider limiting to staged files only, e.g.: + git add $(git diff --name-only --staged)scripts/githooks/update-toc.js (1)
11-12
: Remove extra blank line to comply with Prettier rules.
Prettier flags the blank line as an unnecessary whitespace. Removing it helps maintain a consistent code style.execSync(command, { stdio: 'inherit' }); - }); +});🧰 Tools
🪛 eslint
[error] 11-12: Delete
··⏎
(prettier/prettier)
scripts/custom-test-env.js (2)
5-5
: Define a valid tag for@pdfme
or remove it.
Your TSDoc configuration may not recognize the@pdfme
tag. If you need a custom tag, configure it in your TSDoc settings; otherwise, remove or replace it.🧰 Tools
🪛 eslint
[error] 5-5: tsdoc-undefined-tag: The TSDoc tag "@pdfme" is not defined in this configuration
(tsdoc/syntax)
9-15
: Add an explicit return type forsetup()
.
TypeScript rules recommend explicit return types, especially for overriden methods.export default class CustomTestEnvironment extends Environment { - async setup() { + async setup(): Promise<void> { await super.setup(); if (typeof this.global.TextEncoder === 'undefined') { this.global.TextEncoder = TextEncoder; this.global.TextDecoder = TextDecoder; } } }🧰 Tools
🪛 eslint
[error] 9-9: Missing return type on function.
(@typescript-eslint/explicit-function-return-type)
[error] 9-9: Missing return type on function.
(@typescript-eslint/explicit-module-boundary-types)
config/vite.config.ts (1)
27-28
: Correct the misleading comment about the port.
The comment suggests a default port of 3000, but the code sets it to 4321. Updating the comment clarifies the intended port for future maintainers.-// this sets a default port to 3000 +// this sets a default port to 4321scripts/__mocks__/@pdfme/generator.ts (2)
3-13
: Validate template and inputs more comprehensively.
Currently, the code only checks iftemplate.schemas.length
andinputs.length
are zero. Consider validating forundefined
ornull
values before checking lengths.if (!template || !template.schemas || template.schemas.length === 0 || !inputs || inputs.length === 0) { throw new Error('Template or inputs cannot be empty.'); }
10-13
: Log the validation error for debugging.
Adding a more descriptive log message can help when diagnosing PDF generation issues.} catch (err) { console.error('Error generating mock PDF:', err); throw err; }.github/workflows/check-tsdoc.js (2)
14-35
: Improve error handling for directory traversal.
Consider terminating the script after logging the directory read error, or re-throwing it. This will prevent silent failures if the script cannot read the directory.} catch (err) { console.error(`Error reading directory ${dir}: ${err.message}`); + process.exit(1); }
37-46
: Refine the TSDoc detection logic.
The current regex checks for any/**
comment, but it may match comments that are not necessarily structured as TSDoc. You could refine the pattern to detect TSDoc tags or placeholders for more accurate results..github/workflows/talawa_admin_md_mdx_format_adjuster.py (1)
39-44
: Consider memory usage for large files.While reading the entire file into memory can be convenient for smaller files, it might be inefficient for extremely large Markdown files. If your repository holds potentially large documentation, consider a streaming approach to parse and process the files in chunks.
.github/workflows/eslint_disable_check.py (1)
61-61
: Rename unused variable to underscore for clarity.The
dirs
variable is not used inside the loop. Renaming it to_dirs
helps convey that it's intentionally unused, improving code readability:-for root, dirs, files in os.walk(os.path.join(directory, 'src')): +for root, _dirs, files in os.walk(os.path.join(directory, 'src')):🧰 Tools
🪛 Ruff (0.8.2)
61-61: Loop control variable
dirs
not used within loop bodyRename unused
dirs
to_dirs
(B007)
setup.ts (1)
87-95
: Consider edge cases when updating WebSocket URLs.Replacing
http(s)://
withws(s)://
is straightforward, but consider edge cases where endpoints might have unusual prefixes. Also, ensure you handle trailing slashes or query parameters consistently..github/workflows/compare_translations.py (1)
135-135
: Raise exceptions with cause
Consider raising a chained exception usingraise ValueError(...) from e
to preserve the original stack trace context and distinguish decoding issues from higher-level exceptions.🧰 Tools
🪛 Ruff (0.8.2)
135-135: Within an
except
clause, raise exceptions withraise ... from err
orraise ... from None
to distinguish them from errors in exception handling(B904)
.github/workflows/countline.py (1)
246-264
: Potential improvement for multi-line or block comments
Currently, only lines starting with#
or/
are skipped. If your repository uses multi-line comments (e.g.,/* ... */
in some languages), you may want to enhance comment detection to avoid miscounting lines..github/ISSUE_TEMPLATE/feature-request.md (1)
25-28
: Replace bare URL with a markdown link
To address Markdownlint’s “no-bare-urls” rule, embed the link in markdown, for example:[Potential internship candidates](https://github.com/PalisadoesFoundation/talawa/issues/359)
🧰 Tools
🪛 Markdownlint (0.37.0)
28-28: null
Bare URL used(MD034, no-bare-urls)
25-25: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
.github/workflows/codeql-codescan.yml (1)
17-17
: Fix YAML formatting issues.There are some minor YAML formatting inconsistencies:
- Trailing spaces
- Indentation mismatches
Apply these changes:
- Remove trailing spaces after
'**'
- Fix indentation to use consistent spacing (6 spaces for steps, 11 spaces for action parameters)
Also applies to: 20-20, 31-31, 37-37
🧰 Tools
🪛 yamllint (1.35.1)
[error] 17-17: trailing spaces
(trailing-spaces)
.github/pull_request_template.md (2)
22-25
: Enhance issue reference section formatting.Consider making the issue reference format more explicit to ensure consistent linking.
-**Issue Number:** - -Fixes #<!--Add related issue number here.--> +**Issue Number:** (Required) + +Fixes #<!--Add issue number (e.g., Fixes #123)-->
28-33
: Clarify test requirements section.The test section could be more specific about expectations.
-<!--Yes or No. Note: Add unit tests or automation tests for your code.--> +<!-- +Answer: Yes/No + +If Yes: Describe which tests were added +If No: Explain why tests are not needed +--> -<!--Add snapshots or videos wherever possible.--> +<!--Add snapshots/videos demonstrating the changes (if applicable)-->DOCUMENTATION.md (3)
24-26
: Fix grammar and URL formatting.There are some grammar and formatting issues in the Docusaurus section.
- - A local version of `docs.talawa.io` should automatically launched in your browser at http://localhost:3000/ + - A local version of `docs.talawa.io` should automatically launch in your browser at `http://localhost:3000`🧰 Tools
🪛 LanguageTool
[grammar] ~25-~25: The modal verb ‘should’ requires the verb’s base form.
Context: ...fdocs.talawa.io
should automatically launched in your browser at http://localhost:300...(MD_BASEFORM)
[grammar] ~26-~26: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...ttp://localhost:3000/ 1. Add/modify the markdown documents to thedocs/
directory of t...(MARKDOWN_NNP)
🪛 Markdownlint (0.37.0)
25-25: null
Bare URL used(MD034, no-bare-urls)
26-29
: Improve Markdown formatting consistency.Ensure consistent capitalization and formatting for technical terms.
-1. Add/modify the markdown documents to the `docs/` directory of the `talawa-docs` repository +1. Add/modify the Markdown documents to the `docs/` directory of the `talawa-docs` repository -1. Always monitor the local website in your brower to make sure the changes are acceptable. +1. Always monitor the local website in your browser to make sure the changes are acceptable.🧰 Tools
🪛 LanguageTool
[grammar] ~26-~26: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...ttp://localhost:3000/ 1. Add/modify the markdown documents to thedocs/
directory of t...(MARKDOWN_NNP)
31-32
: Refine repository reference.The final directive could be more specific.
-***PLEASE*** do not add markdown files in this repository. Add them to `talawa-docs`! +***IMPORTANT:*** Do not add Markdown files to this repository. Add all documentation to the [`talawa-docs`](https://github.com/PalisadoesFoundation/talawa-docs) repository instead.🧰 Tools
🪛 LanguageTool
[uncategorized] ~32-~32: The preposition “to” seems more likely in this position.
Context: ... PLEASE do not add markdown files in this repository. Add them to `talawa-do...(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)
.github/workflows/README.md (2)
24-24
: Fix typo in documentationThere's a duplicate "to" in the sentence.
- 1. Place all actions related to to this in the `pull-request-target.yml` file. + 1. Place all actions related to this in the `pull-request-target.yml` file.🧰 Tools
🪛 LanguageTool
[duplication] ~24-~24: Possible typo: you repeated a word
Context: ...ors: 1. Place all actions related to to this in thepull-request-target.yml
f...(ENGLISH_WORD_REPEAT_RULE)
35-35
: Fix abbreviation formatThe abbreviation "eg." should be "e.g." (with periods).
-1. Jobs only work correctly if they have a dedicated file (eg. `CodeQL`) +1. Jobs only work correctly if they have a dedicated file (e.g., `CodeQL`)🧰 Tools
🪛 LanguageTool
[uncategorized] ~35-~35: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...orrectly if they have a dedicated file (eg.CodeQL
) ## Scripts Follow these gui...(E_G)
.github/workflows/issue.yml (1)
34-55
: Optimize label management logicThe current implementation has redundant object creation and could be simplified.
- const { owner, repo } = context.repo; - const issue_number = context.issue.number; - const apiParams = { - owner, - repo, - issue_number - }; - const labels = await github.rest.issues.listLabelsOnIssue(apiParams); + const labels = await github.rest.issues.listLabelsOnIssue({ + ...context.repo, + issue_number: context.issue.number + }); if(labels.data.reduce((a, c)=>a||["dependencies"].includes(c.name), false)) await github.rest.issues.addLabels({ - owner: context.repo.owner, - repo: context.repo.repo, - issue_number: context.issue.number, + ...context.repo, + issue_number: context.issue.number, labels: ["good first issue", "security"] }); else if(labels.data.reduce((a, c)=>a||["security", "ui/ux"].includes(c.name), false)) await github.rest.issues.addLabels({ - owner: context.repo.owner, - repo: context.repo.repo, - issue_number: context.issue.number, + ...context.repo, + issue_number: context.issue.number, labels: ["good first issue"] });ISSUE_GUIDELINES.md (3)
5-5
: Fix grammatical error in the introductionThere's a grammatical error in the sentence structure.
-In order to give everyone a chance to submit a issues reports and contribute to the Talawa project +In order to give everyone a chance to submit issue reports and contribute to the Talawa project🧰 Tools
🪛 LanguageTool
[misspelling] ~5-~5: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...der to give everyone a chance to submit a issues reports and contribute to the Ta...(EN_A_VS_AN)
29-29
: Fix typo in the search instructionsThe sentence contains a duplicated word and incorrect punctuation.
-Your issue may have already been created. Search for duplicate open issues before submitting yours.for similar deficiencies in the code.duplicate issues are created. +Your issue may have already been created. Search for duplicate open issues before submitting yours for similar deficiencies in the code.
44-44
: Capitalize "Slack" in channel references"Slack" is a proper noun and should be capitalized.
-Ask our contributors to assign it to you in `#talawa` slack channel. +Ask our contributors to assign it to you in `#talawa` Slack channel. -Join our `#talawa-github` slack channel for automatic issue and pull request updates. +Join our `#talawa-github` Slack channel for automatic issue and pull request updates. -Discuss issues in our various slack channels when necessary +Discuss issues in our various Slack channels when necessaryAlso applies to: 53-53, 57-57
🧰 Tools
🪛 LanguageTool
[grammar] ~44-~44: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...butors to assign it to you in#talawa
slack channel. Working on these types of exi...(ON_SKYPE)
README.md (1)
53-53
: Fix markdown heading formattingRemove extra space after the hash symbol in the heading.
-# Videos +# Videos🧰 Tools
🪛 Markdownlint (0.37.0)
53-53: null
Multiple spaces after hash on atx style heading(MD019, no-multiple-space-atx)
.eslintrc.json (1)
14-16
: Simplify ESLint configuration extendsThe configuration can be simplified by removing redundant extends:
eslint-config-prettier
andprettier
serve the same purpose- Having both might cause conflicts
"extends": [ "plugin:react/recommended", "eslint:recommended", "plugin:jest/recommended", "plugin:prettier/recommended", "plugin:@typescript-eslint/recommended", - "eslint-config-prettier", - "prettier" ],PR_GUIDELINES.md (1)
31-34
: Add language specifiers to code blocksCode blocks should specify the language for proper syntax highlighting.
Update the code blocks to include language specifiers:
-``` +```bash npm run lint:fix npm run format:fix-
+
bash
npm run lint:check
npm run format:checkAlso applies to: 39-42
🧰 Tools
🪛 Markdownlint (0.37.0)
31-31: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
CODE_STYLE.md (2)
58-62
: Add language specifiers to code blocksCode blocks should specify the language for proper syntax highlighting.
Update the code blocks to include language specifiers:
-``` +```jsx <div className="myCustomClass">...</div>-
+
jsx...```-
+
jsx
Dropdown button
...
-``` +```tsx import Dropdown from 'react-bootstrap/Dropdown'; ...
Also applies to: 64-69, 78-89, 95-115 <details> <summary>🧰 Tools</summary> <details> <summary>🪛 Markdownlint (0.37.0)</summary> 58-58: null Fenced code blocks should have a language specified (MD040, fenced-code-language) </details> </details> --- `239-241`: **Add language specifiers to Sass compilation commands** The Sass compilation command blocks should specify the shell language. Update the code blocks: ```diff -``` +```bash npx sass src/assets/scss/app.scss src/assets/css/app.css
-
+
bash
npx sass src/assets/scss/app.scss src/assets/css/app.css --watch-``` +```bash npx sass --no-source-map src/assets/scss/app.scss src/assets/css/app.css
Also applies to: 245-247, 251-253 <details> <summary>🧰 Tools</summary> <details> <summary>🪛 Markdownlint (0.37.0)</summary> 239-239: null Fenced code blocks should have a language specified (MD040, fenced-code-language) </details> </details> </blockquote></details> <details> <summary>.github/workflows/pull-request.yml (1)</summary><blockquote> `253-254`: **Consider using a more specific glob pattern** While the GraphQL validation is good, the glob pattern could be more specific to target only files with GraphQL operations. Consider this change: ```diff - graphql-inspector validate './src/GraphQl/**/*.ts' './talawa-api/schema.graphql' + graphql-inspector validate './src/GraphQl/**/*{Query,Mutation,Fragment,Subscription}.ts' './talawa-api/schema.graphql'
.github/ISSUE_TEMPLATE/bug-report.md (1)
33-36
: Improve markdown formattingThe internship section needs formatting improvements:
- Use proper heading syntax instead of bold text
- Format URL as a markdown link
Apply these changes:
-**Potential internship candidates** +## Potential internship candidates Please read this if you are planning to apply for a Palisadoes Foundation internship -https://github.com/PalisadoesFoundation/talawa/issues/359 +[Internship Information](https://github.com/PalisadoesFoundation/talawa/issues/359)🧰 Tools
🪛 Markdownlint (0.37.0)
36-36: null
Bare URL used(MD034, no-bare-urls)
33-33: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (75)
package-lock.json
is excluded by!**/package-lock.json
public/favicon.ico
is excluded by!**/*.ico
public/favicon_palisadoes.ico
is excluded by!**/*.ico
public/images/logo512.png
is excluded by!**/*.png
public/images/svg/angleDown.svg
is excluded by!**/*.svg
public/images/svg/arrow-left.svg
is excluded by!**/*.svg
public/images/svg/arrow-right.svg
is excluded by!**/*.svg
public/images/svg/attendees.svg
is excluded by!**/*.svg
public/images/svg/feedback.svg
is excluded by!**/*.svg
public/images/svg/profiledefault.svg
is excluded by!**/*.svg
public/images/svg/up-down.svg
is excluded by!**/*.svg
public/logo192.png
is excluded by!**/*.png
public/markdown/images/install1.png
is excluded by!**/*.png
public/markdown/images/install2.png
is excluded by!**/*.png
src/assets/css/app.css.map
is excluded by!**/*.map
src/assets/images/blank.png
is excluded by!**/*.png
src/assets/images/bronze.png
is excluded by!**/*.png
src/assets/images/defaultImg.png
is excluded by!**/*.png
src/assets/images/gold.png
is excluded by!**/*.png
src/assets/images/palisadoes_logo.png
is excluded by!**/*.png
src/assets/images/silver.png
is excluded by!**/*.png
src/assets/images/talawa-logo-600x600.png
is excluded by!**/*.png
src/assets/images/talawa-logo-dark-200x200.png
is excluded by!**/*.png
src/assets/images/talawa-logo-lite-200x200.png
is excluded by!**/*.png
src/assets/svgs/Attendance.svg
is excluded by!**/*.svg
src/assets/svgs/actionItem.svg
is excluded by!**/*.svg
src/assets/svgs/admin.svg
is excluded by!**/*.svg
src/assets/svgs/agenda-category-icon.svg
is excluded by!**/*.svg
src/assets/svgs/agenda-items.svg
is excluded by!**/*.svg
src/assets/svgs/angleRight.svg
is excluded by!**/*.svg
src/assets/svgs/article.svg
is excluded by!**/*.svg
src/assets/svgs/blockUser.svg
is excluded by!**/*.svg
src/assets/svgs/blockedUser.svg
is excluded by!**/*.svg
src/assets/svgs/cardItemDate.svg
is excluded by!**/*.svg
src/assets/svgs/cardItemEvent.svg
is excluded by!**/*.svg
src/assets/svgs/cardItemLocation.svg
is excluded by!**/*.svg
src/assets/svgs/chat.svg
is excluded by!**/*.svg
src/assets/svgs/checkInRegistrants.svg
is excluded by!**/*.svg
src/assets/svgs/dashboard.svg
is excluded by!**/*.svg
src/assets/svgs/date.svg
is excluded by!**/*.svg
src/assets/svgs/event.svg
is excluded by!**/*.svg
src/assets/svgs/events.svg
is excluded by!**/*.svg
src/assets/svgs/flask.svg
is excluded by!**/*.svg
src/assets/svgs/funds.svg
is excluded by!**/*.svg
src/assets/svgs/key.svg
is excluded by!**/*.svg
src/assets/svgs/listEventRegistrants.svg
is excluded by!**/*.svg
src/assets/svgs/location.svg
is excluded by!**/*.svg
src/assets/svgs/logout.svg
is excluded by!**/*.svg
src/assets/svgs/media.svg
is excluded by!**/*.svg
src/assets/svgs/newChat.svg
is excluded by!**/*.svg
src/assets/svgs/organizations.svg
is excluded by!**/*.svg
src/assets/svgs/palisadoes.svg
is excluded by!**/*.svg
src/assets/svgs/people.svg
is excluded by!**/*.svg
src/assets/svgs/plugins.svg
is excluded by!**/*.svg
src/assets/svgs/post.svg
is excluded by!**/*.svg
src/assets/svgs/posts.svg
is excluded by!**/*.svg
src/assets/svgs/requests.svg
is excluded by!**/*.svg
src/assets/svgs/roles.svg
is excluded by!**/*.svg
src/assets/svgs/settings.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Facebook-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Github-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Instagram-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Linkedin-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Reddit-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Slack-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/X-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Youtube-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/tag.svg
is excluded by!**/*.svg
src/assets/svgs/tags.svg
is excluded by!**/*.svg
src/assets/svgs/talawa.svg
is excluded by!**/*.svg
src/assets/svgs/user.svg
is excluded by!**/*.svg
src/assets/svgs/userEvent.svg
is excluded by!**/*.svg
src/assets/svgs/users.svg
is excluded by!**/*.svg
src/assets/svgs/venues.svg
is excluded by!**/*.svg
src/assets/talawa-logo-lite-200x200.png
is excluded by!**/*.png
📒 Files selected for processing (82)
.coderabbit.yaml
(1 hunks).env.example
(1 hunks).eslintignore
(1 hunks).eslintrc.json
(4 hunks).github/ISSUE_TEMPLATE/bug-report.md
(2 hunks).github/ISSUE_TEMPLATE/feature-request.md
(2 hunks).github/dependabot.yaml
(1 hunks).github/pull_request_template.md
(2 hunks).github/workflows/README.md
(1 hunks).github/workflows/auto-label.json5
(1 hunks).github/workflows/check-tsdoc.js
(1 hunks).github/workflows/ci.yml
(0 hunks).github/workflows/codeql-analysis.yml
(0 hunks).github/workflows/codeql-codescan.yml
(1 hunks).github/workflows/compare_translations.py
(1 hunks).github/workflows/countline.py
(1 hunks).github/workflows/eslint_disable_check.py
(1 hunks).github/workflows/issue.yml
(1 hunks).github/workflows/linter.yml
(0 hunks).github/workflows/npm-publish.yml
(0 hunks).github/workflows/pull-request-target.yml
(1 hunks).github/workflows/pull-request.yml
(1 hunks).github/workflows/push.yml
(1 hunks).github/workflows/stale.yml
(1 hunks).github/workflows/talawa_admin_md_mdx_format_adjuster.py
(1 hunks).gitignore
(2 hunks).husky/post-merge
(1 hunks).husky/pre-commit
(1 hunks).lintstagedrc.json
(1 hunks).node-version
(1 hunks).prettierignore
(1 hunks).prettierrc
(1 hunks)CODEOWNERS
(1 hunks)CODE_OF_CONDUCT.md
(1 hunks)CODE_STYLE.md
(1 hunks)CONTRIBUTING.md
(2 hunks)DOCUMENTATION.md
(1 hunks)Docker_Container/.dockerignore
(0 hunks)Docker_Container/README.md
(0 hunks)Docker_Container/docker-compose.yml
(0 hunks)Docker_Container/dockerfile
(0 hunks)INSTALLATION.md
(1 hunks)ISSUE_GUIDELINES.md
(1 hunks)ISSUE_TEMPLATE.md
(0 hunks)PR-guidelines.md
(0 hunks)PR_GUIDELINES.md
(1 hunks)PULL_REQUEST_TEMPLATE.md
(0 hunks)README.md
(3 hunks)config/babel.config.cjs
(1 hunks)config/vite.config.ts
(1 hunks)index.html
(1 hunks)issue-guidelines.md
(0 hunks)jest-preview.config.ts
(1 hunks)jest.config.js
(1 hunks)package.json
(2 hunks)public/index.html
(0 hunks)public/locales/en/common.json
(1 hunks)public/locales/en/errors.json
(1 hunks)public/locales/en/translation.json
(1 hunks)public/locales/fr/common.json
(1 hunks)public/locales/fr/errors.json
(1 hunks)public/locales/fr/translation.json
(1 hunks)public/locales/hi/common.json
(1 hunks)public/locales/hi/errors.json
(1 hunks)public/locales/hi/translation.json
(1 hunks)public/locales/sp/common.json
(1 hunks)public/locales/sp/errors.json
(1 hunks)public/locales/sp/translation.json
(1 hunks)public/locales/zh/common.json
(1 hunks)public/locales/zh/errors.json
(1 hunks)public/locales/zh/translation.json
(1 hunks)public/manifest.json
(1 hunks)schema.graphql
(1 hunks)scripts/__mocks__/@dicebear/collection.ts
(1 hunks)scripts/__mocks__/@dicebear/core.ts
(1 hunks)scripts/__mocks__/@pdfme/generator.test.ts
(1 hunks)scripts/__mocks__/@pdfme/generator.ts
(1 hunks)scripts/__mocks__/fileMock.js
(1 hunks)scripts/custom-test-env.js
(1 hunks)scripts/githooks/check-localstorage-usage.js
(1 hunks)scripts/githooks/update-toc.js
(1 hunks)setup.ts
(1 hunks)
⛔ Files not processed due to max files limit (28)
- src/App.test.tsx
- src/App.tsx
- src/Constant/constant.spec.ts
- src/Constant/constant.ts
- src/GraphQl/Mutations/ActionItemCategoryMutations.ts
- src/GraphQl/Mutations/ActionItemMutations.ts
- src/GraphQl/Mutations/AgendaCategoryMutations.ts
- src/GraphQl/Mutations/AgendaItemMutations.ts
- src/GraphQl/Mutations/CampaignMutation.ts
- src/GraphQl/Mutations/CommentMutations.ts
- src/GraphQl/Mutations/EventAttendeeMutations.ts
- src/GraphQl/Mutations/EventVolunteerMutation.ts
- src/GraphQl/Mutations/FundMutation.ts
- src/GraphQl/Mutations/OrganizationMutations.ts
- src/GraphQl/Mutations/PledgeMutation.ts
- src/GraphQl/Mutations/TagMutations.ts
- src/GraphQl/Mutations/VenueMutations.ts
- src/GraphQl/Mutations/mutations.ts
- src/GraphQl/Queries/ActionItemCategoryQueries.ts
- src/GraphQl/Queries/ActionItemQueries.ts
- src/GraphQl/Queries/AgendaCategoryQueries.ts
- src/GraphQl/Queries/AgendaItemQueries.ts
- src/GraphQl/Queries/EventVolunteerQueries.ts
- src/GraphQl/Queries/OrganizationQueries.ts
- src/GraphQl/Queries/PlugInQueries.ts
- src/GraphQl/Queries/Queries.ts
- src/GraphQl/Queries/fundQueries.ts
- src/GraphQl/Queries/userTagQueries.ts
💤 Files with no reviewable changes (13)
- .github/workflows/ci.yml
- public/index.html
- ISSUE_TEMPLATE.md
- PR-guidelines.md
- PULL_REQUEST_TEMPLATE.md
- Docker_Container/dockerfile
- issue-guidelines.md
- .github/workflows/linter.yml
- Docker_Container/.dockerignore
- Docker_Container/docker-compose.yml
- Docker_Container/README.md
- .github/workflows/npm-publish.yml
- .github/workflows/codeql-analysis.yml
✅ Files skipped from review due to trivial changes (26)
- .eslintignore
- .node-version
- .github/dependabot.yaml
- public/locales/zh/errors.json
- scripts/mocks/fileMock.js
- .github/workflows/auto-label.json5
- scripts/mocks/@dicebear/core.ts
- public/locales/fr/errors.json
- scripts/mocks/@dicebear/collection.ts
- config/babel.config.cjs
- .prettierrc
- CODEOWNERS
- .coderabbit.yaml
- jest-preview.config.ts
- .prettierignore
- .lintstagedrc.json
- public/locales/sp/translation.json
- .env.example
- public/locales/fr/translation.json
- index.html
- public/locales/hi/translation.json
- public/locales/hi/errors.json
- public/locales/zh/common.json
- public/locales/fr/common.json
- public/locales/en/common.json
- public/locales/sp/common.json
🧰 Additional context used
📓 Learnings (1)
scripts/githooks/check-localstorage-usage.js (1)
Learnt from: MayankJha014
PR: PalisadoesFoundation/talawa-admin#2612
File: scripts/githooks/check-localstorage-usage.js:10-18
Timestamp: 2024-12-07T14:25:09.928Z
Learning: TypeScript type annotations should not be added to JavaScript (`.js`) files in this project. Type annotations can only be used in TypeScript (`.ts` or `.tsx`) files.
🪛 eslint
scripts/custom-test-env.js
[error] 5-5: tsdoc-undefined-tag: The TSDoc tag "@pdfme" is not defined in this configuration
(tsdoc/syntax)
[error] 9-9: Missing return type on function.
(@typescript-eslint/explicit-function-return-type)
[error] 9-9: Missing return type on function.
(@typescript-eslint/explicit-module-boundary-types)
scripts/githooks/update-toc.js
[error] 11-12: Delete ··⏎
(prettier/prettier)
jest.config.js
[error] 33-33: Delete ·
(prettier/prettier)
[error] 34-34: Insert ,
(prettier/prettier)
scripts/githooks/check-localstorage-usage.js
[error] 10-10: Missing return type on function.
(@typescript-eslint/explicit-function-return-type)
[error] 20-20: Missing return type on function.
(@typescript-eslint/explicit-function-return-type)
[error] 43-43: Missing return type on function.
(@typescript-eslint/explicit-function-return-type)
[error] 89-89: Insert ,
(prettier/prettier)
[error] 92-92: Insert ,
(prettier/prettier)
🪛 actionlint (1.7.4)
.github/workflows/codeql-codescan.yml
35-35: the runner of "github/codeql-action/init@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
41-41: the runner of "github/codeql-action/autobuild@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
44-44: the runner of "github/codeql-action/analyze@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/stale.yml
28-28: the runner of "actions/stale@v8" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/pull-request.yml
61-61: property "changed_files" is not defined in object type {changed-files: {conclusion: string; outcome: string; outputs: {string => string}}}
(expression)
62-62: shellcheck reported issue in this script: SC2086:info:1:12: Double quote to prevent globbing and word splitting
(shellcheck)
79-79: "github.event.pull_request.head.ref" is potentially untrusted. avoid using it directly in inline scripts. instead, pass it through an environment variable. see https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions for more details
(expression)
.github/workflows/issue.yml
29-29: the runner of "actions/github-script@v6" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🪛 yamllint (1.35.1)
.github/workflows/codeql-codescan.yml
[error] 6-6: trailing spaces
(trailing-spaces)
[error] 17-17: trailing spaces
(trailing-spaces)
[error] 20-20: trailing spaces
(trailing-spaces)
[warning] 31-31: wrong indentation: expected 6 but found 7
(indentation)
[warning] 37-37: wrong indentation: expected 11 but found 10
(indentation)
.github/workflows/stale.yml
[error] 6-6: trailing spaces
(trailing-spaces)
[error] 20-20: trailing spaces
(trailing-spaces)
[error] 21-21: trailing spaces
(trailing-spaces)
.github/workflows/pull-request-target.yml
[error] 6-6: trailing spaces
(trailing-spaces)
[error] 13-13: trailing spaces
(trailing-spaces)
[error] 15-15: trailing spaces
(trailing-spaces)
[error] 27-27: trailing spaces
(trailing-spaces)
[error] 28-28: trailing spaces
(trailing-spaces)
[error] 29-29: trailing spaces
(trailing-spaces)
[error] 31-31: trailing spaces
(trailing-spaces)
[error] 33-33: trailing spaces
(trailing-spaces)
[error] 34-34: trailing spaces
(trailing-spaces)
[error] 36-36: trailing spaces
(trailing-spaces)
[error] 41-41: trailing spaces
(trailing-spaces)
[error] 46-46: trailing spaces
(trailing-spaces)
[error] 71-71: trailing spaces
(trailing-spaces)
.github/workflows/push.yml
[error] 6-6: trailing spaces
(trailing-spaces)
[error] 17-17: trailing spaces
(trailing-spaces)
[error] 18-18: trailing spaces
(trailing-spaces)
[warning] 20-20: wrong indentation: expected 2 but found 4
(indentation)
[error] 21-21: trailing spaces
(trailing-spaces)
[error] 50-50: trailing spaces
(trailing-spaces)
[warning] 62-62: too many blank lines
(1 > 0) (empty-lines)
.github/workflows/pull-request.yml
[error] 49-49: trailing spaces
(trailing-spaces)
[error] 60-60: trailing spaces
(trailing-spaces)
[error] 63-63: trailing spaces
(trailing-spaces)
[error] 92-92: trailing spaces
(trailing-spaces)
[error] 126-126: trailing spaces
(trailing-spaces)
[error] 129-129: trailing spaces
(trailing-spaces)
[error] 150-150: trailing spaces
(trailing-spaces)
[error] 157-157: trailing spaces
(trailing-spaces)
[error] 197-197: trailing spaces
(trailing-spaces)
[error] 201-201: trailing spaces
(trailing-spaces)
[error] 204-204: trailing spaces
(trailing-spaces)
[error] 205-205: trailing spaces
(trailing-spaces)
[error] 213-213: trailing spaces
(trailing-spaces)
[error] 243-243: trailing spaces
(trailing-spaces)
[error] 249-249: trailing spaces
(trailing-spaces)
[error] 251-251: trailing spaces
(trailing-spaces)
.github/workflows/issue.yml
[error] 6-6: trailing spaces
(trailing-spaces)
[warning] 15-15: wrong indentation: expected 4 but found 6
(indentation)
[warning] 66-66: too many blank lines
(1 > 0) (empty-lines)
🪛 Markdownlint (0.37.0)
.github/ISSUE_TEMPLATE/feature-request.md
28-28: null
Bare URL used
(MD034, no-bare-urls)
25-25: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
DOCUMENTATION.md
25-25: null
Bare URL used
(MD034, no-bare-urls)
CONTRIBUTING.md
104-104: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
113-113: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
128-128: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
139-139: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
143-143: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
158-158: null
No empty links
(MD042, no-empty-links)
159-159: null
No empty links
(MD042, no-empty-links)
161-161: null
No empty links
(MD042, no-empty-links)
CODE_STYLE.md
128-128: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
129-129: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
130-130: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
131-131: Expected: 2; Actual: 4
Unordered list indentation
(MD007, ul-indent)
132-132: Expected: 2; Actual: 4
Unordered list indentation
(MD007, ul-indent)
133-133: Expected: 2; Actual: 4
Unordered list indentation
(MD007, ul-indent)
134-134: Expected: 2; Actual: 4
Unordered list indentation
(MD007, ul-indent)
135-135: Expected: 2; Actual: 4
Unordered list indentation
(MD007, ul-indent)
136-136: Expected: 2; Actual: 4
Unordered list indentation
(MD007, ul-indent)
137-137: Expected: 2; Actual: 4
Unordered list indentation
(MD007, ul-indent)
164-164: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
165-165: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
166-166: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
57-57: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
73-73: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
75-75: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
92-92: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
190-190: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
230-230: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
58-58: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
65-65: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
78-78: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
95-95: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
158-158: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
173-173: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
181-181: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
239-239: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
245-245: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
251-251: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
PR_GUIDELINES.md
31-31: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
39-39: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
README.md
53-53: null
Multiple spaces after hash on atx style heading
(MD019, no-multiple-space-atx)
INSTALLATION.md
321-321: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time
(MD001, heading-increment)
33-33: Expected: 4; Actual: 6
Unordered list indentation
(MD007, ul-indent)
34-34: Expected: 4; Actual: 6
Unordered list indentation
(MD007, ul-indent)
95-95: null
Dollar signs used before commands without showing output
(MD014, commands-show-output)
105-105: null
Bare URL used
(MD034, no-bare-urls)
142-142: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
154-154: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
164-164: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
188-188: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
194-194: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
200-200: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
208-208: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
214-214: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
220-220: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
240-240: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
256-256: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
264-264: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
270-270: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
292-292: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
300-300: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
313-313: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
327-327: Expected: fenced; Actual: indented
Code block style
(MD046, code-block-style)
335-335: Expected: fenced; Actual: indented
Code block style
(MD046, code-block-style)
178-178: Expected: #setting-up-react_app_talawa_url-in-env-file; Actual: #setting-up-REACT_APP_TALAWA_URL-in-env-file
Link fragments should be valid
(MD051, link-fragments)
178-178: Expected: #setting-up-react_app_recaptcha_site_key-in-env-file; Actual: #setting-up-REACT_APP_RECAPTCHA_SITE_KEY-in-env-file
Link fragments should be valid
(MD051, link-fragments)
.github/ISSUE_TEMPLATE/bug-report.md
36-36: null
Bare URL used
(MD034, no-bare-urls)
33-33: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
🪛 LanguageTool
DOCUMENTATION.md
[grammar] ~25-~25: The modal verb ‘should’ requires the verb’s base form.
Context: ...f docs.talawa.io
should automatically launched in your browser at http://localhost:300...
(MD_BASEFORM)
[grammar] ~26-~26: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...ttp://localhost:3000/ 1. Add/modify the markdown documents to the docs/
directory of t...
(MARKDOWN_NNP)
[uncategorized] ~32-~32: The preposition “to” seems more likely in this position.
Context: ... PLEASE do not add markdown files in this repository. Add them to `talawa-do...
(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)
CONTRIBUTING.md
[style] ~27-~27: This expression usually appears with a “please” in front of it.
Context: ...DUCT.md) to understand what this means. Let us know immediately if you have unacceptable ex...
(INSERT_PLEASE)
[uncategorized] ~34-~34: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...)" videos are extremely helpful for new open source contributors. ## Ways to Contribute I...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
[grammar] ~62-~62: A determiner may be missing.
Context: ...l Request guidelines](PR_GUIDELINES.md) is best resource to follow to start working on ...
(THE_SUPERLATIVE)
[uncategorized] ~68-~68: Loose punctuation mark.
Context: ...ushed to the main
branch: - develop
: For unstable code and bug fixing - `mai...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~69-~69: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...d bug fixing - main
: Where the stable production ready code lies. This is our default branch. ...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
[typographical] ~73-~73: Consider adding a comma.
Context: ...ultiple developers are working on issues there is bound to be a conflict of interest (...
(IF_THERE_COMMA)
[typographical] ~73-~73: Consider adding a comma after ‘Usually’ for more clarity.
Context: ...licts) among issues, PRs or even ideas. Usually these conflicts are resolved in a **Fir...
(RB_LY_COMMA)
[grammar] ~73-~73: Did you mean “served” (as in the idiom ‘first come, first served’)?
Context: ...ts are resolved in a First Come First Serve basis however there are certain excep...
(FIRST_SERVED)
[uncategorized] ~75-~75: Possible missing comma found.
Context: ... an extension or in conflict with other PRs it is important to ask the author of th...
(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~75-~75: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...tant to ask the author of the PR in the slack channel or in their PRs or issues thems...
(ON_SKYPE)
[style] ~77-~77: ‘Last but not the least’ might be wordy. Consider a shorter alternative.
Context: ...y and test that function when needed. - Last but not the least, communication is important make sure t...
(EN_WORDINESS_PREMIUM_LAST_BUT_NOT_THE_LEAST)
[grammar] ~77-~77: It seems that “to” is missing before the verb.
Context: ...t the least, communication is important make sure to talk to other contributors, in ...
(MISSING_TO_BETWEEN_BE_AND_VB)
[grammar] ~77-~77: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ... other contributors, in these cases, in slack channel or in a issue/PR thread. - As a...
(ON_SKYPE)
[misspelling] ~77-~77: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ... in these cases, in slack channel or in a issue/PR thread. - As a last resort the...
(EN_A_VS_AN)
[typographical] ~78-~78: It appears that a comma is missing.
Context: ...el or in a issue/PR thread. - As a last resort the Admins would be responsible for dec...
(DURING_THAT_TIME_COMMA)
[grammar] ~135-~135: The operating system from Apple is written “macOS”.
Context: ...r packages can be found for Windows and MacOS. 6. The currently acceptable c...
(MAC_OS)
[uncategorized] ~163-~163: Possible missing comma found.
Context: ...odecov/results.jpg)]() 1. After making changes you can add them to git locally using `...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~164-~164: Possible missing comma found.
Context: ...o add all changes). 1. After adding the changes you need to commit them using `git comm...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~165-~165: Possible missing comma found.
Context: ...using: git push origin <branch_name>
.(Here branch name must be name of the branch ...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~165-~165: Possible missing article found.
Context: ...: git push origin <branch_name>
.(Here branch name must be name of the branch you wan...
(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~165-~165: Possible missing article found.
Context: ...branch_name>`.(Here branch name must be name of the branch you want to push the chan...
(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~167-~167: Possible missing comma found.
Context: ...test suite passes, either locally or on CI once a PR has been created. 1. Review a...
(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~178-~178: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...dation/talawa) for the link to join our slack channel. 1. We also have a technical em...
(ON_SKYPE)
CODE_STYLE.md
[style] ~127-~127: Consider removing “of” to be more concise
Context: ...tories of src
assets
- This houses all of the static assets used in the project - `...
(ALL_OF_THE)
[style] ~128-~128: Consider removing “of” to be more concise
Context: ... in the project - css
- This houses all of the css files used in the project - `imag...
(ALL_OF_THE)
[style] ~129-~129: Consider removing “of” to be more concise
Context: ... the project - images
- This houses all of the images used in the project - scss
-...
(ALL_OF_THE)
[style] ~130-~130: Consider removing “of” to be more concise
Context: ...in the project - scss
- This houses all of the scss files used in the project - `c...
(ALL_OF_THE)
[grammar] ~134-~134: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ...rms - _talawa.scss
- Partial Sass file for Talawa - _utilities.scss
- Pa...
(HE_VERB_AGR)
[grammar] ~135-~135: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... - _utilities.scss
- Partial Sass file for utilities - _variables.scss
-...
(HE_VERB_AGR)
[grammar] ~136-~136: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... - _variables.scss
- Partial Sass file for variables - app.scss
- Main S...
(HE_VERB_AGR)
[style] ~141-~141: Consider removing “of” to be more concise
Context: ...views/screens Constant
- This houses all of the constants used in the project `GraphQl...
(ALL_OF_THE)
[style] ~143-~143: Consider removing “of” to be more concise
Context: ...in the project GraphQl
- This houses all of the GraphQL queries and mutations used in t...
(ALL_OF_THE)
[style] ~145-~145: Consider removing “of” to be more concise
Context: ...in the project screens
- This houses all of the views/screens to be navigated through i...
(ALL_OF_THE)
[style] ~147-~147: Consider removing “of” to be more concise
Context: ... in Talawa-Admin state
- This houses all of the state management code for the project ...
(ALL_OF_THE)
[uncategorized] ~165-~165: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...following order: - React imports - Third party imports - Local imports If there is...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
PR_GUIDELINES.md
[uncategorized] ~2-~2: Loose punctuation mark.
Context: # Pull Request Guidelines 👍🎉 First off, thanks for taking t...
(UNLIKELY_OPENING_PUNCTUATION)
[style] ~4-~4: Consider a shorter alternative to avoid wordiness.
Context: ...ing the time to contribute! 🎉👍 In order to give everyone a chance to submit a pull...
(IN_ORDER_TO_PREMIUM)
[style] ~46-~46: Style-wise, it’s not ideal to insert an adverb (‘manually’) in the middle of an infinitive construction (‘to test’). Try moving the adverb to avoid split infinitives.
Context: ..., you'll need to tell us what steps you followed to manually test your changes. 1. Please read our [CONTRIBUTING.md](C...
(SPLIT_INFINITIVE)
[style] ~56-~56: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...o be closed. The quality of our code is very important to us. Therefore we make experienced ma...
(EN_WEAK_ADJECTIVE)
[uncategorized] ~56-~56: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ...ty of our code is very important to us. Therefore we make experienced maintainers of our ...
(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
[style] ~59-~59: Consider using a different verb for a more formal wording.
Context: ...check if all tests are passing; if not, fix the issues and then create a pull reque...
(FIX_RESOLVE)
[style] ~64-~64: This expression is wordy and overused. Consider replacing it with a more concise and formal alternative.
Context: ...wer your questions, but we'll get to it sooner or later. @mentioning someone just adds to the p...
(SOONER_OR_LATER)
[uncategorized] ~64-~64: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...adds to the pile of notifications we get and it won't make us look at your issue fas...
(COMMA_COMPOUND_SENTENCE)
[style] ~65-~65: Consider shortening or rephrasing this to strengthen your wording.
Context: ...ue faster. 1. Do not force push. If you make changes to your pull request, please simply add a ...
(MAKE_CHANGES)
.github/workflows/README.md
[duplication] ~24-~24: Possible typo: you repeated a word
Context: ...ors: 1. Place all actions related to to this in the pull-request-target.yml
f...
(ENGLISH_WORD_REPEAT_RULE)
[uncategorized] ~35-~35: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...orrectly if they have a dedicated file (eg. CodeQL
) ## Scripts Follow these gui...
(E_G)
ISSUE_GUIDELINES.md
[uncategorized] ~2-~2: Loose punctuation mark.
Context: # Issue Report Guidelines 👍🎉 First off, thanks for taking t...
(UNLIKELY_OPENING_PUNCTUATION)
[style] ~4-~4: Consider a shorter alternative to avoid wordiness.
Context: ...ing the time to contribute! 🎉👍 In order to give everyone a chance to submit a issu...
(IN_ORDER_TO_PREMIUM)
[misspelling] ~5-~5: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...der to give everyone a chance to submit a issues reports and contribute to the Ta...
(EN_A_VS_AN)
[typographical] ~24-~24: Consider adding a comma here.
Context: ...> ___ ## Issue Management In all cases please use the [GitHub open issue search](http...
(PLEASE_COMMA)
[style] ~30-~30: Consider using a different verb for a more formal wording.
Context: .... 1. Verify whether the issue has been fixed by trying to reproduce it using the lat...
(FIX_RESOLVE)
[style] ~35-~35: The wording of this phrase can be improved.
Context: ...lcome contributors who find new ways to make the code better. ### Existing Issues You can also be ...
(MAKE_STYLE_BETTER)
[grammar] ~44-~44: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...butors to assign it to you in #talawa
slack channel. Working on these types of exi...
(ON_SKYPE)
[grammar] ~53-~53: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...ew Issues 1. Join our #talawa-github
slack channel for automatic issue and pull re...
(ON_SKYPE)
[grammar] ~57-~57: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...lines 1. Discuss issues in our various slack channels when necessary 2. Please do no...
(ON_SKYPE)
[typographical] ~57-~57: Consider adding a comma here.
Context: ...ur various slack channels when necessary 2. Please do not derail or troll issues. 3. Keep...
(PLEASE_COMMA)
README.md
[uncategorized] ~56-~56: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...)" videos are extremely helpful for new open source contributors.
(EN_COMPOUND_ADJECTIVE_INTERNAL)
INSTALLATION.md
[duplication] ~25-~25: Possible typo: you repeated a word
Context: ...](#running-talawa-admin) - Accessing Talawa-Admin - [Talawa-Admin Registration](#talawa-admin-registratio...
(ENGLISH_WORD_REPEAT_RULE)
[typographical] ~55-~55: It appears that a comma is missing.
Context: ... that follow. # Prerequisites In this section we'll explain how to set up all the pre...
(DURING_THAT_TIME_COMMA)
[uncategorized] ~61-~61: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: .... Basic git
knowledge is required for open source contribution so make sure you're comfor...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
[grammar] ~67-~67: The word “setup” is a noun. The verb is spelled with a space.
Context: ...avigate to the folder where you want to setup the repository. 2. Open a cmd
(Window...
(NOUN_VERB_CONFUSION)
[grammar] ~68-~68: The operating system from Apple is written “macOS”.
Context: ...cmd
(Windows) or terminal
(Linux or MacOS) session in this folder. 1. An easy ...
(MAC_OS)
[uncategorized] ~70-~70: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...e option based on your OS. 3. For Our Open Source Contributor Software Developers: ...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
[grammar] ~102-~102: The operating system from Apple is written “macOS”.
Context: ...node.jspackages in Windows, Linux and MacOS. 1. For Windows: 1. first install
...
(MAC_OS)
[duplication] ~116-~116: Possible typo: you repeated a word
Context: ... 5. Save the document. 6. Exit notepad
7. Exit PowerShell 8. This will ensure...
(ENGLISH_WORD_REPEAT_RULE)
[grammar] ~119-~119: The operating system from Apple is written “macOS”.
Context: ...t version of node.js
2. For Linux and MacOS, use the terminal window. 1. install...
(MAC_OS)
[grammar] ~123-~123: The word “setup” is a noun. The verb is spelled with a white space.
Context: ... the respective recommended commands to setup your node environment 3. This wil...
(NOUN_VERB_CONFUSION)
[uncategorized] ~162-~162: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...at runtime. It is not a part of the repo and you will have to create it. For a sampl...
(COMMA_COMPOUND_SENTENCE)
[grammar] ~228-~228: The word “setup” is a noun. The verb is spelled with a space.
Context: ...E_KEY in .env file You may not want to setup reCAPTCHA since the project will still ...
(NOUN_VERB_CONFUSION)
[grammar] ~232-~232: The word “setup” is a noun. The verb is spelled with a space.
Context: ...ad the following steps. If you want to setup Google reCAPTCHA now, you may refer to ...
(NOUN_VERB_CONFUSION)
[typographical] ~246-~246: Except for inverted sentences, ‘need them’ requires a question mark at the end of the sentence.
Context: ...t need them or want to keep the console clean # Post Configuration Steps It's now t...
(MD_PRP_QUESTION_MARK)
[uncategorized] ~261-~261: Did you mean: “By default,”?
Context: ...n serve ``` ## Accessing Talawa-Admin By default talawa-admin
runs on port `4321` on y...
(BY_DEFAULT_COMMA)
[grammar] ~311-~311: The word ‘lint’ is a noun or an adjective. A verb or adverb is missing or misspelled here, or maybe a comma is missing.
Context: ...w.webp) ## Linting code files You can lint your code files using this command: ``...
(PRP_MD_NN)
CODE_OF_CONDUCT.md
[duplication] ~11-~11: Possible typo: you repeated a word
Context: ...-responsibilities) - Scope - Enforcement - Enforcement Guidelines ...
(ENGLISH_WORD_REPEAT_RULE)
🪛 Ruff (0.8.2)
.github/workflows/compare_translations.py
135-135: Within an except
clause, raise exceptions with raise ... from err
or raise ... from None
to distinguish them from errors in exception handling
(B904)
.github/workflows/eslint_disable_check.py
61-61: Loop control variable dirs
not used within loop body
Rename unused dirs
to _dirs
(B007)
🔇 Additional comments (36)
CODE_OF_CONDUCT.md (2)
3-20
: Well-structured table of contents implementation!
The table of contents is properly implemented with:
- Clear hierarchical structure
- Correct markdown link syntax
- Proper section mapping
🧰 Tools
🪛 LanguageTool
[duplication] ~11-~11: Possible typo: you repeated a word
Context: ...-responsibilities) - Scope - Enforcement - Enforcement Guidelines ...
(ENGLISH_WORD_REPEAT_RULE)
11-12
: Ignore the word repetition warning.
The repetition of "Enforcement" in the table of contents is correct as these are distinct sections with different purposes.
🧰 Tools
🪛 LanguageTool
[duplication] ~11-~11: Possible typo: you repeated a word
Context: ...-responsibilities) - Scope - Enforcement - Enforcement Guidelines ...
(ENGLISH_WORD_REPEAT_RULE)
public/manifest.json (1)
16-16
: Verify the new image path exists
The logo path has been moved to the "images" subdirectory. Let's verify this path exists and contains the required image.
✅ Verification successful
Logo path verification successful
The image file exists at the new location public/images/logo512.png
, confirming that the manifest.json correctly references the moved image path.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the existence of the 512x512 logo in the new path
# Check if the image exists in the new location
if [ -f "public/images/logo512.png" ]; then
echo "✓ Image exists at public/images/logo512.png"
else
echo "✗ Image not found at public/images/logo512.png"
# Check if it exists in the old location
if [ -f "public/logo512.png" ]; then
echo "! Image found at old location: public/logo512.png"
echo "! Please move the image to public/images/ directory"
else
echo "! Image not found in old location either"
fi
fi
Length of output: 135
.github/workflows/stale.yml (3)
12-17
: LGTM! Well-configured workflow trigger
The workflow name is descriptive and the daily schedule is appropriate for managing stale items.
22-26
: LGTM! Appropriate job configuration
The job configuration is correctly set up with the latest Ubuntu runner.
27-43
: Verify stale action version compatibility
The stale action configuration is well-structured with appropriate timeframes and exemptions. However, there's a potential compatibility issue with the action version.
Let's verify the latest stable version and compatibility:
Consider updating to a newer version if available, but otherwise, the configuration is solid with:
- Appropriate stale/close timeframes (10/180 days)
- Clear notification messages
- Good exemptions for WIP items and milestones
- Reasonable rate limiting (30 operations per run)
🧰 Tools
🪛 actionlint (1.7.4)
28-28: the runner of "actions/stale@v8" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
public/locales/en/translation.json (1)
1-1483
: Well-structured JSON file with proper organization!
The file follows proper JSON formatting with consistent nesting and organization.
scripts/githooks/check-localstorage-usage.js (4)
3-5
: Avoid potential ESM/CJS compatibility issues in JavaScript files.
You're using ES module imports (e.g., import path from 'path'
) in a .js
file, which might not be supported in older Node.js environments without additional configuration. If your Node.js version and environment are modern enough, this is fine. Otherwise, consider using CommonJS-style require
statements.
10-18
: Ignore static-analysis requests for return-type annotations in .js
files.
The static analysis hint suggests adding function return types, but your retrieved learnings mention that type annotations are not used in .js
files. You can safely ignore the ESLint or TypeScript-linter-suggested “return type” addition.
🧰 Tools
🪛 eslint
[error] 10-10: Missing return type on function.
(@typescript-eslint/explicit-function-return-type)
20-37
: Ignore static-analysis requests for return-type annotations in .js
files.
Same reasoning as above for getModifiedFiles
. This is plain JavaScript, so no type annotations are needed.
🧰 Tools
🪛 eslint
[error] 20-20: Missing return type on function.
(@typescript-eslint/explicit-function-return-type)
43-78
: Ignore static-analysis requests for return-type annotations in .js
files.
Again, for checkLocalStorageUsage
, no need for type annotations in .js
.
🧰 Tools
🪛 eslint
[error] 43-43: Missing return type on function.
(@typescript-eslint/explicit-function-return-type)
public/locales/hi/common.json (3)
14-20
: Authentication and navigation translations look good!
The translations use commonly understood Hindi terms that are widely recognized in the context of web applications.
1-98
: JSON structure and formatting look good!
The file follows proper JSON formatting with:
- Valid JSON structure
- Consistent indentation
- No trailing commas
1-98
: Verify translation key consistency across language files
Let's ensure all translation keys are consistent across different language files.
✅ Verification successful
Let me generate another script to better analyze the translation keys since the previous output didn't show the actual differences.
Let me try one more script with a different approach since comm
is not available:
Let me try one final approach with a simpler script:
Translation keys are consistent across all language files
Based on the analysis results, all language files (en, fr, hi, sp, zh) contain exactly 96 keys each, and the sample keys shown are identical across all files. The key structure is perfectly maintained across all translation files, ensuring consistency in the internationalization system.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Compare translation keys across language files to ensure consistency
# Find all language files
echo "Checking for language files..."
fd -e json . public/locales
# Extract and compare keys
for lang in public/locales/*/common.json; do
echo "Analyzing keys in $lang..."
jq -r 'keys[]' "$lang" | sort > "/tmp/$(basename $(dirname $lang))_keys.txt"
done
# Compare keys between files
if [ -f "/tmp/en_keys.txt" ]; then
echo "Comparing with English translations..."
for lang in /tmp/*_keys.txt; do
if [ "$lang" != "/tmp/en_keys.txt" ]; then
echo "Differences with $(basename $lang _keys.txt):"
diff "/tmp/en_keys.txt" "$lang"
fi
done
fi
Length of output: 3011
Script:
#!/bin/bash
# Get a better view of the keys in each language file
for lang in public/locales/*/common.json; do
lang_code=$(basename $(dirname $lang))
echo "=== Keys in $lang_code translation ==="
jq 'keys | length' "$lang" | xargs echo "Total keys:"
# Show keys unique to this language file compared to English
if [ "$lang_code" != "en" ]; then
echo "Keys in $lang_code but not in English:"
comm -13 <(jq -r 'keys[]' public/locales/en/common.json | sort) <(jq -r 'keys[]' "$lang" | sort)
echo "Keys in English but not in $lang_code:"
comm -23 <(jq -r 'keys[]' public/locales/en/common.json | sort) <(jq -r 'keys[]' "$lang" | sort)
fi
echo
done
Length of output: 4110
Script:
#!/bin/bash
# Compare keys between English and other language files using basic tools
for lang in public/locales/*/common.json; do
lang_code=$(basename $(dirname $lang))
echo "=== Comparing $lang_code with English ==="
echo "Total keys in $lang_code: $(jq 'keys | length' "$lang")"
if [ "$lang_code" != "en" ]; then
# Find missing or extra keys
echo "Checking for differences..."
# Keys in this language but not in English
echo "Keys in $lang_code but not in English:"
diff <(jq -r 'keys[]' public/locales/en/common.json | sort) <(jq -r 'keys[]' "$lang" | sort) | grep '^>' || echo "None"
# Keys in English but not in this language
echo "Keys in English but not in $lang_code:"
diff <(jq -r 'keys[]' public/locales/en/common.json | sort) <(jq -r 'keys[]' "$lang" | sort) | grep '^<' || echo "None"
echo
fi
done
Length of output: 4578
Script:
#!/bin/bash
# Simple key count and comparison
echo "=== Translation Key Analysis ==="
# First get English keys as reference
en_keys=$(jq -r 'keys[]' public/locales/en/common.json | sort)
en_count=$(echo "$en_keys" | wc -l)
echo "English keys count: $en_count"
# Compare with other languages
for lang in public/locales/*/common.json; do
lang_code=$(basename $(dirname $lang))
if [ "$lang_code" != "en" ]; then
echo -e "\nAnalyzing $lang_code:"
lang_keys=$(jq -r 'keys[]' "$lang" | sort)
lang_count=$(echo "$lang_keys" | wc -l)
echo "Keys count: $lang_count"
# Show a few sample keys from each file for verification
echo "Sample keys from $lang_code:"
jq -r 'keys[0:3][]' "$lang"
fi
done
Length of output: 11779
config/vite.config.ts (1)
7-11
: Consider verifying environment settings.
It's often helpful to validate that the PORT
and other environment variables match what's defined in your .env
or .env.example
files, ensuring that the server port is dynamically derived rather than hard-coded.
scripts/__mocks__/@pdfme/generator.test.ts (1)
5-11
: These tests correctly check for a Promise return type.
Everything looks good here. Good job ensuring async correctness.
jest.config.js (1)
1-71
: Double-check Jest vs Vitest configurations alignment.
This PR is intended to migrate tests from Jest to Vitest. Keeping or introducing jest.config.js
might be redundant if the project fully switches to Vitest. Ensure that if you're fully transitioning, any references to Jest are phased out.
🧰 Tools
🪛 eslint
[error] 33-33: Delete ·
(prettier/prettier)
[error] 34-34: Insert ,
(prettier/prettier)
.github/workflows/talawa_admin_md_mdx_format_adjuster.py (1)
1-96
: LGTM for the overall approach of escaping MDX characters.
The logic used to escape <
, >
, {
, and }
is clear and well-structured. This approach is sufficient for typical MDX usage.
.github/workflows/eslint_disable_check.py (1)
1-122
: ESLint-disable logic and messaging.
Overall, the script effectively identifies eslint-disable
statements and issues the correct message. This ensures your code remains linted without developer bypass. Very thorough approach.
🧰 Tools
🪛 Ruff (0.8.2)
61-61: Loop control variable dirs
not used within loop body
Rename unused dirs
to _dirs
(B007)
setup.ts (2)
13-19
: Enhance error handling when creating and populating .env
.
The script implicitly assumes .env.example
exists and is valid. Consider adding a try/catch or appropriate checks (e.g., verifying fs.existsSync('.env.example')
) before reading it, to provide a more descriptive error if the file is missing or corrupted.
180-183
: Successful user feedback.
Ending the setup with a celebratory message is a nice user-experience touch. Good job providing clear guidance on next steps.
.github/workflows/compare_translations.py (1)
1-49
: Great introductory module docstring and structure
The purpose, methodology, and usage details are clearly explained. Good job keeping it consistent with Python documentation standards.
.github/workflows/countline.py (1)
1-26
: Informative docstring and approach
Your scripting methodology is clearly described. The code commentary effectively guides contributors to maintain concise files, promoting clarity and reusability.
.gitignore (2)
3-6
: Lock files properly ignored
Ignoring yarn.lock
and pnpm-lock.yaml
is standard practice to avoid introducing potential dependency resolution conflicts across different package managers.
13-13
: Security-conscious environment and coverage ignore
Excluding .env*
files, coverage/
output, and debug logs from version control is good practice. This prevents accidental exposure of sensitive info and keeps the repository clean.
Also applies to: 21-28
.github/ISSUE_TEMPLATE/feature-request.md (1)
2-6
: Consistent naming and labeling
Renaming the title to “Feature Request” and adjusting the associated labels clarifies the issue type for contributors and maintainers.
.github/workflows/push.yml (2)
36-49
: LGTM! Well-structured cache configuration
The cache configuration is well-implemented with:
- Proper cache key based on package-lock.json
- Fallback restore-keys for partial matches
- Caching both ~/.npm and node_modules directories
29-29
: 🛠️ Refactor suggestion
Consider using LTS version of Node.js
The workflow currently uses Node.js 22.x which is the latest development version. For better stability in CI/CD pipelines, consider using the current LTS version (20.x).
- node-version: [22.x]
+ node-version: [20.x]
.github/workflows/README.md (1)
1-47
: LGTM! Well-structured workflow documentation
The documentation provides clear guidelines for:
- Workflow file organization
- Job sequencing
- Script requirements
- Coding standards
🧰 Tools
🪛 LanguageTool
[duplication] ~24-~24: Possible typo: you repeated a word
Context: ...ors: 1. Place all actions related to to this in the pull-request-target.yml
f...
(ENGLISH_WORD_REPEAT_RULE)
[uncategorized] ~35-~35: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...orrectly if they have a dedicated file (eg. CodeQL
) ## Scripts Follow these gui...
(E_G)
.github/workflows/issue.yml (1)
62-65
: LGTM! Well-structured greeting message
The greeting message is informative and includes helpful links to contribution guidelines.
.eslintrc.json (2)
133-134
: Review Jest configuration removal
Since the project is transitioning from Jest to Vitest, consider removing Jest-related configurations.
63-64
: Verify TypeScript rule compatibility
These TypeScript rules appear to be invalid or might not exist in the current version:
@typescript-eslint/no-unsafe-function-type
@typescript-eslint/no-wrapper-object-types
@typescript-eslint/no-empty-object-type
Also applies to: 65-65
.github/workflows/pull-request.yml (1)
214-227
: Well-structured test coverage configuration!
Good practices observed:
- High test coverage requirement (95%) ensures code quality
- Unique naming for Codecov reports prevents collisions
CONTRIBUTING.md (1)
Line range hint 1-179
: Documentation is well-structured and comprehensive
The changes provide clear guidelines for contributors, especially regarding testing which aligns with the PR objective.
🧰 Tools
🪛 LanguageTool
[grammar] ~135-~135: The operating system from Apple is written “macOS”.
Context: ...r packages can be found for Windows and MacOS. 6. The currently acceptable c...
(MAC_OS)
[uncategorized] ~163-~163: Possible missing comma found.
Context: ...odecov/results.jpg)]() 1. After making changes you can add them to git locally using `...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~164-~164: Possible missing comma found.
Context: ...o add all changes). 1. After adding the changes you need to commit them using `git comm...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~165-~165: Possible missing comma found.
Context: ...using: git push origin <branch_name>
.(Here branch name must be name of the branch ...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~165-~165: Possible missing article found.
Context: ...: git push origin <branch_name>
.(Here branch name must be name of the branch you wan...
(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~165-~165: Possible missing article found.
Context: ...branch_name>`.(Here branch name must be name of the branch you want to push the chan...
(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~167-~167: Possible missing comma found.
Context: ...test suite passes, either locally or on CI once a PR has been created. 1. Review a...
(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~178-~178: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...dation/talawa) for the link to join our slack channel. 1. We also have a technical em...
(ON_SKYPE)
🪛 Markdownlint (0.37.0)
104-104: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
113-113: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
128-128: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
139-139: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
143-143: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
158-158: null
No empty links
(MD042, no-empty-links)
159-159: null
No empty links
(MD042, no-empty-links)
161-161: null
No empty links
(MD042, no-empty-links)
INSTALLATION.md (1)
288-308
: Excellent test documentation!
The test documentation is particularly relevant to the PR objective of refactoring tests:
- Clear instructions for running tests
- Debugging guidance with Jest Preview
- Visual aids for understanding test output
🧰 Tools
🪛 Markdownlint (0.37.0)
292-292: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
300-300: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
.github/ISSUE_TEMPLATE/bug-report.md (1)
2-7
: LGTM! Metadata changes follow GitHub conventions
The changes to the template metadata are consistent with GitHub's best practices:
- Proper capitalization in template name
- Lowercase label format
- Valid YAML syntax for assignees
@@ -10,10 +10,10 @@ | |||
{ | |||
"src": "logo192.png", | |||
"type": "image/png", | |||
"sizes": "192x192" | |||
"sizes": "16x16" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Incorrect icon size specification for logo192.png
The size "16x16" is inconsistent with the image filename logo192.png
which suggests a 192x192 pixel image. This mismatch could break PWA requirements and cause display issues.
Apply this diff to fix the icon size:
- "sizes": "16x16"
+ "sizes": "192x192"
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"sizes": "16x16" | |
"sizes": "192x192" |
{ | ||
"talawaApiUnavailable": "Talawa-API service is unavailable!. Is it running? Check your network connectivity too.", | ||
"notFound": "Not found", | ||
"unknownError": "An unknown error occurred. Please try again later. {{msg}}", | ||
"notAuthorised": "Sorry! you are not Authorised!", | ||
"errorSendingMail": "Error sending mail", | ||
"emailNotRegistered": "Email not registered", | ||
"notFoundMsg": "Oops! The Page you requested was not found!", | ||
"errorOccurredCouldntCreate": "Ocurrió un error. No se pudo crear {{entity}}", | ||
"errorLoading": "Ocurrió un error al cargar los datos de {{entity}}" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing Spanish translations
Most error messages are still in English instead of Spanish. Only "errorOccurredCouldntCreate" and "errorLoading" are translated to Spanish.
Please translate all error messages to Spanish. For example:
- "talawaApiUnavailable": "Talawa-API service is unavailable!. Is it running? Check your network connectivity too.",
+ "talawaApiUnavailable": "¡El servicio Talawa-API no está disponible! ¿Está funcionando? Verifique también su conectividad de red.",
- "notFound": "Not found",
+ "notFound": "No encontrado",
Committable suggestion skipped: line range outside the PR's diff.
"atleast_8_char_long": "Atleast 8 Character long", | ||
"atleast_6_char_long": "Atleast 6 Character long", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Standardize naming conventions
There are inconsistencies in the naming conventions:
- Mixed use of snake_case and camelCase for keys
- Inconsistent capitalization in values
Consider adopting a consistent naming convention:
- "atleast_8_char_long": "Atleast 8 Character long",
- "atleast_6_char_long": "Atleast 6 Character long",
+ "minCharLength8": "At least 8 characters long",
+ "minCharLength6": "At least 6 characters long"
Also applies to: 32-35, 231-232, 233-234
"removeUserFrom": "Remove User from {{org}}", | ||
"removeConfirmation": "Are you sure you want to remove '{{name}}' from organization '{{org}}'?", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Enhance internationalization support
Several areas could benefit from better i18n practices:
- Add pluralization support for numeric content
- Use interpolation for dynamic content consistently
Example improvements:
- "removeUserFrom": "Remove User from {{org}}",
- "removeConfirmation": "Are you sure you want to remove '{{name}}' from organization '{{org}}'?",
+ "removeUserFrom": "Remove {{userName}} from {{orgName}}",
+ "removeConfirmation": "Are you sure you want to remove '{{userName}}' from '{{orgName}}'?",
Also applies to: 432-433, 1436-1437
"searchByName": "searchByName", | ||
"users": "users", | ||
"name": "name", | ||
"email": "email", | ||
"endOfResults": "endOfResults", | ||
"admin": "admin", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace placeholder translations with proper content
Several keys have values that appear to be placeholders:
- "searchByName": "searchByName"
- "name": "name"
- "email": "email"
- "endOfResults": "endOfResults"
These should be replaced with proper user-facing messages.
Also applies to: 246-248
"@testing-library/jest-dom": "^6.5.0", | ||
"@testing-library/react": "^16.0.1", | ||
"@testing-library/user-event": "^12.1.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update testing library versions for React 18 compatibility
The current versions of testing libraries are outdated and incompatible with React 18:
- @testing-library/react v16.0.1 is very old
- @testing-library/user-event v12.1.10 is outdated
Apply this diff to update the versions:
- "@testing-library/react": "^16.0.1",
- "@testing-library/user-event": "^12.1.10",
+ "@testing-library/react": "^14.2.1",
+ "@testing-library/user-event": "^14.5.2",
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"@testing-library/jest-dom": "^6.5.0", | |
"@testing-library/react": "^16.0.1", | |
"@testing-library/user-event": "^12.1.10", | |
"@testing-library/jest-dom": "^6.5.0", | |
"@testing-library/react": "^14.2.1", | |
"@testing-library/user-event": "^14.5.2", |
"serve": "cross-env ESLINT_NO_DEV_ERRORS=true vite --config config/vite.config.ts", | ||
"build": "tsc && vite build --config config/vite.config.ts", | ||
"preview": "vite preview --config config/vite.config.ts", | ||
"test": "cross-env NODE_ENV=test jest --env=./scripts/custom-test-env.js --watchAll --coverage", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test configuration doesn't match PR objective
The PR aims to migrate tests to Vitest, but the test script still uses Jest. Consider updating the test configuration to use Vitest.
Apply this diff to update the test script:
- "test": "cross-env NODE_ENV=test jest --env=./scripts/custom-test-env.js --watchAll --coverage",
+ "test": "vitest --coverage",
Committable suggestion skipped: line range outside the PR's diff.
- name: Set up Node.js | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: '22.x' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use stable LTS version of Node.js
The workflow is configured to use Node.js v22.x which is not yet released. This could cause stability issues.
Use a stable LTS version instead:
- node-version: '22.x'
+ node-version: '20.x'
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
- name: Set up Node.js | |
uses: actions/setup-node@v4 | |
with: | |
node-version: '22.x' | |
- name: Set up Node.js | |
uses: actions/setup-node@v4 | |
with: | |
node-version: '20.x' | |
- name: Check for linting errors in modified files | ||
if: steps.changed-files.outputs.only_changed != 'true' | ||
env: | ||
CHANGED_FILES: ${{ steps.changed_files.outputs.all_changed_files }} | ||
run: npx eslint ${CHANGED_FILES} && python .github/workflows/eslint_disable_check.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix shell script safety issues
The script has potential issues with:
- Unquoted variables that could break with filenames containing spaces
- Unchecked environment variable usage
Apply these fixes:
- CHANGED_FILES: ${{ steps.changed_files.outputs.all_changed_files }}
+ CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }}
- npx eslint ${CHANGED_FILES} && python .github/workflows/eslint_disable_check.py
+ npx eslint "${CHANGED_FILES}" && python .github/workflows/eslint_disable_check.py
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
- name: Check for linting errors in modified files | |
if: steps.changed-files.outputs.only_changed != 'true' | |
env: | |
CHANGED_FILES: ${{ steps.changed_files.outputs.all_changed_files }} | |
run: npx eslint ${CHANGED_FILES} && python .github/workflows/eslint_disable_check.py | |
- name: Check for linting errors in modified files | |
if: steps.changed-files.outputs.only_changed != 'true' | |
env: | |
CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }} | |
run: npx eslint "${CHANGED_FILES}" && python .github/workflows/eslint_disable_check.py |
🧰 Tools
🪛 actionlint (1.7.4)
61-61: property "changed_files" is not defined in object type {changed-files: {conclusion: string; outcome: string; outputs: {string => string}}}
(expression)
62-62: shellcheck reported issue in this script: SC2086:info:1:12: Double quote to prevent globbing and word splitting
(shellcheck)
🪛 yamllint (1.35.1)
[error] 60-60: trailing spaces
(trailing-spaces)
@@ -27,3 +28,9 @@ A clear and concise description of how the code performed w.r.t expectations. | |||
If applicable, add screenshots to help explain your problem. | |||
|
|||
**Additional details** | |||
Add any other context or screenshots about the feature request here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix incorrect template reference
The additional details section appears to be copied from a feature request template.
Apply this change:
-Add any other context or screenshots about the feature request here.
+Add any other context or screenshots about the bug report here.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Add any other context or screenshots about the feature request here. | |
Add any other context or screenshots about the bug report here. |
What kind of change does this PR introduce?
Refracting src/setup/askForTalawaApiUrl/askForTalawaApiUrl.test.ts from Jest to Vitest
Issue number :
Fixes #2749
Did you add tests for your changes?
Yes
Snapshots/Videos:
If relevant, did you update the documentation?
Does this PR introduce a breaking change?
No
Other information
No
Have you read the contributing guide?
Yes
Summary by CodeRabbit
Based on the comprehensive changes, here are the release notes:
New Features
Documentation
Improvements
Localization
Testing