Refactored src/components/AddOn/* from jest to Vitest #2917
Conversation
WalkthroughThis pull request involves changes to multiple test files in the Changes
Assessment against linked issues
Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (4)
💤 Files with no reviewable changes (2)
✅ Files skipped from review due to trivial changes (1)
🧰 Additional context used📓 Learnings (1)📓 Common learnings🔇 Additional comments (4)src/components/AddOn/core/AddOnStore/AddOnStore.spec.tsx (4)
Line range hint
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #2917 +/- ##
=====================================================
+ Coverage 58.52% 88.11% +29.59%
=====================================================
Files 299 316 +17
Lines 7414 8265 +851
Branches 1621 1810 +189
=====================================================
+ Hits 4339 7283 +2944
+ Misses 2828 769 -2059
+ Partials 247 213 -34 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Why were these files deleted
- src/components/AddOn/core/AddOnEntry/AddOnEntry.test.tsx
- src/components/AddOn/support/components/Action/Action.test.tsx
Why was this file edited? It is out of scope
- src/components/CheckIn/tagTemplate.ts
You didn't fix all the files in the original issue
|
I deleted src/components/AddOn/core/AddOnEntry/AddOnEntry.test.tsx src/components/AddOn/support/components/Action/Action.test.tsx These files because in the issue thread I was told that I can delete them for good. Secondly regarding rest of the files mentioned in the issue... those were already updated by someone else written in vitest. |
Thanks, Why weren't the deleted files replaced with |
They were they were... There were actually 5 file changes requested in the issue... out of which 4 were already converted from jest into vitest .... and for 2 for the rest 2 there were both the .test.* and .spec.* file.... so I asked in the issue comment and therefore I deleted the .test.* file.. for the current scenario we have the .spec.* vitest files for all the 5 files :
|
palisadoes
merged commit 89aebba
into
PalisadoesFoundation:develop-postgres
What kind of change does this PR introduce?
Refactor
Issue Number:
Fixes #2788
Did you add tests for your changes?
No
Snapshots/Videos:
This is the snapshot for the changed for
src/components/AddOn/core/AddOnStore/AddOnStore.test.tsx:The rest of the files that were asked to change in the issue were already updated with vitest when I did git pull... and I ran the tests on them and that came out to be successful... I deleted the redundant .test.* files.
If relevant, did you update the documentation?
No
Summary
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes
Summary by CodeRabbit
Bug Fixes
AddOnEntryandActioncomponents.New Features
AddOnStorecomponent, enhancing testing capabilities.Documentation
tagTemplateobject, including type assertion updates.