Refactor src/components/LeftDrawerOrg/LeftDrawerOrg.test.tsx from Jest to Vitest

[gracefullcoder]

What kind of change does this PR introduce?

Replace Jest-specific functions and mocks with Vitest equivalents in LeftDrawerOrg.test.tsx testing file

Issue Number:

Fixes #2833

Did you add tests for your changes?

Yes

Snapshots/Videos:

If relevant, did you update the documentation?

No

Summary

-Made Changes as per the context provide also svg images are passed in test and all 9/9 test passed.
-Migrated test for ChangeLanguageDropdown.tsx from jest to vitest.

Does this PR introduce a breaking change?

No

Have you read the contributing guide?

Yes

Summary by CodeRabbit

• New Features

  • Introduced a new configuration file for YAML language server settings.
  • Added a .env.example file to guide environment variable setup.
  • Implemented a new GitHub Actions workflow for CodeQL analysis.
  • Added comprehensive localization support with new JSON files for multiple languages.
  • Introduced a setup script for configuring the development environment.

• Bug Fixes

  • Enhanced error handling and logging in various scripts.

• Documentation

  • Updated installation guide and contributing guidelines for clarity and structure.
  • Added new documents for issue reporting and code style.

• Chores

  • Removed outdated files and configurations to streamline the project.
  • Updated various scripts and configurations for better performance and maintainability.

[coderabbitai]

Walkthrough

This pull request introduces comprehensive changes to the Talawa Admin project, focusing on configuration, testing infrastructure, localization, and development workflow improvements. The changes span multiple areas including environment setup, GitHub workflows, linting configurations, testing frameworks, and internationalization support. The project has been migrated to use Vite as the build tool, updated to use Vitest for testing, and enhanced with multi-language support.

Changes

File/Directory	Change Summary
.coderabbit.yaml	New configuration file for YAML language server and AI-assisted code review
.env.example	New environment variable template with configuration options
.eslintrc.json	Enhanced ESLint configuration with stricter TypeScript and React rules
.github/workflows/	Multiple new workflow files for CI/CD, code quality checks, and automated processes
config/	New configuration files for Babel, Vite, and testing environments
public/locales/	Added localization files for English, French, Hindi, Spanish, and Chinese
scripts/	New utility scripts for testing, Git hooks, and development workflows
package.json	Updated dependencies, scripts, and project configuration

Assessment against linked issues

Objective	Addressed	Explanation
Refactor LeftDrawerOrg.test.tsx from Jest to Vitest [#2833]	❓	Partial migration setup completed, but specific file refactoring not evident

Possibly related issues

• Refactor : src/components/ChangeLanguageDropdown/ChangeLanguageDropdown.test.tsx from Jest to Vitest #2493: Refactoring ChangeLanguageDropdown.test.tsx from Jest to Vitest
• Refactor: src/components/AddOn/support/components/MainContent/MainContent.test.tsx from Jest to Vitest #2475: Refactoring MainContent.test.tsx from Jest to Vitest
• Refactor : src/components/CheckIn/TableRow.test.tsx from Jest to Vitest #2496: Refactoring TableRow.test.tsx from Jest to Vitest
• Refactor : src/components/CheckIn/CheckInWrapper.test.tsx from Jest to Vitest #2495: Refactoring CheckInWrapper.test.tsx from Jest to Vitest

Possibly related PRs

• Refactor Tests: Migrate src/screens/UserPortal/UserScreen/UserScreen.tsx from Jest to Vitest #2632: Refactoring tests from Jest to Vitest
• Refactor: jest to vitest of itemDeleteModal : fixes #2557 #2713: Migrating tests to Vitest
• fixed:#2475 Refactor: src/components/AddOn/support/components/MainContent/MainContent.test.tsx from Jest to Vitest #2843: Refactoring UserScreen component tests
• fixed:2479 Refactor: src/components/AddOn/core/AddOnRegister/AddOnRegister.test.tsx from Jest to Vitest #2860: Refactoring AddOnRegister component tests

Suggested reviewers

• @palisadoes

Poem

🐰 A Rabbit's Code Review Delight

In configs and workflows so bright,
Vitest dances, locales take flight,
ESLint rules with laser-like might,
CodeRabbit whispers, "Everything's right!"

🚀 Hop into progress, code burning light! 🌟

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Our Pull Request Approval Process

Thanks for contributing!

Testing Your Code

Remember, your PRs won't be reviewed until these criteria are met:

1. We don't merge PRs with poor code quality.
   1. Follow coding best practices such that CodeRabbit.ai approves your PR.
2. We don't merge PRs with failed tests.
   1. When tests fail, click on the Details link to learn more.
   2. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
   3. Tests may fail if you edit sensitive files. Ask to add the ignore-sensitive-files-pr label if the edits are necessary.
3. We cannot merge PRs with conflicting files. These must be fixed.

Our policies make our code better.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

1. comments in this PR or
2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

1. arbitrators of future discussions with other contributors about the validity of your changes
2. point of contact for evaluating the validity of your work
3. person who verifies matching issues by others that should be closed.
4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

1. PRs with issues not assigned to you will be closed by the reviewer
2. Fix the first comment in the PR so that each issue listed automatically closes

Other

1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
2. Read the CONTRIBUTING.md file make

[github-actions]

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

[coderabbitai]

Actionable comments posted: 23

🧹 Nitpick comments (62)

config/vite.config.ts (1)

24-29: Maintain consistency between code and comments.

The comment on line 27 references “default port to 3000,” but the actual value is 4321. Update your comment to reflect the correct port, or adjust the port if 3000 is intended.

-// this sets a default port to 3000
+// this sets a default port to 4321

.github/workflows/countline.py (6)

68-79: Extend logic to skip additional file types if needed.
You have a check for image extensions like .css, .jpg, and .png. If your repository includes other non-code file types (e.g., .svg, .gif), consider adding them to the invalid_extensions list to prevent inflating the line count.

---

81-120: Consider direct directory-level exclusion.
The _valid_exclusions function filters individual files by path, but it only excludes directories after enumerating their contents. For large repositories with numerous subdirectories, a direct directory-level exclusion could be more performant.

---

122-143: Potential synergy with other listing utilities.
While _filepaths_in_directories works, consider using standard helpers like Python's pathlib for simpler path manipulation. This can improve code readability and maintainability.

---

145-195: Leverage argument grouping.
The _arg_parser_resolver function defines several arguments. You could utilize argument groups (e.g., parser.add_argument_group) to structure them, especially for exclusion arguments. This minor enhancement often makes CLI usage more discoverable.

---

197-294: Enhance comment detection and skipping.
The current logic skips lines starting with # or /. This may not catch multi-line comments or code-specific comment syntax in some languages. If the repository has more varied files (e.g., .ts, .vue), consider more robust detection.

---

267-267: Fix minor spelling typo.
The comment uses "voilated" instead of "violated". This can be corrected for clarity and professionalism.

-    # If the line rule is voilated then...
+    # If the line rule is violated then...

scripts/githooks/check-localstorage-usage.js (2)

20-27: Potential coverage of .js files
Currently, the script only scans .ts or .tsx files when using --scan-entire-repo. If you also need to enforce this rule in regular .js or .jsx files, consider including them in the pattern.

🧰 Tools

🪛 eslint

[error] 20-20: Missing return type on function.

(@typescript-eslint/explicit-function-return-type)

---

89-92: Add trailing commas to match Prettier rules
Prettier suggests trailing commas for multiline function calls. Here is a possible fix:

  console.info(
    '\x1b[34m%s\x1b[0m',
-    '\nInfo: Consider using custom hook functions.'
+    '\nInfo: Consider using custom hook functions.',
  );

  console.info(
-    'Please use the getItem, setItem, and removeItem functions provided by the custom hook useLocalStorage.\n'
+    'Please use the getItem, setItem, and removeItem functions provided by the custom hook useLocalStorage.\n',
  );

🧰 Tools

🪛 eslint

[error] 89-89: Insert ,

(prettier/prettier)

---

[error] 92-92: Insert ,

(prettier/prettier)

public/locales/en/errors.json (3)

2-2: Fix double punctuation in error message

The message contains both "!" and "." consecutively, which is incorrect.

-  "talawaApiUnavailable": "Talawa-API service is unavailable!. Is it running? Check your network connectivity too.",
+  "talawaApiUnavailable": "Talawa-API service is unavailable! Is it running? Check your network connectivity too.",

---

5-5: Standardize American English spelling

For consistency with American English, "Authorised" should be "Authorized".

-  "notAuthorised": "Sorry! you are not Authorised!",
+  "notAuthorized": "Sorry! You are not Authorized!",

---

10-10: Fix typo in error message

The word "occured" is misspelled. It should be "occurred".

-  "errorLoading": "Error occured while loading {{entity}} data"
+  "errorLoading": "Error occurred while loading {{entity}} data"

schema.graphql (3)

581-741: Standardize mutation naming conventions.

Some mutations don't follow consistent naming patterns. For example:

• acceptMembershipRequest vs blockPluginCreationBySuperadmin
• addEventAttendee vs createAdmin

Consider standardizing mutation names using verb prefixes consistently:

• create* for creation operations
• update* for modifications
• delete* for removals
• add*/remove* for collection modifications

---

1114-1117: Enhance real-time capabilities with additional subscriptions.

The current subscription type is limited to chat messages and plugin updates. Consider adding subscriptions for:

1. Event updates (status changes, cancellations)
2. Organization membership changes
3. Action item status changes

 type Subscription {
   messageSentToChat(userId: ID!): ChatMessage
   onPluginUpdate: Plugin
+  onEventUpdate(eventId: ID!): Event
+  onOrganizationMembershipChange(organizationId: ID!): Organization
+  onActionItemStatusChange(actionItemId: ID!): ActionItem
 }

---

5-20: Add descriptions to types and fields.

Key types like ActionItem and ActionItemCategory lack descriptions. Add documentation to improve schema clarity and maintainability.

+"""
+Represents an action item that can be assigned to users within an event or organization.
+"""
 type ActionItem {
+  """
+  Unique identifier for the action item
+  """
   _id: ID!
+  """
+  Category of the action item for organizational purposes
+  """
   actionItemCategory: ActionItemCategory
   # ... add descriptions for other fields
 }

Also applies to: 22-30

.github/workflows/push.yml (4)

14-18: Consider limiting branch triggers

The workflow currently runs on all branches ('**'). Consider limiting it to main/development branches and pull requests to optimize CI resources.

on:
  push:
    branches:
-      - '**'   
+      - 'main'
+      - 'develop'

🧰 Tools

🪛 yamllint (1.35.1)

[error] 17-17: trailing spaces

(trailing-spaces)

---

[error] 18-18: trailing spaces

(trailing-spaces)

---

19-21: Fix YAML indentation

The env section has incorrect indentation. It should be aligned with jobs.

env:
-    CODECOV_UNIQUE_NAME: CODECOV_UNIQUE_NAME-${{ github.run_id }}-${{ github.run_number }}
+  CODECOV_UNIQUE_NAME: CODECOV_UNIQUE_NAME-${{ github.run_id }}-${{ github.run_number }}

🧰 Tools

🪛 yamllint (1.35.1)

[warning] 20-20: wrong indentation: expected 2 but found 4

(indentation)

---

[error] 21-21: trailing spaces

(trailing-spaces)

---

42-49: Optimize cache restore-keys

The current restore-keys pattern might lead to cache hits from unrelated workflows. Consider making it more specific.

          restore-keys: |
-            ${{ runner.os }}-code-coverage-${{ env.cache-name }}-
-            ${{ runner.os }}-code-coverage-
-            ${{ runner.os }}-
+            ${{ runner.os }}-code-coverage-${{ env.cache-name }}-
+            ${{ runner.os }}-code-coverage-node-

---

54-61: Enhance test coverage configuration

A few suggestions to improve the test coverage setup:

1. Consider specifying the coverage format explicitly
2. The fail_ci_if_error: false might hide Codecov upload issues

-      - run: npm run test -- --watchAll=false --coverage
+      - run: npm run test -- --watchAll=false --coverage --coverageReporters=json-summary,lcov
       - name: Present and upload coverage to Codecov as ${{env.CODECOV_UNIQUE_NAME}}
         uses: codecov/codecov-action@v4
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           verbose: true
-          fail_ci_if_error: false
+          fail_ci_if_error: true
           name: '${{env.CODECOV_UNIQUE_NAME}}'

public/locales/hi/common.json (2)

97-97: Improve Hindi translation for searchBy

The current translation places the placeholder after "के द्वारा खोजें", which might cause readability issues. Consider restructuring to a more natural Hindi word order.

-  "searchBy": "के द्वारा खोजें {{item}}"
+  "searchBy": "{{item}} द्वारा खोजें"

---

41-41: Fix inconsistent spacing in password translation

The Hindi translation for "enterPassword" has inconsistent spacing in "पास वर्ड".

-  "enterPassword": "पास वर्ड दर्ज करें"
+  "enterPassword": "पासवर्ड दर्ज करें"

.husky/post-merge (1)

1-4: Optional: Check for corresponding lock file changes.
Currently, this script installs dependencies whenever package.json changes. If your team uses npm with a lock file (for example, package-lock.json), consider also checking for lock file changes to ensure consistent installs.

Possible approach:

-git diff HEAD^ HEAD --exit-code -- ./package.json || npm install
+git diff HEAD^ HEAD --exit-code -- ./package.json ./package-lock.json || npm install

.husky/pre-commit (1)

4-10: Re-staging changes may override partial commits.
Running git add . after formatting and linting is a common hook pattern. However, consider whether partial commits or interactive staging are used by contributors—re-staging everything might unintentionally bundle extra changes into the commit.

scripts/githooks/update-toc.js (1)

11-12: Clean up extra newline for Prettier compliance.
Static analysis hints point out superfluous whitespace at lines 11–12. Removing it will ensure your code passes Prettier checks.

Apply this diff:

   execSync(command, { stdio: 'inherit' });
-
 }

🧰 Tools

🪛 eslint

[error] 11-12: Delete ··⏎

(prettier/prettier)

scripts/custom-test-env.js (2)

5-5: Resolve the TSDoc configuration warning.
The @pdfme tag in the doc comment may trigger a linter rule that reports it as undefined. You can either remove or configure this tag in your TSDoc settings to silence the warning.

🧰 Tools

🪛 eslint

[error] 5-5: tsdoc-undefined-tag: The TSDoc tag "@pdfme" is not defined in this configuration

(tsdoc/syntax)

---

1-2: Reassess the usage of Jest environment in a Vitest ecosystem.
Because the project is migrating from Jest to Vitest, confirm if you still need jest-environment-jsdom. If you plan to run these tests in Vitest, you might look for an equivalent custom environment solution.

scripts/__mocks__/@pdfme/generator.ts (2)

10-13: Use descriptive error handling for empty template or inputs.
Currently, you throw a generic error. Consider more explicit error classes or messages to help downstream debugging.

---

18-21: Ensure consistent test snapshots.
Because the content is randomized with each run, your snapshot or byte-level comparisons could fail nondeterministically. If needed, use a seed or deterministic approach to generate consistent results.

.github/workflows/check-tsdoc.js (2)

13-31: Consider skipping non-source or large directories.
Recursively reading every directory might slow down checks in big projects. You may want to skip known directories (like node_modules) or unnecessary paths to optimize performance.

---

37-46: Use concurrency or batch reading techniques.
For large codebases, reading each file sequentially might be time-consuming. Explore parallel reading strategies (e.g., Promise.all) to improve performance without blocking the main thread.

jest.config.js (2)

13-13: Insert a line break for better readability.

A minor formatting improvement is recommended by the static analysis tool, which suggests inserting a line break at line 13 to improve readability.

13c13
-    '!vitest.config.ts',],
+    '!vitest.config.ts',
+],

🧰 Tools

🪛 eslint

[error] 13-13: Insert ⏎··

(prettier/prettier)

---

33-36: Consider removing environment-specific absolute paths.

Using user-specific absolute paths ('/Users/prathamesh/Desktop/Open-Source/palisadoes/talawa-admin/src') can cause issues for other developers or CI environments. Consider using relative paths or standard environment-based configuration.

.github/workflows/eslint_disable_check.py (1)

61-61: Rename the unused variable to avoid warnings.

The dirs variable is unused in this loop. Rename it to _dirs to avoid lint warnings and clarify its unused status.

-for root, dirs, files in os.walk(os.path.join(directory, 'src')):
+for root, _dirs, files in os.walk(os.path.join(directory, 'src')):

🧰 Tools

🪛 Ruff (0.8.2)

61-61: Loop control variable dirs not used within loop body

Rename unused dirs to _dirs

(B007)

setup.ts (2)

40-49: Watch out for possible concurrency issues with asynchronous file operations.

Reading and writing .env in callback style (fs.readFile, then fs.writeFileSync) could introduce race conditions if multiple operations occur rapidly. Consider switching to consistent synchronous or promise-based operations to avoid potential conflicts.

---

106-160: Maintain consistency in file read/write modes.

The file is sometimes read synchronously (fs.readFileSync) and other times asynchronously (fs.readFile(..., (err, data) => {})). For better maintainability, consider adopting a single consistent approach (e.g., all synchronous or all promise-based) and handle errors uniformly.

.github/workflows/compare_translations.py (2)

63-89: Consider reducing repetition for error reporting in compare_translations.
Lines 63–89 check for missing/mismatched keys and build error messages for each. While this is correct, you might consider grouping common checks or using helper methods to reduce duplication and enhance readability when the function grows.

---

117-136: Improve exception raising for JSON decode errors.
Lines 134–136 raise a new ValueError within the except block. To provide better traceback context, raise the error using an additional context specifier:

-    raise ValueError(f"Error decoding JSON from file {filepath}: {e}")
+    raise ValueError(f"Error decoding JSON from file {filepath}: {e}") from e

This ensures future debugging attains the full original error chain.

🧰 Tools

🪛 Ruff (0.8.2)

135-135: Within an except clause, raise exceptions with raise ... from err or raise ... from None to distinguish them from errors in exception handling

(B904)

.github/ISSUE_TEMPLATE/feature-request.md (2)

25-25: Avoid emphasis for section titles.
Using **Potential internship candidates** as a heading triggers the Markdownlint rule (MD036). Changing it to a heading (## Potential internship candidates) can improve readability.

-**Potential internship candidates**
+## Potential internship candidates

🧰 Tools

🪛 Markdownlint (0.37.0)

25-25: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

---

28-28: Convert bare URL to a link.
The link at line 28 triggers MD034. Wrap it in Markdown brackets for clarity.

-https://github.com/PalisadoesFoundation/talawa/issues/359
+[Issue #359](https://github.com/PalisadoesFoundation/talawa/issues/359)

🧰 Tools

🪛 Markdownlint (0.37.0)

28-28: null
Bare URL used

(MD034, no-bare-urls)

.github/workflows/codeql-codescan.yml (1)

1-44: Fix YAML formatting issues

There are some minor formatting issues in the YAML file:

• Remove trailing spaces (lines 6, 17, 20)
• Fix indentation (lines 31, 37)

🧰 Tools

🪛 actionlint (1.7.4)

35-35: the runner of "github/codeql-action/init@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

---

41-41: the runner of "github/codeql-action/autobuild@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

---

44-44: the runner of "github/codeql-action/analyze@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

🪛 yamllint (1.35.1)

[error] 6-6: trailing spaces

(trailing-spaces)

---

[error] 17-17: trailing spaces

(trailing-spaces)

---

[error] 20-20: trailing spaces

(trailing-spaces)

---

[warning] 31-31: wrong indentation: expected 6 but found 7

(indentation)

---

[warning] 37-37: wrong indentation: expected 11 but found 10

(indentation)

DOCUMENTATION.md (2)

25-25: Fix grammar in Docusaurus launch description

The sentence has a modal verb agreement issue.

-    - A local version of `docs.talawa.io` should automatically launched in your browser at http://localhost:3000/
+    - A local version of `docs.talawa.io` should automatically launch in your browser at `http://localhost:3000/`

🧰 Tools

🪛 Markdownlint (0.37.0)

25-25: null
Bare URL used

(MD034, no-bare-urls)

🪛 LanguageTool

[grammar] ~25-~25: The modal verb ‘should’ requires the verb’s base form.
Context: ...f docs.talawa.io should automatically launched in your browser at http://localhost:300...

(MD_BASEFORM)

---

26-29: Fix Markdown formatting and typos

Several minor formatting and spelling issues:

-1. Add/modify the markdown documents to the `docs/` directory
+1. Add/modify the Markdown documents to the `docs/` directory
-1. Always monitor the local website in your brower to make sure
+1. Always monitor the local website in your browser to make sure

🧰 Tools

🪛 LanguageTool

[grammar] ~26-~26: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...ttp://localhost:3000/ 1. Add/modify the markdown documents to the docs/ directory of t...

(MARKDOWN_NNP)

.github/workflows/stale.yml (1)

6-6: Fix trailing whitespace

Remove trailing spaces from these lines for consistent formatting.

Also applies to: 20-21

🧰 Tools

🪛 yamllint (1.35.1)

[error] 6-6: trailing spaces

(trailing-spaces)

.github/workflows/issue.yml (1)

34-55: Simplify label management logic

The current implementation uses multiple repetitive API calls. Consider refactoring to reduce duplication and improve maintainability.

- if(labels.data.reduce((a, c)=>a||["dependencies"].includes(c.name), false))
-   await github.rest.issues.addLabels({
-     owner: context.repo.owner,
-     repo: context.repo.repo,
-     issue_number: context.issue.number,
-     labels: ["good first issue", "security"]
-   });
- else if(labels.data.reduce((a, c)=>a||["security", "ui/ux"].includes(c.name), false))
-   await github.rest.issues.addLabels({
-     owner: context.repo.owner,
-     repo: context.repo.repo,
-     issue_number: context.issue.number,
-     labels: ["good first issue"]
-   });
+ const hasLabel = (labelNames) => labels.data.some(label => labelNames.includes(label.name));
+ const labelsToAdd = [];
+ 
+ if (hasLabel(["dependencies"])) {
+   labelsToAdd.push("good first issue", "security");
+ } else if (hasLabel(["security", "ui/ux"])) {
+   labelsToAdd.push("good first issue");
+ }
+ 
+ if (labelsToAdd.length > 0) {
+   await github.rest.issues.addLabels({
+     ...apiParams,
+     labels: labelsToAdd
+   });
+ }

ISSUE_GUIDELINES.md (2)

44-44: Capitalize "Slack" consistently

"Slack" is a proper noun and should be capitalized consistently throughout the document.

- slack channel
+ Slack channel

Also applies to: 53-53, 57-57

🧰 Tools

🪛 LanguageTool

[grammar] ~44-~44: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...butors to assign it to you in #talawa slack channel. Working on these types of exi...

(ON_SKYPE)

---

5-5: Fix grammar in introduction

Use "an" instead of "a" before "issues reports".

- to submit a issues reports
+ to submit an issue report

🧰 Tools

🪛 LanguageTool

[misspelling] ~5-~5: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...der to give everyone a chance to submit a issues reports and contribute to the Ta...

(EN_A_VS_AN)

README.md (1)

53-53: Fix heading formatting

Remove extra spaces after the hash symbol in the "Videos" heading.

-#  Videos
+# Videos

🧰 Tools

🪛 Markdownlint (0.37.0)

53-53: null
Multiple spaces after hash on atx style heading

(MD019, no-multiple-space-atx)

.github/workflows/pull-request-target.yml (1)

1-77: Fix YAML formatting

There are multiple trailing spaces throughout the file that should be removed for consistency.

Use an editor with YAML support to automatically trim trailing spaces.

🧰 Tools

🪛 yamllint (1.35.1)

[error] 6-6: trailing spaces

(trailing-spaces)

---

[error] 13-13: trailing spaces

(trailing-spaces)

---

[error] 15-15: trailing spaces

(trailing-spaces)

---

[error] 27-27: trailing spaces

(trailing-spaces)

---

[error] 28-28: trailing spaces

(trailing-spaces)

---

[error] 29-29: trailing spaces

(trailing-spaces)

---

[error] 31-31: trailing spaces

(trailing-spaces)

---

[error] 33-33: trailing spaces

(trailing-spaces)

---

[error] 34-34: trailing spaces

(trailing-spaces)

---

[error] 36-36: trailing spaces

(trailing-spaces)

---

[error] 41-41: trailing spaces

(trailing-spaces)

---

[error] 46-46: trailing spaces

(trailing-spaces)

---

[error] 71-71: trailing spaces

(trailing-spaces)

PR_GUIDELINES.md (2)

31-34: Add language specifiers to code blocks

The code blocks should specify the shell language for better syntax highlighting and clarity.

-```
+```shell
npm run lint:fix
npm run format:fix

Also applies to: 39-42

<details>
<summary>🧰 Tools</summary>

<details>
<summary>🪛 Markdownlint (0.37.0)</summary>

31-31: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

</details>

</details>

---

`46-47`: **Enhance testing requirements section**

Consider adding specific guidance about the project's testing framework (Vitest) and any migration requirements from Jest.

```diff
-1. All pull requests must have test units. If, for some reason, it is not possible to add tests, please let us know and explain why. In that case, you'll need to tell us what steps you followed to manually test your changes.
+1. All pull requests must have test units using Vitest. If migrating existing tests from Jest, ensure they follow the Vitest conventions. If adding new tests is not possible, please explain why and detail your manual testing steps.

🧰 Tools

🪛 LanguageTool

[style] ~46-~46: Style-wise, it’s not ideal to insert an adverb (‘manually’) in the middle of an infinitive construction (‘to test’). Try moving the adverb to avoid split infinitives.
Context: ..., you'll need to tell us what steps you followed to manually test your changes. 1. Please read our [CONTRIBUTING.md](C...

(SPLIT_INFINITIVE)

CODE_STYLE.md (3)

1-8: Strengthen the introduction with clear enforcement mechanism.

The document states that rules are enforced with ESLint but doesn't mention how contributors can verify their code against these rules locally.

Add a section about running ESLint locally:

+## Verifying Code Style
+
+Before submitting your changes, ensure your code follows our style guidelines by running:
+
+```bash
+npm run lint
+npm run format
+```
+
+These commands will help you identify and fix any style violations.

---

47-115: Enhance code examples with TypeScript.

Since the project uses TypeScript, the code examples should reflect this by including type annotations.

Update the examples to include TypeScript:

-<div className={styles.myCustomClass}>...</div>
+interface StyleProps {
+  myCustomClass: string;
+}
+
+const styles: StyleProps = {
+  myCustomClass: 'custom-class'
+};
+
+<div className={styles.myCustomClass}>...</div>

🧰 Tools

🪛 Markdownlint (0.37.0)

57-57: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

---

73-73: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

---

75-75: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

---

92-92: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

---

58-58: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

65-65: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

78-78: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

95-95: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

187-253: Add version compatibility note for Bootstrap customization.

The document specifies Bootstrap v5.3.0 but doesn't mention compatibility requirements or upgrade considerations.

Add a note about version compatibility and upgrade process to help maintainers handle future Bootstrap updates.

🧰 Tools

🪛 Markdownlint (0.37.0)

190-190: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

---

230-230: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

---

239-239: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

245-245: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

251-251: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

CONTRIBUTING.md (1)

104-107: Add troubleshooting section for test commands.

The test commands are provided without context about common issues or troubleshooting steps.

Add a troubleshooting section:

+### Troubleshooting Tests
+
+If you encounter issues running tests:
+
+1. Clear Jest cache: `npm run test --clearCache`
+2. Ensure all dependencies are installed: `npm ci`
+3. Check Node.js version compatibility

🧰 Tools

🪛 Markdownlint (0.37.0)

104-104: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

INSTALLATION.md (3)

321-335: Fix markdown heading hierarchy and list indentation.

Several markdown formatting issues need to be addressed:

1. The heading "pre-commit hook" and "post-merge hook" should use h3 (###) instead of h4 (####)
2. The list items under these sections should use consistent 4-space indentation

-#### pre-commit hook
+### pre-commit hook

-#### post-merge hook
+### post-merge hook

-        git commit -m "commit message" --no-verify
+    git commit -m "commit message" --no-verify

-        git pull --no-verify
+    git pull --no-verify

🧰 Tools

🪛 Markdownlint (0.37.0)

321-321: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time

(MD001, heading-increment)

---

327-327: Expected: fenced; Actual: indented
Code block style

(MD046, code-block-style)

---

335-335: Expected: fenced; Actual: indented
Code block style

(MD046, code-block-style)

---

142-315: Add language specifiers to code blocks for better readability.

Several code blocks are missing language specifiers. Add appropriate language specifiers like bash, env, or plaintext.

For example:

-```
+```bash
npm install

🧰 Tools

🪛 Markdownlint (0.37.0)

142-142: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

154-154: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

164-164: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

188-188: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

194-194: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

200-200: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

208-208: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

214-214: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

220-220: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

240-240: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

256-256: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

264-264: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

270-270: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

292-292: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

300-300: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

313-313: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

178-178: Expected: #setting-up-react_app_talawa_url-in-env-file; Actual: #setting-up-REACT_APP_TALAWA_URL-in-env-file
Link fragments should be valid

(MD051, link-fragments)

---

178-178: Expected: #setting-up-react_app_recaptcha_site_key-in-env-file; Actual: #setting-up-REACT_APP_RECAPTCHA_SITE_KEY-in-env-file
Link fragments should be valid

(MD051, link-fragments)

🪛 LanguageTool

[uncategorized] ~162-~162: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...at runtime. It is not a part of the repo and you will have to create it. For a sampl...

(COMMA_COMPOUND_SENTENCE)

---

[grammar] ~228-~228: The word “setup” is a noun. The verb is spelled with a space.
Context: ...E_KEY in .env file You may not want to setup reCAPTCHA since the project will still ...

(NOUN_VERB_CONFUSION)

---

[grammar] ~232-~232: The word “setup” is a noun. The verb is spelled with a space.
Context: ...ad the following steps. If you want to setup Google reCAPTCHA now, you may refer to ...

(NOUN_VERB_CONFUSION)

---

[typographical] ~246-~246: Except for inverted sentences, ‘need them’ requires a question mark at the end of the sentence.
Context: ...t need them or want to keep the console clean # Post Configuration Steps It's now t...

(MD_PRP_QUESTION_MARK)

---

[uncategorized] ~261-~261: Did you mean: “By default,”?
Context: ...n serve ``` ## Accessing Talawa-Admin By default talawa-admin runs on port `4321` on y...

(BY_DEFAULT_COMMA)

---

[grammar] ~311-~311: The word ‘lint’ is a noun or an adjective. A verb or adverb is missing or misspelled here, or maybe a comma is missing.
Context: ...w.webp) ## Linting code files You can lint your code files using this command: ``...

(PRP_MD_NN)

---

168-177: Add security notes for environment variables.

Consider adding security notes about:

1. Not committing the .env file to version control
2. Protecting sensitive values like reCAPTCHA keys
3. Using appropriate file permissions for the .env file

.github/ISSUE_TEMPLATE/bug-report.md (1)

31-36: Improve template formatting and links.

1. Use markdown link syntax instead of bare URLs
2. Use proper heading syntax for sections

-**Potential internship candidates**
+## Potential internship candidates

-https://github.com/PalisadoesFoundation/talawa/issues/359
+[Internship Information](https://github.com/PalisadoesFoundation/talawa/issues/359)

🧰 Tools

🪛 Markdownlint (0.37.0)

36-36: null
Bare URL used

(MD034, no-bare-urls)

---

33-33: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

.github/workflows/README.md (1)

24-24: Fix grammatical issues in the text.

1. Remove duplicate "to" in line 24
2. Use "e.g." instead of "eg." in line 35

-Place all actions related to to this in the `pull-request-target.yml` file.
+Place all actions related to this in the `pull-request-target.yml` file.

-Jobs only work correctly if they have a dedicated file (eg. `CodeQL`)
+Jobs only work correctly if they have a dedicated file (e.g., `CodeQL`)

Also applies to: 35-35

🧰 Tools

🪛 LanguageTool

[duplication] ~24-~24: Possible typo: you repeated a word
Context: ...ors: 1. Place all actions related to to this in the pull-request-target.yml f...

(ENGLISH_WORD_REPEAT_RULE)

.github/workflows/pull-request.yml (3)

14-17: Consider restricting PR trigger branches

The current configuration allows PRs to any branch ('**'). Consider restricting this to specific branches (e.g., develop, main) to prevent unnecessary workflow runs and potential security risks.

on:
  pull_request:
    branches:
-      - '**'
+      - 'develop'
+      - 'main'

---

22-265: Consider workflow optimization opportunities

The workflow is well-structured but could be optimized:

1. Consider caching npm dependencies between jobs
2. Parallelize independent jobs where possible
3. Reuse Node.js setup steps across jobs

Example cache configuration:

- name: Cache dependencies
  uses: actions/cache@v3
  with:
    path: ~/.npm
    key: npm-${{ hashFiles('package-lock.json') }}
    restore-keys: npm-

🧰 Tools

🪛 actionlint (1.7.4)

61-61: property "changed_files" is not defined in object type {changed-files: {conclusion: string; outcome: string; outputs: {string => string}}}

(expression)

---

62-62: shellcheck reported issue in this script: SC2086:info:1:12: Double quote to prevent globbing and word splitting

(shellcheck)

---

79-79: "github.event.pull_request.head.ref" is potentially untrusted. avoid using it directly in inline scripts. instead, pass it through an environment variable. see https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions for more details

(expression)

🪛 yamllint (1.35.1)

[error] 49-49: trailing spaces

(trailing-spaces)

---

[error] 60-60: trailing spaces

(trailing-spaces)

---

[error] 63-63: trailing spaces

(trailing-spaces)

---

[error] 92-92: trailing spaces

(trailing-spaces)

---

[error] 126-126: trailing spaces

(trailing-spaces)

---

[error] 129-129: trailing spaces

(trailing-spaces)

---

[error] 150-150: trailing spaces

(trailing-spaces)

---

[error] 157-157: trailing spaces

(trailing-spaces)

---

[error] 197-197: trailing spaces

(trailing-spaces)

---

[error] 201-201: trailing spaces

(trailing-spaces)

---

[error] 204-204: trailing spaces

(trailing-spaces)

---

[error] 205-205: trailing spaces

(trailing-spaces)

---

[error] 213-213: trailing spaces

(trailing-spaces)

---

[error] 243-243: trailing spaces

(trailing-spaces)

---

[error] 249-249: trailing spaces

(trailing-spaces)

---

[error] 251-251: trailing spaces

(trailing-spaces)

---

49-49: Remove trailing spaces

Multiple lines contain trailing spaces. While this doesn't affect functionality, it's good practice to remove them for consistency.

Also applies to: 60-60, 63-63, 92-92, 126-126, 129-129, 150-150, 157-157, 197-197, 201-201, 204-204, 205-205, 213-213, 243-243, 249-249, 251-251

🧰 Tools

🪛 yamllint (1.35.1)

[error] 49-49: trailing spaces

(trailing-spaces)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3209a18 and cc9acab.

⛔ Files ignored due to path filters (75)

• package-lock.json is excluded by !**/package-lock.json
• public/favicon.ico is excluded by !**/*.ico
• public/favicon_palisadoes.ico is excluded by !**/*.ico
• public/images/logo512.png is excluded by !**/*.png
• public/images/svg/angleDown.svg is excluded by !**/*.svg
• public/images/svg/arrow-left.svg is excluded by !**/*.svg
• public/images/svg/arrow-right.svg is excluded by !**/*.svg
• public/images/svg/attendees.svg is excluded by !**/*.svg
• public/images/svg/feedback.svg is excluded by !**/*.svg
• public/images/svg/profiledefault.svg is excluded by !**/*.svg
• public/images/svg/up-down.svg is excluded by !**/*.svg
• public/logo192.png is excluded by !**/*.png
• public/markdown/images/install1.png is excluded by !**/*.png
• public/markdown/images/install2.png is excluded by !**/*.png
• src/assets/css/app.css.map is excluded by !**/*.map
• src/assets/images/blank.png is excluded by !**/*.png
• src/assets/images/bronze.png is excluded by !**/*.png
• src/assets/images/defaultImg.png is excluded by !**/*.png
• src/assets/images/gold.png is excluded by !**/*.png
• src/assets/images/palisadoes_logo.png is excluded by !**/*.png
• src/assets/images/silver.png is excluded by !**/*.png
• src/assets/images/talawa-logo-600x600.png is excluded by !**/*.png
• src/assets/images/talawa-logo-dark-200x200.png is excluded by !**/*.png
• src/assets/images/talawa-logo-lite-200x200.png is excluded by !**/*.png
• src/assets/svgs/Attendance.svg is excluded by !**/*.svg
• src/assets/svgs/actionItem.svg is excluded by !**/*.svg
• src/assets/svgs/admin.svg is excluded by !**/*.svg
• src/assets/svgs/agenda-category-icon.svg is excluded by !**/*.svg
• src/assets/svgs/agenda-items.svg is excluded by !**/*.svg
• src/assets/svgs/angleRight.svg is excluded by !**/*.svg
• src/assets/svgs/article.svg is excluded by !**/*.svg
• src/assets/svgs/blockUser.svg is excluded by !**/*.svg
• src/assets/svgs/blockedUser.svg is excluded by !**/*.svg
• src/assets/svgs/cardItemDate.svg is excluded by !**/*.svg
• src/assets/svgs/cardItemEvent.svg is excluded by !**/*.svg
• src/assets/svgs/cardItemLocation.svg is excluded by !**/*.svg
• src/assets/svgs/chat.svg is excluded by !**/*.svg
• src/assets/svgs/checkInRegistrants.svg is excluded by !**/*.svg
• src/assets/svgs/dashboard.svg is excluded by !**/*.svg
• src/assets/svgs/date.svg is excluded by !**/*.svg
• src/assets/svgs/event.svg is excluded by !**/*.svg
• src/assets/svgs/events.svg is excluded by !**/*.svg
• src/assets/svgs/flask.svg is excluded by !**/*.svg
• src/assets/svgs/funds.svg is excluded by !**/*.svg
• src/assets/svgs/key.svg is excluded by !**/*.svg
• src/assets/svgs/listEventRegistrants.svg is excluded by !**/*.svg
• src/assets/svgs/location.svg is excluded by !**/*.svg
• src/assets/svgs/logout.svg is excluded by !**/*.svg
• src/assets/svgs/media.svg is excluded by !**/*.svg
• src/assets/svgs/newChat.svg is excluded by !**/*.svg
• src/assets/svgs/organizations.svg is excluded by !**/*.svg
• src/assets/svgs/palisadoes.svg is excluded by !**/*.svg
• src/assets/svgs/people.svg is excluded by !**/*.svg
• src/assets/svgs/plugins.svg is excluded by !**/*.svg
• src/assets/svgs/post.svg is excluded by !**/*.svg
• src/assets/svgs/posts.svg is excluded by !**/*.svg
• src/assets/svgs/requests.svg is excluded by !**/*.svg
• src/assets/svgs/roles.svg is excluded by !**/*.svg
• src/assets/svgs/settings.svg is excluded by !**/*.svg
• src/assets/svgs/social-icons/Facebook-Logo.svg is excluded by !**/*.svg
• src/assets/svgs/social-icons/Github-Logo.svg is excluded by !**/*.svg
• src/assets/svgs/social-icons/Instagram-Logo.svg is excluded by !**/*.svg
• src/assets/svgs/social-icons/Linkedin-Logo.svg is excluded by !**/*.svg
• src/assets/svgs/social-icons/Reddit-Logo.svg is excluded by !**/*.svg
• src/assets/svgs/social-icons/Slack-Logo.svg is excluded by !**/*.svg
• src/assets/svgs/social-icons/X-Logo.svg is excluded by !**/*.svg
• src/assets/svgs/social-icons/Youtube-Logo.svg is excluded by !**/*.svg
• src/assets/svgs/tag.svg is excluded by !**/*.svg
• src/assets/svgs/tags.svg is excluded by !**/*.svg
• src/assets/svgs/talawa.svg is excluded by !**/*.svg
• src/assets/svgs/user.svg is excluded by !**/*.svg
• src/assets/svgs/userEvent.svg is excluded by !**/*.svg
• src/assets/svgs/users.svg is excluded by !**/*.svg
• src/assets/svgs/venues.svg is excluded by !**/*.svg
• src/assets/talawa-logo-lite-200x200.png is excluded by !**/*.png

📒 Files selected for processing (82)

• .coderabbit.yaml (1 hunks)
• .env.example (1 hunks)
• .eslintignore (1 hunks)
• .eslintrc.json (4 hunks)
• .github/ISSUE_TEMPLATE/bug-report.md (2 hunks)
• .github/ISSUE_TEMPLATE/feature-request.md (2 hunks)
• .github/dependabot.yaml (1 hunks)
• .github/pull_request_template.md (2 hunks)
• .github/workflows/README.md (1 hunks)
• .github/workflows/auto-label.json5 (1 hunks)
• .github/workflows/check-tsdoc.js (1 hunks)
• .github/workflows/ci.yml (0 hunks)
• .github/workflows/codeql-analysis.yml (0 hunks)
• .github/workflows/codeql-codescan.yml (1 hunks)
• .github/workflows/compare_translations.py (1 hunks)
• .github/workflows/countline.py (1 hunks)
• .github/workflows/eslint_disable_check.py (1 hunks)
• .github/workflows/issue.yml (1 hunks)
• .github/workflows/linter.yml (0 hunks)
• .github/workflows/npm-publish.yml (0 hunks)
• .github/workflows/pull-request-target.yml (1 hunks)
• .github/workflows/pull-request.yml (1 hunks)
• .github/workflows/push.yml (1 hunks)
• .github/workflows/stale.yml (1 hunks)
• .github/workflows/talawa_admin_md_mdx_format_adjuster.py (1 hunks)
• .gitignore (2 hunks)
• .husky/post-merge (1 hunks)
• .husky/pre-commit (1 hunks)
• .lintstagedrc.json (1 hunks)
• .node-version (1 hunks)
• .prettierignore (1 hunks)
• .prettierrc (1 hunks)
• CODEOWNERS (1 hunks)
• CODE_OF_CONDUCT.md (1 hunks)
• CODE_STYLE.md (1 hunks)
• CONTRIBUTING.md (2 hunks)
• DOCUMENTATION.md (1 hunks)
• Docker_Container/.dockerignore (0 hunks)
• Docker_Container/README.md (0 hunks)
• Docker_Container/docker-compose.yml (0 hunks)
• Docker_Container/dockerfile (0 hunks)
• INSTALLATION.md (1 hunks)
• ISSUE_GUIDELINES.md (1 hunks)
• ISSUE_TEMPLATE.md (0 hunks)
• PR-guidelines.md (0 hunks)
• PR_GUIDELINES.md (1 hunks)
• PULL_REQUEST_TEMPLATE.md (0 hunks)
• README.md (3 hunks)
• config/babel.config.cjs (1 hunks)
• config/vite.config.ts (1 hunks)
• index.html (1 hunks)
• issue-guidelines.md (0 hunks)
• jest-preview.config.ts (1 hunks)
• jest.config.js (1 hunks)
• package.json (2 hunks)
• public/index.html (0 hunks)
• public/locales/en/common.json (1 hunks)
• public/locales/en/errors.json (1 hunks)
• public/locales/en/translation.json (1 hunks)
• public/locales/fr/common.json (1 hunks)
• public/locales/fr/errors.json (1 hunks)
• public/locales/fr/translation.json (1 hunks)
• public/locales/hi/common.json (1 hunks)
• public/locales/hi/errors.json (1 hunks)
• public/locales/hi/translation.json (1 hunks)
• public/locales/sp/common.json (1 hunks)
• public/locales/sp/errors.json (1 hunks)
• public/locales/sp/translation.json (1 hunks)
• public/locales/zh/common.json (1 hunks)
• public/locales/zh/errors.json (1 hunks)
• public/locales/zh/translation.json (1 hunks)
• public/manifest.json (1 hunks)
• schema.graphql (1 hunks)
• scripts/__mocks__/@dicebear/collection.ts (1 hunks)
• scripts/__mocks__/@dicebear/core.ts (1 hunks)
• scripts/__mocks__/@pdfme/generator.test.ts (1 hunks)
• scripts/__mocks__/@pdfme/generator.ts (1 hunks)
• scripts/__mocks__/fileMock.js (1 hunks)
• scripts/custom-test-env.js (1 hunks)
• scripts/githooks/check-localstorage-usage.js (1 hunks)
• scripts/githooks/update-toc.js (1 hunks)
• setup.ts (1 hunks)

⛔ Files not processed due to max files limit (28)

• src/App.test.tsx
• src/App.tsx
• src/Constant/constant.spec.ts
• src/Constant/constant.ts
• src/GraphQl/Mutations/ActionItemCategoryMutations.ts
• src/GraphQl/Mutations/ActionItemMutations.ts
• src/GraphQl/Mutations/AgendaCategoryMutations.ts
• src/GraphQl/Mutations/AgendaItemMutations.ts
• src/GraphQl/Mutations/CampaignMutation.ts
• src/GraphQl/Mutations/CommentMutations.ts
• src/GraphQl/Mutations/EventAttendeeMutations.ts
• src/GraphQl/Mutations/EventVolunteerMutation.ts
• src/GraphQl/Mutations/FundMutation.ts
• src/GraphQl/Mutations/OrganizationMutations.ts
• src/GraphQl/Mutations/PledgeMutation.ts
• src/GraphQl/Mutations/TagMutations.ts
• src/GraphQl/Mutations/VenueMutations.ts
• src/GraphQl/Mutations/mutations.ts
• src/GraphQl/Queries/ActionItemCategoryQueries.ts
• src/GraphQl/Queries/ActionItemQueries.ts
• src/GraphQl/Queries/AgendaCategoryQueries.ts
• src/GraphQl/Queries/AgendaItemQueries.ts
• src/GraphQl/Queries/EventVolunteerQueries.ts
• src/GraphQl/Queries/OrganizationQueries.ts
• src/GraphQl/Queries/PlugInQueries.ts
• src/GraphQl/Queries/Queries.ts
• src/GraphQl/Queries/fundQueries.ts
• src/GraphQl/Queries/userTagQueries.ts

💤 Files with no reviewable changes (13)

• ISSUE_TEMPLATE.md
• issue-guidelines.md
• Docker_Container/.dockerignore
• .github/workflows/ci.yml
• .github/workflows/linter.yml
• Docker_Container/docker-compose.yml
• Docker_Container/dockerfile
• public/index.html
• Docker_Container/README.md
• PR-guidelines.md
• .github/workflows/codeql-analysis.yml
• PULL_REQUEST_TEMPLATE.md
• .github/workflows/npm-publish.yml

✅ Files skipped from review due to trivial changes (23)

• .node-version
• public/locales/fr/errors.json
• CODEOWNERS
• public/locales/hi/errors.json
• scripts/mocks/@dicebear/collection.ts
• scripts/mocks/fileMock.js
• public/locales/zh/errors.json
• .eslintignore
• scripts/mocks/@dicebear/core.ts
• .github/dependabot.yaml
• config/babel.config.cjs
• .github/workflows/auto-label.json5
• .prettierignore
• .lintstagedrc.json
• public/locales/sp/translation.json
• .prettierrc
• index.html
• public/locales/zh/translation.json
• .env.example
• public/locales/fr/translation.json
• public/locales/hi/translation.json
• public/locales/fr/common.json
• public/locales/en/common.json

🧰 Additional context used

📓 Learnings (1)

scripts/githooks/check-localstorage-usage.js (1)

Learnt from: MayankJha014
PR: PalisadoesFoundation/talawa-admin#2612
File: scripts/githooks/check-localstorage-usage.js:10-18
Timestamp: 2024-12-07T14:25:09.928Z
Learning: TypeScript type annotations should not be added to JavaScript (`.js`) files in this project. Type annotations can only be used in TypeScript (`.ts` or `.tsx`) files.

🪛 eslint

scripts/custom-test-env.js

[error] 5-5: tsdoc-undefined-tag: The TSDoc tag "@pdfme" is not defined in this configuration

(tsdoc/syntax)

---

[error] 9-9: Missing return type on function.

(@typescript-eslint/explicit-function-return-type)

---

[error] 9-9: Missing return type on function.

(@typescript-eslint/explicit-module-boundary-types)

jest.config.js

[error] 13-13: Insert ⏎··

(prettier/prettier)

scripts/githooks/update-toc.js

[error] 11-12: Delete ··⏎

(prettier/prettier)

scripts/githooks/check-localstorage-usage.js

[error] 10-10: Missing return type on function.

(@typescript-eslint/explicit-function-return-type)

---

[error] 20-20: Missing return type on function.

(@typescript-eslint/explicit-function-return-type)

---

[error] 43-43: Missing return type on function.

(@typescript-eslint/explicit-function-return-type)

---

[error] 89-89: Insert ,

(prettier/prettier)

---

[error] 92-92: Insert ,

(prettier/prettier)

🪛 LanguageTool

CODE_OF_CONDUCT.md

[duplication] ~11-~11: Possible typo: you repeated a word
Context: ...-responsibilities) - Scope - Enforcement - Enforcement Guidelines ...

(ENGLISH_WORD_REPEAT_RULE)

DOCUMENTATION.md

[grammar] ~25-~25: The modal verb ‘should’ requires the verb’s base form.
Context: ...f docs.talawa.io should automatically launched in your browser at http://localhost:300...

(MD_BASEFORM)

---

[grammar] ~26-~26: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...ttp://localhost:3000/ 1. Add/modify the markdown documents to the docs/ directory of t...

(MARKDOWN_NNP)

---

[uncategorized] ~32-~32: The preposition “to” seems more likely in this position.
Context: ... PLEASE do not add markdown files in this repository. Add them to `talawa-do...

(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)

ISSUE_GUIDELINES.md

[uncategorized] ~2-~2: Loose punctuation mark.
Context: # Issue Report Guidelines 👍🎉 First off, thanks for taking t...

(UNLIKELY_OPENING_PUNCTUATION)

---

[style] ~4-~4: Consider a shorter alternative to avoid wordiness.
Context: ...ing the time to contribute! 🎉👍 In order to give everyone a chance to submit a issu...

(IN_ORDER_TO_PREMIUM)

---

[misspelling] ~5-~5: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...der to give everyone a chance to submit a issues reports and contribute to the Ta...

(EN_A_VS_AN)

---

[typographical] ~24-~24: Consider adding a comma here.
Context: ...> ___ ## Issue Management In all cases please use the [GitHub open issue search](http...

(PLEASE_COMMA)

---

[uncategorized] ~27-~27: A comma might be missing here.
Context: ...reported. ### New Issues To create new issues follow these steps: 1. Your issue may ...

(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)

---

[style] ~30-~30: Consider using a different verb for a more formal wording.
Context: .... 1. Verify whether the issue has been fixed by trying to reproduce it using the lat...

(FIX_RESOLVE)

---

[style] ~35-~35: The wording of this phrase can be improved.
Context: ...lcome contributors who find new ways to make the code better. ### Existing Issues You can also be ...

(MAKE_STYLE_BETTER)

---

[grammar] ~44-~44: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...butors to assign it to you in #talawa slack channel. Working on these types of exi...

(ON_SKYPE)

---

[grammar] ~53-~53: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...ew Issues 1. Join our #talawa-github slack channel for automatic issue and pull re...

(ON_SKYPE)

---

[grammar] ~57-~57: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...lines 1. Discuss issues in our various slack channels when necessary 2. Please do no...

(ON_SKYPE)

---

[typographical] ~57-~57: Consider adding a comma here.
Context: ...ur various slack channels when necessary 2. Please do not derail or troll issues. 3. Keep...

(PLEASE_COMMA)

README.md

[uncategorized] ~56-~56: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...)" videos are extremely helpful for new open source contributors.

(EN_COMPOUND_ADJECTIVE_INTERNAL)

PR_GUIDELINES.md

[uncategorized] ~2-~2: Loose punctuation mark.
Context: # Pull Request Guidelines 👍🎉 First off, thanks for taking t...

(UNLIKELY_OPENING_PUNCTUATION)

---

[style] ~4-~4: Consider a shorter alternative to avoid wordiness.
Context: ...ing the time to contribute! 🎉👍 In order to give everyone a chance to submit a pull...

(IN_ORDER_TO_PREMIUM)

---

[style] ~46-~46: Style-wise, it’s not ideal to insert an adverb (‘manually’) in the middle of an infinitive construction (‘to test’). Try moving the adverb to avoid split infinitives.
Context: ..., you'll need to tell us what steps you followed to manually test your changes. 1. Please read our [CONTRIBUTING.md](C...

(SPLIT_INFINITIVE)

---

[style] ~56-~56: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...o be closed. The quality of our code is very important to us. Therefore we make experienced ma...

(EN_WEAK_ADJECTIVE)

---

[uncategorized] ~56-~56: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ...ty of our code is very important to us. Therefore we make experienced maintainers of our ...

(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)

---

[style] ~59-~59: Consider using a different verb for a more formal wording.
Context: ...check if all tests are passing; if not, fix the issues and then create a pull reque...

(FIX_RESOLVE)

---

[style] ~64-~64: This expression is wordy and overused. Consider replacing it with a more concise and formal alternative.
Context: ...wer your questions, but we'll get to it sooner or later. @mentioning someone just adds to the p...

(SOONER_OR_LATER)

---

[uncategorized] ~64-~64: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...adds to the pile of notifications we get and it won't make us look at your issue fas...

(COMMA_COMPOUND_SENTENCE)

---

[style] ~65-~65: Consider shortening or rephrasing this to strengthen your wording.
Context: ...ue faster. 1. Do not force push. If you make changes to your pull request, please simply add a ...

(MAKE_CHANGES)

CODE_STYLE.md

[style] ~127-~127: Consider removing “of” to be more concise
Context: ...tories of src assets - This houses all of the static assets used in the project - `...

(ALL_OF_THE)

---

[style] ~128-~128: Consider removing “of” to be more concise
Context: ... in the project - css - This houses all of the css files used in the project - `imag...

(ALL_OF_THE)

---

[style] ~129-~129: Consider removing “of” to be more concise
Context: ... the project - images - This houses all of the images used in the project - scss -...

(ALL_OF_THE)

---

[style] ~130-~130: Consider removing “of” to be more concise
Context: ...in the project - scss - This houses all of the scss files used in the project - `c...

(ALL_OF_THE)

---

[grammar] ~134-~134: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ...rms - _talawa.scss - Partial Sass file for Talawa - _utilities.scss - Pa...

(HE_VERB_AGR)

---

[grammar] ~135-~135: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... - _utilities.scss - Partial Sass file for utilities - _variables.scss -...

(HE_VERB_AGR)

---

[grammar] ~136-~136: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... - _variables.scss - Partial Sass file for variables - app.scss - Main S...

(HE_VERB_AGR)

---

[style] ~141-~141: Consider removing “of” to be more concise
Context: ...views/screens Constant - This houses all of the constants used in the project `GraphQl...

(ALL_OF_THE)

---

[style] ~143-~143: Consider removing “of” to be more concise
Context: ...in the project GraphQl - This houses all of the GraphQL queries and mutations used in t...

(ALL_OF_THE)

---

[style] ~145-~145: Consider removing “of” to be more concise
Context: ...in the project screens - This houses all of the views/screens to be navigated through i...

(ALL_OF_THE)

---

[style] ~147-~147: Consider removing “of” to be more concise
Context: ... in Talawa-Admin state - This houses all of the state management code for the project ...

(ALL_OF_THE)

---

[uncategorized] ~165-~165: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...following order: - React imports - Third party imports - Local imports If there is...

(EN_COMPOUND_ADJECTIVE_INTERNAL)

CONTRIBUTING.md

[style] ~27-~27: This expression usually appears with a “please” in front of it.
Context: ...DUCT.md) to understand what this means. Let us know immediately if you have unacceptable ex...

(INSERT_PLEASE)

---

[uncategorized] ~34-~34: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...)" videos are extremely helpful for new open source contributors. ## Ways to Contribute I...

(EN_COMPOUND_ADJECTIVE_INTERNAL)

---

[grammar] ~62-~62: A determiner may be missing.
Context: ...l Request guidelines](PR_GUIDELINES.md) is best resource to follow to start working on ...

(THE_SUPERLATIVE)

---

[uncategorized] ~68-~68: Loose punctuation mark.
Context: ...ushed to the main branch: - develop: For unstable code and bug fixing - `mai...

(UNLIKELY_OPENING_PUNCTUATION)

---

[uncategorized] ~69-~69: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...d bug fixing - main: Where the stable production ready code lies. This is our default branch. ...

(EN_COMPOUND_ADJECTIVE_INTERNAL)

---

[typographical] ~73-~73: Consider adding a comma.
Context: ...ultiple developers are working on issues there is bound to be a conflict of interest (...

(IF_THERE_COMMA)

---

[typographical] ~73-~73: Consider adding a comma after ‘Usually’ for more clarity.
Context: ...licts) among issues, PRs or even ideas. Usually these conflicts are resolved in a **Fir...

(RB_LY_COMMA)

---

[grammar] ~73-~73: Did you mean “served” (as in the idiom ‘first come, first served’)?
Context: ...ts are resolved in a First Come First Serve basis however there are certain excep...

(FIRST_SERVED)

---

[grammar] ~75-~75: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...tant to ask the author of the PR in the slack channel or in their PRs or issues thems...

(ON_SKYPE)

---

[style] ~77-~77: ‘Last but not the least’ might be wordy. Consider a shorter alternative.
Context: ...y and test that function when needed. - Last but not the least, communication is important make sure t...

(EN_WORDINESS_PREMIUM_LAST_BUT_NOT_THE_LEAST)

---

[grammar] ~77-~77: It seems that “to” is missing before the verb.
Context: ...t the least, communication is important make sure to talk to other contributors, in ...

(MISSING_TO_BETWEEN_BE_AND_VB)

---

[grammar] ~77-~77: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ... other contributors, in these cases, in slack channel or in a issue/PR thread. - As a...

(ON_SKYPE)

---

[misspelling] ~77-~77: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ... in these cases, in slack channel or in a issue/PR thread. - As a last resort the...

(EN_A_VS_AN)

---

[typographical] ~78-~78: It appears that a comma is missing.
Context: ...el or in a issue/PR thread. - As a last resort the Admins would be responsible for dec...

(DURING_THAT_TIME_COMMA)

---

[grammar] ~135-~135: The operating system from Apple is written “macOS”.
Context: ...r packages can be found for Windows and MacOS. 6. The currently acceptable c...

(MAC_OS)

---

[grammar] ~165-~165: The past participle is required after “must be”.
Context: ...branch_name>`.(Here branch name must be name of the branch you want to push the chan...

(BE_VBP_IN)

---

[grammar] ~178-~178: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...dation/talawa) for the link to join our slack channel. 1. We also have a technical em...

(ON_SKYPE)

INSTALLATION.md

[duplication] ~25-~25: Possible typo: you repeated a word
Context: ...](#running-talawa-admin) - Accessing Talawa-Admin - [Talawa-Admin Registration](#talawa-admin-registratio...

(ENGLISH_WORD_REPEAT_RULE)

---

[typographical] ~55-~55: It appears that a comma is missing.
Context: ... that follow. # Prerequisites In this section we'll explain how to set up all the pre...

(DURING_THAT_TIME_COMMA)

---

[uncategorized] ~61-~61: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: .... Basic git knowledge is required for open source contribution so make sure you're comfor...

(EN_COMPOUND_ADJECTIVE_INTERNAL)

---

[grammar] ~67-~67: The word “setup” is a noun. The verb is spelled with a space.
Context: ...avigate to the folder where you want to setup the repository. 2. Open a cmd (Window...

(NOUN_VERB_CONFUSION)

---

[grammar] ~68-~68: The operating system from Apple is written “macOS”.
Context: ...cmd (Windows) or terminal (Linux or MacOS) session in this folder. 1. An easy ...

(MAC_OS)

---

[uncategorized] ~70-~70: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...e option based on your OS. 3. For Our Open Source Contributor Software Developers: ...

(EN_COMPOUND_ADJECTIVE_INTERNAL)

---

[grammar] ~102-~102: The operating system from Apple is written “macOS”.
Context: ...node.jspackages in Windows, Linux and MacOS. 1. For Windows: 1. first install...

(MAC_OS)

---

[duplication] ~116-~116: Possible typo: you repeated a word
Context: ... 5. Save the document. 6. Exit notepad 7. Exit PowerShell 8. This will ensure...

(ENGLISH_WORD_REPEAT_RULE)

---

[grammar] ~119-~119: The operating system from Apple is written “macOS”.
Context: ...t version of node.js 2. For Linux and MacOS, use the terminal window. 1. install...

(MAC_OS)

---

[grammar] ~123-~123: The word “setup” is a noun. The verb is spelled with a white space.
Context: ... the respective recommended commands to setup your node environment 3. This wil...

(NOUN_VERB_CONFUSION)

---

[uncategorized] ~162-~162: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...at runtime. It is not a part of the repo and you will have to create it. For a sampl...

(COMMA_COMPOUND_SENTENCE)

---

[grammar] ~228-~228: The word “setup” is a noun. The verb is spelled with a space.
Context: ...E_KEY in .env file You may not want to setup reCAPTCHA since the project will still ...

(NOUN_VERB_CONFUSION)

---

[grammar] ~232-~232: The word “setup” is a noun. The verb is spelled with a space.
Context: ...ad the following steps. If you want to setup Google reCAPTCHA now, you may refer to ...

(NOUN_VERB_CONFUSION)

---

[typographical] ~246-~246: Except for inverted sentences, ‘need them’ requires a question mark at the end of the sentence.
Context: ...t need them or want to keep the console clean # Post Configuration Steps It's now t...

(MD_PRP_QUESTION_MARK)

---

[uncategorized] ~261-~261: Did you mean: “By default,”?
Context: ...n serve ``` ## Accessing Talawa-Admin By default talawa-admin runs on port `4321` on y...

(BY_DEFAULT_COMMA)

---

[grammar] ~311-~311: The word ‘lint’ is a noun or an adjective. A verb or adverb is missing or misspelled here, or maybe a comma is missing.
Context: ...w.webp) ## Linting code files You can lint your code files using this command: ``...

(PRP_MD_NN)

.github/workflows/README.md

[uncategorized] ~13-~13: Possible missing comma found.
Context: ...ding on the type of workflow. Whenever possible you must ensure that: 1. The file roles...

(AI_HYDRA_LEO_MISSING_COMMA)

---

[duplication] ~24-~24: Possible typo: you repeated a word
Context: ...ors: 1. Place all actions related to to this in the pull-request-target.yml f...

(ENGLISH_WORD_REPEAT_RULE)

---

[uncategorized] ~35-~35: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...orrectly if they have a dedicated file (eg. CodeQL) ## Scripts Follow these gui...

(E_G)

🪛 actionlint (1.7.4)

.github/workflows/codeql-codescan.yml

35-35: the runner of "github/codeql-action/init@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

---

41-41: the runner of "github/codeql-action/autobuild@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

---

44-44: the runner of "github/codeql-action/analyze@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

.github/workflows/issue.yml

29-29: the runner of "actions/github-script@v6" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

.github/workflows/pull-request.yml

61-61: property "changed_files" is not defined in object type {changed-files: {conclusion: string; outcome: string; outputs: {string => string}}}

(expression)

---

62-62: shellcheck reported issue in this script: SC2086:info:1:12: Double quote to prevent globbing and word splitting

(shellcheck)

---

79-79: "github.event.pull_request.head.ref" is potentially untrusted. avoid using it directly in inline scripts. instead, pass it through an environment variable. see https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions for more details

(expression)

.github/workflows/stale.yml

28-28: the runner of "actions/stale@v8" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

🪛 yamllint (1.35.1)

.github/workflows/codeql-codescan.yml

[error] 6-6: trailing spaces

(trailing-spaces)

---

[error] 17-17: trailing spaces

(trailing-spaces)

---

[error] 20-20: trailing spaces

(trailing-spaces)

---

[warning] 31-31: wrong indentation: expected 6 but found 7

(indentation)

---

[warning] 37-37: wrong indentation: expected 11 but found 10

(indentation)

.github/workflows/pull-request-target.yml

[error] 6-6: trailing spaces

(trailing-spaces)

---

[error] 13-13: trailing spaces

(trailing-spaces)

---

[error] 15-15: trailing spaces

(trailing-spaces)

---

[error] 27-27: trailing spaces

(trailing-spaces)

---

[error] 28-28: trailing spaces

(trailing-spaces)

---

[error] 29-29: trailing spaces

(trailing-spaces)

---

[error] 31-31: trailing spaces

(trailing-spaces)

---

[error] 33-33: trailing spaces

(trailing-spaces)

---

[error] 34-34: trailing spaces

(trailing-spaces)

---

[error] 36-36: trailing spaces

(trailing-spaces)

---

[error] 41-41: trailing spaces

(trailing-spaces)

---

[error] 46-46: trailing spaces

(trailing-spaces)

---

[error] 71-71: trailing spaces

(trailing-spaces)

.github/workflows/issue.yml

[error] 6-6: trailing spaces

(trailing-spaces)

---

[warning] 15-15: wrong indentation: expected 4 but found 6

(indentation)

---

[warning] 66-66: too many blank lines

(1 > 0) (empty-lines)

.github/workflows/pull-request.yml

[error] 49-49: trailing spaces

(trailing-spaces)

---

[error] 60-60: trailing spaces

(trailing-spaces)

---

[error] 63-63: trailing spaces

(trailing-spaces)

---

[error] 92-92: trailing spaces

(trailing-spaces)

---

[error] 126-126: trailing spaces

(trailing-spaces)

---

[error] 129-129: trailing spaces

(trailing-spaces)

---

[error] 150-150: trailing spaces

(trailing-spaces)

---

[error] 157-157: trailing spaces

(trailing-spaces)

---

[error] 197-197: trailing spaces

(trailing-spaces)

---

[error] 201-201: trailing spaces

(trailing-spaces)

---

[error] 204-204: trailing spaces

(trailing-spaces)

---

[error] 205-205: trailing spaces

(trailing-spaces)

---

[error] 213-213: trailing spaces

(trailing-spaces)

---

[error] 243-243: trailing spaces

(trailing-spaces)

---

[error] 249-249: trailing spaces

(trailing-spaces)

---

[error] 251-251: trailing spaces

(trailing-spaces)

.github/workflows/stale.yml

[error] 6-6: trailing spaces

(trailing-spaces)

---

[error] 20-20: trailing spaces

(trailing-spaces)

---

[error] 21-21: trailing spaces

(trailing-spaces)

.github/workflows/push.yml

[error] 6-6: trailing spaces

(trailing-spaces)

---

[error] 17-17: trailing spaces

(trailing-spaces)

---

[error] 18-18: trailing spaces

(trailing-spaces)

---

[warning] 20-20: wrong indentation: expected 2 but found 4

(indentation)

---

[error] 21-21: trailing spaces

(trailing-spaces)

---

[error] 50-50: trailing spaces

(trailing-spaces)

---

[warning] 62-62: too many blank lines

(1 > 0) (empty-lines)

🪛 Markdownlint (0.37.0)

DOCUMENTATION.md

25-25: null
Bare URL used

(MD034, no-bare-urls)

README.md

53-53: null
Multiple spaces after hash on atx style heading

(MD019, no-multiple-space-atx)

PR_GUIDELINES.md

31-31: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

39-39: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

CODE_STYLE.md

128-128: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)

---

129-129: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)

---

130-130: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)

---

131-131: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)

---

132-132: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)

---

133-133: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)

---

134-134: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)

---

135-135: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)

---

136-136: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)

---

137-137: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)

---

164-164: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)

---

165-165: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)

---

166-166: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)

---

57-57: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

---

73-73: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

---

75-75: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

---

92-92: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

---

190-190: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

---

230-230: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

---

58-58: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

65-65: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

78-78: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

95-95: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

158-158: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

173-173: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

181-181: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

239-239: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

245-245: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

251-251: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

.github/ISSUE_TEMPLATE/feature-request.md

28-28: null
Bare URL used

(MD034, no-bare-urls)

---

25-25: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

CONTRIBUTING.md

104-104: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

113-113: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

128-128: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

139-139: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

143-143: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

158-158: null
No empty links

(MD042, no-empty-links)

---

159-159: null
No empty links

(MD042, no-empty-links)

---

161-161: null
No empty links

(MD042, no-empty-links)

INSTALLATION.md

321-321: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time

(MD001, heading-increment)

---

33-33: Expected: 4; Actual: 6
Unordered list indentation

(MD007, ul-indent)

---

34-34: Expected: 4; Actual: 6
Unordered list indentation

(MD007, ul-indent)

---

95-95: null
Dollar signs used before commands without showing output

(MD014, commands-show-output)

---

105-105: null
Bare URL used

(MD034, no-bare-urls)

---

142-142: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

154-154: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

164-164: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

188-188: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

194-194: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

200-200: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

208-208: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

214-214: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

220-220: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

240-240: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

256-256: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

264-264: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

270-270: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

292-292: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

300-300: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

313-313: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

327-327: Expected: fenced; Actual: indented
Code block style

(MD046, code-block-style)

---

335-335: Expected: fenced; Actual: indented
Code block style

(MD046, code-block-style)

---

178-178: Expected: #setting-up-react_app_talawa_url-in-env-file; Actual: #setting-up-REACT_APP_TALAWA_URL-in-env-file
Link fragments should be valid

(MD051, link-fragments)

---

178-178: Expected: #setting-up-react_app_recaptcha_site_key-in-env-file; Actual: #setting-up-REACT_APP_RECAPTCHA_SITE_KEY-in-env-file
Link fragments should be valid

(MD051, link-fragments)

.github/ISSUE_TEMPLATE/bug-report.md

36-36: null
Bare URL used

(MD034, no-bare-urls)

---

33-33: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

🪛 Ruff (0.8.2)

.github/workflows/compare_translations.py

135-135: Within an except clause, raise exceptions with raise ... from err or raise ... from None to distinguish them from errors in exception handling

(B904)

.github/workflows/eslint_disable_check.py

61-61: Loop control variable dirs not used within loop body

Rename unused dirs to _dirs

(B007)

🔇 Additional comments (51)

config/vite.config.ts (4)

1-5: Well-structured imports.

All plugins are pertinent to a React + Vite setup. Importing each plugin at the top keeps dependencies visible and ensures a clean structure.

---

9-11: Confirm output directory structure alignment with build pipelines.

Storing the build output under “build” is typical for React apps. Double-check that your deployment tooling or hosting service references the correct build output folder.

---

12-12: Clarify base usage.

The base parameter is set to an empty string, which is usually fine for local development. However, ensure that your production environment doesn’t require a specific subpath (e.g., "/admin").

---

16-16: Check environment variable usage.

You’re passing 'all' to EnvironmentPlugin, which might expose unintended environment variables. Verify that only the necessary environment variables are included.

.github/workflows/countline.py (1)

35-56: Ensure naming consistency for _valid_filename.
Currently, _valid_filename flags the presence of .test. or .spec. as invalid, while these file suffixes may actually represent valid test files. If your goal is to skip test files from analysis, consider making that intention more explicit—e.g., renaming the function or adding docstring details to clarify. Otherwise, confirm that ignoring test-related files is desired behavior.

scripts/githooks/check-localstorage-usage.js (3)

10-10: Ignore type annotation suggestions in JS files
ESLint’s complaint about a missing return type is not applicable here since this is a .js file, and per your project guidelines, TypeScript type annotations should not be used in JavaScript files.

🧰 Tools

🪛 eslint

[error] 10-10: Missing return type on function.

(@typescript-eslint/explicit-function-return-type)

---

20-20: Ignore type annotation suggestions in JS files
Same as above: We can safely disregard ESLint’s request for a function return type in a JavaScript file.

🧰 Tools

🪛 eslint

[error] 20-20: Missing return type on function.

(@typescript-eslint/explicit-function-return-type)

---

43-43: Ignore type annotation suggestions in JS files
Again, per project-specific guidelines, .js files should not contain TS-specific type annotations.

🧰 Tools

🪛 eslint

[error] 43-43: Missing return type on function.

(@typescript-eslint/explicit-function-return-type)

.gitignore (5)

31-32: LGTM: Debug log exclusion

Adding debug.log to .gitignore is appropriate for excluding application logs.

---

34-37: LGTM: Editor configuration exclusion

The addition of editor-specific files (.idea, .vscode, *.swp) is a good practice to keep the repository clean of personal IDE configurations.

---

21-21: Ensure environment variable documentation exists

Adding .env to .gitignore is correct for security, but we should verify that an example template exists.

✅ Verification successful

Environment variable documentation exists and is well-structured ✅

The repository has a properly documented .env.example file that lists all the required environment variables:

• PORT
• REACT_APP_TALAWA_URL
• REACT_APP_USE_RECAPTCHA
• REACT_APP_RECAPTCHA_SITE_KEY
• REACT_APP_BACKEND_WEBSOCKET_URL
• ALLOW_LOGS

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for environment variable documentation
echo "Checking for .env example files..."
find . -maxdepth 1 -type f -name ".env.example"

# If exists, check its content structure (without revealing values)
if [ -f ".env.example" ]; then
    echo "Checking .env.example structure..."
    grep -v '^#' .env.example | grep -v '^$' | cut -d '=' -f1
fi

Length of output: 426

---

3-5: Verify package manager configuration

Including both yarn.lock and pnpm-lock.yaml in .gitignore might indicate mixed usage of package managers. This could lead to inconsistent dependency resolution.

---

13-14: Update coverage path for Vitest migration

The addition of coverage/ and codecov entries aligns with the PR objective of migrating from Jest to Vitest. However, let's verify the coverage configuration.

✅ Verification successful

The coverage paths in .gitignore are correctly configured for the Jest to Vitest migration

The verification shows that:

• The Vitest configuration is properly set up with coverage reporting to ./coverage/vitest
• Both Jest (test script) and Vitest (test:vitest:coverage script) test commands are present in package.json
• The .gitignore entries are correct as:
  • coverage/ will catch both Jest and Vitest coverage outputs
  • codecov is appropriate for CI integration with Codecov service

The configuration aligns well with a transitional state where both testing frameworks coexist, and the coverage paths are properly ignored.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for test configuration files that might reference coverage paths
echo "Checking for Vitest configuration..."
find . -type f -name "vitest.config.*"

# Check package.json for coverage-related configurations
if [ -f "package.json" ]; then
    echo "Checking coverage configuration in package.json..."
    jq '.scripts | with_entries(select(.value | contains("coverage")))' package.json
fi

Length of output: 515

---

Script:

#!/bin/bash
# Check Vitest configuration for coverage settings
echo "Checking Vitest configuration file content..."
cat vitest.config.ts

# Look for any Jest configuration files that might still exist
echo -e "\nChecking for Jest configuration files..."
find . -type f -name "jest.config.*"

# Check for any remaining Jest coverage configuration
echo -e "\nChecking for Jest coverage configuration in package.json..."
jq '.jest.coverageDirectory' package.json 2>/dev/null || echo "No Jest coverage config found in package.json"

Length of output: 1363

public/locales/sp/errors.json (1)

1-11: Verify translations with a native Spanish speaker

The Spanish translations should be reviewed by a native speaker to ensure they convey the correct meaning and tone.

.github/workflows/push.yml (1)

1-11: Verify the referenced README file exists

The header comments reference a README.md file that should define the contents of this workflow file. Let's verify its existence.

✅ Verification successful

README exists and provides clear guidelines for workflow files

The referenced README.md exists in the .github/workflows/ directory and provides comprehensive guidelines for GitHub workflow files. According to the README:

• The push.yml file is correctly placed as per the guidelines which state "Place all actions related to pushes in the push.yml file"
• Any changes to files in this directory should only be made on the advice of a contributor
• The file follows the designated role categorization for workflow files

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if the README exists in the workflows directory
if [ -f ".github/workflows/README.md" ]; then
  echo "README exists. Content:"
  cat ".github/workflows/README.md"
else
  echo "README not found in .github/workflows/"
fi

Length of output: 2203

🧰 Tools

🪛 yamllint (1.35.1)

[error] 6-6: trailing spaces

(trailing-spaces)

public/locales/zh/common.json (1)

1-98: LGTM: Chinese translations are well-structured

The Chinese translations are complete and properly formatted:

• All entries are translated to Chinese
• Placeholders ({{item}}, {{text}}) are correctly preserved
• Translations appear accurate and natural

public/locales/hi/common.json (1)

1-98: Verify translations are being loaded correctly

Let's verify that the translation files are being loaded and used correctly in the application.

✅ Verification successful

Translations are properly configured and consistent across locales

The verification shows that:

1. The translation system is properly integrated across the application with extensive usage of useTranslation and i18n in components and screens (150+ files)
2. All locale files (en, fr, hi, sp, zh) under public/locales/*/common.json have exactly the same set of translation keys, ensuring consistent coverage
3. The Hindi translations in common.json contain valid translations for all the required keys

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for translation key usage in the codebase
echo "Checking translation key usage..."
rg -l "useTranslation|i18n" src/

# Check for consistent keys across all locale files
echo "Checking for consistency across locale files..."
for locale in public/locales/*/common.json; do
  echo "Keys in $locale:"
  jq 'keys' "$locale"
done

Length of output: 24300

public/locales/en/translation.json (2)

1082-1082: Review and enhance context for localization.

Some translations might need additional context for proper localization:

1. The date format in "Posted on {{date}}" might need to be specified for different locales
2. The donation amount range message might need currency formatting guidelines

Please verify if these strings provide enough context for translators and if they handle different locales correctly.

Consider adding translator comments to provide context for complex strings, especially those involving dates, currencies, and variable interpolation.

Also applies to: 1177-1179

---

168-179: Add missing translations for placeholder keys.

Several translation strings are identical to their keys, which suggests they are placeholder values that need to be properly translated:

• "name"
• "email"
• "searchByName"
• "description"
• "location"
• "address"
• "displayImage"
• "filter"
• "cancel"
• "endOfResults"
• "noResultsFoundFor"

Run the following script to find all instances where the key and value are identical:

Also applies to: 231-248

jest-preview.config.ts (1)

1-5: Looks good overall!
The new moduleNameMapper configuration straightforwardly maps @mui/(.*) to be resolved from <rootDir>/node_modules. This helps ensure correct resolution of MUI packages for Jest.

scripts/custom-test-env.js (1)

9-9: Consider adding a return type.
Static analysis flags the missing return type on your setup method. While this file is JavaScript, configuring it either as TypeScript or suppressing the rule might help maintain consistency.

🧰 Tools

🪛 eslint

[error] 9-9: Missing return type on function.

(@typescript-eslint/explicit-function-return-type)

---

[error] 9-9: Missing return type on function.

(@typescript-eslint/explicit-module-boundary-types)

scripts/__mocks__/@pdfme/generator.test.ts (1)

4-11: Extend assertion for promise resolution.
It is good practice to either await the generate function or to use .resolves in your assertion to confirm that the test awaits the promise’s resolution. Relying on toBeInstanceOf(Promise) alone may not fully validate asynchronous behavior.

jest.config.js (1)

1-83: Overall configuration looks solid.

The Jest configuration file is well-structured, with appropriate transform rules, coverage settings, and moduleNameMapper entries.

🧰 Tools

🪛 eslint

[error] 13-13: Insert ⏎··

(prettier/prettier)

.github/workflows/talawa_admin_md_mdx_format_adjuster.py (1)

19-44: No issues found in special character escaping logic.

The escape_mdx_characters() function is clearly documented and implements regex-based replacements accurately.

.github/workflows/eslint_disable_check.py (1)

1-120: Overall logic for ESLint-disable check is valid.

The script thoroughly scans .tsx files (excluding tests) and logs violations. The error handling is appropriate and does not interrupt the entire process.

🧰 Tools

🪛 Ruff (0.8.2)

61-61: Loop control variable dirs not used within loop body

Rename unused dirs to _dirs

(B007)

setup.ts (2)

10-22: Good approach for creating and populating the .env file.

Lines 10-22 ensure an .env file exists by copying from .env.example if needed. This is a straightforward setup strategy that helps standardize environment variables among developers.

---

1-185: Setup logic is well-structured and user-friendly.

Beyond the concurrency and consistency suggestions, the file demonstrates clear prompts and environment updates. This approach simplifies onboarding and ensures required environment variables are set.

.github/workflows/compare_translations.py (3)

1-49: Good use of comprehensive docstring.
Lines 1–49 effectively outline the purpose and functionality of the script. The structured docstring clarifies how to run the script, details utility functions, and references best practices. This thoroughness makes it easy for new contributors to understand and maintain the script.

---

91-116: Efficient flattening approach.
Lines 91–116 utilize a depth-first traversal approach for flattening JSON structures. This is a clean, recursive design that keeps the calling code simple. The docstring is clear, making it straightforward for others to extend or debug.

---

138-212: Robust error handling and exit codes.
Lines 138–212 implement check_translations and main, including system exit codes to indicate detailed success/failure states. This is a reliable pattern for stand-alone scripts. The code organizes logic well: loading default translations, iterating over language directories, and printing specific errors.

.coderabbit.yaml (4)

1-3: Concise language settings.
The YAML file effectively defines the schema, language, and an early access flag. This ensures a standardized configuration for the language server and user experience.

---

4-10: Adjust settings for your desired review style.
Lines 4–10 specify review behavior, such as profile, request_changes_workflow, poem, and more. Confirm these align with your team's preferences. If a more formal style is preferred, adjust or disable features like poem.

---

11-16: Ensure base branches reflect current workflow.
Lines 11–16 configure auto_review for branches develop and main. Double-check that these remain the correct base branches as your repository grows in complexity (e.g., addition of new stable or release branches).

---

17-18: Auto-reply considerations.
Enabling auto-reply to PR or issue comments can be helpful but may overwhelm maintainers if the project grows significantly. Periodically confirm it aligns with project needs.

public/manifest.json (2)

13-13: Icon size update from "192x192" to "16x16".
Changing the size to 16×16 may be intentional for a smaller app icon. However, confirm that all usage of the old 192×192 icon (for example, on mobile devices) is fully removed or replaced.

---

16-16: Updated path for "logo512.png" to "images/logo512.png".
This appears to standardize or reorganize media resources. Confirm the new path is correct in your build/serve environment, and that references to "logo512.png" are updated wherever they occur.

.github/ISSUE_TEMPLATE/feature-request.md (1)

2-6: Metadata changes for clarity and consistency.
Lines 2–6 rename “Feature request” to “Feature Request” and adjust labels. This improves consistency across templates. Ensure any automation that relies on these labels is updated accordingly.

.github/pull_request_template.md (1)

Line range hint 1-53: LGTM! Well-structured PR template

The PR template is well-organized with clear sections and important warnings about the branching strategy. The emphasis on submitting PRs against the develop branch is particularly important.

🧰 Tools

🪛 Markdownlint (0.37.0)

38-38: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

DOCUMENTATION.md (1)

1-32: LGTM! Clear and well-structured documentation

The documentation is well-organized with a clear table of contents and comprehensive instructions for both finding and contributing to documentation.

🧰 Tools

🪛 Markdownlint (0.37.0)

25-25: null
Bare URL used

(MD034, no-bare-urls)

🪛 LanguageTool

[grammar] ~25-~25: The modal verb ‘should’ requires the verb’s base form.
Context: ...f docs.talawa.io should automatically launched in your browser at http://localhost:300...

(MD_BASEFORM)

---

[grammar] ~26-~26: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...ttp://localhost:3000/ 1. Add/modify the markdown documents to the docs/ directory of t...

(MARKDOWN_NNP)

---

[uncategorized] ~32-~32: The preposition “to” seems more likely in this position.
Context: ... PLEASE do not add markdown files in this repository. Add them to `talawa-do...

(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)

README.md (2)

24-31: LGTM! Well-structured Table of Contents

The addition of a Table of Contents with clear sections improves document navigation.

---

45-51: LGTM! Clear documentation structure

The documentation section is well-organized with clear links to important files and resources.

.github/workflows/pull-request-target.yml (1)

73-77: LGTM! Welcoming first-time contributors

The greeting message effectively welcomes first-time contributors and points them to important documentation.

.eslintrc.json (3)

41-77: LGTM! Comprehensive TypeScript and React rules

The TypeScript and React rules are well-configured with appropriate strictness levels. The explicit return types, ban on unsafe practices, and strict component rules will help maintain code quality.

---

78-123: LGTM! Well-defined naming conventions

The naming conventions are comprehensive and well-structured:

• Interfaces must be prefixed with Interface or TestInterface
• Type-related entities follow PascalCase
• Variables and functions have appropriate casing rules
• Private members require leading underscores

---

32-39: LGTM! Essential plugins included

The inclusion of TypeScript, Jest, import, and TSDoc plugins provides comprehensive linting coverage.

CODE_OF_CONDUCT.md (1)

3-20: LGTM! Table of contents improves document navigation

The addition of a table of contents enhances the document's accessibility and navigation.

🧰 Tools

🪛 LanguageTool

[duplication] ~11-~11: Possible typo: you repeated a word
Context: ...-responsibilities) - Scope - Enforcement - Enforcement Guidelines ...

(ENGLISH_WORD_REPEAT_RULE)

package.json (1)

77-80: Clarify test runner strategy

The project appears to be in transition from Jest to Vitest, but both test runners are present. Consider:

1. Removing Jest-related scripts and dependencies if migration is complete
2. Adding a comment about the migration status if it's still in progress

.github/workflows/README.md (1)

1-47: LGTM! Well-structured workflow guidelines.

The document provides clear and comprehensive guidelines for:

1. Different types of workflows and their organization
2. Exceptions to the standard rules
3. Coding standards for scripts

🧰 Tools

🪛 LanguageTool

[uncategorized] ~13-~13: Possible missing comma found.
Context: ...ding on the type of workflow. Whenever possible you must ensure that: 1. The file roles...

(AI_HYDRA_LEO_MISSING_COMMA)

---

[duplication] ~24-~24: Possible typo: you repeated a word
Context: ...ors: 1. Place all actions related to to this in the pull-request-target.yml f...

(ENGLISH_WORD_REPEAT_RULE)

---

[uncategorized] ~35-~35: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...orrectly if they have a dedicated file (eg. CodeQL) ## Scripts Follow these gui...

(E_G)

.github/workflows/pull-request.yml (3)

85-136: LGTM! Well-implemented sensitive file protection

The sensitive file check implementation is robust with:

• Proper bot exclusions
• Comprehensive protected file list
• Clear error messaging

🧰 Tools

🪛 yamllint (1.35.1)

[error] 92-92: trailing spaces

(trailing-spaces)

---

[error] 126-126: trailing spaces

(trailing-spaces)

---

[error] 129-129: trailing spaces

(trailing-spaces)

---

256-265: LGTM! Proper branch protection

The target branch check is well-implemented with:

• Clear error message
• Reference to PR guidelines
• Proper bot exclusions

---

222-227: Verify the 95% coverage threshold requirement

A 95% coverage threshold is quite high and might be challenging to maintain. Consider if this strict requirement aligns with the project's quality vs. development speed trade-offs.

✅ Verification successful

Based on the analysis of the configuration files and test setup, I can provide a final response regarding the 95% coverage threshold requirement.

95% coverage threshold is appropriate for this project

The codebase shows a strong commitment to testing and quality:

• The project has recently undergone significant test framework modernization (migrating from Jest to Vitest)
• Multiple PRs show active maintenance of test coverage
• The test configuration excludes appropriate files from coverage (like index files, test files, types)
• Coverage reports are generated in multiple formats (text, html, text-summary, lcov)

While 95% is indeed a high threshold, it's justified here because:

1. The codebase has proper coverage exclusions configured for files that shouldn't be tested
2. The project shows active test maintenance through recent PRs
3. The configuration demonstrates mature test practices with proper setup and reporting

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check historical coverage trends
gh api graphql -f query='
{
  repository(owner: "PalisadoesFoundation", name: "talawa-admin") {
    object(expression: "develop") {
      ... on Commit {
        history(first: 10) {
          nodes {
            oid
            messageHeadline
            checkSuites(first: 1) {
              nodes {
                checkRuns(first: 10) {
                  nodes {
                    name
                    conclusion
                    output {
                      title
                    }
                  }
                }
              }
            }
          }
        }
      }
    }
  }
}'

Length of output: 985

---

Script:

#!/bin/bash
# Let's check the test coverage configuration in package.json and other config files
echo "=== Checking package.json for coverage config ==="
fd "package.json" --exec cat {}

echo -e "\n=== Checking jest.config files ==="
fd "jest.config" --exec cat {}

echo -e "\n=== Checking current coverage reports if available ==="
fd "lcov.info" --exec cat {}

echo -e "\n=== Checking PR history for coverage discussions ==="
gh pr list --state all --search "coverage in:title,body" --json number,title,body --limit 10

Length of output: 28038

[coderabbitai]

⚠️ Potential issue

Translate English messages to Spanish

Most error messages are still in English. For proper localization, all messages should be translated to Spanish. Here are suggested translations:

-  "talawaApiUnavailable": "Talawa-API service is unavailable!. Is it running? Check your network connectivity too.",
+  "talawaApiUnavailable": "¡El servicio Talawa-API no está disponible! ¿Está funcionando? Verifique también su conectividad de red.",
-  "notFound": "Not found",
+  "notFound": "No encontrado",
-  "unknownError": "An unknown error occurred. Please try again later. {{msg}}",
+  "unknownError": "Ocurrió un error desconocido. Por favor, inténtelo de nuevo más tarde. {{msg}}",
-  "notAuthorised": "Sorry! you are not Authorised!",
+  "notAuthorised": "¡Lo siento! ¡No está autorizado!",
-  "errorSendingMail": "Error sending mail",
+  "errorSendingMail": "Error al enviar el correo",
-  "emailNotRegistered": "Email not registered",
+  "emailNotRegistered": "Correo electrónico no registrado",
-  "notFoundMsg": "Oops! The Page you requested was not found!",
+  "notFoundMsg": "¡Ups! ¡La página que solicitó no fue encontrada!",

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	"talawaApiUnavailable": "Talawa-API service is unavailable!. Is it running? Check your network connectivity too.",
	"notFound": "Not found",
	"unknownError": "An unknown error occurred. Please try again later. {{msg}}",
	"notAuthorised": "Sorry! you are not Authorised!",
	"errorSendingMail": "Error sending mail",
	"emailNotRegistered": "Email not registered",
	"notFoundMsg": "Oops! The Page you requested was not found!",
	"talawaApiUnavailable": "¡El servicio Talawa-API no está disponible! ¿Está funcionando? Verifique también su conectividad de red.",
	"notFound": "No encontrado",
	"unknownError": "Ocurrió un error desconocido. Por favor, inténtelo de nuevo más tarde. {{msg}}",
	"notAuthorised": "¡Lo siento! ¡No está autorizado!",
	"errorSendingMail": "Error al enviar el correo",
	"emailNotRegistered": "Correo electrónico no registrado",
	"notFoundMsg": "¡Ups! ¡La página que solicitó no fue encontrada!",

[coderabbitai]

⚠️ Potential issue

Remove duplicate type definition.

The OrganizationCustomField type is defined twice with exactly the same fields. Remove one of the duplicate definitions to maintain schema clarity.

 type OrganizationCustomField {
   _id: ID!
   name: String!
   organizationId: String!
   type: String!
 }

-type OrganizationCustomField {
-  _id: ID!
-  name: String!
-  organizationId: String!
-  type: String!
-}

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	type OrganizationCustomField {
	_id: ID!
	name: String!
	organizationId: String!
	type: String!
	}
	type OrganizationCustomField {
	_id: ID!
	name: String!
	organizationId: String!
	type: String!
	}
	type OrganizationCustomField {
	_id: ID!
	name: String!
	organizationId: String!
	type: String!
	}

[coderabbitai]

🛠️ Refactor suggestion

Enhance authorization directives with clear documentation and parameters.

The @auth directive lacks parameters to specify the type of authorization required. Consider:

1. Adding parameters to define the authorization scope
2. Adding directive documentation using """ """ blocks

+"""
+Enforces authentication requirements for fields.
+Parameters can include:
+- requires: [Permission!] - list of required permissions
+- allowPublic: Boolean - whether to allow public access
+"""
 directive @auth on FIELD_DEFINITION

Committable suggestion skipped: line range outside the PR's diff.

[coderabbitai]

🛠️ Refactor suggestion

Add input validations for user registration.

The UserInput type lacks validation constraints. Consider:

1. Password strength requirements
2. Name length restrictions
3. Custom directives for validation rules

 input UserInput {
   appLanguageCode: String
   email: EmailAddress!
-  firstName: String!
-  lastName: String!
-  password: String!
+  firstName: String! @constraint(minLength: 2, maxLength: 50)
+  lastName: String! @constraint(minLength: 2, maxLength: 50)
+  password: String! @constraint(minLength: 8, pattern: "^(?=.*[A-Za-z])(?=.*\\d)[A-Za-z\\d]{8,}$")
   selectedOrganization: ID!
 }

Committable suggestion skipped: line range outside the PR's diff.

[coderabbitai]

🛠️ Refactor suggestion

Consider using LTS version of Node.js

Node.js 22.x is currently in development. Consider using an LTS version (e.g., 20.x) for better stability in CI environment.

    strategy:
      matrix:
-        node-version: [22.x]
+        node-version: [20.x]

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	strategy:
	matrix:
	node-version: [22.x]
	strategy:
	matrix:
	node-version: [20.x]

[coderabbitai]

🛠️ Refactor suggestion

Update community communication channels.

The Slack channel joining instructions could be more specific, and the freelists.org reference needs clarification.

Provide direct links and clearer instructions:

-1. The Palisadoes Foundation has a Slack channel where members can assist with support and clarification. Visit the [Talawa GitHub repository home page](https://github.com/PalisadoesFoundation/talawa) for the link to join our slack channel.
+1. Join our Slack workspace:
+   1. Visit our [Slack invitation page](https://join.slack.com/t/thepalisadoes-dyb6419/shared_invite/...)
+   2. Join the `#talawa-admin` channel for project-specific discussions
+   3. Introduce yourself in the `#introductions` channel

Committable suggestion skipped: line range outside the PR's diff.

🧰 Tools

🪛 LanguageTool

[grammar] ~178-~178: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...dation/talawa) for the link to join our slack channel. 1. We also have a technical em...

(ON_SKYPE)

[coderabbitai]

🛠️ Refactor suggestion

Use LTS version of Node.js

Node.js 22.x is not an LTS version. Consider using the latest LTS version for better stability and security.

- node-version: '22.x'
+ node-version: '20.x'  # Latest LTS version

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	uses: actions/setup-node@v4
	with:
	node-version: '22.x'
	uses: actions/setup-node@v4
	with:
	node-version: '20.x'

[coderabbitai]

⚠️ Potential issue

Secure the git clone command

The branch name should be properly escaped to prevent command injection. Use the --git-dir option for additional security.

- git clone --branch $FULL_BRANCH_NAME https://github.com/PalisadoesFoundation/talawa-api && ls -a 
+ git clone --branch "${FULL_BRANCH_NAME}" --git-dir="talawa-api/.git" https://github.com/PalisadoesFoundation/talawa-api

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	git clone --branch $FULL_BRANCH_NAME https://github.com/PalisadoesFoundation/talawa-api && ls -a
	git clone --branch "${FULL_BRANCH_NAME}" --git-dir="talawa-api/.git" https://github.com/PalisadoesFoundation/talawa-api

🧰 Tools

🪛 yamllint (1.35.1)

[error] 251-251: trailing spaces

(trailing-spaces)

[coderabbitai]

🛠️ Refactor suggestion

Use consistent LTS version of Node.js

Similar to the previous job, use the LTS version of Node.js here as well.

- node-version: '22.x'
+ node-version: '20.x'  # Latest LTS version

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	uses: actions/setup-node@v4
	with:
	node-version: '22.x'
	uses: actions/setup-node@v4
	with:
	node-version: '20.x' # Latest LTS version

[coderabbitai]

⚠️ Potential issue

Fix shell command injection vulnerability

The eslint command is vulnerable to command injection due to unquoted variable expansion. Always quote shell variables.

- CHANGED_FILES: ${{ steps.changed_files.outputs.all_changed_files }}
- run: npx eslint ${CHANGED_FILES} && python .github/workflows/eslint_disable_check.py
+ CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }}
+ run: npx eslint "${CHANGED_FILES}" && python .github/workflows/eslint_disable_check.py

Committable suggestion skipped: line range outside the PR's diff.

🧰 Tools

🪛 actionlint (1.7.4)

61-61: property "changed_files" is not defined in object type {changed-files: {conclusion: string; outcome: string; outputs: {string => string}}}

(expression)

---

62-62: shellcheck reported issue in this script: SC2086:info:1:12: Double quote to prevent globbing and word splitting

(shellcheck)

[palisadoes]

This PR has too many submitted files that are out of scope of the original issue.

Please ensure the following:

1. Fetch the latest upstream/develop-postgres files
2. Create a new local branch based on the latest upstream/develop-postgres branch.
   1. Your new local branch must not have the same name
3. Make your PR modifications based on this new local branch
4. Submit your PRs against our develop-postgres branch.

Please ask the slack channels for assistance.

Closing