-
-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/test jest to vitest 2486 #2687
Refactor/test jest to vitest 2486 #2687
Conversation
…sFoundation#1968) Bumps [@dicebear/collection](https://github.com/dicebear/dicebear) from 7.0.4 to 7.1.2. - [Release notes](https://github.com/dicebear/dicebear/releases) - [Changelog](https://github.com/dicebear/dicebear/blob/8.x/CHANGELOG.md) - [Commits](dicebear/dicebear@v7.0.4...v7.1.2) --- updated-dependencies: - dependency-name: "@dicebear/collection" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…dation#1966) Bumps [sanitize-html](https://github.com/apostrophecms/sanitize-html) from 2.12.1 to 2.13.0. - [Changelog](https://github.com/apostrophecms/sanitize-html/blob/main/CHANGELOG.md) - [Commits](apostrophecms/sanitize-html@2.12.1...2.13.0) --- updated-dependencies: - dependency-name: sanitize-html dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ion#1965) Bumps [graphql-ws](https://github.com/enisdenjo/graphql-ws) from 5.14.0 to 5.16.0. - [Release notes](https://github.com/enisdenjo/graphql-ws/releases) - [Changelog](https://github.com/enisdenjo/graphql-ws/blob/master/CHANGELOG.md) - [Commits](enisdenjo/graphql-ws@v5.14.0...v5.16.0) --- updated-dependencies: - dependency-name: graphql-ws dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…on#1972) * Fix routing issue for EventManagement * Update tests * Remove unnecessary change in INSTALLATION.md * Remove changes
* fix Requests to Membership Requests * Update Requests tests --------- Co-authored-by: Vamshi Maskuri <[email protected]>
…n#1896) * Removed `jest-enzyme` package * Adding check for * Added CommunityProfile page * Added tests for CommunityProfile page * Fixed formatting errors * Format fix * Merge branch 'develop' of https://github.com/git-init-priyanshu/talawa-admin-clone into priyanshu * Fixed merge conflicts * Format fix * Fix typecheck error * Added language support * Lint error fix * Integrated APIs * Revert changes * Fixed Failing Test * FIxed failing test * Fixed LoginPage failing tests * Full code coverage * Redesigned the Donations page * Added Tests * Fixed formatting errors * 100% code coverage for OrgListCard.tsx * Redesign of Post screen * View Post * Changed start post UI * Added Tests * Fixed failing tests * Added Edit Post & Delete Post Functionality * 100% code coverage
…ion#1981) Bumps [react-icons](https://github.com/react-icons/react-icons) from 4.12.0 to 5.2.1. - [Release notes](https://github.com/react-icons/react-icons/releases) - [Commits](react-icons/react-icons@v4.12.0...v5.2.1) --- updated-dependencies: - dependency-name: react-icons dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…oesFoundation#1982) Bumps [@mui/x-charts](https://github.com/mui/mui-x/tree/HEAD/packages/x-charts) from 6.0.0-alpha.13 to 7.4.0. - [Release notes](https://github.com/mui/mui-x/releases) - [Changelog](https://github.com/mui/mui-x/blob/master/CHANGELOG.md) - [Commits](https://github.com/mui/mui-x/commits/v7.4.0/packages/x-charts) --- updated-dependencies: - dependency-name: "@mui/x-charts" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ation#1983) Bumps [@dicebear/core](https://github.com/dicebear/dicebear) from 7.0.4 to 7.1.2. - [Release notes](https://github.com/dicebear/dicebear/releases) - [Changelog](https://github.com/dicebear/dicebear/blob/8.x/CHANGELOG.md) - [Commits](dicebear/dicebear@v7.0.4...v7.1.2) --- updated-dependencies: - dependency-name: "@dicebear/core" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#1984) Bumps [graphql](https://github.com/graphql/graphql-js) from 15.8.0 to 16.8.1. - [Release notes](https://github.com/graphql/graphql-js/releases) - [Commits](graphql/graphql-js@v15.8.0...v16.8.1) --- updated-dependencies: - dependency-name: graphql dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…Foundation#1985) Bumps [@emotion/styled](https://github.com/emotion-js/emotion) from 11.11.0 to 11.11.5. - [Release notes](https://github.com/emotion-js/emotion/releases) - [Changelog](https://github.com/emotion-js/emotion/blob/main/CHANGELOG.md) - [Commits](https://github.com/emotion-js/emotion/compare/@emotion/[email protected]...@emotion/[email protected]) --- updated-dependencies: - dependency-name: "@emotion/styled" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…adoesFoundation#1994) Bumps [typedoc-plugin-markdown](https://github.com/typedoc2md/typedoc-plugin-markdown/tree/HEAD/packages/typedoc-plugin-markdown) from 3.17.1 to 4.0.2. - [Release notes](https://github.com/typedoc2md/typedoc-plugin-markdown/releases) - [Changelog](https://github.com/typedoc2md/typedoc-plugin-markdown/blob/main/packages/typedoc-plugin-markdown/CHANGELOG.md) - [Commits](https://github.com/typedoc2md/typedoc-plugin-markdown/commits/[email protected]/packages/typedoc-plugin-markdown) --- updated-dependencies: - dependency-name: typedoc-plugin-markdown dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…Foundation#1996) Bumps [@dicebear/core](https://github.com/dicebear/dicebear) and [@dicebear/collection](https://github.com/dicebear/dicebear). These dependencies needed to be updated together. Updates `@dicebear/core` from 7.1.2 to 8.0.1 - [Release notes](https://github.com/dicebear/dicebear/releases) - [Changelog](https://github.com/dicebear/dicebear/blob/8.x/CHANGELOG.md) - [Commits](dicebear/dicebear@v7.1.2...v8.0.1) Updates `@dicebear/collection` from 7.1.2 to 8.0.1 - [Release notes](https://github.com/dicebear/dicebear/releases) - [Changelog](https://github.com/dicebear/dicebear/blob/8.x/CHANGELOG.md) - [Commits](dicebear/dicebear@v7.1.2...v8.0.1) --- updated-dependencies: - dependency-name: "@dicebear/core" dependency-type: direct:production update-type: version-update:semver-major - dependency-name: "@dicebear/collection" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…Foundation#2002) * folder restructure * namespace added * fix for 'register' common * feat: Update screens to use tCommon for localization * feat: Update screens to use tCommon for localization * feat: Update screens to use tCommon for localization * feat: Update screens to use tCommon for localization - yes no * feat: Update screens to use tCommon for localization - saveChanges * feat: Update screens to use tCommon for localization - email, name, pass * feat: Update screens to use tCommon for localization * remove pass * Update localization for first name and last name fields * tCommon fixes * Update localization * Update UsersTableItem component to remove unnecessary code and improve performance * Update common.json with startTime and endTime translations * Update localization for name field in screens * Update localization for enterLocation field * translations in test * chore: Update OrgPostCard.test.tsx with language detector mock * error translation fix * Refactor UsersTableItem component to optimize performance and remove unnecessary code * Update common.json with startTime and endTime translations * Update error translations in French, Hindi, Spanish, and Chinese locales * fix variable * fix tests usertableitem
…oundation#2010) Bumps [@mui/x-data-grid](https://github.com/mui/mui-x/tree/HEAD/packages/grid/x-data-grid) from 6.10.0 to 6.20.0. - [Release notes](https://github.com/mui/mui-x/releases) - [Changelog](https://github.com/mui/mui-x/blob/v6.20.0/CHANGELOG.md) - [Commits](https://github.com/mui/mui-x/commits/v6.20.0/packages/grid/x-data-grid) --- updated-dependencies: - dependency-name: "@mui/x-data-grid" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…2011) Bumps [dayjs](https://github.com/iamkun/dayjs) from 1.11.9 to 1.11.11. - [Release notes](https://github.com/iamkun/dayjs/releases) - [Changelog](https://github.com/iamkun/dayjs/blob/dev/CHANGELOG.md) - [Commits](iamkun/dayjs@v1.11.9...v1.11.11) --- updated-dependencies: - dependency-name: dayjs dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ndation#2013) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.12.7 to 20.12.12. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: Update common translations for multiple locales * chore: Update CollapsibleDropdown component with Redux and i18next providers
PalisadoesFoundation#2021) * add translations * feat: Add "viewProfile" translation for common.json * feat: Add i18n support for ProfileDropdown component
…oundation#2022) Bumps [@emotion/react](https://github.com/emotion-js/emotion) from 11.11.1 to 11.11.4. - [Release notes](https://github.com/emotion-js/emotion/releases) - [Changelog](https://github.com/emotion-js/emotion/blob/main/CHANGELOG.md) - [Commits](https://github.com/emotion-js/emotion/compare/@emotion/[email protected]...@emotion/[email protected]) --- updated-dependencies: - dependency-name: "@emotion/react" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…sFoundation#2023) Bumps [@mui/x-date-pickers](https://github.com/mui/mui-x/tree/HEAD/packages/x-date-pickers) from 6.10.0 to 7.6.1. - [Release notes](https://github.com/mui/mui-x/releases) - [Changelog](https://github.com/mui/mui-x/blob/master/CHANGELOG.md) - [Commits](https://github.com/mui/mui-x/commits/v7.6.1/packages/x-date-pickers) --- updated-dependencies: - dependency-name: "@mui/x-date-pickers" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…undation#2025) Bumps [@mui/material](https://github.com/mui/material-ui/tree/HEAD/packages/mui-material) from 5.15.15 to 5.15.19. - [Release notes](https://github.com/mui/material-ui/releases) - [Changelog](https://github.com/mui/material-ui/blob/v5.15.19/CHANGELOG.md) - [Commits](https://github.com/mui/material-ui/commits/v5.15.19/packages/mui-material) --- updated-dependencies: - dependency-name: "@mui/material" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [sass](https://github.com/sass/dart-sass) from 1.71.1 to 1.77.4. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.71.1...1.77.4) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* OrgPeople screen translations * venues screen fix * Action Itme screen fix * Action Itme screen fix * . * fix screens * chore: Update EditCustomFieldDropDown test to use i18nForTest provider
…doesFoundation#2036) Bumps [typedoc-plugin-markdown](https://github.com/typedoc2md/typedoc-plugin-markdown/tree/HEAD/packages/typedoc-plugin-markdown) from 4.0.2 to 4.0.3. - [Release notes](https://github.com/typedoc2md/typedoc-plugin-markdown/releases) - [Changelog](https://github.com/typedoc2md/typedoc-plugin-markdown/blob/main/packages/typedoc-plugin-markdown/CHANGELOG.md) - [Commits](https://github.com/typedoc2md/typedoc-plugin-markdown/commits/[email protected]/packages/typedoc-plugin-markdown) --- updated-dependencies: - dependency-name: typedoc-plugin-markdown dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…oundation#2033) Bumps [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom) from 6.22.2 to 6.23.1. - [Release notes](https://github.com/remix-run/react-router/releases) - [Changelog](https://github.com/remix-run/react-router/blob/main/packages/react-router-dom/CHANGELOG.md) - [Commits](https://github.com/remix-run/react-router/commits/[email protected]/packages/react-router-dom) --- updated-dependencies: - dependency-name: react-router-dom dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump sass from 1.80.6 to 1.80.7 (PalisadoesFoundation#2433) Bumps [sass](https://github.com/sass/dart-sass) from 1.80.6 to 1.80.7. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.80.6...1.80.7) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump eslint-plugin-import from 2.30.0 to 2.31.0 (PalisadoesFoundation#2434) Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.30.0 to 2.31.0. - [Release notes](https://github.com/import-js/eslint-plugin-import/releases) - [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.30.0...v2.31.0) --- updated-dependencies: - dependency-name: eslint-plugin-import dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @mui/x-charts from 7.22.1 to 7.22.2 (PalisadoesFoundation#2435) Bumps [@mui/x-charts](https://github.com/mui/mui-x/tree/HEAD/packages/x-charts) from 7.22.1 to 7.22.2. - [Release notes](https://github.com/mui/mui-x/releases) - [Changelog](https://github.com/mui/mui-x/blob/v7.22.2/CHANGELOG.md) - [Commits](https://github.com/mui/mui-x/commits/v7.22.2/packages/x-charts) --- updated-dependencies: - dependency-name: "@mui/x-charts" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @types/react from 18.3.3 to 18.3.12 (PalisadoesFoundation#2436) Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.3.3 to 18.3.12. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update pull-request.yml * css for color blinds * fix * lint fix * lint fix * fix failing test * fix * fix * fix * fix * fix * fix * fix * lock file changes * fix type * fix type * Update tagTemplate.ts * Update tagTemplate.ts * Update tagTemplate.ts * Update tagTemplate.ts * Update tagTemplate.ts * Update tagTemplate.ts * Update TableRow.tsx * Update tsconfig.json --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Harrison <[email protected]>
* reverting workflow changes * changes 1 * identation fix
….tsx from Jest to Vitest (PalisadoesFoundation#2482) * Migrated to vitest * Added ts-doc comment --------- Co-authored-by: Vamshi Maskuri <[email protected]>
* advertisement and plugin screen * added revamped design * fixes added * fixed testcases * chore(deps): bump sass from 1.80.6 to 1.80.7 (PalisadoesFoundation#2433) Bumps [sass](https://github.com/sass/dart-sass) from 1.80.6 to 1.80.7. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.80.6...1.80.7) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump eslint-plugin-import from 2.30.0 to 2.31.0 (PalisadoesFoundation#2434) Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.30.0 to 2.31.0. - [Release notes](https://github.com/import-js/eslint-plugin-import/releases) - [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.30.0...v2.31.0) --- updated-dependencies: - dependency-name: eslint-plugin-import dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @mui/x-charts from 7.22.1 to 7.22.2 (PalisadoesFoundation#2435) Bumps [@mui/x-charts](https://github.com/mui/mui-x/tree/HEAD/packages/x-charts) from 7.22.1 to 7.22.2. - [Release notes](https://github.com/mui/mui-x/releases) - [Changelog](https://github.com/mui/mui-x/blob/v7.22.2/CHANGELOG.md) - [Commits](https://github.com/mui/mui-x/commits/v7.22.2/packages/x-charts) --- updated-dependencies: - dependency-name: "@mui/x-charts" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @types/react from 18.3.3 to 18.3.12 (PalisadoesFoundation#2436) Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.3.3 to 18.3.12. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update pull-request.yml * Update dependabot.yaml * added docker check to workflow (PalisadoesFoundation#2414) * added docker check to workflow * made recommended changes to docker check in workflow * added changes to docker check inn workflow as recommended * added changes * updated indentation in pull-request.yml file * updated indentation in pull-request.yml file * added Dockerfile and Docker-compose.yml file * added Dockerfile and Docker-compose.yml file * updated .docker-ignore file * added recommended changes by code rabbit * added recommended changes by code rabbit * added recommended changes by code rabbit * added recommended changes by code rabbit * added recommended changes by code rabbit * added recommended changes by code rabbit * properly formatted code * trying to make docker check pass * trying to make docker check pass * updated INSTALLATION.md * updated INSTALLATION.md * added recommended changes to INSTALLATION.md * added recommended changes to INSTALLATION.md * added recommended changes to INSTALLATION.md * updated docker workflow * updated INSTALLATION.md * eslint-rule-no_unused_vars (PalisadoesFoundation#2428) * Updated pr template with checklist (PalisadoesFoundation#2454) * Updated pr template with checklist * Additional changes for the PR template * Changed the url for the PR template * refactored addOnStore * refactored addOnEntry v1 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Harrison <[email protected]> Co-authored-by: Vanshika Sabharwal <[email protected]> Co-authored-by: prayansh_chhablani <[email protected]> Co-authored-by: Dhiraj Udhani <[email protected]>
…ndation#2523) (PalisadoesFoundation#2610) * refactored: CSS files in src/screens/OrgSettings(fixes: PalisadoesFoundation#2523) * refactored: CSS files in src/screens/OrgSettings(fixes: PalisadoesFoundation#2523) * refactored: CSS files in src/screens/OrgSettings(fixes: PalisadoesFoundation#2523) * refactored: CSS files in src/screens/OrgSettings(fixes: PalisadoesFoundation#2523)
…sFoundation#2641) * Refactor: jest to vitest : Fixes PalisadoesFoundation#2547 * Refactor: jest to vitest : Fixes PalisadoesFoundation#2547 * updated src/screens/EventVolunteers/Requests.spec.tsx --------- Co-authored-by: bandhan-majumder <[email protected]> Co-authored-by: Bandhan Majumder <[email protected]>
…t to Vitest (PalisadoesFoundation#2636) Co-authored-by: im-vedant <[email protected]>
…isadoesFoundation#2640) * Refactored: src/screens/UserPortal/Campaigns from Jest to Vitest * Refactored: src/screens/UserPortal/Campaigns from Jest to Vitest * Refactored: src/screens/UserPortal/Campaigns from Jest to Vitest
…doesFoundation#2567) (PalisadoesFoundation#2625) * refactored: src/screens/OrgSettings from Jest to Vitest(fixes: PalisadoesFoundation#2567) * refactored: src/screens/OrgSettings from Jest to Vitest(fixes: PalisadoesFoundation#2567) * refactored: src/screens/OrgSettings from Jest to Vitest(fixes: PalisadoesFoundation#2567) * refactored: src/screens/OrgSettings from Jest to Vitest(fixes: PalisadoesFoundation#2567) * refactored: src/screens/OrgSettings from Jest to Vitest(fixes: PalisadoesFoundation#2567) * refactored: src/screens/OrgSettings from Jest to Vitest(fixes: PalisadoesFoundation#2567) * refactored: src/screens/OrgSettings from Jest to Vitest(fixes: PalisadoesFoundation#2567) * updated check-tsdoc to ignore .spec.tsx
* refactor:request screen to vitest * refactor:vitest to Requests Screen * implement codreabbit suggestions
* refactor: Users-css * Update Users.tsx * Update app.module.css * Updated app.module.css * Fixed formatting isuess * Fixed formatting isuess * fixed issues * Fix linting issues
PalisadoesFoundation#2593) * refactored OrganizationDashboard css/ closes PalisadoesFoundation#2513 * refactor:OrganizationDashboard_css(fixes PalisadoesFoundation#2513) * Plugin and advertisement screen revamp (PalisadoesFoundation#2006) * advertisement and plugin screen * added revamped design * fixes added * fixed testcases * chore(deps): bump sass from 1.80.6 to 1.80.7 (PalisadoesFoundation#2433) Bumps [sass](https://github.com/sass/dart-sass) from 1.80.6 to 1.80.7. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.80.6...1.80.7) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump eslint-plugin-import from 2.30.0 to 2.31.0 (PalisadoesFoundation#2434) Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.30.0 to 2.31.0. - [Release notes](https://github.com/import-js/eslint-plugin-import/releases) - [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.30.0...v2.31.0) --- updated-dependencies: - dependency-name: eslint-plugin-import dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @mui/x-charts from 7.22.1 to 7.22.2 (PalisadoesFoundation#2435) Bumps [@mui/x-charts](https://github.com/mui/mui-x/tree/HEAD/packages/x-charts) from 7.22.1 to 7.22.2. - [Release notes](https://github.com/mui/mui-x/releases) - [Changelog](https://github.com/mui/mui-x/blob/v7.22.2/CHANGELOG.md) - [Commits](https://github.com/mui/mui-x/commits/v7.22.2/packages/x-charts) --- updated-dependencies: - dependency-name: "@mui/x-charts" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @types/react from 18.3.3 to 18.3.12 (PalisadoesFoundation#2436) Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.3.3 to 18.3.12. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update pull-request.yml * Update dependabot.yaml * added docker check to workflow (PalisadoesFoundation#2414) * added docker check to workflow * made recommended changes to docker check in workflow * added changes to docker check inn workflow as recommended * added changes * updated indentation in pull-request.yml file * updated indentation in pull-request.yml file * added Dockerfile and Docker-compose.yml file * added Dockerfile and Docker-compose.yml file * updated .docker-ignore file * added recommended changes by code rabbit * added recommended changes by code rabbit * added recommended changes by code rabbit * added recommended changes by code rabbit * added recommended changes by code rabbit * added recommended changes by code rabbit * properly formatted code * trying to make docker check pass * trying to make docker check pass * updated INSTALLATION.md * updated INSTALLATION.md * added recommended changes to INSTALLATION.md * added recommended changes to INSTALLATION.md * added recommended changes to INSTALLATION.md * updated docker workflow * updated INSTALLATION.md * eslint-rule-no_unused_vars (PalisadoesFoundation#2428) * Updated pr template with checklist (PalisadoesFoundation#2454) * Updated pr template with checklist * Additional changes for the PR template * Changed the url for the PR template * refactored addOnStore * refactored addOnEntry v1 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Harrison <[email protected]> Co-authored-by: Vanshika Sabharwal <[email protected]> Co-authored-by: prayansh_chhablani <[email protected]> Co-authored-by: Dhiraj Udhani <[email protected]> * refactored: CSS files in src/screens/OrgSettings(fixes: PalisadoesFoundation#2523) (PalisadoesFoundation#2610) * refactored: CSS files in src/screens/OrgSettings(fixes: PalisadoesFoundation#2523) * refactored: CSS files in src/screens/OrgSettings(fixes: PalisadoesFoundation#2523) * refactored: CSS files in src/screens/OrgSettings(fixes: PalisadoesFoundation#2523) * refactored: CSS files in src/screens/OrgSettings(fixes: PalisadoesFoundation#2523) * Update pull-request.yml * refactored: CSS files in src/screens/OrganizationDashboard(fixes: PalisadoesFoundation#2513) * refactored: CSS files in src/screens/OrganizationDashboard(fixes: PalisadoesFoundation#2513) * improve import for global css --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Shekhar Patel <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Harrison <[email protected]> Co-authored-by: Vanshika Sabharwal <[email protected]> Co-authored-by: prayansh_chhablani <[email protected]> Co-authored-by: Dhiraj Udhani <[email protected]>
…o Vitest (PalisadoesFoundation#2623) * migrated UpcomingEvents tests from Jest to Vitest * Rename UpcomingEvents.test.tsx to UpcomingEvents.spec.tsx * add header comments for UpcomingEvents component tests
WalkthroughThis pull request introduces a comprehensive set of configuration files, documentation updates, and workflow modifications for the Talawa Admin project. The changes span multiple aspects of the project, including development environment setup, testing infrastructure, localization, and GitHub workflow management. The PR aims to enhance code quality, improve developer experience, and standardize project practices. Changes
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Repo as Repository
participant CI as GitHub Actions
participant CodeRabbit as CodeRabbit AI
Dev->>Repo: Commits code
Repo->>CI: Triggers workflows
CI->>CI: Run linting, testing
CI->>CodeRabbit: Trigger review
CodeRabbit->>CodeRabbit: Analyze changes
CodeRabbit->>Dev: Provide review comments
Possibly related issues
Possibly related PRs
Suggested reviewersPoem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
@khushipatil1523 I think it's your first contribution here. Welcome! We don't accept PRs against You can follow this
Now make changes in this branch and submit a new PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 34
🔭 Outside diff range comments (1)
.eslintrc.json (1)
Line range hint
1-146
: Add Vitest-specific configurationConsider adding Vitest-specific ESLint rules to maintain code quality in tests.
Add the following rules:
"rules": { + "vitest/expect-expect": "error", + "vitest/no-disabled-tests": "warn", + "vitest/no-focused-tests": "error", + "vitest/valid-expect": "error", // ... existing rules ... }
🧹 Nitpick comments (49)
scripts/__mocks__/@dicebear/core.ts (1)
1-5
: Consider restructuring mock location for VitestThe current file is located in
scripts/__mocks__/@dicebear/core.ts
following Jest's automatic mocking convention. However, Vitest handles mocking differently and doesn't rely on the__mocks__
directory structure.Consider these approaches instead:
- Move the mock to a
__mocks__
directory adjacent to your test files- Create the mock inline in your test files using
vi.mock()
- Use a dedicated test utils directory, for example:
// tests/utils/mocks/dicebear.ts import { vi } from 'vitest'; export const mockCreateAvatar = vi.fn(() => ({ toDataUri: vi.fn(() => 'mocked-data-uri'), })); // In your test file import { mockCreateAvatar } from '@/tests/utils/mocks/dicebear'; vi.mock('@dicebear/core', () => ({ createAvatar: mockCreateAvatar }));.github/workflows/eslint_disable_check.py (1)
61-61
: Rename unused variable 'dirs' to '_' or another placeholder
The variable 'dirs' in the loop is not used within its body, which can cause confusion and trigger lint warnings.Apply this diff to rename the variable:
-for root, dirs, files in os.walk(os.path.join(directory, 'src')): +for root, _, files in os.walk(os.path.join(directory, 'src')):🧰 Tools
🪛 Ruff (0.8.2)
61-61: Loop control variable
dirs
not used within loop bodyRename unused
dirs
to_dirs
(B007)
.github/workflows/compare_translations.py (1)
134-135
: Include the original error context when re-raising exceptions
When re-raising exceptions in the except block, Python best practices recommend using "from e" to preserve the original traceback context.Suggested change:
except json.JSONDecodeError as e: - raise ValueError(f"Error decoding JSON from file {filepath}: {e}") + raise ValueError(f"Error decoding JSON from file {filepath}: {e}") from e🧰 Tools
🪛 Ruff (0.8.2)
135-135: Within an
except
clause, raise exceptions withraise ... from err
orraise ... from None
to distinguish them from errors in exception handling(B904)
.github/workflows/countline.py (1)
198-200
: Clarify the docstring to match actual functionality
The docstring mentions "Analyze dart files", but the script analyzes lines of code in multiple directories, possibly for various file types. It can be confusing for new contributors. Consider updating the docstring for accuracy.Example update:
-"""Analyze dart files. +"""Analyze code files in specified directories..husky/post-merge (1)
1-4
: Add error handling and user feedbackWhile the basic functionality is correct, consider enhancing the script's robustness and user experience.
#!/bin/sh . "$(dirname "$0")/_/husky.sh" -git diff HEAD^ HEAD --exit-code -- ./package.json || npm install +if ! git diff HEAD^ HEAD --exit-code -- ./package.json; then + echo "📦 package.json changes detected. Running npm install..." + if ! npm install; then + echo "❌ npm install failed. Please resolve dependencies manually." + exit 1 + fi + echo "✅ Dependencies updated successfully!" +fi.husky/pre-commit (1)
5-5
: Remove or uncomment the lint:fix commandThe commented
lint:fix
command should either be removed or uncommented if needed.-# npm run lint:fix
public/locales/zh/errors.json (1)
4-4
: Standardize placeholder formatThe file uses different placeholder formats:
{{msg}}
for unknown errors{{entity}}
for creation and loading errorsConsider standardizing the placeholder naming convention across all messages.
Also applies to: 9-9, 10-10
public/locales/hi/errors.json (1)
2-2
: Remove trailing spaces from translationsThere are unnecessary trailing spaces in several translations:
- Line 2: "तलवा-एपीआई सेवा उपलब्ध नहीं है! " (space after !)
- Line 5: "क्षमा मांगना! " (space after !)
- Line 8: "उफ़! " (space after !)
- "talawaApiUnavailable": "तलवा-एपीआई सेवा उपलब्ध नहीं है! ", + "talawaApiUnavailable": "तलवा-एपीआई सेवा उपलब्ध नहीं है!", - "notAuthorised": "क्षमा मांगना! ", + "notAuthorised": "क्षमा मांगना!", - "notFoundMsg": "उफ़! ", + "notFoundMsg": "उफ़!",Also applies to: 5-5, 8-8
.github/ISSUE_TEMPLATE/feature-request.md (2)
27-28
: Format URL as a proper Markdown linkThe bare URL should be formatted as a proper Markdown link for better readability and to comply with Markdown best practices.
-Please read this if you are planning to apply for a Palisadoes Foundation internship -- https://github.com/PalisadoesFoundation/talawa/issues/359 +Please read this if you are planning to apply for a Palisadoes Foundation internship: +[Internship Information](https://github.com/PalisadoesFoundation/talawa/issues/359)🧰 Tools
🪛 Markdownlint (0.37.0)
28-28: null
Bare URL used(MD034, no-bare-urls)
25-26
: Use proper heading formatConvert the bold text to a proper Markdown heading for better document structure.
-**Potential internship candidates** +### Potential internship candidates🧰 Tools
🪛 Markdownlint (0.37.0)
25-25: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
public/locales/en/errors.json (3)
2-2
: Fix punctuation in API unavailability messageThere's an unnecessary period after the exclamation mark.
- "talawaApiUnavailable": "Talawa-API service is unavailable!. Is it running? Check your network connectivity too.", + "talawaApiUnavailable": "Talawa-API service is unavailable! Is it running? Check your network connectivity too.",
5-5
: Fix capitalization in authorization messageThe word "Authorised" should not be capitalized in the middle of a sentence, and "Sorry" doesn't need an exclamation mark when the sentence already ends with one.
- "notAuthorised": "Sorry! you are not Authorised!", + "notAuthorised": "Sorry, you are not authorised!",
10-10
: Fix spelling error in error message"occurred" is misspelled as "occured".
- "errorLoading": "Error occured while loading {{entity}} data", + "errorLoading": "Error occurred while loading {{entity}} data",.github/workflows/codeql-codescan.yml (2)
14-20
: Consider restricting branch patterns for securityRunning CodeQL analysis on all branches (
'**'
) could potentially expose the repository to resource exhaustion if many branches are created. Consider limiting this to main branches and pull requests.on: pull_request: branches: - - '**' + - 'main' + - 'develop' push: branches: - - '**' + - 'main' + - 'develop'🧰 Tools
🪛 yamllint (1.35.1)
[error] 17-17: trailing spaces
(trailing-spaces)
[error] 20-20: trailing spaces
(trailing-spaces)
21-30
: Add concurrency control to prevent parallel runsAdd concurrency configuration to cancel in-progress runs when new commits are pushed, improving resource utilization.
jobs: + # Add concurrency group to cancel in-progress runs + concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + CodeQL: if: ${{ github.actor != 'dependabot[bot]' }} name: Analyse Code With CodeQL runs-on: ubuntu-latest.github/workflows/stale.yml (2)
37-38
: Consider increasing the stale periodThe current configuration marks issues as stale after just 10 days of inactivity, which might be too aggressive for a community project. Consider increasing this period to allow for more community engagement.
- days-before-stale: 10 + days-before-stale: 30 days-before-close: 180
41-42
: Consider additional exempt labelsThe current configuration only exempts 'wip' labeled items. Consider adding more exempt labels for long-term tracking items like 'good first issue', 'help wanted', or 'documentation'.
- exempt-pr-labels: 'wip' - exempt-issue-labels: 'wip' + exempt-pr-labels: 'wip,good first issue,help wanted,documentation' + exempt-issue-labels: 'wip,good first issue,help wanted,documentation'.github/workflows/check-tsdoc.js (2)
5-11
: Consider making filesToSkip configurableThe hardcoded skip list might be better maintained in a configuration file, making it easier to update without modifying the script.
Consider moving the skip list to a
.tsconfig.json
or similar configuration file:-const filesToSkip = [ - 'index.tsx', - 'EventActionItems.tsx', - 'OrgPostCard.tsx', - 'UsersTableItem.tsx', - 'FundCampaignPledge.tsx' -]; +const filesToSkip = require('./tsconfig.json').tsdocSkipFiles || [];
49-67
: Add progress reporting and summary statisticsThe script could provide better feedback about its progress and results.
async function run() { const dir = process.argv[2] || './src'; + console.log(`Starting TSDoc validation in ${dir}`); const files = await findTsxFiles(dir); + console.log(`Found ${files.length} TSX files to check`); const filesWithoutTsDoc = []; for (const file of files) { if (!await containsTsDocComment(file)) { filesWithoutTsDoc.push(file); } } if (filesWithoutTsDoc.length > 0) { + console.error(`\nFound ${filesWithoutTsDoc.length} files missing TSDoc comments:`); filesWithoutTsDoc.forEach(file => { console.error(`No TSDoc comment found in file: ${file}`); }); process.exit(1); + } else { + console.log('\nSuccess: All TSX files have TSDoc comments! 🎉'); } }.github/pull_request_template.md (1)
58-58
: Fix markdown formattingUse proper heading syntax instead of emphasis.
-**Other information** +### Other information🧰 Tools
🪛 Markdownlint (0.37.0)
58-58: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
.github/workflows/issue.yml (2)
42-48
: Optimize GitHub API script implementationThe script contains redundant owner/repo references and could be simplified.
- await github.rest.issues.addLabels({ - owner: context.repo.owner, - repo: context.repo.repo, - issue_number: context.issue.number, - labels: ["good first issue", "security"] - }); + await github.rest.issues.addLabels({ + ...apiParams, + labels: ["good first issue", "security"] + });
49-55
: Reuse existing apiParams objectSimilar to the previous section, this block can be simplified using the existing apiParams object.
- await github.rest.issues.addLabels({ - owner: context.repo.owner, - repo: context.repo.repo, - issue_number: context.issue.number, - labels: ["good first issue"] - }); + await github.rest.issues.addLabels({ + ...apiParams, + labels: ["good first issue"] + });.github/workflows/talawa_admin_md_mdx_format_adjuster.py (2)
55-57
: Add error handling for file operationsFile operations should include error handling to gracefully handle potential issues.
- with open(filepath, 'r', encoding='utf-8') as file: - content = file.read() + try: + with open(filepath, 'r', encoding='utf-8') as file: + content = file.read() + except IOError as e: + print(f"Error reading file {filepath}: {e}") + return
90-93
: Add progress reporting for large directoriesWhen processing multiple files, it would be helpful to show progress, especially for large directories.
+ from tqdm import tqdm + # Process each Markdown file in the directory + markdown_files = [] for root, _, files in os.walk(args.directory): for file in files: if file.lower().endswith(".md"): - process_file(os.path.join(root, file)) + markdown_files.append(os.path.join(root, file)) + + for filepath in tqdm(markdown_files, desc="Processing Markdown files"): + process_file(filepath)README.md (2)
53-53
: Fix heading formattingRemove extra space after the hash symbol in the "Videos" heading.
-# Videos +# Videos🧰 Tools
🪛 Markdownlint (0.37.0)
53-53: null
Multiple spaces after hash on atx style heading(MD019, no-multiple-space-atx)
45-51
: Document testing framework transitionSince this PR transitions from Jest to Vitest, consider adding information about the testing framework in the documentation section.
Add a note about using Vitest for testing, for example:
1. The `talawa` documentation can be found at our [docs.talawa.io](https://docs.talawa.io) site. 1. It is automatically generated from the markdown files stored in our [Talawa-Docs GitHub repository](https://github.com/PalisadoesFoundation/talawa-docs). This makes it easy for you to update our documenation. +1. We use Vitest as our testing framework. For more information about writing tests, see our testing documentation.
.github/workflows/pull-request-target.yml (2)
37-37
: Specify testing framework in PR policySince we're transitioning to Vitest, consider mentioning it explicitly in the testing requirements.
- 1. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository + 1. Write sufficient tests using Vitest (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
6-70
: Remove trailing spacesMultiple lines contain trailing spaces. This can cause issues with some text editors and version control systems.
Remove trailing spaces from lines 6, 13, 15, 27-29, 33, 35, 40, 45, and 70.
🧰 Tools
🪛 yamllint (1.35.1)
[error] 6-6: trailing spaces
(trailing-spaces)
[error] 13-13: trailing spaces
(trailing-spaces)
[error] 15-15: trailing spaces
(trailing-spaces)
[error] 27-27: trailing spaces
(trailing-spaces)
[error] 28-28: trailing spaces
(trailing-spaces)
[error] 29-29: trailing spaces
(trailing-spaces)
[error] 33-33: trailing spaces
(trailing-spaces)
[error] 35-35: trailing spaces
(trailing-spaces)
[error] 40-40: trailing spaces
(trailing-spaces)
[error] 45-45: trailing spaces
(trailing-spaces)
[error] 70-70: trailing spaces
(trailing-spaces)
PR_GUIDELINES.md (3)
21-23
: Consider rephrasing for clarityThe current wording could be clearer about issue assignment and PR requirements.
-Do not start working on any open issue and raise a PR unless the issue is assigned to you. PRs that don't meet these guidelines will be closed. +Do not start working on any open issue or submit a PR unless the issue has been assigned to you. PRs that don't follow this guideline will be closed.
46-47
: Improve grammar in testing requirementsThe sentence contains a split infinitive and could be more specific about testing requirements.
-If, for some reason, it is not possible to add tests, please let us know and explain why. In that case, you'll need to tell us what steps you followed to manually test your changes. +If adding tests is not possible, please explain why and describe the steps you followed to test your changes manually.🧰 Tools
🪛 LanguageTool
[style] ~46-~46: Style-wise, it’s not ideal to insert an adverb (‘manually’) in the middle of an infinitive construction (‘to test’). Try moving the adverb to avoid split infinitives.
Context: ..., you'll need to tell us what steps you followed to manually test your changes. 1. Please read our [CONTRIBUTING.md](C...(SPLIT_INFINITIVE)
56-57
: Fix punctuation and strengthen wordingAdd a comma after "Therefore" and strengthen the statement about code quality.
-The quality of our code is very important to us. Therefore we make experienced maintainers of our code base review your code. +The quality of our code is crucial. Therefore, we ensure that experienced maintainers review your code.🧰 Tools
🪛 LanguageTool
[style] ~56-~56: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...o be closed. The quality of our code is very important to us. Therefore we make experienced ma...(EN_WEAK_ADJECTIVE)
[uncategorized] ~56-~56: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ...ty of our code is very important to us. Therefore we make experienced maintainers of our ...(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
package.json (1)
168-170
: Consider relaxing Node.js version requirementThe current Node.js version requirement might be too restrictive. Consider supporting LTS versions.
- "node": ">=20.x" + "node": ">=18.x"CODE_STYLE.md (2)
58-62
: Add language specifier to code blocksCode blocks should specify the language for proper syntax highlighting.
-``` +```jsx🧰 Tools
🪛 Markdownlint (0.37.0)
58-58: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
127-138
: Fix list indentationThe list indentation is inconsistent. Sub-items should be indented with 2 spaces.
`assets` - This houses all static assets used in the project - `css` - This houses all CSS files used in the project - `images` - This houses all images used in the project - `scss` - This houses all SCSS files used in the project - `components` - All Sass files for components - `content` - All Sass files for content - `forms` - All Sass files for forms - `_talawa.scss` - Partial Sass file for Talawa - `_utilities.scss` - Partial Sass file for utilities - `_variables.scss` - Partial Sass file for variables - `app.scss` - Main Sass file for the app🧰 Tools
🪛 Markdownlint (0.37.0)
128-128: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
129-129: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
130-130: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
131-131: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
132-132: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
133-133: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
134-134: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
135-135: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
136-136: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
137-137: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
🪛 LanguageTool
[style] ~127-~127: Consider removing “of” to be more concise
Context: ...tories ofsrc
assets
- This houses all of the static assets used in the project - `...(ALL_OF_THE)
[style] ~128-~128: Consider removing “of” to be more concise
Context: ... in the project -css
- This houses all of the css files used in the project - `imag...(ALL_OF_THE)
[style] ~129-~129: Consider removing “of” to be more concise
Context: ... the project -images
- This houses all of the images used in the project -scss
-...(ALL_OF_THE)
[style] ~130-~130: Consider removing “of” to be more concise
Context: ...in the project -scss
- This houses all of the scss files used in the project - `c...(ALL_OF_THE)
[grammar] ~134-~134: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ...rms -_talawa.scss
- Partial Sass file for Talawa -_utilities.scss
- Pa...(HE_VERB_AGR)
[grammar] ~135-~135: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... -_utilities.scss
- Partial Sass file for utilities -_variables.scss
-...(HE_VERB_AGR)
[grammar] ~136-~136: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... -_variables.scss
- Partial Sass file for variables -app.scss
- Main S...(HE_VERB_AGR)
CONTRIBUTING.md (3)
31-34
: Consider enhancing the Videos section description.While the links are valuable, consider adding a brief description of what contributors can expect to learn from each playlist.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~34-~34: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...)" videos are extremely helpful for new open source contributors. ## Ways to Contribute I...(EN_COMPOUND_ADJECTIVE_INTERNAL)
66-69
: Consider adding a visual representation of the branching strategy.A diagram showing the relationship between
develop
andmain
branches would help contributors better understand the workflow.🧰 Tools
🪛 LanguageTool
[uncategorized] ~68-~68: Loose punctuation mark.
Context: ...ushed to themain
branch: -develop
: For unstable code and bug fixing - `mai...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~69-~69: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...d bug fixing -main
: Where the stable production ready code lies. This is our default branch. ...(EN_COMPOUND_ADJECTIVE_INTERNAL)
102-162
: Fix code block formatting inconsistencies.Several code blocks are missing language specifiers. Add appropriate language identifiers to improve syntax highlighting.
Example:
-``` +```bash npm run test --watchAll=false --coverage🧰 Tools
🪛 Markdownlint (0.37.0)
104-104: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
113-113: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
128-128: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
139-139: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
143-143: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
158-158: null
No empty links(MD042, no-empty-links)
159-159: null
No empty links(MD042, no-empty-links)
161-161: null
No empty links(MD042, no-empty-links)
🪛 LanguageTool
[grammar] ~135-~135: The operating system from Apple is written “macOS”.
Context: ...r packages can be found for Windows and MacOS. 6. The currently acceptable c...(MAC_OS)
.github/workflows/pull-request.yml (2)
12-21
: Add workflow documentation comments.Consider adding comments to explain the purpose of the
CODECOV_UNIQUE_NAME
environment variable and why it's constructed this way.
404-413
: Consider making target branch name configurable.Instead of hard-coding 'develop-postgres', consider making it a repository variable or workflow input parameter for better flexibility.
INSTALLATION.md (2)
132-162
: Fix Docker section code block formatting.There are inconsistencies in the code block formatting:
- Remove extra backticks at line 150
- Remove duplicate language specifiers at lines 152 and 160
Apply these fixes:
-````bash +```bash docker build -t talawa-admin . -```bash
186-195
: Consider adding example values for environment variables.While the descriptions are clear, providing example values for each environment variable would make it easier for users to understand the expected format.
.github/ISSUE_TEMPLATE/bug-report.md (1)
33-36
: Fix markdown formatting issues.
- Use proper heading syntax instead of emphasis
- Format the URL properly using markdown link syntax
-**Potential internship candidates** +## Potential internship candidates Please read this if you are planning to apply for a Palisadoes Foundation internship -https://github.com/PalisadoesFoundation/talawa/issues/359 +[Internship Information](https://github.com/PalisadoesFoundation/talawa/issues/359)🧰 Tools
🪛 Markdownlint (0.37.0)
36-36: null
Bare URL used(MD034, no-bare-urls)
33-33: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
DOCUMENTATION.md (2)
22-25
: Fix grammatical and formatting issues in the Docusaurus instructions.There are several minor issues in this section that should be addressed.
-The process in easy: +The process is easy: 1. Install `talawa-docs` on your system 1. Launch docusaurus on your system according to the `talawa-docs`documentation. - - A local version of `docs.talawa.io` should automatically launched in your browser at http://localhost:3000/ + - A local version of `docs.talawa.io` should automatically launch in your browser at [http://localhost:3000](http://localhost:3000)🧰 Tools
🪛 Markdownlint (0.37.0)
25-25: null
Bare URL used(MD034, no-bare-urls)
🪛 LanguageTool
[grammar] ~25-~25: The modal verb ‘should’ requires the verb’s base form.
Context: ...fdocs.talawa.io
should automatically launched in your browser at http://localhost:300...(MD_BASEFORM)
28-29
: Fix typo in browser monitoring instructions.There's a minor typo in the word "browser".
-1. Always monitor the local website in your brower to make sure the changes are acceptable. +1. Always monitor the local website in your browser to make sure the changes are acceptable..github/workflows/README.md (4)
7-7
: Enhance clarity of the contribution warningThe warning about changes could be more specific about the review process.
-Any changes to files in this directory are flagged when pull requests are run. Make changes only on the advice of a contributor. +Any changes to workflow files are automatically flagged during pull request checks. Please consult with a project maintainer before modifying these files to ensure changes align with the project's CI/CD strategy.
24-24
: Fix typo in workflow description- 1. Place all actions related to to this in the `pull-request-target.yml` file. + 1. Place all actions related to this in the `pull-request-target.yml` file.🧰 Tools
🪛 LanguageTool
[duplication] ~24-~24: Possible typo: you repeated a word
Context: ...ors: 1. Place all actions related to to this in thepull-request-target.yml
f...(ENGLISH_WORD_REPEAT_RULE)
35-35
: Fix abbreviation format-1. Jobs only work correctly if they have a dedicated file (eg. `CodeQL`) +1. Jobs only work correctly if they have a dedicated file (e.g., `CodeQL`)🧰 Tools
🪛 LanguageTool
[uncategorized] ~35-~35: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...orrectly if they have a dedicated file (eg.CodeQL
) ## Scripts Follow these gui...(E_G)
41-47
: Enhance Python scripts guidelinesConsider adding:
- Minimum Python version requirement
- References to configuration files for each linting tool
- Example of the required
main()
function structureCODE_OF_CONDUCT.md (1)
5-19
: Consider automating table of contents generationThe manual TOC is well-structured, but consider using tools like
markdown-toc
to automatically generate and maintain it. This would ensure the TOC stays in sync with document changes.Example using
markdown-toc
:npx markdown-toc -i CODE_OF_CONDUCT.md🧰 Tools
🪛 LanguageTool
[duplication] ~11-~11: Possible typo: you repeated a word
Context: ...-responsibilities) - Scope - Enforcement - Enforcement Guidelines ...(ENGLISH_WORD_REPEAT_RULE)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (75)
package-lock.json
is excluded by!**/package-lock.json
public/favicon.ico
is excluded by!**/*.ico
public/favicon_palisadoes.ico
is excluded by!**/*.ico
public/images/logo512.png
is excluded by!**/*.png
public/images/svg/angleDown.svg
is excluded by!**/*.svg
public/images/svg/arrow-left.svg
is excluded by!**/*.svg
public/images/svg/arrow-right.svg
is excluded by!**/*.svg
public/images/svg/attendees.svg
is excluded by!**/*.svg
public/images/svg/feedback.svg
is excluded by!**/*.svg
public/images/svg/profiledefault.svg
is excluded by!**/*.svg
public/images/svg/up-down.svg
is excluded by!**/*.svg
public/logo192.png
is excluded by!**/*.png
public/markdown/images/install1.png
is excluded by!**/*.png
public/markdown/images/install2.png
is excluded by!**/*.png
src/assets/css/app.css.map
is excluded by!**/*.map
src/assets/images/blank.png
is excluded by!**/*.png
src/assets/images/bronze.png
is excluded by!**/*.png
src/assets/images/defaultImg.png
is excluded by!**/*.png
src/assets/images/gold.png
is excluded by!**/*.png
src/assets/images/palisadoes_logo.png
is excluded by!**/*.png
src/assets/images/silver.png
is excluded by!**/*.png
src/assets/images/talawa-logo-600x600.png
is excluded by!**/*.png
src/assets/images/talawa-logo-dark-200x200.png
is excluded by!**/*.png
src/assets/images/talawa-logo-lite-200x200.png
is excluded by!**/*.png
src/assets/svgs/Attendance.svg
is excluded by!**/*.svg
src/assets/svgs/actionItem.svg
is excluded by!**/*.svg
src/assets/svgs/admin.svg
is excluded by!**/*.svg
src/assets/svgs/agenda-category-icon.svg
is excluded by!**/*.svg
src/assets/svgs/agenda-items.svg
is excluded by!**/*.svg
src/assets/svgs/angleRight.svg
is excluded by!**/*.svg
src/assets/svgs/article.svg
is excluded by!**/*.svg
src/assets/svgs/blockUser.svg
is excluded by!**/*.svg
src/assets/svgs/blockedUser.svg
is excluded by!**/*.svg
src/assets/svgs/cardItemDate.svg
is excluded by!**/*.svg
src/assets/svgs/cardItemEvent.svg
is excluded by!**/*.svg
src/assets/svgs/cardItemLocation.svg
is excluded by!**/*.svg
src/assets/svgs/chat.svg
is excluded by!**/*.svg
src/assets/svgs/checkInRegistrants.svg
is excluded by!**/*.svg
src/assets/svgs/dashboard.svg
is excluded by!**/*.svg
src/assets/svgs/date.svg
is excluded by!**/*.svg
src/assets/svgs/event.svg
is excluded by!**/*.svg
src/assets/svgs/events.svg
is excluded by!**/*.svg
src/assets/svgs/flask.svg
is excluded by!**/*.svg
src/assets/svgs/funds.svg
is excluded by!**/*.svg
src/assets/svgs/key.svg
is excluded by!**/*.svg
src/assets/svgs/listEventRegistrants.svg
is excluded by!**/*.svg
src/assets/svgs/location.svg
is excluded by!**/*.svg
src/assets/svgs/logout.svg
is excluded by!**/*.svg
src/assets/svgs/media.svg
is excluded by!**/*.svg
src/assets/svgs/newChat.svg
is excluded by!**/*.svg
src/assets/svgs/organizations.svg
is excluded by!**/*.svg
src/assets/svgs/palisadoes.svg
is excluded by!**/*.svg
src/assets/svgs/people.svg
is excluded by!**/*.svg
src/assets/svgs/plugins.svg
is excluded by!**/*.svg
src/assets/svgs/post.svg
is excluded by!**/*.svg
src/assets/svgs/posts.svg
is excluded by!**/*.svg
src/assets/svgs/requests.svg
is excluded by!**/*.svg
src/assets/svgs/roles.svg
is excluded by!**/*.svg
src/assets/svgs/settings.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Facebook-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Github-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Instagram-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Linkedin-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Reddit-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Slack-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/X-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Youtube-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/tag.svg
is excluded by!**/*.svg
src/assets/svgs/tags.svg
is excluded by!**/*.svg
src/assets/svgs/talawa.svg
is excluded by!**/*.svg
src/assets/svgs/user.svg
is excluded by!**/*.svg
src/assets/svgs/userEvent.svg
is excluded by!**/*.svg
src/assets/svgs/users.svg
is excluded by!**/*.svg
src/assets/svgs/venues.svg
is excluded by!**/*.svg
src/assets/talawa-logo-lite-200x200.png
is excluded by!**/*.png
📒 Files selected for processing (82)
.coderabbit.yaml
(1 hunks).dockerignore
(1 hunks).env.example
(1 hunks).eslintignore
(1 hunks).eslintrc.json
(2 hunks).github/ISSUE_TEMPLATE/bug-report.md
(2 hunks).github/ISSUE_TEMPLATE/feature-request.md
(2 hunks).github/dependabot.yaml
(1 hunks).github/pull_request_template.md
(2 hunks).github/workflows/README.md
(1 hunks).github/workflows/auto-label.json5
(1 hunks).github/workflows/check-tsdoc.js
(1 hunks).github/workflows/ci.yml
(0 hunks).github/workflows/codeql-analysis.yml
(0 hunks).github/workflows/codeql-codescan.yml
(1 hunks).github/workflows/compare_translations.py
(1 hunks).github/workflows/countline.py
(1 hunks).github/workflows/eslint_disable_check.py
(1 hunks).github/workflows/issue.yml
(1 hunks).github/workflows/linter.yml
(0 hunks).github/workflows/npm-publish.yml
(0 hunks).github/workflows/pull-request-target.yml
(1 hunks).github/workflows/pull-request.yml
(1 hunks).github/workflows/push.yml
(1 hunks).github/workflows/stale.yml
(1 hunks).github/workflows/talawa_admin_md_mdx_format_adjuster.py
(1 hunks).gitignore
(2 hunks).husky/post-merge
(1 hunks).husky/pre-commit
(1 hunks).idea/.gitignore
(1 hunks).idea/inspectionProfiles/Project_Default.xml
(1 hunks).idea/modules.xml
(1 hunks).idea/talawa-admin.iml
(1 hunks).idea/vcs.xml
(1 hunks).lintstagedrc.json
(1 hunks).node-version
(1 hunks).prettierignore
(1 hunks).prettierrc
(1 hunks)CODEOWNERS
(1 hunks)CODE_OF_CONDUCT.md
(1 hunks)CODE_STYLE.md
(1 hunks)CONTRIBUTING.md
(2 hunks)DOCUMENTATION.md
(1 hunks)Docker_Container/.dockerignore
(0 hunks)Docker_Container/README.md
(0 hunks)Docker_Container/docker-compose.yml
(0 hunks)Docker_Container/dockerfile
(0 hunks)Dockerfile
(1 hunks)INSTALLATION.md
(1 hunks)ISSUE_GUIDELINES.md
(1 hunks)ISSUE_TEMPLATE.md
(0 hunks)PR-guidelines.md
(0 hunks)PR_GUIDELINES.md
(1 hunks)PULL_REQUEST_TEMPLATE.md
(0 hunks)README.md
(3 hunks)config/babel.config.cjs
(1 hunks)config/vite.config.ts
(1 hunks)index.html
(1 hunks)issue-guidelines.md
(0 hunks)jest-preview.config.ts
(1 hunks)jest.config.js
(1 hunks)package.json
(2 hunks)public/index.html
(0 hunks)public/locales/en/common.json
(1 hunks)public/locales/en/errors.json
(1 hunks)public/locales/en/translation.json
(1 hunks)public/locales/fr/common.json
(1 hunks)public/locales/fr/errors.json
(1 hunks)public/locales/fr/translation.json
(1 hunks)public/locales/hi/common.json
(1 hunks)public/locales/hi/errors.json
(1 hunks)public/locales/hi/translation.json
(1 hunks)public/locales/sp/common.json
(1 hunks)public/locales/sp/errors.json
(1 hunks)public/locales/sp/translation.json
(1 hunks)public/locales/zh/common.json
(1 hunks)public/locales/zh/errors.json
(1 hunks)public/locales/zh/translation.json
(1 hunks)public/manifest.json
(1 hunks)schema.graphql
(1 hunks)scripts/__mocks__/@dicebear/collection.ts
(1 hunks)scripts/__mocks__/@dicebear/core.ts
(1 hunks)
⛔ Files not processed due to max files limit (35)
- scripts/mocks/@pdfme/generator.test.ts
- scripts/mocks/@pdfme/generator.ts
- scripts/mocks/fileMock.js
- scripts/custom-test-env.js
- scripts/githooks/check-localstorage-usage.js
- scripts/githooks/update-toc.js
- setup.ts
- src/App.test.tsx
- src/App.tsx
- src/Constant/constant.spec.ts
- src/Constant/constant.ts
- src/GraphQl/Mutations/ActionItemCategoryMutations.ts
- src/GraphQl/Mutations/ActionItemMutations.ts
- src/GraphQl/Mutations/AgendaCategoryMutations.ts
- src/GraphQl/Mutations/AgendaItemMutations.ts
- src/GraphQl/Mutations/CampaignMutation.ts
- src/GraphQl/Mutations/CommentMutations.ts
- src/GraphQl/Mutations/EventAttendeeMutations.ts
- src/GraphQl/Mutations/EventVolunteerMutation.ts
- src/GraphQl/Mutations/FundMutation.ts
- src/GraphQl/Mutations/OrganizationMutations.ts
- src/GraphQl/Mutations/PledgeMutation.ts
- src/GraphQl/Mutations/TagMutations.ts
- src/GraphQl/Mutations/VenueMutations.ts
- src/GraphQl/Mutations/mutations.ts
- src/GraphQl/Queries/ActionItemCategoryQueries.ts
- src/GraphQl/Queries/ActionItemQueries.ts
- src/GraphQl/Queries/AgendaCategoryQueries.ts
- src/GraphQl/Queries/AgendaItemQueries.ts
- src/GraphQl/Queries/EventVolunteerQueries.ts
- src/GraphQl/Queries/OrganizationQueries.ts
- src/GraphQl/Queries/PlugInQueries.ts
- src/GraphQl/Queries/Queries.ts
- src/GraphQl/Queries/fundQueries.ts
- src/GraphQl/Queries/userTagQueries.ts
💤 Files with no reviewable changes (13)
- Docker_Container/.dockerignore
- .github/workflows/linter.yml
- PULL_REQUEST_TEMPLATE.md
- .github/workflows/ci.yml
- Docker_Container/docker-compose.yml
- Docker_Container/dockerfile
- Docker_Container/README.md
- public/index.html
- issue-guidelines.md
- PR-guidelines.md
- .github/workflows/npm-publish.yml
- ISSUE_TEMPLATE.md
- .github/workflows/codeql-analysis.yml
✅ Files skipped from review due to trivial changes (29)
- .node-version
- .prettierrc
- jest-preview.config.ts
- .idea/.gitignore
- .github/dependabot.yaml
- .eslintignore
- .idea/vcs.xml
- .idea/talawa-admin.iml
- config/babel.config.cjs
- .coderabbit.yaml
- .dockerignore
- .github/workflows/auto-label.json5
- .idea/modules.xml
- .prettierignore
- scripts/mocks/@dicebear/collection.ts
- CODEOWNERS
- public/locales/fr/translation.json
- public/locales/hi/common.json
- public/locales/zh/translation.json
- .env.example
- public/locales/en/translation.json
- public/locales/fr/errors.json
- index.html
- .idea/inspectionProfiles/Project_Default.xml
- .gitignore
- public/locales/hi/translation.json
- config/vite.config.ts
- public/locales/en/common.json
- public/locales/zh/common.json
🧰 Additional context used
🪛 yamllint (1.35.1)
.github/workflows/codeql-codescan.yml
[error] 6-6: trailing spaces
(trailing-spaces)
[error] 17-17: trailing spaces
(trailing-spaces)
[error] 20-20: trailing spaces
(trailing-spaces)
[warning] 31-31: wrong indentation: expected 6 but found 7
(indentation)
[warning] 37-37: wrong indentation: expected 11 but found 10
(indentation)
.github/workflows/pull-request-target.yml
[error] 6-6: trailing spaces
(trailing-spaces)
[error] 13-13: trailing spaces
(trailing-spaces)
[error] 15-15: trailing spaces
(trailing-spaces)
[error] 27-27: trailing spaces
(trailing-spaces)
[error] 28-28: trailing spaces
(trailing-spaces)
[error] 29-29: trailing spaces
(trailing-spaces)
[error] 33-33: trailing spaces
(trailing-spaces)
[error] 35-35: trailing spaces
(trailing-spaces)
[error] 40-40: trailing spaces
(trailing-spaces)
[error] 45-45: trailing spaces
(trailing-spaces)
[error] 70-70: trailing spaces
(trailing-spaces)
.github/workflows/stale.yml
[error] 6-6: trailing spaces
(trailing-spaces)
[error] 20-20: trailing spaces
(trailing-spaces)
[error] 21-21: trailing spaces
(trailing-spaces)
.github/workflows/push.yml
[error] 6-6: trailing spaces
(trailing-spaces)
[error] 17-17: trailing spaces
(trailing-spaces)
[error] 18-18: trailing spaces
(trailing-spaces)
[warning] 20-20: wrong indentation: expected 2 but found 4
(indentation)
[error] 21-21: trailing spaces
(trailing-spaces)
[error] 50-50: trailing spaces
(trailing-spaces)
[warning] 62-62: too many blank lines
(1 > 0) (empty-lines)
.github/workflows/issue.yml
[error] 6-6: trailing spaces
(trailing-spaces)
[warning] 15-15: wrong indentation: expected 4 but found 6
(indentation)
[warning] 66-66: too many blank lines
(1 > 0) (empty-lines)
.github/workflows/pull-request.yml
[error] 49-49: trailing spaces
(trailing-spaces)
[error] 60-60: trailing spaces
(trailing-spaces)
[error] 63-63: trailing spaces
(trailing-spaces)
[error] 92-92: trailing spaces
(trailing-spaces)
[error] 104-104: trailing spaces
(trailing-spaces)
[error] 134-134: trailing spaces
(trailing-spaces)
[error] 137-137: trailing spaces
(trailing-spaces)
[error] 158-158: trailing spaces
(trailing-spaces)
[error] 165-165: trailing spaces
(trailing-spaces)
[error] 205-205: trailing spaces
(trailing-spaces)
[error] 209-209: trailing spaces
(trailing-spaces)
[error] 231-231: trailing spaces
(trailing-spaces)
[error] 232-232: trailing spaces
(trailing-spaces)
[error] 271-271: trailing spaces
(trailing-spaces)
[error] 277-277: trailing spaces
(trailing-spaces)
[error] 279-279: trailing spaces
(trailing-spaces)
🪛 Markdownlint (0.37.0)
.github/pull_request_template.md
58-58: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
README.md
53-53: null
Multiple spaces after hash on atx style heading
(MD019, no-multiple-space-atx)
CODE_STYLE.md
128-128: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
129-129: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
130-130: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
131-131: Expected: 2; Actual: 4
Unordered list indentation
(MD007, ul-indent)
132-132: Expected: 2; Actual: 4
Unordered list indentation
(MD007, ul-indent)
133-133: Expected: 2; Actual: 4
Unordered list indentation
(MD007, ul-indent)
134-134: Expected: 2; Actual: 4
Unordered list indentation
(MD007, ul-indent)
135-135: Expected: 2; Actual: 4
Unordered list indentation
(MD007, ul-indent)
136-136: Expected: 2; Actual: 4
Unordered list indentation
(MD007, ul-indent)
137-137: Expected: 2; Actual: 4
Unordered list indentation
(MD007, ul-indent)
164-164: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
165-165: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
166-166: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
57-57: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
73-73: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
75-75: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
92-92: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
190-190: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
230-230: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
58-58: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
65-65: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
78-78: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
95-95: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
158-158: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
173-173: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
181-181: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
239-239: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
245-245: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
251-251: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
PR_GUIDELINES.md
31-31: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
39-39: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
.github/ISSUE_TEMPLATE/feature-request.md
28-28: null
Bare URL used
(MD034, no-bare-urls)
25-25: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
INSTALLATION.md
79-79: null
Dollar signs used before commands without showing output
(MD014, commands-show-output)
89-89: null
Bare URL used
(MD034, no-bare-urls)
208-208: null
Bare URL used
(MD034, no-bare-urls)
216-216: null
Bare URL used
(MD034, no-bare-urls)
224-224: null
Bare URL used
(MD034, no-bare-urls)
300-300: null
Bare URL used
(MD034, no-bare-urls)
308-308: null
Bare URL used
(MD034, no-bare-urls)
126-126: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
184-184: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
210-210: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
218-218: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
226-226: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
236-236: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
244-244: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
252-252: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
274-274: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
292-292: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
302-302: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
310-310: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
334-334: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
345-345: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
359-359: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
CONTRIBUTING.md
104-104: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
113-113: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
128-128: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
139-139: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
143-143: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
158-158: null
No empty links
(MD042, no-empty-links)
159-159: null
No empty links
(MD042, no-empty-links)
161-161: null
No empty links
(MD042, no-empty-links)
.github/ISSUE_TEMPLATE/bug-report.md
36-36: null
Bare URL used
(MD034, no-bare-urls)
33-33: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
DOCUMENTATION.md
25-25: null
Bare URL used
(MD034, no-bare-urls)
🪛 LanguageTool
ISSUE_GUIDELINES.md
[uncategorized] ~2-~2: Loose punctuation mark.
Context: # Issue Report Guidelines 👍🎉 First off, thanks for taking t...
(UNLIKELY_OPENING_PUNCTUATION)
[style] ~4-~4: Consider a shorter alternative to avoid wordiness.
Context: ...ing the time to contribute! 🎉👍 In order to give everyone a chance to submit a issu...
(IN_ORDER_TO_PREMIUM)
[misspelling] ~5-~5: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...der to give everyone a chance to submit a issues reports and contribute to the Ta...
(EN_A_VS_AN)
[typographical] ~24-~24: Consider adding a comma here.
Context: ...> ___ ## Issue Management In all cases please use the [GitHub open issue search](http...
(PLEASE_COMMA)
[style] ~30-~30: Consider using a different verb for a more formal wording.
Context: .... 1. Verify whether the issue has been fixed by trying to reproduce it using the lat...
(FIX_RESOLVE)
[uncategorized] ~32-~32: Possible missing preposition found.
Context: ...lawa-admin/issues/new/choose) button 1. Use the templates to create a standardized ...
(AI_HYDRA_LEO_MISSING_TO)
[style] ~35-~35: The wording of this phrase can be improved.
Context: ...lcome contributors who find new ways to make the code better. ### Existing Issues You can also be ...
(MAKE_STYLE_BETTER)
[grammar] ~44-~44: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...butors to assign it to you in #talawa
slack channel. Working on these types of exi...
(ON_SKYPE)
[grammar] ~53-~53: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...ew Issues 1. Join our #talawa-github
slack channel for automatic issue and pull re...
(ON_SKYPE)
[grammar] ~57-~57: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...lines 1. Discuss issues in our various slack channels when necessary 2. Please do no...
(ON_SKYPE)
[typographical] ~57-~57: Consider adding a comma here.
Context: ...ur various slack channels when necessary 2. Please do not derail or troll issues. 3. Keep...
(PLEASE_COMMA)
README.md
[uncategorized] ~56-~56: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...)" videos are extremely helpful for new open source contributors.
(EN_COMPOUND_ADJECTIVE_INTERNAL)
CODE_STYLE.md
[style] ~127-~127: Consider removing “of” to be more concise
Context: ...tories of src
assets
- This houses all of the static assets used in the project - `...
(ALL_OF_THE)
[style] ~128-~128: Consider removing “of” to be more concise
Context: ... in the project - css
- This houses all of the css files used in the project - `imag...
(ALL_OF_THE)
[style] ~129-~129: Consider removing “of” to be more concise
Context: ... the project - images
- This houses all of the images used in the project - scss
-...
(ALL_OF_THE)
[style] ~130-~130: Consider removing “of” to be more concise
Context: ...in the project - scss
- This houses all of the scss files used in the project - `c...
(ALL_OF_THE)
[grammar] ~134-~134: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ...rms - _talawa.scss
- Partial Sass file for Talawa - _utilities.scss
- Pa...
(HE_VERB_AGR)
[grammar] ~135-~135: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... - _utilities.scss
- Partial Sass file for utilities - _variables.scss
-...
(HE_VERB_AGR)
[grammar] ~136-~136: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... - _variables.scss
- Partial Sass file for variables - app.scss
- Main S...
(HE_VERB_AGR)
[style] ~141-~141: Consider removing “of” to be more concise
Context: ...views/screens Constant
- This houses all of the constants used in the project `GraphQl...
(ALL_OF_THE)
[style] ~143-~143: Consider removing “of” to be more concise
Context: ...in the project GraphQl
- This houses all of the GraphQL queries and mutations used in t...
(ALL_OF_THE)
[style] ~145-~145: Consider removing “of” to be more concise
Context: ...in the project screens
- This houses all of the views/screens to be navigated through i...
(ALL_OF_THE)
[style] ~147-~147: Consider removing “of” to be more concise
Context: ... in Talawa-Admin state
- This houses all of the state management code for the project ...
(ALL_OF_THE)
[uncategorized] ~165-~165: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...following order: - React imports - Third party imports - Local imports If there is...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
PR_GUIDELINES.md
[uncategorized] ~2-~2: Loose punctuation mark.
Context: # Pull Request Guidelines 👍🎉 First off, thanks for taking t...
(UNLIKELY_OPENING_PUNCTUATION)
[style] ~4-~4: Consider a shorter alternative to avoid wordiness.
Context: ...ing the time to contribute! 🎉👍 In order to give everyone a chance to submit a pull...
(IN_ORDER_TO_PREMIUM)
[style] ~46-~46: Style-wise, it’s not ideal to insert an adverb (‘manually’) in the middle of an infinitive construction (‘to test’). Try moving the adverb to avoid split infinitives.
Context: ..., you'll need to tell us what steps you followed to manually test your changes. 1. Please read our [CONTRIBUTING.md](C...
(SPLIT_INFINITIVE)
[style] ~56-~56: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...o be closed. The quality of our code is very important to us. Therefore we make experienced ma...
(EN_WEAK_ADJECTIVE)
[uncategorized] ~56-~56: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ...ty of our code is very important to us. Therefore we make experienced maintainers of our ...
(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
[style] ~59-~59: Consider using a different verb for a more formal wording.
Context: ...check if all tests are passing; if not, fix the issues and then create a pull reque...
(FIX_RESOLVE)
[style] ~64-~64: This expression is wordy and overused. Consider replacing it with a more concise and formal alternative.
Context: ...wer your questions, but we'll get to it sooner or later. @mentioning someone just adds to the p...
(SOONER_OR_LATER)
[uncategorized] ~64-~64: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...adds to the pile of notifications we get and it won't make us look at your issue fas...
(COMMA_COMPOUND_SENTENCE)
[style] ~65-~65: Consider shortening or rephrasing this to strengthen your wording.
Context: ...ue faster. 1. Do not force push. If you make changes to your pull request, please simply add a ...
(MAKE_CHANGES)
INSTALLATION.md
[typographical] ~39-~39: It appears that a comma is missing.
Context: ... that follow. # Prerequisites In this section we'll explain how to set up all the pre...
(DURING_THAT_TIME_COMMA)
[uncategorized] ~45-~45: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: .... Basic git
knowledge is required for open source contribution so make sure you're comfor...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
[uncategorized] ~48-~48: Possible missing comma found.
Context: ...ithub. ## Setting up this repository First you need a local copy of
talawa-admin`...
(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~51-~51: The word “setup” is a noun. The verb is spelled with a space.
Context: ...avigate to the folder where you want to setup the repository. 2. Open a cmd
(Window...
(NOUN_VERB_CONFUSION)
[grammar] ~52-~52: The operating system from Apple is written “macOS”.
Context: ...cmd
(Windows) or terminal
(Linux or MacOS) session in this folder. 1. An easy ...
(MAC_OS)
[uncategorized] ~53-~53: Possible missing article found.
Context: ...to do this is to right-click and choose appropriate option based on your OS. 3. **For Our O...
(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~54-~54: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...e option based on your OS. 3. For Our Open Source Contributor Software Developers: ...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
[grammar] ~86-~86: The operating system from Apple is written “macOS”.
Context: ...node.jspackages in Windows, Linux and MacOS. 1. For Windows: 1. first install
...
(MAC_OS)
[duplication] ~100-~100: Possible typo: you repeated a word
Context: ... 5. Save the document. 6. Exit notepad
7. Exit PowerShell 8. This will ensure...
(ENGLISH_WORD_REPEAT_RULE)
[grammar] ~103-~103: The operating system from Apple is written “macOS”.
Context: ...t version of node.js
2. For Linux and MacOS, use the terminal window. 1. install...
(MAC_OS)
[grammar] ~107-~107: The word “setup” is a noun. The verb is spelled with a white space.
Context: ... the respective recommended commands to setup your node environment 3. This wil...
(NOUN_VERB_CONFUSION)
[uncategorized] ~114-~114: Possible missing comma found.
Context: ...stall TypeScript, you can use the npm
command which comes with node.js
: ```bash np...
(AI_HYDRA_LEO_MISSING_COMMA)
CONTRIBUTING.md
[style] ~27-~27: This expression usually appears with a “please” in front of it.
Context: ...DUCT.md) to understand what this means. Let us know immediately if you have unacceptable ex...
(INSERT_PLEASE)
[uncategorized] ~34-~34: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...)" videos are extremely helpful for new open source contributors. ## Ways to Contribute I...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
[grammar] ~62-~62: A determiner may be missing.
Context: ...l Request guidelines](PR_GUIDELINES.md) is best resource to follow to start working on ...
(THE_SUPERLATIVE)
[uncategorized] ~68-~68: Loose punctuation mark.
Context: ...ushed to the main
branch: - develop
: For unstable code and bug fixing - `mai...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~69-~69: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...d bug fixing - main
: Where the stable production ready code lies. This is our default branch. ...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
[typographical] ~73-~73: Consider adding a comma.
Context: ...ultiple developers are working on issues there is bound to be a conflict of interest (...
(IF_THERE_COMMA)
[typographical] ~73-~73: Consider adding a comma after ‘Usually’ for more clarity.
Context: ...licts) among issues, PRs or even ideas. Usually these conflicts are resolved in a **Fir...
(RB_LY_COMMA)
[grammar] ~73-~73: Did you mean “served” (as in the idiom ‘first come, first served’)?
Context: ...ts are resolved in a First Come First Serve basis however there are certain excep...
(FIRST_SERVED)
[grammar] ~75-~75: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...tant to ask the author of the PR in the slack channel or in their PRs or issues thems...
(ON_SKYPE)
[style] ~77-~77: ‘Last but not the least’ might be wordy. Consider a shorter alternative.
Context: ...y and test that function when needed. - Last but not the least, communication is important make sure t...
(EN_WORDINESS_PREMIUM_LAST_BUT_NOT_THE_LEAST)
[grammar] ~77-~77: It seems that “to” is missing before the verb.
Context: ...t the least, communication is important make sure to talk to other contributors, in ...
(MISSING_TO_BETWEEN_BE_AND_VB)
[grammar] ~77-~77: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ... other contributors, in these cases, in slack channel or in a issue/PR thread. - As a...
(ON_SKYPE)
[misspelling] ~77-~77: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ... in these cases, in slack channel or in a issue/PR thread. - As a last resort the...
(EN_A_VS_AN)
[typographical] ~78-~78: It appears that a comma is missing.
Context: ...el or in a issue/PR thread. - As a last resort the Admins would be responsible for dec...
(DURING_THAT_TIME_COMMA)
[grammar] ~135-~135: The operating system from Apple is written “macOS”.
Context: ...r packages can be found for Windows and MacOS. 6. The currently acceptable c...
(MAC_OS)
[grammar] ~165-~165: The past participle is required after “must be”.
Context: ...branch_name>`.(Here branch name must be name of the branch you want to push the chan...
(BE_VBP_IN)
[grammar] ~178-~178: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...dation/talawa) for the link to join our slack channel. 1. We also have a technical em...
(ON_SKYPE)
.github/workflows/README.md
[duplication] ~24-~24: Possible typo: you repeated a word
Context: ...ors: 1. Place all actions related to to this in the pull-request-target.yml
f...
(ENGLISH_WORD_REPEAT_RULE)
[uncategorized] ~35-~35: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...orrectly if they have a dedicated file (eg. CodeQL
) ## Scripts Follow these gui...
(E_G)
CODE_OF_CONDUCT.md
[duplication] ~11-~11: Possible typo: you repeated a word
Context: ...-responsibilities) - Scope - Enforcement - Enforcement Guidelines ...
(ENGLISH_WORD_REPEAT_RULE)
DOCUMENTATION.md
[grammar] ~25-~25: The modal verb ‘should’ requires the verb’s base form.
Context: ...f docs.talawa.io
should automatically launched in your browser at http://localhost:300...
(MD_BASEFORM)
[grammar] ~26-~26: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...ttp://localhost:3000/ 1. Add/modify the markdown documents to the docs/
directory of t...
(MARKDOWN_NNP)
[uncategorized] ~32-~32: The preposition “to” seems more likely in this position.
Context: ... PLEASE do not add markdown files in this repository. Add them to `talawa-do...
(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)
🪛 eslint
jest.config.js
[error] 13-13: Insert ⏎··
(prettier/prettier)
🪛 Ruff (0.8.2)
.github/workflows/eslint_disable_check.py
61-61: Loop control variable dirs
not used within loop body
Rename unused dirs
to _dirs
(B007)
.github/workflows/compare_translations.py
135-135: Within an except
clause, raise exceptions with raise ... from err
or raise ... from None
to distinguish them from errors in exception handling
(B904)
🪛 actionlint (1.7.4)
.github/workflows/pull-request.yml
62-62: shellcheck reported issue in this script: SC2086:info:1:12: Double quote to prevent globbing and word splitting
(shellcheck)
79-79: "github.event.pull_request.head.ref" is potentially untrusted. avoid using it directly in inline scripts. instead, pass it through an environment variable. see https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions for more details
(expression)
381-381: shellcheck reported issue in this script: SC2086:info:3:35: Double quote to prevent globbing and word splitting
(shellcheck)
381-381: shellcheck reported issue in this script: SC2086:info:10:6: Double quote to prevent globbing and word splitting
(shellcheck)
🔇 Additional comments (7)
public/manifest.json (1)
16-16
: Verify logo path exists
The path has been updated to "images/logo512.png". Let's verify this path exists.
✅ Verification successful
Logo file path verification successful
The logo file exists at the specified path public/images/logo512.png
, confirming that the manifest.json reference is correct.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if the logo file exists in the new path
if [ -f "public/images/logo512.png" ]; then
echo "✅ Logo file exists at the new path"
else
echo "❌ Logo file not found at public/images/logo512.png"
echo "Searching for possible locations..."
fd "logo512.png" public/
fi
Length of output: 117
public/locales/zh/errors.json (1)
1-16
: Verify translation completeness and placeholder consistency
Let's verify that all error messages and placeholders are consistent across language files.
✅ Verification successful
Chinese translations are consistent with placeholder usage and keys
The verification shows that:
- All translation keys in the Chinese (zh) file match with other language files
- Placeholder usage ({{msg}} and {{entity}}) is consistent across all language files
- The translations maintain semantic equivalence while being culturally appropriate
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for missing translations and placeholder consistency
echo "Checking for translation files in other languages..."
for lang in en fr hi sp; do
if [ -f "public/locales/$lang/errors.json" ]; then
echo "Comparing $lang with zh translations..."
# Compare keys and placeholder usage
jq -r 'keys[]' "public/locales/$lang/errors.json" | sort > "/tmp/${lang}_keys.txt"
jq -r 'keys[]' "public/locales/zh/errors.json" | sort > "/tmp/zh_keys.txt"
diff "/tmp/${lang}_keys.txt" "/tmp/zh_keys.txt"
# Check placeholder consistency
echo "Checking placeholders in $lang..."
rg -o "{{[^}]+}}" "public/locales/$lang/errors.json"
fi
done
Length of output: 2142
Script:
#!/bin/bash
# Let's try a different approach to check translations and placeholders
# First, let's check if all language files exist and show their content
for lang in en fr hi sp zh; do
echo "=== Content of $lang/errors.json ==="
if [ -f "public/locales/$lang/errors.json" ]; then
cat "public/locales/$lang/errors.json"
else
echo "File not found"
fi
echo "==="
done
# Let's use grep with a different pattern to find placeholders
echo "=== Checking placeholders ==="
for lang in en fr hi sp zh; do
if [ -f "public/locales/$lang/errors.json" ]; then
echo "Placeholders in $lang:"
grep -o '{{[^}]*}}' "public/locales/$lang/errors.json" || true
fi
done
Length of output: 6214
public/locales/en/errors.json (1)
1-16
: Verify translation key consistency across language files
The error message keys and placeholders should be consistent across all language files (en, hi, fr, sp, zh).
✅ Verification successful
Translation keys and placeholders are consistent across all language files
The verification shows that:
- All language files (en, fr, hi, sp, zh) contain exactly the same set of translation keys
- The placeholders
{{msg}}
and{{entity}}
are consistently used across all translations for the corresponding error messages
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for consistency in translation keys across language files
# Find all error.json files
files=$(fd "errors.json" public/locales)
# Extract and compare keys from each file
for file in $files; do
echo "=== Keys in $file ==="
jq 'keys' "$file"
done
# Check for placeholder consistency
echo "=== Checking placeholder consistency ==="
for file in $files; do
echo "=== Placeholders in $file ==="
jq -r 'to_entries | .[] | select(.value | contains("{{")) | .value' "$file"
done
Length of output: 4487
public/locales/sp/errors.json (1)
9-10
: Verify template variable consistency
The error messages use the {{entity}}
template variable. Please ensure that all consuming components pass this variable correctly.
✅ Verification successful
Template variables are correctly used across all components
All components are properly passing the entity
variable to both errorLoading
and errorOccurredCouldntCreate
translation keys. The entities are meaningful and context-appropriate, such as 'Events', 'Volunteers', 'Action Items', 'Campaigns', etc. No inconsistencies were found in the usage of these error message templates.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for components using these error messages
rg -l "errorOccurredCouldntCreate|errorLoading" --type ts --type tsx
Length of output: 98
Script:
#!/bin/bash
# Search for components using these error messages with ripgrep, without file type filtering
rg -l "errorOccurredCouldntCreate|errorLoading"
Length of output: 1113
Script:
#!/bin/bash
# Let's check how these error messages are being used in components
rg "errorOccurredCouldntCreate|errorLoading" -A 2 -B 2 src/
Length of output: 8270
public/locales/fr/common.json (1)
1-98
: Verify translations with native French speakers
While the translations appear correct, it would be beneficial to have them reviewed by native French speakers to ensure natural language flow and cultural appropriateness.
CONTRIBUTING.md (1)
7-23
: Well-structured Table of Contents!
The ToC is properly implemented with clear navigation links to all major sections.
public/locales/sp/translation.json (1)
1-1485
: LGTM! The translations file is well-structured and comprehensive.
The Spanish translations are well-organized into logical sections and cover all UI elements. The JSON structure is valid and follows consistent formatting.
export const createAvatar = jest.fn(() => { | ||
return { | ||
toDataUri: jest.fn(() => 'mocked-data-uri'), | ||
}; | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update Jest mocking syntax to Vitest
The current implementation uses Jest-specific mocking syntax (jest.fn()
), but since we're migrating to Vitest, this needs to be updated.
Apply this diff to migrate to Vitest:
-export const createAvatar = jest.fn(() => {
+export const createAvatar = vi.fn(() => {
return {
- toDataUri: jest.fn(() => 'mocked-data-uri'),
+ toDataUri: vi.fn(() => 'mocked-data-uri'),
};
});
Additionally, ensure you add the following import at the top of the file:
import { vi } from 'vitest';
enum AdvertisementType { | ||
BANNER | ||
MENU | ||
POPUP | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate enum 'AdvertisementType'
The enum 'AdvertisementType' is declared twice. To avoid naming collisions and confusion, remove or merge one of them.
Possible removal of duplicate lines:
-# Second 'AdvertisementType' declaration at lines 554-558
-enum AdvertisementType {
- BANNER
- MENU
- POPUP
-}
Also applies to: 554-558
input AddressInput { | ||
city: String | ||
countryCode: String | ||
dependentLocality: String | ||
line1: String | ||
line2: String | ||
postalCode: String | ||
sortingCode: String | ||
state: String | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate 'AddressInput' definition
'AddressInput' is declared at lines 43-52 and again at lines 1212-1221, which can cause schema conflicts. Consolidate these into a single definition.
Also applies to: 1212-1221
enum EducationGrade { | ||
GRADE_1 | ||
GRADE_2 | ||
GRADE_3 | ||
GRADE_4 | ||
GRADE_5 | ||
GRADE_6 | ||
GRADE_7 | ||
GRADE_8 | ||
GRADE_9 | ||
GRADE_10 | ||
GRADE_11 | ||
GRADE_12 | ||
GRADUATE | ||
KG | ||
NO_GRADE | ||
PRE_KG | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate enum 'EducationGrade'
'EducationGrade' is defined twice, potentially causing conflicts. Remove the duplicate or merge any differences.
Also applies to: 1223-1240
enum EmploymentStatus { | ||
FULL_TIME | ||
PART_TIME | ||
UNEMPLOYED | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate enum 'EmploymentStatus'
The enum 'EmploymentStatus' appears twice. Ensure you only keep the correct, final version to avoid naming clashes.
Also applies to: 1242-1246
"plugin:jest/recommended", | ||
"plugin:prettier/recommended", | ||
"plugin:@typescript-eslint/recommended" | ||
"plugin:@typescript-eslint/recommended", | ||
"eslint-config-prettier", | ||
"prettier" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update test framework configuration
Since we're transitioning from Jest to Vitest, the ESLint configuration should be updated accordingly.
"extends": [
"plugin:react/recommended",
"eslint:recommended",
- "plugin:jest/recommended",
+ "plugin:vitest/recommended",
"plugin:prettier/recommended",
"plugin:@typescript-eslint/recommended",
"eslint-config-prettier",
"prettier"
],
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"plugin:jest/recommended", | |
"plugin:prettier/recommended", | |
"plugin:@typescript-eslint/recommended" | |
"plugin:@typescript-eslint/recommended", | |
"eslint-config-prettier", | |
"prettier" | |
"plugin:react/recommended", | |
"eslint:recommended", | |
"plugin:vitest/recommended", | |
"plugin:prettier/recommended", | |
"plugin:@typescript-eslint/recommended", | |
"eslint-config-prettier", | |
"prettier" |
"test:vitest": "vitest run", | ||
"test:vitest:watch": "vitest", | ||
"test:vitest:coverage": "vitest run --coverage", | ||
"test": "cross-env NODE_ENV=test jest --env=./scripts/custom-test-env.js --watchAll --coverage", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove redundant test configurations
The package.json contains both Jest and Vitest configurations. Since we're transitioning to Vitest, we should remove Jest-related configurations and dependencies.
- "test": "cross-env NODE_ENV=test jest --env=./scripts/custom-test-env.js --watchAll --coverage",
- "jest-preview": "jest-preview",
- "jest": "^27.4.5",
- "jest-localstorage-mock": "^2.4.19",
- "jest-location-mock": "^2.0.0",
- "jest-preview": "^0.3.1",
Also applies to: 150-151
"resolutions": { | ||
"@apollo/client": "^3.4.0-beta.19", | ||
"@types/react": "17.0.2", | ||
"@types/react-dom": "17.0.2", | ||
"graphql": "^16.5.0" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review version resolutions
The resolutions field contains outdated versions that might conflict with the main dependencies.
- "resolutions": {
- "@apollo/client": "^3.4.0-beta.19",
- "@types/react": "17.0.2",
- "@types/react-dom": "17.0.2",
- "graphql": "^16.5.0"
- },
run: npx eslint ${CHANGED_FILES} && python .github/workflows/eslint_disable_check.py | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix potential shell script injection vulnerability.
The current implementation is vulnerable to word splitting and globbing issues.
Apply this fix:
-run: npx eslint ${CHANGED_FILES} && python .github/workflows/eslint_disable_check.py
+run: npx eslint "${CHANGED_FILES}" && python .github/workflows/eslint_disable_check.py
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
run: npx eslint ${CHANGED_FILES} && python .github/workflows/eslint_disable_check.py | |
run: npx eslint "${CHANGED_FILES}" && python .github/workflows/eslint_disable_check.py | |
🧰 Tools
🪛 actionlint (1.7.4)
62-62: shellcheck reported issue in this script: SC2086:info:1:12: Double quote to prevent globbing and word splitting
(shellcheck)
🪛 yamllint (1.35.1)
[error] 63-63: trailing spaces
(trailing-spaces)
Add any other context or screenshots about the feature request here. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider rephrasing the additional details section.
The section seems to reference a "feature request" which is inconsistent with this being a bug report template.
-Add any other context or screenshots about the feature request here.
+Add any other context or screenshots about the bug report here.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Add any other context or screenshots about the feature request here. | |
Add any other context or screenshots about the bug report here. | |
This PR has too many submitted files that are out of scope of the original issue. Please ensure the following:
Closing |
What kind of change does this PR introduce?
refactoring
Issue Number: #2484
Fixes ##2484
Did you add tests for your changes?
Vitest test passed 👍:
Summary by CodeRabbit
Release Notes
New Features
.coderabbit.yaml
,.dockerignore
, and.env.example
.Documentation
INSTALLATION.md
,DOCUMENTATION.md
, andCODE_STYLE.md
to guide users on setup and coding standards.Bug Fixes
Chores
package.json
to reflect new dependencies and scripts.Style