-
-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored src/screen/PageNotFound component test from jest to vitest #2669
base: develop-postgres
Are you sure you want to change the base?
Refactored src/screen/PageNotFound component test from jest to vitest #2669
Conversation
WalkthroughThis pull request focuses on migrating test files from Jest to Vitest for two specific components: Changes
Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
🧰 Additional context used📓 Learnings (1)src/screens/UserPortal/Campaigns/Campaigns.spec.tsx (1)
🔇 Additional comments (5)src/screens/PageNotFound/PageNotFound.spec.tsx (1)
The import statement has been correctly updated to use Vitest's testing functions. The test structure remains compatible with Vitest without requiring additional changes. src/screens/UserPortal/Campaigns/Campaigns.spec.tsx (4)
The import statement correctly includes the necessary Vitest testing functions.
The mock implementations have been correctly updated to use Vitest's mocking API:
The
The mock cleanup operations have been correctly updated:
Also applies to: 156-156 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
|
Please fix the conflicting file |
Please fix the conflicting file which has been recently updated |
What kind of change does this PR introduce?
Refactoring
Issue Number:
#2568
Fixes #
Snapshots/Videos:
Summary
Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
Yes
Summary by CodeRabbit
PageNotFound
component with distinct cases for regular and admin users.Campaigns
test suite from Jest to Vitest, updating mock implementations and improving documentation.