-
-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format fix #2646
Closed
prathmesh703
wants to merge
36
commits into
PalisadoesFoundation:develop-postgres
from
prathmesh703:format-fix
Closed
Format fix #2646
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
65a766e
Updated branching strategy
DangaRanga 0a6d4d6
Removed duplicate entry
DangaRanga e16a3ad
Updated contributing.md
DangaRanga 653345e
Added extra markdown styling to contribute.md
DangaRanga 13180c2
Merge pull request #54 from DangaRanga/master
DangaRanga 07f4465
Bump dns-packet from 1.3.1 to 1.3.4
dependabot[bot] f9d7eae
Merge pull request #60 from PalisadoesFoundation/dependabot/npm_and_y…
palisadoes 1a57176
Update pull_request_template.md
palisadoes c4580fa
disabled CodeQL cron jobs and push actions (#72)
akshatgarg12 f71bc11
Merge Develop into Main (#1099)
noman2002 1fd4105
[#1123] Changes position and text of "All Organizations" button (#1124)
adi790uu 9ff2924
Revert "[#1123] Changes position and text of "All Organizations" butt…
noman2002 a320d35
Added Base branch check to main (#1515)
palisadoes 42633e2
Pre-GSoC 2024 - Stable (#1934)
palisadoes f6c6f03
Update README.md
palisadoes 423b990
Merge develop - 20240504 (#1956)
palisadoes 7befb35
Merge develop - 20240504 (#1957)
palisadoes a4d2a07
Bump follow-redirects from 1.15.5 to 1.15.6 (#1960)
dependabot[bot] 9b5d158
Bump tar from 6.1.15 to 6.2.1 (#1959)
dependabot[bot] 389ac01
Bump tj-actions/changed-files from 40 to 41 in /.github/workflows (#1…
dependabot[bot] d3d681f
Bump express from 4.18.2 to 4.19.2 (#1962)
dependabot[bot] 7091c76
Bump ejs from 3.1.9 to 3.1.10 (#1963)
dependabot[bot] bf9852d
coderabbit yaml file (#1991)
pranshugupta54 f661cc9
Updating the main branch to the latest develop code (#2020)
palisadoes 5010350
Latest Develop 20240724 (#2127)
palisadoes b991d54
Update README.md
palisadoes f358420
Update CONTRIBUTING.md
palisadoes 15c8753
Update CONTRIBUTING.md
palisadoes 30c1d18
Merge with Develop 20240924 (#2306)
palisadoes 6fbba6e
Bump tj-actions/changed-files from 40 to 41 in /.github/workflows (#2…
dependabot[bot] e828b78
Bump rollup from 4.21.3 to 4.22.5 (#2308)
dependabot[bot] d01b5d2
Merge with Develop 2024-1-14 (#2432)
palisadoes 1fe19c1
Update dependabot.yaml
palisadoes d2a4d73
Update pull-request-target.yml
palisadoes 3d1f1f0
Update pull-request-target.yml
palisadoes aaab8a2
format fix github workflow
prathmesh703 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json | ||
language: "en-US" | ||
early_access: false | ||
reviews: | ||
profile: "chill" | ||
request_changes_workflow: true | ||
high_level_summary: true | ||
poem: true | ||
review_status: true | ||
collapse_walkthrough: false | ||
auto_review: | ||
enabled: true | ||
drafts: false | ||
base_branches: | ||
- develop | ||
- main | ||
chat: | ||
auto_reply: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# 👋 Welcome, we're glad you're setting up an installation of Talawa-admin. Copy this | ||
# file to .env or set the variables in your local environment manually. | ||
|
||
|
||
# Custom port number for the talawa-admin development server to run on. Default is 4321. | ||
|
||
PORT=4321 | ||
|
||
# Run Talawa-api locally in your system, and put its url into the same. | ||
|
||
REACT_APP_TALAWA_URL= | ||
|
||
# Do you want to setup and use "I'm not a robot" Checkbox (Google Recaptcha)? | ||
# If no, leave blank, else write yes | ||
# Example: REACT_APP_USE_RECAPTCHA=yes | ||
|
||
REACT_APP_USE_RECAPTCHA= | ||
|
||
# If you are using Google Recaptcha, i.e., REACT_APP_USE_RECAPTCHA=yes, read the following steps | ||
# Get the google recaptcha site key from google recaptcha admin or https://www.google.com/recaptcha/admin/create | ||
# from here for reCAPTCHA v2 and "I'm not a robot" Checkbox, and paste the key here. | ||
# Note: In domains, fill localhost | ||
|
||
REACT_APP_RECAPTCHA_SITE_KEY= | ||
|
||
# has to be inserted in the env file to use plugins and other websocket based features. | ||
REACT_APP_BACKEND_WEBSOCKET_URL=ws://localhost:4000/graphql/ | ||
|
||
# If you want to logs Compiletime and Runtime error , warning and info write YES or if u want to | ||
# keep the console clean leave it blank | ||
ALLOW_LOGS= |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
# Contains the PDF file of the Tag as JSON string, thus does not need to be linted | ||
src/components/CheckIn/tagTemplate.ts |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# Configuration for automated dependency updates using Dependabot | ||
version: 2 | ||
updates: | ||
# Define the target package ecosystem | ||
- package-ecosystem: "npm" | ||
# Specify the root directory | ||
directory: "/" | ||
# Schedule automated updates to run weekly | ||
schedule: | ||
interval: "monthly" | ||
# Labels to apply to Dependabot PRs | ||
labels: | ||
- "dependencies" | ||
# Specify the target branch for PRs | ||
target-branch: "develop-postgres" | ||
# Customize commit message prefix | ||
commit-message: | ||
prefix: "chore(deps):" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
# Talawa GitHub Workflows Guidelines | ||
|
||
Follow these guidelines when contributing to this directory. | ||
|
||
## General | ||
|
||
Any changes to files in this directory are flagged when pull requests are run. Make changes only on the advice of a contributor. | ||
|
||
## YAML Workflow Files | ||
|
||
The YAML files in this directory have very specific roles depending on the type of workflow. | ||
|
||
Whenever possible you must ensure that: | ||
1. The file roles below are maintained | ||
1. The sequence of the jobs in the workflows are maintained using [GitHub Action dependencies](https://docs.github.com/en/actions/learn-github-actions/managing-complex-workflows). | ||
|
||
### File Roles | ||
Follow these guidelines when creating new YAML defined GitHub actions. This is done to make troubleshooting easier. | ||
|
||
1. `Issue` Workflows: | ||
1. Place all actions related to issues in the `issues.yml` file. | ||
1. `Pull Request` workflows to be run by: | ||
1. Workflows to run **First Time** repo contributors: | ||
1. Place all actions related to to this in the `pull-request-target.yml` file. | ||
prathmesh703 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
1. Workflows to be run by **ALL** repo contributors: | ||
1. Place all actions related to pull requests in the `pull-request.yml` file. | ||
1. `Push` workflows: | ||
1. Place all actions related to pushes in the `push.yml` file. | ||
|
||
#### File Role Exceptions | ||
|
||
There are some exceptions to these rules in which jobs can be placed in dedicated separate files: | ||
1. Jobs that require unique `cron:` schedules | ||
1. Jobs that require unique `paths:` statements that operate only when files in a specific path are updated. | ||
1. Jobs only work correctly if they have a dedicated file (eg. `CodeQL`) | ||
prathmesh703 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## Scripts | ||
|
||
Follow these guidelines when creating or modifying scripts in this directory. | ||
|
||
1. All scripts in this directory must be written in python3 for consistency. | ||
1. The python3 scripts must follow the following coding standards. Run these commands against your scripts before submitting PRs that modify or create python3 scripts in this directory. | ||
1. Pycodestyle | ||
1. Pydocstyle | ||
1. Pylint | ||
1. Flake8 | ||
1. All scripts must run a main() function. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"labelsSynonyms": { | ||
"dependencies": ["dependabot", "dependency", "dependencies"], | ||
"security": ["security"], | ||
"ui/ux": ["layout", "screen", "design", "figma"] | ||
}, | ||
"defaultLabels": ["unapproved"], | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Based on the results, I can now provide a final response:
Several files contain
any
types that would violate the new strict rulesThe codebase currently has multiple instances of
any
type usage that would violate the new@typescript-eslint/no-explicit-any
rule. Key locations:src/utils/useLocalstorage.ts
: Multipleany
types in function parameters and return typessrc/state/helpers/Action.ts
:any
type in payload definitionsrc/state/reducers/pluginReducer.ts
:any
type in state definitionsrc/state/action-creators/index.ts
: Multipleany
types in function parameterssrc/components/AddOn/*
: Several files usingany
for plugin-related typesThe new strict TypeScript rules would require proper type definitions for all these cases. Consider:
any
🔗 Analysis chain
Verify the impact of strict TypeScript rules
The new TypeScript rules are quite strict and might affect existing codebase. Particularly:
Let me try a different approach to verify the impact of these strict rules.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 486
Script:
Length of output: 31153