-
-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Origin/2503 #2598
Origin/2503 #2598
Changes from all commits
65a766e
0a6d4d6
e16a3ad
653345e
13180c2
07f4465
f9d7eae
1a57176
c4580fa
f71bc11
1fd4105
9ff2924
a320d35
42633e2
f6c6f03
423b990
7befb35
a4d2a07
9b5d158
389ac01
d3d681f
7091c76
bf9852d
f661cc9
5010350
b991d54
f358420
15c8753
30c1d18
6fbba6e
e828b78
d01b5d2
1fe19c1
d2a4d73
3d1f1f0
90b1d16
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json | ||
language: "en-US" | ||
early_access: false | ||
reviews: | ||
profile: "chill" | ||
request_changes_workflow: true | ||
high_level_summary: true | ||
poem: true | ||
review_status: true | ||
collapse_walkthrough: false | ||
auto_review: | ||
enabled: true | ||
drafts: false | ||
base_branches: | ||
- develop | ||
- main | ||
chat: | ||
auto_reply: true |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# 👋 Welcome, we're glad you're setting up an installation of Talawa-admin. Copy this | ||
# file to .env or set the variables in your local environment manually. | ||
|
||
|
||
# Custom port number for the talawa-admin development server to run on. Default is 4321. | ||
|
||
PORT=4321 | ||
|
||
# Run Talawa-api locally in your system, and put its url into the same. | ||
|
||
REACT_APP_TALAWA_URL= | ||
|
||
# Do you want to setup and use "I'm not a robot" Checkbox (Google Recaptcha)? | ||
# If no, leave blank, else write yes | ||
# Example: REACT_APP_USE_RECAPTCHA=yes | ||
|
||
REACT_APP_USE_RECAPTCHA= | ||
|
||
# If you are using Google Recaptcha, i.e., REACT_APP_USE_RECAPTCHA=yes, read the following steps | ||
# Get the google recaptcha site key from google recaptcha admin or https://www.google.com/recaptcha/admin/create | ||
# from here for reCAPTCHA v2 and "I'm not a robot" Checkbox, and paste the key here. | ||
# Note: In domains, fill localhost | ||
|
||
REACT_APP_RECAPTCHA_SITE_KEY= | ||
|
||
# has to be inserted in the env file to use plugins and other websocket based features. | ||
REACT_APP_BACKEND_WEBSOCKET_URL=ws://localhost:4000/graphql/ | ||
|
||
# If you want to logs Compiletime and Runtime error , warning and info write YES or if u want to | ||
# keep the console clean leave it blank | ||
ALLOW_LOGS= |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
# Contains the PDF file of the Tag as JSON string, thus does not need to be linted | ||
src/components/CheckIn/tagTemplate.ts |
Original file line number | Diff line number | Diff line change | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -1,9 +1,10 @@ | ||||||||||||||||||
--- | ||||||||||||||||||
name: Bug report | ||||||||||||||||||
name: Bug Report | ||||||||||||||||||
about: Create a report to help us improve. | ||||||||||||||||||
title: Bug report | ||||||||||||||||||
labels: Bug | ||||||||||||||||||
assignees: "" | ||||||||||||||||||
title: Bug Report | ||||||||||||||||||
labels: bug | ||||||||||||||||||
assignees: '' | ||||||||||||||||||
|
||||||||||||||||||
--- | ||||||||||||||||||
|
||||||||||||||||||
**Describe the bug** | ||||||||||||||||||
|
@@ -27,3 +28,9 @@ A clear and concise description of how the code performed w.r.t expectations. | |||||||||||||||||
If applicable, add screenshots to help explain your problem. | ||||||||||||||||||
|
||||||||||||||||||
**Additional details** | ||||||||||||||||||
Add any other context or screenshots about the feature request here. | ||||||||||||||||||
|
||||||||||||||||||
**Potential internship candidates** | ||||||||||||||||||
|
||||||||||||||||||
Please read this if you are planning to apply for a Palisadoes Foundation internship | ||||||||||||||||||
- https://github.com/PalisadoesFoundation/talawa/issues/359 | ||||||||||||||||||
Comment on lines
+33
to
+36
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Format section header and URL properly.
Apply these changes: -**Potential internship candidates**
+### Potential internship candidates
-Please read this if you are planning to apply for a Palisadoes Foundation internship
-https://github.com/PalisadoesFoundation/talawa/issues/359
+Please read this if you are planning to apply for a Palisadoes Foundation internship:
+[Internship Information](https://github.com/PalisadoesFoundation/talawa/issues/359) 📝 Committable suggestion
Suggested change
🧰 Tools🪛 Markdownlint (0.35.0)36-36: null (MD034, no-bare-urls) 33-33: null (MD036, no-emphasis-as-heading) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# Configuration for automated dependency updates using Dependabot | ||
version: 2 | ||
updates: | ||
# Define the target package ecosystem | ||
- package-ecosystem: "npm" | ||
# Specify the root directory | ||
directory: "/" | ||
# Schedule automated updates to run weekly | ||
schedule: | ||
interval: "monthly" | ||
# Labels to apply to Dependabot PRs | ||
labels: | ||
- "dependencies" | ||
# Specify the target branch for PRs | ||
target-branch: "develop-postgres" | ||
# Customize commit message prefix | ||
commit-message: | ||
prefix: "chore(deps):" |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,13 +1,40 @@ | ||||||
<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. --> | ||||||
<!-- | ||||||
This section can be deleted after reading. | ||||||
|
||||||
We employ the following branching strategy to simplify the development process and to ensure that only stable code is pushed to the `master` branch: | ||||||
|
||||||
- `develop`: For unstable code: New features and bug fixes. | ||||||
- `master`: Where the stable production ready code lies. Only security related bugs. | ||||||
|
||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix branch name inconsistency The template refers to -master`: Where the stable production ready code lies. Only security related bugs.
+main`: Where the stable production ready code lies. Only security related bugs. 📝 Committable suggestion
Suggested change
|
||||||
NOTE!!! | ||||||
|
||||||
ONLY SUBMIT PRS AGAINST OUR `DEVELOP` BRANCH. THE DEFAULT IS `MAIN`, SO YOU WILL HAVE TO MODIFY THIS BEFORE SUBMITTING YOUR PR FOR REVIEW. PRS MADE AGAINST `MAIN` WILL BE CLOSED. | ||||||
--> | ||||||
|
||||||
<!-- | ||||||
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. | ||||||
--> | ||||||
|
||||||
**What kind of change does this PR introduce?** | ||||||
|
||||||
<!-- E.g. a bugfix, feature, refactoring, etc… --> | ||||||
|
||||||
**Issue Number:** | ||||||
|
||||||
Fixes #<!--Add related issue number here.--> | ||||||
|
||||||
**Did you add tests for your changes?** | ||||||
|
||||||
<!--Yes or No. Note: Add unit tests or automation tests for your code.--> | ||||||
|
||||||
**Snapshots/Videos:** | ||||||
|
||||||
<!--Add snapshots or videos wherever possible.--> | ||||||
|
||||||
**If relevant, did you update the documentation?** | ||||||
|
||||||
<!--Add link to Talawa-Docs.--> | ||||||
|
||||||
**Summary** | ||||||
|
||||||
<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> | ||||||
|
@@ -18,3 +45,9 @@ | |||||
<!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. --> | ||||||
|
||||||
**Other information** | ||||||
|
||||||
<!--Add extra information about this PR here--> | ||||||
|
||||||
**Have you read the [contributing guide](https://github.com/PalisadoesFoundation/talawa-admin/blob/master/CONTRIBUTING.md)?** | ||||||
|
||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update documentation link to use main branch The contributing guide link should point to the main branch instead of master. -**Have you read the [contributing guide](https://github.com/PalisadoesFoundation/talawa-admin/blob/master/CONTRIBUTING.md)?**
+**Have you read the [contributing guide](https://github.com/PalisadoesFoundation/talawa-admin/blob/main/CONTRIBUTING.md)?** 📝 Committable suggestion
Suggested change
|
||||||
<!--Yes or No--> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
# Talawa GitHub Workflows Guidelines | ||
|
||
Follow these guidelines when contributing to this directory. | ||
|
||
## General | ||
|
||
Any changes to files in this directory are flagged when pull requests are run. Make changes only on the advice of a contributor. | ||
|
||
## YAML Workflow Files | ||
|
||
The YAML files in this directory have very specific roles depending on the type of workflow. | ||
|
||
Whenever possible you must ensure that: | ||
1. The file roles below are maintained | ||
1. The sequence of the jobs in the workflows are maintained using [GitHub Action dependencies](https://docs.github.com/en/actions/learn-github-actions/managing-complex-workflows). | ||
|
||
### File Roles | ||
Follow these guidelines when creating new YAML defined GitHub actions. This is done to make troubleshooting easier. | ||
|
||
1. `Issue` Workflows: | ||
1. Place all actions related to issues in the `issues.yml` file. | ||
1. `Pull Request` workflows to be run by: | ||
1. Workflows to run **First Time** repo contributors: | ||
1. Place all actions related to to this in the `pull-request-target.yml` file. | ||
1. Workflows to be run by **ALL** repo contributors: | ||
1. Place all actions related to pull requests in the `pull-request.yml` file. | ||
1. `Push` workflows: | ||
1. Place all actions related to pushes in the `push.yml` file. | ||
|
||
#### File Role Exceptions | ||
|
||
There are some exceptions to these rules in which jobs can be placed in dedicated separate files: | ||
1. Jobs that require unique `cron:` schedules | ||
1. Jobs that require unique `paths:` statements that operate only when files in a specific path are updated. | ||
1. Jobs only work correctly if they have a dedicated file (eg. `CodeQL`) | ||
|
||
## Scripts | ||
|
||
Follow these guidelines when creating or modifying scripts in this directory. | ||
|
||
1. All scripts in this directory must be written in python3 for consistency. | ||
1. The python3 scripts must follow the following coding standards. Run these commands against your scripts before submitting PRs that modify or create python3 scripts in this directory. | ||
1. Pycodestyle | ||
1. Pydocstyle | ||
1. Pylint | ||
1. Flake8 | ||
1. All scripts must run a main() function. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"labelsSynonyms": { | ||
"dependencies": ["dependabot", "dependency", "dependencies"], | ||
"security": ["security"], | ||
"ui/ux": ["layout", "screen", "design", "figma"] | ||
}, | ||
"defaultLabels": ["unapproved"], | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add React Hooks lint rules for better code quality
The configuration is missing essential React Hooks rules which help prevent common mistakes.
Add the React Hooks plugin and rules:
"plugins": [ "react", "@typescript-eslint", "jest", "import", "eslint-plugin-tsdoc", "prettier", + "react-hooks" ],
Also add the corresponding rules: