-
-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade package @testing-library/user-event from 12.8.3 to 13.5.0 #2468 #2471
Closed
mohamedrehan1
wants to merge
36
commits into
PalisadoesFoundation:develop-postgres
from
mohamedrehan1:main
Closed
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
65a766e
Updated branching strategy
DangaRanga 0a6d4d6
Removed duplicate entry
DangaRanga e16a3ad
Updated contributing.md
DangaRanga 653345e
Added extra markdown styling to contribute.md
DangaRanga 13180c2
Merge pull request #54 from DangaRanga/master
DangaRanga 07f4465
Bump dns-packet from 1.3.1 to 1.3.4
dependabot[bot] f9d7eae
Merge pull request #60 from PalisadoesFoundation/dependabot/npm_and_y…
palisadoes 1a57176
Update pull_request_template.md
palisadoes c4580fa
disabled CodeQL cron jobs and push actions (#72)
akshatgarg12 f71bc11
Merge Develop into Main (#1099)
noman2002 1fd4105
[#1123] Changes position and text of "All Organizations" button (#1124)
adi790uu 9ff2924
Revert "[#1123] Changes position and text of "All Organizations" butt…
noman2002 a320d35
Added Base branch check to main (#1515)
palisadoes 42633e2
Pre-GSoC 2024 - Stable (#1934)
palisadoes f6c6f03
Update README.md
palisadoes 423b990
Merge develop - 20240504 (#1956)
palisadoes 7befb35
Merge develop - 20240504 (#1957)
palisadoes a4d2a07
Bump follow-redirects from 1.15.5 to 1.15.6 (#1960)
dependabot[bot] 9b5d158
Bump tar from 6.1.15 to 6.2.1 (#1959)
dependabot[bot] 389ac01
Bump tj-actions/changed-files from 40 to 41 in /.github/workflows (#1…
dependabot[bot] d3d681f
Bump express from 4.18.2 to 4.19.2 (#1962)
dependabot[bot] 7091c76
Bump ejs from 3.1.9 to 3.1.10 (#1963)
dependabot[bot] bf9852d
coderabbit yaml file (#1991)
pranshugupta54 f661cc9
Updating the main branch to the latest develop code (#2020)
palisadoes 5010350
Latest Develop 20240724 (#2127)
palisadoes b991d54
Update README.md
palisadoes f358420
Update CONTRIBUTING.md
palisadoes 15c8753
Update CONTRIBUTING.md
palisadoes 30c1d18
Merge with Develop 20240924 (#2306)
palisadoes 6fbba6e
Bump tj-actions/changed-files from 40 to 41 in /.github/workflows (#2…
dependabot[bot] e828b78
Bump rollup from 4.21.3 to 4.22.5 (#2308)
dependabot[bot] d01b5d2
Merge with Develop 2024-1-14 (#2432)
palisadoes 1fe19c1
Update dependabot.yaml
palisadoes 9b9321d
Upgrade package @testing-library/user-event from 12.8.3 to 13.5.0
mohamedrehan1 d62dc3d
Merge branch 'develop-postgres' of https://github.com/PalisadoesFound…
mohamedrehan1 0dceb82
Upgrade package @testing-library/user-event from 12.8.3 to 13.5.0
mohamedrehan1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider using userEvent instead of fireEvent
The change from
userEvent
tofireEvent
seems to contradict the PR's objective of upgrading@testing-library/user-event
.userEvent
is recommended overfireEvent
as it more accurately simulates real user interactions by:Consider this implementation instead:
Note: With
@testing-library/user-event
v13+, we need to use the new setup() API and await the interactions.