Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated User and Admin portal with file uploads (GSoC 24) #2408

Closed
wants to merge 7 commits into from
Closed

Updated User and Admin portal with file uploads (GSoC 24) #2408

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f1c4de8
feat: updated UI and integrated new APIs for file upload and manageme…
chandel-aman Nov 2, 2024
709aa57
Merge branch 'develop' of https://github.com/chandel-aman/talawa-admi…
chandel-aman Nov 3, 2024
32e79d6
tests: improved the tests for OrgPostCard, Posts, and modified the mo…
chandel-aman Nov 4, 2024
15025c6
Merge branch 'develop' of https://github.com/chandel-aman/talawa-admi…
chandel-aman Nov 4, 2024
e4fa134
Update pre-commit
chandel-aman Nov 4, 2024
48f54a7
fix: lint fixes
chandel-aman Nov 4, 2024
3e71c6e
fix: lint
chandel-aman Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions .env.example
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
. "$(dirname -- "$0")/_/husky.sh"

# npm run format:fix
# npm run lint:fix
npm run lint:fix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Remove redundant lint:fix command from pre-commit hook

The lint:fix command is redundant as lint-staged already includes ESLint fixing for TypeScript files:

  • lint:fix runs: eslint --fix "**/*.{ts,tsx}"
  • lint-staged runs: eslint --fix on **/*.{ts, tsx, json}

The lint-staged configuration is more comprehensive as it:

  • Handles the same file types as lint:fix
  • Additionally includes JSON files
  • Also runs Prettier formatting
  • Only processes staged files instead of all files
🔗 Analysis chain

Consider potential redundancy with lint-staged.

The addition of npm run lint:fix before lint-staged might be redundant as lint-staged typically handles linting of staged files. Consider verifying if both commands are necessary or if they serve different purposes.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check the configuration of lint-staged and lint:fix to understand their scope
# Expected: Different configurations or purposes for each command

echo "Checking package.json for lint:fix and lint-staged configurations:"
cat package.json | jq '.scripts["lint:fix"], ."lint-staged"'

Length of output: 350

npm run lint-staged
npm run typecheck
npm run update:toc
Expand Down
Loading
Loading