Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Configurable Session timeout for Community (#2186). This rever… #2344

Conversation

JordanCampbell1
Copy link
Contributor

@JordanCampbell1 JordanCampbell1 commented Oct 20, 2024

…ts commit 025bc1d.In addition, adjusted to include my feature of session timeout as well

What kind of change does this PR introduce?

fixing a mistake I did where I did not include the following in my last PR: #2231

Issue Number:

#2231

Summary by CodeRabbit

  • New Features

    • Enhanced localization support with new translations for English, French, Hindi, Spanish, and Chinese.
    • Added new key-value pairs for various terms in localization files, improving user interface clarity.
    • Introduced new modal components for managing action item categories and actions, including creation and deletion functionalities.
  • Bug Fixes

    • Improved error handling and messaging in various components, ensuring better user feedback during interactions.
  • Documentation

    • Updated test cases to reflect changes in component structure and functionality, ensuring comprehensive coverage.
  • Chores

    • Cleaned up and optimized code across multiple components, enhancing maintainability and readability.

…on#2186). This reverts commit 025bc1d.In addition, adjusted to include my feature of session timeout as well
Copy link
Contributor

coderabbitai bot commented Oct 20, 2024

Caution

Review failed

The head commit changed during the review from b877f02 to f0e07e1.

Walkthrough

This pull request introduces extensive modifications across multiple localization files, enhancing the application's internationalization capabilities. New key-value pairs are added to JSON files for English, French, Hindi, Spanish, and Chinese locales, improving the breadth of translations for various user interface elements. Additionally, several existing entries are updated for grammatical accuracy and consistency. The changes also include the removal and restructuring of several React components and their associated tests, particularly those related to action items, thereby streamlining the codebase and improving the organization of the application.

Changes

File Path Change Summary
public/locales/en/common.json Added new localization entries and modified existing ones for consistency.
public/locales/en/translation.json Updated strings for grammatical correctness and added new entries for clarity.
public/locales/fr/common.json Added new localization entries and modified existing ones for consistency.
public/locales/fr/translation.json Updated strings for clarity and consistency, added new entries.
public/locales/hi/common.json Added new localization entries.
public/locales/hi/translation.json Updated strings for clarity and consistency.
public/locales/sp/common.json Added new localization entries and modified existing ones for consistency.
public/locales/sp/translation.json Removed certain strings, updated others for clarity and consistency.
public/locales/zh/common.json Added new localization entries.
public/locales/zh/translation.json Modified entries for clarity and consistency.
src/App.tsx Removed route for OrganizationAgendaCategory and cleaned up import statements.
src/GraphQl/Mutations/ActionItemCategoryMutations.ts Added isDisabled parameter to mutations for creating and updating action item categories.
src/GraphQl/Mutations/ActionItemMutations.ts Added allotedHours parameter to mutations for creating and updating action items.
src/GraphQl/Queries/ActionItemCategoryQueries.ts Updated query to accept additional parameters for filtering and ordering.
src/GraphQl/Queries/ActionItemQueries.ts Removed and added parameters for improved filtering of action items.
src/components/ActionItems/ActionItemsContainer.module.css Removed several CSS classes related to action item styling.
src/components/ActionItems/ActionItemsContainer.test.tsx Deleted test suite for the ActionItemsContainer component.
src/components/ActionItems/ActionItemsContainer.tsx Deleted the component responsible for managing action items.
src/components/ActionItems/ActionItemsContainerMocks.ts Deleted mock data for action items.
src/components/ActionItems/ActionItemsContainerProps.ts Deleted TypeScript types related to action items.
src/components/ActionItems/ActionItemsModal.test.tsx Deleted test suite for the ActionItemsModal component.
src/components/ActionItems/ActionItemsModal.tsx Deleted the modal component for managing action items.
src/components/ActionItems/ActionItemsModalBody.tsx Deleted the body component for the action items modal.
src/components/ActionItems/ActionItemsWrapper.module.css Removed styling related to action items.
src/components/ActionItems/ActionItemsWrapper.test.tsx Deleted test suite for the ActionItemsWrapper component.
src/components/ActionItems/ActionItemsWrapper.tsx Deleted the wrapper component for action items.
src/components/AgendaCategory/AgendaCategoryContainer.tsx Refactored import paths for modal components.
src/screens/OrganizationActionItems/ActionItemCreateModal.tsx Deleted the modal component for creating action items.
src/screens/OrganizationActionItems/ActionItemDeleteModal.tsx Deleted the modal component for deleting action items.
src/screens/OrganizationActionItems/ActionItemPreviewModal.tsx Deleted the modal component for previewing action items.
src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx Deleted the modal component for updating action items.
src/screens/OrganizationActionItems/ItemDeleteModal.tsx Introduced a new modal component for confirming deletion of action items.
src/screens/OrganizationActionItems/ItemModal.tsx Introduced a new modal component for managing action items.
src/screens/OrganizationActionItems/ItemUpdateStatusModal.tsx Introduced a new modal component for updating action item statuses.
src/screens/OrganizationActionItems/ItemViewModal.tsx Introduced a new modal component for displaying action item details.
src/screens/OrganizationActionItems/OrganizationActionItems.tsx Major restructuring for managing action items, including state management and rendering logic.
src/screens/OrganizationActionItems/OrganizationActionItem.mocks.ts Introduced mock data for action items and related queries.
src/screens/OrgSettings/OrgSettings.module.css Added new CSS class for header buttons.
src/screens/OrgSettings/OrgSettings.tsx Introduced a new component for managing organization settings.
src/screens/OrgSettings/OrgSettings.test.tsx Updated test suite structure and improved clarity of test cases.

Possibly related PRs

  • Agenda category CRUD operations #2030: This PR is related as it introduces new translations in the localization files for agenda categories, which aligns with the changes made in the main PR that enhances localization capabilities by adding new key-value pairs in the common.json file.
  • Configurable Session timeout for Community #2186: This PR is relevant because it includes updates to the translation.json files, adding new entries and modifying existing ones, which is similar to the changes in the main PR that also involves updates to localization files.
  • session management feature for merge #2314: This PR is connected as it focuses on session management features, which may involve user interface elements that require localization updates, similar to the enhancements made in the main PR regarding localization strings.

Suggested reviewers

  • palisadoes
  • aashimawadhwa

Poem

🐇 In the land of code where rabbits play,
New words and phrases come out to stay.
With every string, our app takes flight,
Localization makes everything right!
So hop along, let’s celebrate,
For every change, we’ll elevate! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@JordanCampbell1
Copy link
Contributor Author

@DMills27 just did the fix, could you please check it out, sorry for the inconvenience of this whole scenario. I would think this should be the last of it.

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.58%. Comparing base (7496bb3) to head (f0e07e1).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2344      +/-   ##
===========================================
- Coverage    97.62%   97.58%   -0.04%     
===========================================
  Files          250      244       -6     
  Lines         7188     7010     -178     
  Branches      2069     2037      -32     
===========================================
- Hits          7017     6841     -176     
+ Misses         159      157       -2     
  Partials        12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tasneemkoushar tasneemkoushar merged commit a2b0167 into PalisadoesFoundation:develop Oct 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants