-
-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert Configurable Session timeout for Community (#2186). This rever… #2344
Revert Configurable Session timeout for Community (#2186). This rever… #2344
Conversation
WalkthroughThis pull request introduces extensive modifications across multiple localization files, enhancing the application's internationalization capabilities. New key-value pairs are added to JSON files for English, French, Hindi, Spanish, and Chinese locales, improving the breadth of translations for various user interface elements. Additionally, several existing entries are updated for grammatical accuracy and consistency. The changes also include the removal and restructuring of several React components and their associated tests, particularly those related to action items, thereby streamlining the codebase and improving the organization of the application. Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
@DMills27 just did the fix, could you please check it out, sorry for the inconvenience of this whole scenario. I would think this should be the last of it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2344 +/- ##
===========================================
- Coverage 97.62% 97.58% -0.04%
===========================================
Files 250 244 -6
Lines 7188 7010 -178
Branches 2069 2037 -32
===========================================
- Hits 7017 6841 -176
+ Misses 159 157 -2
Partials 12 12 ☔ View full report in Codecov by Sentry. |
a2b0167
into
PalisadoesFoundation:develop
…ts commit 025bc1d.In addition, adjusted to include my feature of session timeout as well
What kind of change does this PR introduce?
fixing a mistake I did where I did not include the following in my last PR: #2231
Issue Number:
#2231
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores