-
-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated eslint-plugin-jest to v28.6.0 #2221
Updated eslint-plugin-jest to v28.6.0 #2221
Conversation
Updated CONTRIBUTING.md with new branching strategy
Bumps [dns-packet](https://github.com/mafintosh/dns-packet) from 1.3.1 to 1.3.4. - [Release notes](https://github.com/mafintosh/dns-packet/releases) - [Changelog](https://github.com/mafintosh/dns-packet/blob/master/CHANGELOG.md) - [Commits](mafintosh/dns-packet@v1.3.1...v1.3.4) Signed-off-by: dependabot[bot] <[email protected]>
…arn/dns-packet-1.3.4 Bump dns-packet from 1.3.1 to 1.3.4
* Update authorized-changes-detection.yml * Code Coverage @ 87.1% * Update .gitignore * Delete codecov This executable should not be in the repo * added translation hint text in placeholders (#487) * Update pull-requests.yml * Create DOCUMENTATION.md * Rename issue-guidelines.md to ISSUE_GUIDELINES.md * Update CONTRIBUTING.md * Update issue.yml * Rename PR-guidelines.md to PR_GUIDELINES.md * Update CONTRIBUTING.md * Update pull-request-target.yml * Delete PULL_REQUEST_TEMPLATE.md * Delete ISSUE_TEMPLATE.md * Rename Code_Style.md to CODE_STYLE.md * added removeMember mutation (#491) * added removeMember mutation * changed mutation name * remove contributions from router (#502) * Fixed Settings page Header (#501) * fixed cani-use lite warning * fixed the alignments for smaller screens and also added spacing on places where it was needed * fixed the linting errors * ran prettier to remove styling errors * made the orgSetting title dynamic * linted the code and made the settings header as required and also made the settings page navbar responsive * linted code and made necessary changes * errors fixed * Added dropdown for Applanguage in UserUpdation form (#498) * Added dropdown for Applanguage in UserUpdation form * App language code changed to Default language * Change the Scalar Types [Provides relevant client side changes for #1085 in Talawa-API] (#500) * Change typedefs * Fix date parsing * Move ID to ObjectID scalar * Client changes for Adding GraphQL Scalars (#511) * Change typedefs * Fix date parsing * Move ID to ObjectID scalar * Revert ObjectID to ID * Change ObjectID to ID * modal closed after organization creation (#516) * most recently added Org displays at the top (#515) * Add Husky (#520) * updated contributing (#521) * Display and choose Organisation image (#512) * upload image working for createOrganisation * Organisation image showing everywhere * Testcase failure fixed * Linting fixed * convertToBase64 func made and tests for it * CI/CD error fixed * tests added for AdminNavbar & OrganisationDashboard * Linting fixed * fixed translation on the plugin tab (#510) * added OrgName to the Navbar (#525) * Fix create event mutation [Fixes part of #1101 in Talawa-API] (#523) * Add format fix * Fix updation of posts * Test coverage improved for organizationPeople.tsx (#526) * Update INSTALLATION.md * Update INSTALLATION.md * Update INSTALLATION.md * Update stale.yml * Remove tags (#532) * Fixed navbar added tests (#534) * Fixed navbar added tests * Fixed the translation of All orgnaizations btn in AdminNavbar * Fix the updateOrg page, and made it to create mutation request [Fixes #531] (#536) * fix orgUpdate system * fix translations * Update CONTRIBUTING.md * Code Coverage @ 88% * Fixes #478 : Implemeneted calendar to the Event tab (#537) * calendar-implemented * calendar-implemented * fixed tests * Added post-merge hook using husky (#541) * Added post-merge hook using husky * made required changes to installation.md * make changes to documentation for husky * made the required changes in installation guide * Update pull-requests.yml * Fixed yarn installation instructions (#584) * organization sorting for all organization (#619) * removed redundant notification (#577) * Profile Page for Members (#543) * Initial member page made * Changed query added Org and Events section * Homescreen ready * initial translation added for Profile * initial translation added for Profile * Added translations * Added translations * Revised translation * Fixed failing tests for components * Link added to OrgAdminListCard * Linting fixed for OrgPeopleListCard * Added tests, removed logs * Uniform design * Fix:routing issue for orgdash page (#580) * Fix:routing issue for orgdash page * fix:failing test of SuperDashListCard * Rectify Warnings: EventListCard.test.tsx (#595) * Added logic to close modal after successful submission (#623) * Feature Request: Position of the search bar. (#631) * Feature Request: Position of the search bar #614 resolved * Feature Request: Position of the search bar #614 resolved * fixes: #550 added test for the calendar (#552) * added test for the calendar * updates mocks * Update Router Function [Fixes #636] (#638) * Update Router Function * Empty commit * Fix about content overflow (#632) Signed-off-by: Ekene Nwobodo <[email protected]> * removed duplicate rows per page section in orgposts (#648) * fixed :made card in organization dashboard interactive (#620) * Implemented manage functionality for admin and super admin after login (#539) * Implememnted manage functinality for admin/superadmin after login * Update AdminDashListCard.module.css * Some formatting issues with module file * resolved workflow issues * Added folding feature to posts (#581) * added folding feature to posts * added fold feature to posts * brought code under code coverage * added tests * added tests for remainging uncovered lines * brought code coverage to 100% for the changes * Code coverage @87.2% * Fix User Update Details Page and Add Update Password Page [Fixes #530] (#657) * fixed updateuser logic * update translations * fix lint * lint fix 2 * fix tests * fixed:move orgLocation & remove duplicate orgName (#655) * fixed:move orgLocation & remove duplicate orgName * Dummy commit * fixes - [#597] - Navbar navlinks hover and button styles (#603) * fixed: #585 - Password error showing. Tested * fix: #590 - fixed navbar hover issues * fix: #590 - fixed navbar hover issues * Code Coverage 87.4% * fixes 599 (#653) * fixed errors and removed window.replace * written test case for ensure window.location.replace * written test case for ensure window.location.replace * added useHistory to keep track of routing behind the scenes * fixed merge conflicts and errors * updated comments for file changes * Added warning comments for routing --------- Co-authored-by: Adepeju <adepeju.kayode@gmail> * fix org search location (#682) Signed-off-by: Ekene Nwobodo <[email protected]> * fixed the issue of validate the input before submit #674 (#678) * Adds required tests for OrganizationEvents.tsx and Fixes a minor bug in Calendar (#527) * adds tests for organization events * removes the unrequired branch from OrganizationEvents.tsx * fixes failing tests * fixes failing lint tests * Update password preview feature with coverage tests (#629) * Fix to the issue #585 (#607) * [fix]- fixed the password error warning * [fix]- fixed the password error warning * [fix]- fixed the password error warning * [fix]-fixed the password error warning * [fix]-fixed the password error warning * [fix]-fixed the password error warning * [fix]-fixed the password error warning * [feat]-added test cases for password error warning * [feat]- added test cases for password error warning * [feat]- added test cases for password error warning * [fix]- fixed the linting * Improve test coverage for calendar.tsx (#679) * Improve test coverage for calendar.tsx * Restore previous tests * remove --coverage * i rebased my codebase and resolved the initial issue (#669) * fixed the issue use of toast in place of window.alert #645 (#687) * Update ISSUE_GUIDELINES.md * fixed the static time data under Organization card in the Organization List tab (#689) * fixed the static time in org card * formatted the date to MM D, YYYY --------- Co-authored-by: thesaaddevloper <[email protected]> * Fixed the pagination alignment issue (#702) * [fix]- fixed the password error warning * [fix]- fixed the password error warning * [fix]- fixed the password error warning * [fix]-fixed the password error warning * [fix]-fixed the password error warning * [fix]-fixed the password error warning * [fix]-fixed the password error warning * [feat]-added test cases for password error warning * [feat]- added test cases for password error warning * [feat]- added test cases for password error warning * [fix]- fixed the linting * [fix]- fixed the pagination alignment issue * [fix]- fixed the pagination alignment issue * [fix]- fixed the pagination alignment issue * Removed overlapping (#675) * changes input element to textarea and changes in test (#710) * Code Coverage @90.7% * Indicating active tabs (#691) * added underline to active links in navbar * fixed lint error * fixed the org default image #688 and removed stock image (#695) * fixed the org default image #688 and removed stock image * removed eslint warning * added new img as default org img * Update INSTALLATION.md * Added Clear Error and Warn Messages when API is unavailable (#670) * Added error and warn messages * Added tests & fixed inconsistency in mocks * Lint fix LoginPage * Lint Fix LoginPage.test * minor fix * Minor update to LoginPage * Minor change to LoginPage.test * Replaced toast.warn() with toast.error() * Fixed test accordingly * Lint Fix * Minor fix * Extra edge case handled * code coverage fix * Lint fix * Update LoginPage * Update LoginPage.test * Lint fix * improve test coverage for orgpost.tsx (#718) * Improve test coverage for calendar.tsx * Restore previous tests * remove --coverage * improve test for orgpost.tsx * Implemented Proper Error Handling for all Screens [Fixes: #535] (#731) * Handled error cases for all screens * Some more fixes * Some more fixes * Added StaticMockLink to use Mocks multiple times [Fixes Multiple Issues] (#745) * add StaticMockLink * lint fix * remove showWarning * Added prompt to Register on Login Page (#628) * Add prompt to Login page - Add prompt in other languages: fr, sp, hi, zh. - switch styling of Login Button with Reg Button * format with prettier * fixed event checkboxes to update (#707) * Block/Unblock functionality for only members of the organization (#690) * Implememnted manage functinality for admin/superadmin after login * Update AdminDashListCard.module.css * Some formatting issues with module file * resolved workflow issues * Updated block/unblock page preventing users who are not members of organiztion * Update BlockUser.test.tsx to resolve failing tests Modified the mocks fields according to the corresponding changes in BlockUser.tsx file. * created a reusable postNotFound Component with responsive UI (#717) * created a reusable postNotFound Component with responsive UI * run test error solved * added translation to the component and also created the test.tsx for the error component * fixed the failing test and added the postNotFound reusable component for OrgList --------- Co-authored-by: thesaaddevloper <[email protected]> * fix: #601 modal responsive width (#621) * added dynamic title to OrgPeople section (#704) * added dynamic title to OrgPeople section * fixed code coverage * fixed code coverage * uncommented the mistakenly added code * Delete er * Updated session timeout notification toast with already existing one (#734) * Added a toast to notify users that session has expired and redirects to the login page * Updated toast notification on session timeout with already existing one * eliminated the use of magic numbers * minor error correction on the timeout minutes --------- Co-authored-by: TheoCathy <[email protected]> * Fixed the empty space in the OrgList (#751) * created a reusable postNotFound Component with responsive UI * run test error solved * added translation to the component and also created the test.tsx for the error component * fixed the failing test and added the postNotFound reusable component for OrgList * fixed the empty space in orgList * fixed the failing test * removed the unwanted files --------- Co-authored-by: thesaaddevloper <[email protected]> * align navbar items (#755) * align navbar items * replace More with a hamburger icon * replace More with a hamburger icon to fix workflow error * replace More with a hamburger icon to fix workflow error * Fixes: toggle password for registration (#758) * added toggle-password * updated * formatting * added icon for toggle password * Super Admin Dashboard Error When Organizations Absent (#754) * No Organization Warning on OrgList * Minor Fix * Fixed failing tests * Added Warning on Roles and Request Pages * Added Tests for OrgList * Testing Fixes * Added more tests * Added Tests for Roles and Request Pages * Code Coverage @ 91.0% * Add link to dashboard admin card (#760) * image upload made functional (#677) * image upload made functional * lint * fixed failing test * linting * re run test , remove yarn.lock changes * updateUser test cov * OrgPost * rerun tests * Empty commit * reverted last 2 commits changes * re run code cov * update userUpdate * rerun code cov again * revert last commit * Update PR_GUIDELINES.md * Implemented Search bar and the radio buttons in orgPost page that searches both title and text of post (#770) * created a reusable postNotFound Component with responsive UI * run test error solved * added translation to the component and also created the test.tsx for the error component * fixed the failing test and added the postNotFound reusable component for OrgList * fixed the empty space in orgList * fixed the failing test * removed the unwanted files * the one search bar which searches both text and title of post * testing file * orpost file testing * code coverage is increased * fixed the failing test --------- Co-authored-by: thesaaddevloper <[email protected]> Co-authored-by: saadabban76 <�[email protected]> * center org image on mobile (#778) Signed-off-by: Ekene Nwobodo <[email protected]> * removed link for plugin dropdown toggle (#781) * removed link for plugin dropdown toggle * added id * align superadmin nav items and fix failed tests (#766) * changed the handleSearchByName function in searchByName in Roles page (#735) * changed the handleSearchByName function to search using target's value instead of searchByName variable * updated the file Roles.tsx to take care of useState lag * changed tests for suiting searchByName * changed tests for searchByName including backspaces * added tests for paginationList and changing rowsPerPage * added tests to increase coverage in Roles.tsx * changed the package.json file's test command * removed extra scrollbars (#800) * Recently added Post displays at top (#773) * Recently added Post displays at top * reversed the posts as required in the query * Increased the OrgList Code Coverage (#786) * increased the orgList coverage to 95$ * increased the orgList Code Coverage * increased the orgList Code Coverage * increased the orgList Code Coverage * fixed image rendering in orgPost page * increased the code coverage for orgList Component * increased code coverage to 97% in orgList Component --------- Co-authored-by: saadabban76 <�[email protected]> * Modify event visibility for non-admins (#796) * Modify event visibility for non-admins Signed-off-by: Ekene Nwobodo <[email protected]> * Add test suites for events visibilty --------- Signed-off-by: Ekene Nwobodo <[email protected]> * Bug Fix: Drawer menu visibility (#794) * Remove filter by event field (#807) * increased the orgList coverage to 95$ * increased the orgList Code Coverage * increased the orgList Code Coverage * increased the orgList Code Coverage * fixed image rendering in orgPost page * increased the code coverage for orgList Component * increased code coverage to 97% in orgList Component * removed the filter by event section in orgPeople's component * fixed the failing test --------- Co-authored-by: saadabban76 <�[email protected]> * Add image to post (#804) * increased the orgList coverage to 95$ * increased the orgList Code Coverage * increased the orgList Code Coverage * increased the orgList Code Coverage * fixed image rendering in orgPost page * increased the code coverage for orgList Component * increased code coverage to 97% in orgList Component * added Image to the post's card * replaced external links with codebase default image * replaced external links with codebase default image * replaced blank image with the default image * fixed the failing test --------- Co-authored-by: saadabban76 <�[email protected]> * Update pull-request-target.yml * Update pull-request-target.yml * Update pull-request-target.yml * Update pull-request-target.yml * Update pull-request-target.yml * Update pull-request-target.yml * Upgrade Yarn to NPM in Talawa Admin Project (#802) * npm upgrade * remove package lock * Update push.yml * empty * upgrade yarn to npm * fix docs * fix scripts * empty * stop watch mode * fix ymls * empty * fix scripts * empty commit * update scripts * Redirect to dashboard on organization update (#816) * Redirect to dashboard on organization update * Minor Change * Proper Testing Of Pagination In All List Views (#797) * install faker package used for mocks in tests * Test init for pagination * install dependencies needed to implement certain tests * add a data-testid attribute to their markup for use in tests * add data-testid attributes to its markup being referenced from tests * add test to ensure the number of organization displayed on the page corresponds to the option selected from rowsPerPage * add prop to allow rendering of component in test environment * add data-testid attributes to their markup being referenced from tests * add data-testid attributes to its markup being referenced from tests * add test to affirm that the number of persons displayed on the webpage is same with the selected option from rowsPerPage * install dependencies for certain tests * fix lint errors * tests fix * remove unnecessary dependencies * lint fix * tests fix update * restore file to previous state * empty commit * tests fix update * lint fix * Conditional Usage of Google reCAPTCHA [Fixes #798] (#820) * conditonal recaptcha * Update INSTALLATION.md * add tests * fixed the issue of Mismatched passwords validation #722 (#824) * fixed the issue of Mismatched passwords validation #722 * fixed lint code error * Code Coverage @ 92% * Replace Talawa Portal with Talawa Admin Portal #817 (#821) * Update website title to Talawa Admin Portal in en * Update website title in fr json file * Update website title in sp json file * Update website title in zh json file * Update website title in hi json file * Update the test in ListNavbar file * Update the test in LoginPage.test file * Create a function for the tex macher to make test * Fix lint errors in the LandingPage test file * Remove console.log in LandingPage test file * Upgrade to use npm instead of yarn * Delete yarn.lock file * Fix lint errors * Fix lint errors * Update the heading in hi.json file * Remove unused codes * Fix lint error in LanfingPage file * Correct the talawa_portal value in Fr json file * Correct the talawa_portal value in sp json file * Remove anused package in package.json file * Organization Form Redirect Issue Prevents User Navigation, Affecting User Experience. Issue #808 (#815) * addressing issue #808 * finished - requested changes * addressing warning * Added: event preview modal to view event details (#772) * added event preview model * added event preview model * fixed formatting * added test * added test * added test * failing tests * test * tests * Update workflow (#832) * Workflow fix (#833) * Update pull-requests.yml * Update pull-requests.yml * Update pull-requests.yml * Code Coverage @ 91.0% * Feature: Separation of ADMIN and SUPERADMIN functionalities (#826) * Initial changes * Commit to sync repo * Made changes to OrgList * Some fixes * Minor fix * Added tests for OrgList * Added tests for OrgList * Coverage fix * Required changes added * Made changes to OrgList * Some fix * Some fixes * fixes test for OrgList * Some more fixes * Empty commit * Lint fix * Fixed test * Lint fix * Added Whitespace Validation to Organization and Post create forms (#838) * Added whitespace check in Org Create form * Added Tests * Added Empty String check to OrgPost Form * Added Tests for OrgPost * fixed the issue of Toast msg is not available in all languages #740 (#845) * fixed the issue of Toast msg is not available in all languages #740 * format issue * Empty-Commit * Fixed Org Update (#843) * Prevent Admins and Super Admins from downgrading their own roles (#840) * Code Cleanup * Disabled Super Admins from changing their roles * Added Tests * Added more tests * Improved Code Quality * Revert "Fixed Org Update (#843)" (#847) This reverts commit 53c3fef28ef986d63b1eec45663acb7d07cf1b8d. * Fixed Organization Update and Translation (#849) * Fixed Organization Update * Minor Changes * Success message updated * Fail tests on warning [Priority Needed] (#856) * fix warnings Signed-off-by: Ansh Goyal <[email protected]> * fix warnings Signed-off-by: Ansh Goyal <[email protected]> * fix warnings Signed-off-by: Ansh Goyal <[email protected]> * fix warnings Signed-off-by: Ansh Goyal <[email protected]> * fix warnings Signed-off-by: Ansh Goyal <[email protected]> * restore addonregister Signed-off-by: Ansh Goyal <[email protected]> --------- Signed-off-by: Ansh Goyal <[email protected]> * Code duplicacy removed (#852) * Code duplicacy removed * Tests added * Added comments * Fixed failing tests * Code formatted * Unused packages removed, flag icons package updated to latest version (#860) * Unused packages removed, flag icons updated to latest version * Empty commit * Changes in package-lock.json * Fixes #848: limiting mulitple toast (#851) * limiting-toast * added test * Organization People Filters Improved (#855) * Added Filters to Users and Organizations Query * Added Last Name Filter on User, Member and Admin * Added Translation * Fixed Failing Tests * Added Tests for Filters * Fixed Failing Tests * Code Cleanup * Fixed Tests * Added Translation * remove graphql-boost dep (#866) Signed-off-by: Ansh Goyal <[email protected]> * added UserNotFound component to the Roles page and improved the search (#865) * changed the handleSearchByName function to search using target's value instead of searchByName variable * updated the file Roles.tsx to take care of useState lag * changed tests for suiting searchByName * changed tests for searchByName including backspaces * added tests for paginationList and changing rowsPerPage * added tests to increase coverage in Roles.tsx * changed the package.json file's test command * changed PostNotFound component to be used as a reusable one and added it in Roles section and set languages option in locales folder * changed formatting in locales changed files * removed comments in Roles.tsx * Empty commit * renamed the PostNotFound component and modifiied relevant files * changed Roles.tsx filtering * empty commit * reverted changes in package.json * Improved signupform validations (#828) * Improved signupform validations * updated signup form validation to show all messages at once * improved test coverage for LoginPage * Fixed failing test --------- Co-authored-by: Joyce Malicha <[email protected]> * added tests for Search Bar in the Organization List Page of SUPERADMIN #827 (#867) * added tests for Search Bar in the Organization List Page of SUPERADMIN #827 * added tests for Search Bar in the Organization List Page of SUPERADMIN #827 * Added Tests Previews (#868) * Installed jest-preview * Automatic Setup * Fiixed Failing Test Command * Added Basic CSS * Added PostCSS Module * Fixed MUI Styling * Minor Changes * Added cross-env to support windows * Adaptar for React 17 and CSS Modules Mock * Added Mocked Styles to Tests * Documentatin Updated * Fixed Failing Tests * Minorr change in documentation * Jest is now Dev Dependency * Workflow Test * Jest Module Path Updates * Module Path Tese 2 * Github Workflow Fixed * Removed Legacy Test Command * Added Documentation to Debug Tests * Fixed Documentation * Docs Image Added To Repo * Images Reorganization * Organized Images * Revert "Improved signupform validations (#828)" (#875) This reverts commit 5820dd9ec05256551b48470c8880fcdc05452fda. * Restored SearchBar Test for OrgList Page (#878) * Restored searchBar test * Lint fix * Coverage fix * Lint fix * Some fixes * Some fixes * fixed the issue of Users filter to fetch corresponding Users to Organisation #701 (#853) * fixed the issue of Users filter to fetch corresponding Users to Organisation #701 * removedd uunused variable * fixed failing text * fixed merged issue * fixed lint error * swap variable * Revert "Restored SearchBar Test for OrgList Page (#878)" (#879) This reverts commit 3d39c524d54e81853490d2d8a1f844ce67252365. * Fixed crashing on error in Block/Unblock page (#862) * Website crash fixed * lint fixed * Added tests for empty response from server * More tests added * Rerun tests empty commit * Redirect on error functioning * Fixed failing tests * Testcase and Title added when users not found * Linting fixed * Typo fixed * Fixed failing tests * Linting fixed * Added NotFound component in OrgPeople and changed Roles.tsx (#882) * changed the handleSearchByName function to search using target's value instead of searchByName variable * updated the file Roles.tsx to take care of useState lag * changed tests for suiting searchByName * changed tests for searchByName including backspaces * added tests for paginationList and changing rowsPerPage * added tests to increase coverage in Roles.tsx * changed the package.json file's test command * changed PostNotFound component to be used as a reusable one and added it in Roles section and set languages option in locales folder * changed formatting in locales changed files * removed comments in Roles.tsx * Empty commit * renamed the PostNotFound component and modifiied relevant files * changed Roles.tsx filtering * empty commit * reverted changes in package.json * added NotFound component in OrgPeople, made changes in the locales files and made some changes to Roles too * added NotFound component to OrgPeople, changerd locales files and changed Roles.tsx * minor change * Restored Search-Bar Test for OrgList Page (#880) * Restored searchBar test * Lint fix * Coverage fix * Lint fix * Some fixes * Some fixes * Fixed Org Dashboard Error (#873) * Fixed TypeError * Minor Change * Fixed Tests * Added back logo512 * Fixed auth header getting copied on login (#890) * fix user update (#876) * fix user detials update * remove userType from update-user page * fix failed test for userUpdate.test.tsx * Removed and Replaced Ant Design from the project (#891) * Fixed auth header getting copied on login * Removed/Replaced Ant Design from the project * Fixed failing tests * Removed comment * Add today functionality in calendar (#897) * Update countline.py * Update pull-requests.yml * Updated countlines.py to cover .spec. files (#900) Co-authored-by: Peter Harrison <[email protected]> * fixed the Inability to set user roles for specific organizations #556 (#898) * fixed the Inability to set user roles for specific organizations #556 * added all language translation * Revert "fixed the Inability to set user roles for specific organizations #556 (#898)" (#901) This reverts commit 891d898eb5543116bb9042a6386b5a12e474159c. * Documentation updated, Redundant css files removed (#896) * Doc updated unused files removed * Removed unused css files from setup tests * Added small calendar in the events #887 (#903) * added small clanedar * added small clanedar * fixed Code Coverage: Create tests for OrgSettings.tsx #396 (#905) * remove redundancy from orgPostCard (#906) * Revert "remove redundancy from orgPostCard (#906)" (#910) This reverts commit d5ce4aa27ee241b0687f7db3d6acd1b62339562f. * Block/Unblock Page Improvements (#885) * Added Radio Buttons * Optimized Queries * Optimized Query and Added Last Name Filter * Radio Button Working * Added Translations * Fixed Filter Name * Fixed Debounce * Fixed Asynchronous Debounce * Added Tests * Better Error and Loading State Handline * Fixed Loader * Fixed Loader * Modulrised Mock Data * Minor Change * Fixed Tests * Increase Coverage * User query replaced with OrgMemberConnection * Fixed Tests * Code Coverage Increase * Code Cov * Fixed Translations * Fixed Failing Tests * fix in failing test (#913) * Improve and Standardize Automated Linting Tests (#916) * added linting rules * added linting rules * added linting rules * Rename `data` variables to more readable name [Fixes #829] (#835) * Refactor screens * Update components * Fix test * Fix typecheck errors * Increase test coverage * Merge latest adminUI-Redesign into Develop (#927) * Updated CODE_STYLE.md * Updated CODE_STYLE.md (#917) * Updated CODE_STYLE.md * Import section update * Upgrade and Migrate from Bootstrap 4 to Bootstrap 5 (#925) * Updated CODE_STYLE.md * Latest Boostrap v5.3.0 & react-bootstrap v2.7.4 installed * Buttons replaced from normal ones to Bootstrap ones * Import section update * Error fixed for Buttons * Language dropdowns and Change language * InputBoxes & Checkboxes fixed and imported from BS * Removed unused package popper.js * Replaced react-modal with Bootstrap one in Login Page * Modals converted to React Bootstrap one * Completely replaced react-modal with react-bootstrap/Modal from the project * Removed react-modal from the project * Removed classbased modal and unused images * Notification navbar migrated * Modal migration * Modal migration * Modal migration done for OrgPostCard * Empty commit to make workflow run * Empty commit to make workflow run * Empty commit to run the workflow --------- Co-authored-by: Anwer Sayeed <[email protected]> * Introduces API versioning check in CI/CD (#924) * a random change * husky precommit * one more try * one more try * one more try * one more try * one more try * one more try * second try * removed unwanted deps * removed unwanted deps * resolved the error * updated variable name * rerun test * rerun test * added test to pull.yml * removed push check * resolved conflict * Update stale.yml * Update CONTRIBUTING.md * Merge talawa-user-portal into develop (#935) * Create login and register page for user portal * Lint public locales * Create tests for login page components * Add react import in tests * Create organizations screen for user portal * Fix failing tests and lint code * fix failing tests * Add tests for organization screen and componenets * Fix non-null assertions * Fix non-null assertions in organizations test * Fix bootstrap migration changes * Merge latest Admin UI Redesign into Develop (#934) * Updated CODE_STYLE.md * Updated CODE_STYLE.md (#917) * Updated CODE_STYLE.md * Import section update * Upgrade and Migrate from Bootstrap 4 to Bootstrap 5 (#925) * Updated CODE_STYLE.md * Latest Boostrap v5.3.0 & react-bootstrap v2.7.4 installed * Buttons replaced from normal ones to Bootstrap ones * Import section update * Error fixed for Buttons * Language dropdowns and Change language * InputBoxes & Checkboxes fixed and imported from BS * Removed unused package popper.js * Replaced react-modal with Bootstrap one in Login Page * Modals converted to React Bootstrap one * Completely replaced react-modal with react-bootstrap/Modal from the project * Removed react-modal from the project * Removed classbased modal and unused images * Notification navbar migrated * Modal migration * Modal migration * Modal migration done for OrgPostCard * Empty commit to make workflow run * Empty commit to make workflow run * Empty commit to run the workflow * Sass filed added with documentation * Linting fixed * Fixed the folder structure and naming convention * Customised Bootstrap (#929) * Sass filed added with documentation * Linting fixed * Fixed the folder structure and naming convention * Assets typo fixed * Typo fix * Merge conflict error fixed --------- Co-authored-by: Anwer Sayeed <[email protected]> * test PR for API versioning check (#932) * testPR * test2 * testing the change * testing it again * test--no-verify * test--no-verify * echo token * test-again * test-again * test * test * read-only * clone * clone * redesigned newsfeed (#939) * Revert "redesigned newsfeed (#939)" (#943) This reverts commit a645eca7cf2ce1335374f48b52335a293e344580. * Make Talawa-Admin mutations in sync with the backend (#946) * Initial change * Redundant Notification removed * Fixed linting and other issues * Tests fixed * Add Home Screen And People Screen along with other components (#940) * Create login and register page for user portal * Lint public locales * Create tests for login page components * Add react import in tests * Create organizations screen for user portal * Fix failing tests and lint code * fix failing tests * Add tests for organization screen and componenets * Fix non-null assertions * Fix non-null assertions in organizations test * Fix bootstrap migration changes * Add Home Screen along with other components * Fix failing tests * Add required tests and Offcanvas navbar * Remove unused variables from tests * Sync the Mutations with talawa-api * Merge AdminUI-Redesign into Develop (#947) * Updated CODE_STYLE.md * Updated CODE_STYLE.md (#917) * Updated CODE_STYLE.md * Import section update * Upgrade and Migrate from Bootstrap 4 to Bootstrap 5 (#925) * Updated CODE_STYLE.md * Latest Boostrap v5.3.0 & react-bootstrap v2.7.4 installed * Buttons replaced from normal ones to Bootstrap ones * Import section update * Error fixed for Buttons * Language dropdowns and Change language * InputBoxes & Checkboxes fixed and imported from BS * Removed unused package popper.js * Replaced react-modal with Bootstrap one in Login Page * Modals converted to React Bootstrap one * Completely replaced react-modal with react-bootstrap/Modal from the project * Removed react-modal from the project * Removed classbased modal and unused images * Notification navbar migrated * Modal migration * Modal migration * Modal migration done for OrgPostCard * Empty commit to make workflow run * Empty commit to make workflow run * Empty commit to run the workflow * Sass filed added with documentation * Linting fixed * Fixed the folder structure and naming convention * Customised Bootstrap (#929) * Sass filed added with documentation * Linting fixed * Fixed the folder structure and naming convention * Assets typo fixed * Typo fix * Initial login page work * Merge conflict error fixed * Theming modified and Added Loader over every screen * Fixed UI issue for navbar and login * Fixed production bug * Removed unused variable * Tests fixed * Added Change Language Btn dropdown * Merge conflict fixed, merge latest develop into adminUI-redesign (#938) * Merge latest adminUI-Redesign into Develop (#927) * Updated CODE_STYLE.md * Updated CODE_STYLE.md (#917) * Updated CODE_STYLE.md * Import section update * Upgrade and Migrate from Bootstrap 4 to Bootstrap 5 (#925) * Updated CODE_STYLE.md * Latest Boostrap v5.3.0 & react-bootstrap v2.7.4 installed * Buttons replaced from normal ones to Bootstrap ones * Import section update * Error fixed for Buttons * Language dropdowns and Change language * InputBoxes & Checkboxes fixed and imported from BS * Removed unused package popper.js * Replaced react-modal with Bootstrap one in Login Page * Modals converted to React Bootstrap one * Completely replaced react-modal with react-bootstrap/Modal from the project * Removed react-modal from the project * Removed classbased modal and unused images * Notification navbar migrated * Modal migration * Modal migration * Modal migration done for OrgPostCard * Empty commit to make workflow run * Empty commit to make workflow run * Empty commit to run the workflow --------- Co-authored-by: Anwer Sayeed <[email protected]> * Introduces API versioning check in CI/CD (#924) * a random change * husky precommit * one more try * one more try * one more try * one more try * one more try * one more try * second try * removed unwanted deps * removed unwanted deps * resolved the error * updated variable name * rerun test * rerun test * added test to pull.yml * removed push check * resolved conflict * Sass filed added with documentation * Linting fixed * Fixed the folder structure and naming convention * Update stale.yml * Typo fix * Update CONTRIBUTING.md * Merge talawa-user-portal into develop (#935) * Create login and register page for user portal * Lint public locales * Create tests for login page components * Add react import in tests * Create organizations screen for user portal * Fix failing tests and lint code * fix failing tests * Add tests for organization screen and componenets * Fix non-null assertions * Fix non-null assertions in organizations test * Fix bootstrap migration changes * Merge conflict error fixed --------- Co-authored-by: Anwer Sayeed <[email protected]> Co-authored-by: Kanishka Bansode <[email protected]> Co-authored-by: Peter Harrison <[email protected]> Co-authored-by: Noble Mittal <[email protected]> * Random checkout * Design ready for homescreen * Login page 100% code c=coverage * Login page icon adjustment * Added translations * Fixed the failing tests * Revert to older version of loader * Animation added fixed warnings * Fixed accessability * Mutations and Tests foxed * Fixed coloring in UserPortal * Tests fixed and ChangeLanguageDropdown used in UserLoginPage * Linting Fixed --------- Co-authored-by: Anwer Sayeed <[email protected]> Co-authored-by: Kanishka Bansode <[email protected]> Co-authored-by: Peter Harrison <[email protected]> Co-authored-by: Noble Mittal <[email protected]> * Merge latest adminUI-Redesign (#950) * Initial Organizations screen done * Removed yellow scrollbar * Linting fixed * Replaced images with svgs for logos * Styling done for btnsContainer * Better typechecking and readability * Animated Drawer working * Responsive page ready * OrgCard responsive * Fixed navbar issue and added webkit keyframes * LeftDrawer ready * Translations added * Added shimmer loading effect * Styling issue fixed * Failing tests fixed for OrgList * Removed unused vars * Tests done for LeftDrawer * Succesfully made component without causing any breaking change * 100% Code coverage achieved for Requests Screen * Fix alignment * Roles screen UI done * Role screen fixed with 100% test coverage * Changing screen activeness fixed * Unused vars and Typos fixed * Language support added * Linting and typos fixed * Fixed failing tests for LeftDrawer * Completed tests of AdminDashListCard with 100% code coverage * OrgListCard done * Finalised tests * Requests user search made functional again ! * Fixed loading on refetch and UX on all screens * OrgList failing errors fixed * Fixed all failing tests * Achieved 100% code coverage for OrgList.tsx * Wrote tests and mod LeftDrawer for admins * Minor ui issue fixed * Fixed failing test * UI bug dropdown * Frontend insync with Backend attempt 1 * Introspection fail fix 1 * Introspection error fix 3 * Introspection error fix another attempt * Another attempt * [Talawa-user-portal] Add Settings and Donate Screen, along with other UI fixes (#953) * Create login and register page for user portal * Lint public locales * Create tests for login page components * Add react import in tests * Create organizations screen for user portal * Fix failing tests and lint code * fix failing tests * Add tests for organization screen and componenets * Fix non-null assertions * Fix non-null assertions in organizations test * Fix bootstrap migration changes * Add Home Screen along with other components * Fix failing tests * Add required tests and Offcanvas navbar * Remove unused variables from tests * Sync the Mutations with talawa-api * Add Settings and Donate Screen * Add multilingual support for the screens * Add Event Project and Volunteer Management (#961) * Add screens for adding and updating event projects * Add delete operation for event projects and debug update * Remove yarn.lock * Begin testing * Add display of tasks and functionality to add tasks * Add modal for edit task * Add UpdateTaskModal * Add Delete Task Modal and volunteers display * Add test for DeleteEventProjectModal.tsx * Add tests for add and update event project modal * Add screen for managing volunteers * Add option to assign and remove volunteers * Add tests for AddTaskModal.tsx * Add tests for TaskListItem.tsx and DeleteTaskModal.tsx * Complete testing for all Task Modals * Add completed display to tasks * Add tests for event dashboard * Restructure files * Add attendee management modal * Add testing for EventAttendeeModal * Move to 100% testing and wrapper for attendees modal * Add basic checkIn functionality for users * Add testing for CheckIn modals * Introduce the tag generation into the repository * Update linting rule and fix errors * Remove alloted seat and alloted room * Fix testing * Correct some tests * Migrate from attendees to registrants * Migrate Event Project modals to new design * Migrate registrants modals and checkin modals to new design with 100% test coverage * Move task modals to new styles * Move to 100% test coverage * Admin workflow completed with updated package.json (#960) * Merge latest AdminUI Redesign into develop (#956) * Initial Organizations screen done * Removed yellow scrollbar * Linting fixed * Replaced images with svgs for logos * Styling done for btnsContainer * Better typechecking and readability * Animated Drawer working * Responsive page ready * OrgCard responsive * Fixed navbar issue and added webkit keyframes * LeftDrawer ready * Translations added * Added shimmer loading effect * Styling issue fixed * Failing tests fixed for OrgList * Removed unused vars * Tests done for LeftDrawer * Succesfully made component without causing any breaking change * 100% Code coverage achieved for Requests Screen * Fix alignment * Roles screen UI done * Role screen fixed with 100% test coverage * Changing screen activeness fixed * Unused vars and Typos fixed * Language support added * Linting and typos fixed * Fixed failing tests for LeftDrawer * Completed tests of AdminDashListCard with 100% code coverage * OrgListCard done * Finalised tests * Requests user search made functional again ! * Fixed loading on refetch and UX on all screens * OrgList failing errors fixed * Fixed all failing tests * Achieved 100% code coverage for OrgList.tsx * Wrote tests and mod LeftDrawer for admins * Minor ui issue fixed * Fixed failing test * UI bug dropdown * Frontend insync with Backend attempt 1 * Introspection fail fix 1 * Introspection error fix 3 * Introspection error fix another attempt * Another attempt * Fixed Default Animation on Organizations Screen * Fixed typo * Loading data from localstorage functional * Fixed name conventions * Fixed typo * UI Fix * Changed screen name * Table Loader added * Added LeftOrg drawer and Organization screen comp to Screens * routesReducer tests fixed * Redundant adminNavbar removed from project * MemberDetail issue fixed * Achieved 100% code coverage for LeftDrawerOrg, Added Empty div in images * Fixed failing tests * Fix tests * Fixed warnings * Linting fixes * Linting issues fixed * Achieved 100% code coverage for CollapsibleDropdown * Achieved 100% CC on IconComponent and removed useless imports * Achieved 100% cc for LeftDrawer Component * Achieved 100% CC on SuperAdminScreen Component * Fixed typo * Integrated Event Dashboard * Failing tests for LeftDrawer LeftDrawerOrg OrgList screen fixed * Removed redundant code * Removed useless imports * Linting fixed * Removed LeftDrawerOrg * Update documentation * copy-docs -to-talawa branch update to develop * removed dependance of code copying from generate segment * Update push.yml (#969) * Update push.yml (#970) * Feature Request: Adding a dialog to go to plugin store after an organization is created by the admin (#951) * Add/ test for OrgPost.tsx * fix: org post back to default * Added Dialog 2 * Updated Dialog UI * Removed Extra code * Updated Plugin store * fix: warnings and solves #951 & #948 * fix: warnings and solves #951 & #948 * fix: warnings and solves #951 & #948 * Fix: UI Redesign * fix: merge * fix * Update AddOnStore.tsx * Fixed Merge Errors * Add test: for OrgEntry * Test 3 * fix test 4 * Merge latest AdminUI Redesign into develop (#972) * Initial Organizations screen done * Removed yellow scrollbar * Linting fixed * Replaced images with svgs for logos * Styling done for btnsContainer * Better typechecking and readability * Animated Drawer working * Responsive page ready * OrgCard responsive * Fixed navbar issue and added webkit keyframes * LeftDrawer ready * Translations added * Added shimmer loading effect * Styling issue fixed * Failing tests fixed for OrgList * Removed unused vars * Tests done for LeftDrawer * Succesfully made component without causing any breaking change * 100% Code coverage achieved for Requests Screen * Fix alignment * Roles screen UI done * Role screen fixed with 100% test coverage * Changing screen activeness fixed * Unused vars and Typos fixed * Language support added * Linting and typos fixed * Fixed failing tests for LeftDrawer * Completed tests of AdminDashListCard with 100% code coverage * OrgListCard done * Finalised tests * Requests user search made functional again ! * Fixed loading on refetch and UX on all screens * OrgList failing errors fixed * Fixed all failing tests * Achieved 100% code coverage for OrgList.tsx * Wrote tests and mod LeftDrawer for admins * Minor ui issue fixed * Fixed failing test * UI bug dropdown * Frontend insync with Backend attempt 1 * Introspection fail fix 1 * Introspection error fix 3 * Introspection error fix another attempt * Another attempt * Fixed Default Animation on Organizations Screen * Fixed typo * Loading data from localstorage functional * Fixed name conventions * Fixed typo * UI Fix * Changed screen name * Table Loader added * Added LeftOrg drawer and Organization screen comp to Screens * routesReducer tests fixed * Redundant adminNavbar removed from project * MemberDetail issue fixed * Achieved 100% code coverage for LeftDrawerOrg, Added Empty div in images * Fixed failing tests * Fix tests * Fixed warnings * Linting fixes * Linting issues fixed * Achieved 100% code coverage for CollapsibleDropdown * Achieved 100% CC on IconComponent and removed useless imports * Achieved 100% cc for LeftDrawer Component * Achieved 100% CC on SuperAdminScreen Component * Fixed typo * Integrated Event Dashboard * Failing tests for LeftDrawer LeftDrawerOrg OrgList screen fixed * Removed redundant code * Removed useless imports * Linting fixed * Removed LeftDrawerOrg * Dashboard screen ui almost ready * Org Dash ready * Block/Unblock screen ready * Organization settings page ready * Lang changes * Page refresh on updating org removed * OrgUpdate tests done * OrgUpdate 100% test coverage achieved * OrgSettings Tests done * Organization Dashboard Cards done * Organization Dashboard achieved 100% CC * 100% CC achieved for BlockUser screen * Finalised changes * Small change * Tests fixed * Separate OrgSettings component made * Linting fixed * Formatting fixed * Events screen and Post Comment Modal for Talawa-user-portal (#963) * Create login and register page for user portal * Lint public locales * Create tests for login page components * Add react import in tests * Create organizations screen for user portal * Fix failing tests and lint code * fix failing tests * Add tests for organization screen and componenets * Fix non-null assertions * Fix non-null assertions in organizations test * Fix bootstrap migration changes * Add Home Screen along with other components * Fix failing tests * Add required tests and Offcanvas navbar * Remove unused variables from tests * Sync the Mutations with talawa-api * Add Settings and Donate Screen * Add multilingual support for the screens * Add events screen without calendar view * Add multilingual support to Events screen * Fix failing tests due to merge * Add Post Comment functionality * Refactor Events tests * Deprecate event registrants from query * Update README.md * Add My Tasks screen and Fix UI bugs [User Portal] (#978) * Create login and register page for user portal * Lint public locales * Create tests for login page components * Add react import in tests * Create organizations screen for user portal * Fix failing tests and lint code * fix failing tests * Add tests for organization screen and componenets * Fix non-null assertions * Fix non-null assertions in organizations test * Fix bootstrap migration changes * Add Home Screen along with other components * Fix failing tests * Add required tests and Offcanvas navbar * Remove unused variables from tests * Sync the Mutations with talawa-api * Add Settings and Donate Screen * Add multilingual support for the screens * Add events screen without calendar view * Add multilingual support to Events screen * Fix failing tests due to merge * Add Post Comment functionality * Refactor Events tests * Deprecate event registrants from query * Add my tasks screen for user portal * Remove unnecessary comments from test files * Add Feedback UI Components to Talawa Admin (#980) * Add feedback component * Add tests for feedback modal * Add handling for empty feedback * Add Average Rating and Reviews component * Add testing for all the added cards * Fix tests and move to 100% coverage * Add bugfix * Add merge function to fix failing tests * Add key definitons * Change merge policy * Add custom merge policy to all the Event Stat tests * remove cache * Migrate to a single query in the parent * Adding Plugin Logic to the Talawa Mobile Web App (#976) * Add/ test for OrgPost.tsx * fix: org post back to default * Added Dialog 2 * Updated Dialog UI * Removed Extra code * Updated Plugin store * fix: warnings and solves #951 & #948 * fix: warnings and solves #951 & #948 * fix: warnings and solves #951 & #948 * Fix: UI Redesign * fix: merge * fix * Update AddOnStore.tsx * Fixed Merge Errors * Add test: for OrgEntry * Test 3 * fix test 4 * chores: version changes * Add: Initial Websocket setup on talawa mobile web * Add: plugin logic * Add: plugin logic * removed extra * removed extra * Added: Tests * fix * Add Side Navigation to Event Dashboard (#981) * Create left drawer for event dashboard * Add basic styles to the event dashboard * Fix button styling * Add testing * Add testing for the left event drawer * Add 100% line coverage for all components * Increase timeout for tests * Move maximum rating in feedback from 10 to 5 [Fixes #990] (#987) * Move maximum rating in feedbacks from 10 to 5 * Fix failing tests * Add chat screen to talawa-user-portal (#986) * Create login and register page for user portal * Lint public locales * Create tests for login page components * Add react import in tests * Create organizations screen for user portal * Fix failing tests and lint code * fix failing tests * Add tests for organization screen and componenets * Fix non-null assertions * Fix non-null assertions in organizations test * Fix bootstrap migration changes * Add Home Screen along with other components * Fix failing tests * Add required tests and Offcanvas navbar * Remove unused variables from tests * Sync the Mutations with talawa-api * Add Settings and Donate Screen * Add multilingual support for the screens * Add events screen without calendar view * Add multilingual support to Events screen * Fix failing tests due to merge * Add Post Comment functionality * Refactor Events tests * Deprecate event registrants from query * Add my tasks screen for user portal * Remove unnecessary comments from test files * Add chat screen along with components * Add mui/system package for x-chart support * Add chat screen tests and fix other bugs * Update issue.yml * Update stale.yml * Merge latest AdminUI Redesign into Master (#1006) * Pagination Done for Orglist * Fixed warnings * Infinite scroll and search working for Requests screen * Simplified the code * Infinite scroll enabled and functioning on OrgList Requests and Users screen * FIxed warning * Fixed typo * Fixed bug * Joined and Blockedbyorgs screen and mdoal ready * Tables ready ! * Remove user from organization functionality working well * Update user role in organization feature ready * Minor changes * Done with tests on OrgList * Done with testss of Requests screen * 100% CC achieved for Users screen * Main tests done for UserTableItem * 100% Code Coverage Achieved for UserTableItem * Removed Redundant Landing Page * 100% CC achieved for TableLoader * Translation added for Users Screen * Translation done for Requests screen * Translation done for dashboard screen * Linting and warnings fixed * Improved login page * UI Done for Forgot Password Screen * Forgot Password Screen Tests done! * Fixed all pending tests * Better message for btns and coloring * Linting issues fixed * Fixed code styles * SUPPRESSED UNKNOWN ERROR * Fixed formatting * Updated typoed message * Fixed failing tests accompanying typo * fix createEvent to close modal and show events without refresh (#1014) * fix: Ensure Full Visibility of Logo on 404 Error Page (#1018) - Adjusted the positioning of the logo on the 404 error page to ensure full visibility. - Implemented CSS modifications to prevent the logo from being covered or cut off. - Tested the changes by navigating to various undefined endpoints, confirming that the logo is now displayed correctly on the 404 error page. This commit addresses the bug by ensuring the proper display of the logo on the 404 error page, enhancing the user experience. Fixes #1016 Signed-off-by: Akhilender <[email protected]> * Implemented featurs for Postfeed Management (#982) * redesigned newsfeed * added test * newsfeed management * pinned post * postfeed management * pin unpin tag and video control * changes part 2 * newsfeed changes * changes in Card Preview of newsfeed * changes in Card Preview of newsfeed * testing phase 1 * translation * tests * tests * merged intto develop * test * Added query * Update pull-requests.yml * update and delete buttons of event modal are now working (#1051) * update and delete buttons of event modal are now working * fixed the naming conventions and style of the modal * Dynamic dashboard Enhancements (#979) * Dynamic Organization Dashboard * Dynamic Organization Dashboard * refined organization dashboard * Update src/utils/handleLatestFeed.ts Co-authored-by: Noble Mittal <[email protected]> * fixed inconsistent casing * fixed org dashboard test * fixed org dashboard test * revert previous commit * final changes * final changes --------- Co-authored-by: Noble Mittal <[email protected]> * Fix dashboard items (#1007) * Dashboard items are working now. * added variables for links -fix dashboard items * Added variables for links -fix dashboard items. * made the changes as said * Removed : string from variable assignment. * remove repititive code and resolved falling tests * Fix repeating code and falling tests. * Resolved some more falling tests * write test for missed lines * Fix event creation issue with white spaces. (#1025) * fix event creation with white spaces * Add test for empty input values * chore: fix unit test (#1052) * Fix layout distortion due to untruncated title description of events. (#1049) * Fix layout distortion due to untruncated title description of events * Add test * add test for LeftDrawerEvent.tsx * fixed some tests * add test complete * test: SecuredRouteForUser component 100% Test Coverage and fixed uncovered lines (#1048) * SecuredRouteForUser test case added * Fixed Linting Errors * Update SecuredRouteForUser.test.tsx * Update SecuredRouteForUser.test.tsx * linting fix * Update SecuredRouteForUser.test.tsx * Update SecuredRouteForUser.test.tsx * Fix incorrect toast Notification. (#1053) * correct toast notification for TableRow.tsx with full test coverage * Add correct toast with full code coverage * Add correct toast for deleteEventProjectModal.tsx with full test coverage * Add correct toast for UpdateEventProjectModal.tsx with full test coverage * Add correct toast for EventRegistrantsModal.tsx and full test coverage. * Add correct toast for AddTaskModal.tsx with full test coverage * Add correct toast for UpdateTaskModal.tsx with full test coverage * minor fix * Add correct toast to EventRegistrantsModal.tsx * fix EventRegitrantsModal.tsx * created a return button on event dashboard (#1057) * test: Loader Component 100% Test Coverage and Fix Uncovered Lines (#1047) * test: Achieve 100% Test Coverage and Fix Uncovered Lines - Improved the test coverage for the Loader component, addressing the previously uncovered lines and ensuring that all tests pass successfully. - Added a test to ensure that the component renders correctly with a custom 'sm' size. I verified that both the spinner-wrapper and spinner elements are present and that the correct class is applied. - Added a test to ensure that the component renders correctly with a 'lg' size. I verified that the spinner element has the appropriate class. - Added a test to ensure that the component renders correctly with an 'xl' size. I verified that the spinner element has the correct class. With these new tests, I now have 100% test coverage, and there are no more uncovered lines. The Loader component is thoroughly tested for different size scenarios, and all tests pass successfully. Signed-off-by: Akhilender <[email protected]> * Fixed linting in Loader component Signed-off-by: Akhilender <[email protected]> * Test: Increasing the test level - Trying to meet the code coverage level for Loader component. Signed-off-by: Akhilender <[email protected]> * Fixed Linting Signed-off-by: Akhilender <[email protected]> * fix: Linting Signed-off-by: Akhilender <[email protected]> * Improving test coverage for Loader Component - Fixed lint errors Signed-off-by: Akhilender <[email protected]> * test: Improving the tests on the Loader Component - Added a new aspect in the test-case1 Signed-off-by: Akhilender <[email protected]> * Fixed: Removed runtime-generated classes from testing - Eliminated all checks for classes associated with bootstrap components assigned at runtime. - Recognized that validating classes assigned during runtime is inappropriate. Signed-off-by: Akhilender <[email protected]> --------- Signed-off-by: Akhilender <[email protected]> * Simulated Test Database (#984) * Dynamic Organization Dashboard * Dynamic Organization Dashboard * Sample Org Implementation * removed unnecessary changes * removed unnecessary svgs * removed unnecessary import * added appropriate button style * fixed OrgListCard tests * Fixed OrgList and OrgListCard Tests * Removed Unnecessary 'container' Variable * Added Missing Translations and removed unused variable * Fixed event check in management not updating automatically bug (#1062) * fixed the event checkIn bug * fixed the failing test * fixed the CheckInWrapper test * Fix user profile buttons layout and added form validation (#1064) * Fix user profile buttons layout and added form validation * Fix falling tests and warnings * Add test for missed lines * fix falling tests * test: Achieved 100% test coverage and fixed uncovered lines (#1068) * test: Achieved 100% test coverage and fixed uncovered lines - Improved the test coverage for the User-Password-Update component, addressing the previously uncovered lines and ensuring that all tests pass successfully. - Added two new tests 1. Empty Password Field Test: - The first test ensures that an error is displayed when attempting to save changes with an empty password field. 2. Mismatched New and Confirm Passwords Test - The second test covers the scenario where the new and confirm password fields do not match. With these new tests, I now have 100% test coverage, and there are no more uncovered lines. Signed-off-by: Akhilender <[email protected]> * Altered the formData - Altered the formData to make sure all are related to the organization name. Signed-off-by: Akhilender <[email protected]> --------- Signed-off-by: Akhilender <[email protected]> * created test for src/components/UserPortal/EventCard/EventCard.tsx (#1079) * created test for eventCard of User portal * corrected the start and end time * Feature request: Adding advertisement screen (#994) * Add/ test for OrgPost.tsx * fix: org post back to default * Added Dialog 2 * Updated Dialog UI * Removed Extra code * Updated Plugin store * fix: warnings and solves #951 & #948 * fix: warnings and solves #951 & #948 * fix: warnings and solve…
* Changes position and text of all organization button * Made changes to the routesReducer.test file * Made changes in IconComponent.test file * Fetched changes from main repo * Fixed unnecessary changes --------- Co-authored-by: Aditya Agarwal <[email protected]>
* Added Base branch check to main * Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop to main * Deleted all main files * Merged develop into main
* Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop into main
* Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop into main * Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop into main
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.5 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.5...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.15 to 6.2.1. - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.1.15...v6.2.1) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 40 to 41. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v40...v41) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.2...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ejs](https://github.com/mde/ejs) from 3.1.9 to 3.1.10. - [Release notes](https://github.com/mde/ejs/releases) - [Commits](mde/ejs@v3.1.9...v3.1.10) --- updated-dependencies: - dependency-name: ejs dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop into main --------- Co-authored-by: Peter Harrison <[email protected]>
* 20240727112607 Deleted all files in the main branch in anticipation of merging develop into main cleanly * 20240727112842 Merge develop into main
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
WalkthroughThe changes include the addition of configuration files, scripts, and localization resources for the Talawa-admin application. Key enhancements involve improved dependency management, updated linting and formatting rules, and comprehensive localization support in multiple languages. The restructuring of issue and pull request templates aims to facilitate better contributor engagement while refining project documentation enhances usability for developers and users alike. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add Documentation and Community
|
@Kanishk-tiwari-045 Thanks for your PR! But your local branch should be upstream with develop and raise PR against the develop branch too If you are not already added upstream check with
If you see upstream here apart from origin then you are ready to go to execute below cds and if you haven't seen any upstream there use this cd:
Then go with this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 49
Outside diff range, codebase verification and nitpick comments (56)
scripts/config-overrides/custom_build.js (1)
4-5
: Fix the typo in the comment.There's a typo in the comment: "scritps" should be "scripts".
Apply this diff to fix the typo:
-//use default react scritps config +//use default react scripts configpublic/index.html (1)
5-21
: Verify Google Fonts URLs: HTTP 404 Error DetectedThe URLs for Google Fonts (
https://fonts.googleapis.com
andhttps://fonts.gstatic.com
) returned a 404 error, indicating they are not accessible. Please verify and correct these URLs to ensure proper loading of fonts.
- Google Fonts URL Issue: Verify and update the URLs to ensure they are correct and accessible.
Analysis chain
HTML updates enhance performance and aesthetics. Verify URLs.
The updates to icons, stylesheets, and preconnect links improve the application's visual appearance and performance.
Ensure that the URLs are correct and accessible to avoid loading issues.
Run the following script to check the accessibility of the URLs:
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify accessibility of URLs used in the HTML. # Test: Check if URLs are accessible. Expect: HTTP status 200. curl -I https://fonts.googleapis.com | grep 'HTTP/2 200' curl -I https://fonts.gstatic.com | grep 'HTTP/2 200' curl -I https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.15.3/css/all.min.css | grep 'HTTP/2 200'Length of output: 1182
Script:
#!/bin/bash # Description: Verify accessibility of URLs used in the HTML with detailed output. # Test: Check if URLs are accessible and capture the full HTTP response headers. curl -I https://fonts.googleapis.com curl -I https://fonts.gstatic.com curl -I https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.15.3/css/all.min.cssLength of output: 2617
src/assets/scss/_general.scss (2)
1-3
: Consider adding more CSS variables for theme customization.Defining additional CSS variables for colors, spacing, and typography can enhance the maintainability and scalability of the styling.
19-22
: Consider using CSS variables for colors.The background color
#f2f7ff
could be defined as a CSS variable for consistency and easier theme management..github/workflows/codeql-codescan.yml (1)
28-28
: Consider expanding language support.Currently, the workflow only analyzes JavaScript. If the project includes other languages, consider adding them to the matrix.
DOCUMENTATION.md (1)
16-20
: Clarify and improve formatting in the documentation section.Consider using bullet points for clarity and correcting the formatting for the Docusaurus link.
Apply this diff for improvements:
Our documentation can be found in ONLY TWO PLACES: -1. ***Inline within the repository's code files***: We have automated processes to extract this information and place it in our Talawa documentation site [docs.talawa.io](https://docs.talawa.io/). -1. ***In our `talawa-docs` repository***: Our [Talawa-Docs](https://github.com/PalisadoesFoundation/talawa-docs) repository contains user edited markdown files that are automatically integrated into our Talawa documentation site [docs.talawa.io](https://docs.talawa.io/) using the [Docusaurus](https://docusaurus.io/) package. +* **Inline within the repository's code files**: We have automated processes to extract this information and place it in our Talawa documentation site [docs.talawa.io](https://docs.talawa.io/). +* **In our `talawa-docs` repository**: Our [Talawa-Docs](https://github.com/PalisadoesFoundation/talawa-docs) repository contains user-edited Markdown files that are automatically integrated into our Talawa documentation site [docs.talawa.io](https://docs.talawa.io/) using the [Docusaurus](https://docusaurus.io/) package.ISSUE_GUIDELINES.md (4)
3-5
: Revise the introduction for clarity and grammar.There are minor grammatical and stylistic issues in the introduction. Consider these revisions:
- Use "an issue report" instead of "a issues reports."
- Simplify the phrase "In order to give everyone a chance" to "To allow everyone to."
Apply this diff to improve the introduction:
:+1::tada: First off, thanks for taking the time to contribute! :tada::+1: -In order to give everyone a chance to submit a issues reports and contribute to the Talawa project, we have put restrictions in place. +To allow everyone to submit an issue report and contribute to the Talawa project, we have put restrictions in place.Tools
LanguageTool
[style] ~4-~4: Consider a shorter alternative to avoid wordiness.
Context: ...ing the time to contribute! 🎉👍 In order to give everyone a chance to submit a issu...(IN_ORDER_TO_PREMIUM)
[misspelling] ~5-~5: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...der to give everyone a chance to submit a issues reports and contribute to the Ta...(EN_A_VS_AN)
24-24
: Add a comma for clarity.Consider adding a comma after "In all cases" for better readability.
Apply this diff to improve clarity:
In all cases please use the [GitHub open issue search](https://github.com/PalisadoesFoundation/talawa-admin/issues) to check whether the issue has already been reported. +,
Tools
LanguageTool
[typographical] ~24-~24: Consider adding a comma here.
Context: ...> ___ ## Issue Management In all cases please use the [GitHub open issue search](http...(PLEASE_COMMA)
29-29
: Revise for clarity and conciseness.The sentence is repetitive and unclear. Consider rephrasing for clarity.
Apply this diff to improve the sentence:
-Your issue may have already been created. Search for duplicate open issues before submitting yours.for similar deficiencies in the code.duplicate issues are created. +Search for duplicate open issues before submitting yours to avoid redundancy.
57-57
: Capitalize "Slack" for consistency."Slack" should be capitalized as it is a proper noun.
Apply this diff to ensure consistency:
Discuss issues in our various slack channels when necessary +Slack
Tools
LanguageTool
[grammar] ~57-~57: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...lines 1. Discuss issues in our various slack channels when necessary 2. Please do no...(ON_SKYPE)
[typographical] ~57-~57: Consider adding a comma here.
Context: ...ur various slack channels when necessary 2. Please do not derail or troll issues. 3. Keep...(PLEASE_COMMA)
README.md (1)
55-56
: Videos section expansion looks good.The expansion of the videos section with YouTube playlist links provides valuable resources for contributors.
Consider hyphenating "new open source contributors."
The phrase "new open source contributors" may be clearer as "new open-source contributors" if it is intended as a compound adjective.
Tools
LanguageTool
[uncategorized] ~56-~56: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...)" videos are extremely helpful for new open source contributors.(EN_COMPOUND_ADJECTIVE_INTERNAL)
PR_GUIDELINES.md (1)
1-5
: Consider stylistic improvements in the introduction.The introduction is welcoming, but consider the following stylistic improvements:
- Remove "In order to" for conciseness.
- Add a comma after "Therefore" for clarity.
Apply this diff to improve the text:
In order to give everyone a chance to submit a pull request and contribute to the Talawa project, we have put restrictions in place. +Therefore, this section outlines the guidelines that should be imposed upon pull requests in the Talawa project.
Tools
LanguageTool
[uncategorized] ~2-~2: Loose punctuation mark.
Context: # Pull Request Guidelines 👍🎉 First off, thanks for taking t...(UNLIKELY_OPENING_PUNCTUATION)
[style] ~4-~4: Consider a shorter alternative to avoid wordiness.
Context: ...ing the time to contribute! 🎉👍 In order to give everyone a chance to submit a pull...(IN_ORDER_TO_PREMIUM)
.github/workflows/countline.py (2)
145-194
: Enhance argument parsing.The
_arg_parser_resolver
function is well-structured, but consider adding more detailed help messages for better user guidance.Enhance the help messages for clarity.
197-293
: Improve error message clarity.In the
main
function, the error message printed when files exceed the line limit could be more user-friendly.Consider rephrasing the message for clarity.
src/App.tsx (2)
51-90
: Improve localStorage usage.Consider using a more secure method for storing sensitive user information instead of localStorage.
Consider using session storage or secure cookies for sensitive data.
1-27
: Missing Import File:components/plugins/index.tsx
The import path
components/plugins/index.tsx
does not exist in the codebase. Please verify the path or ensure the file is added to the repository.
- Ensure that
components/plugins/index.tsx
is correctly referenced or created.Analysis chain
Ensure import paths are correct.
The import paths should be verified to ensure they point to the correct components and files.
Run the following script to verify the existence of imported files:
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of imported files. # Test: Check if all imported files exist. Expect: All paths should be valid. fd --type f --exec echo "File exists: {}" || echo "File not found: {}"Length of output: 62942
Script:
#!/bin/bash # Description: Verify the existence of specific imported files in src/App.tsx. # Define the list of imported files to check imports=( "components/AddOn/core/AddOnStore/AddOnStore" "components/OrganizationScreen/OrganizationScreen" "components/SecuredRoute/SecuredRoute" "components/SuperAdminScreen/SuperAdminScreen" "components/plugins/index" "screens/BlockUser/BlockUser" "screens/EventManagement/EventManagement" "screens/ForgotPassword/ForgotPassword" "screens/LoginPage/LoginPage" "screens/MemberDetail/MemberDetail" "screens/OrgContribution/OrgContribution" "screens/OrgList/OrgList" "screens/OrgPost/OrgPost" "screens/OrgSettings/OrgSettings" "screens/OrganizationActionItems/OrganizationActionItems" "screens/OrganizationAgendaCategory/OrganizationAgendaCategory" "screens/OrganizationDashboard/OrganizationDashboard" "screens/OrganizationEvents/OrganizationEvents" "screens/OrganizationFundCampaign/OrganizationFundCampagins" "screens/OrganizationFunds/OrganizationFunds" "screens/OrganizationPeople/OrganizationPeople" "screens/PageNotFound/PageNotFound" "screens/Requests/Requests" "screens/Users/Users" "screens/CommunityProfile/CommunityProfile" "screens/OrganizationVenues/OrganizationVenues" ) # Check each import path for import in "${imports[@]}"; do # Replace dots with slashes for directory structure path="./src/${import}.tsx" if [[ -f $path ]]; then echo "File exists: $path" else echo "File not found: $path" fi doneLength of output: 8424
CODE_STYLE.md (9)
5-7
: Clarify the enforcement of code style rules.Lines 5-7 emphasize the importance of adhering to the code style but could be more concise and clear.
Consider rephrasing to: "Strict adherence to the code style ensures consistency across contributions to Talawa-Admin. Do not alter the code style."
55-55
: Improve clarity on CSS usage.The guideline about using modular CSS and Bootstrap classes could be clearer.
Rephrase to: "Avoid using custom classes directly; prefer modular CSS and Bootstrap classes."
57-62
: Specify the language for code blocks.The code blocks lack a specified language, which could improve readability.
Add
html
as the language for these code blocks:- ``` + ```htmlTools
Markdownlint
57-57: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
58-58: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
71-71
: Clarify component usage guideline.The guideline on component usage could be more explicit.
Rephrase to: "Use components from the React-Bootstrap or Material UI libraries instead of plain Bootstrap classes."
96-114
: Specify the language for code blocks.The code blocks lack a specified language, which could improve readability.
Add
javascript
as the language for these code blocks:- ``` + ```javascript
127-147
: Remove unnecessary words for conciseness.The repeated phrase "all of the" can be removed for conciseness.
Consider rephrasing to: "This directory contains static assets used in the project."
Tools
LanguageTool
[style] ~127-~127: Consider removing “of” to be more concise
Context: ...tories ofsrc
assets
- This houses all of the static assets used in the project - `...(ALL_OF_THE)
[style] ~128-~128: Consider removing “of” to be more concise
Context: ... in the project -css
- This houses all of the css files used in the project - `imag...(ALL_OF_THE)
[style] ~129-~129: Consider removing “of” to be more concise
Context: ... the project -images
- This houses all of the images used in the project -scss
-...(ALL_OF_THE)
[style] ~130-~130: Consider removing “of” to be more concise
Context: ...in the project -scss
- This houses all of the scss files used in the project - `c...(ALL_OF_THE)
[grammar] ~134-~134: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ...rms -_talawa.scss
- Partial Sass file for Talawa -_utilities.scss
- Pa...(HE_VERB_AGR)
[grammar] ~135-~135: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... -_utilities.scss
- Partial Sass file for utilities -_variables.scss
-...(HE_VERB_AGR)
[grammar] ~136-~136: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... -_variables.scss
- Partial Sass file for variables -app.scss
- Main S...(HE_VERB_AGR)
[style] ~141-~141: Consider removing “of” to be more concise
Context: ...views/screensConstant
- This houses all of the constants used in the project `GraphQl...(ALL_OF_THE)
[style] ~143-~143: Consider removing “of” to be more concise
Context: ...in the projectGraphQl
- This houses all of the GraphQL queries and mutations used in t...(ALL_OF_THE)
[style] ~145-~145: Consider removing “of” to be more concise
Context: ...in the projectscreens
- This houses all of the views/screens to be navigated through i...(ALL_OF_THE)
[style] ~147-~147: Consider removing “of” to be more concise
Context: ... in Talawa-Adminstate
- This houses all of the state management code for the project ...(ALL_OF_THE)
Markdownlint
128-128: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
129-129: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
130-130: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
131-131: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
132-132: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
133-133: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
134-134: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
135-135: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
136-136: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
137-137: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
164-166
: Use a hyphen for compound adjectives.The phrase "third party imports" should use a hyphen.
Rephrase to: "Third-party imports."
Tools
LanguageTool
[uncategorized] ~165-~165: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...following order: - React imports - Third party imports - Local imports If there is...(EN_COMPOUND_ADJECTIVE_INTERNAL)
Markdownlint
164-164: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
165-165: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
166-166: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
190-230
: Use headings instead of emphasis for section titles.The section titles use emphasis instead of headings, which is not recommended.
Replace emphasis with appropriate heading levels for better structure and readability.
Tools
Markdownlint
190-190: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
230-230: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
239-253
: Specify the language for code blocks.The code blocks lack a specified language, which could improve readability.
Add
bash
as the language for these code blocks:- ``` + ```bashTools
Markdownlint
239-239: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
245-245: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
251-251: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
CONTRIBUTING.md (3)
27-27
: Consider adding "please" for politeness.The sentence could be more polite by adding "please."
Rephrase to: "Please let us know immediately if you have unacceptable experiences in this area."
Tools
LanguageTool
[style] ~27-~27: This expression usually appears with a “please” in front of it.
Context: ...DUCT.md) to understand what this means. Let us know immediately if you have unacceptable ex...(INSERT_PLEASE)
61-61
: Add a determiner for clarity.The sentence is missing a determiner.
Rephrase to: "The Pull Request guidelines are the best resource to follow to start working on open issues."
Tools
LanguageTool
[grammar] ~61-~61: A determiner may be missing.
Context: ...l Request guidelines](PR_GUIDELINES.md) is best resource to follow to start working on ...(THE_SUPERLATIVE)
76-76
: Streamline the phrase "Last but not the least."The phrase is wordy and can be shortened.
Rephrase to: "Lastly, communication is important; make sure to talk to other contributors."
Tools
LanguageTool
[style] ~76-~76: ‘Last but not the least’ might be wordy. Consider a shorter alternative.
Context: ...y and test that function when needed. - Last but not the least, communication is important make sure t...(EN_WORDINESS_PREMIUM_LAST_BUT_NOT_THE_LEAST)
[grammar] ~76-~76: It seems that “to” is missing before the verb.
Context: ...t the least, communication is important make sure to talk to other contributors, in ...(MISSING_TO_BETWEEN_BE_AND_VB)
[grammar] ~76-~76: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ... other contributors, in these cases, in slack channel or in a issue/PR thread. - As a...(ON_SKYPE)
[misspelling] ~76-~76: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ... in these cases, in slack channel or in a issue/PR thread. - As a last resort the...(EN_A_VS_AN)
INSTALLATION.md (5)
3-3
: Add a comma for clarity.A comma is needed for better readability.
Rephrase to: "The instructions are written to be followed in sequence, so make sure to go through each of them step by step without skipping any sections."
Tools
LanguageTool
[uncategorized] ~3-~3: Possible missing comma found.
Context: ...tructions are written to be followed in sequence so make sure to go through each of them...(AI_HYDRA_LEO_MISSING_COMMA)
60-60
: Add a hyphen for compound adjectives.The phrase "open source contribution" should use a hyphen.
Rephrase to: "open-source contribution."
Tools
LanguageTool
[uncategorized] ~60-~60: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: .... Basicgit
knowledge is required for open source contribution so make sure you're comfor...(EN_COMPOUND_ADJECTIVE_INTERNAL)
[uncategorized] ~60-~60: Possible missing comma found.
Context: ...` knowledge is required for open source contribution so make sure you're comfortable with it...(AI_HYDRA_LEO_MISSING_COMMA)
221-221
: Add a question mark for clarity.The sentence should end with a question mark.
Rephrase to: "Set the
ALLOW_LOGS
to 'YES' if you want warnings, info, and error messages in your console, or leave it blank if you don't need them or want to keep the console clean?"Tools
LanguageTool
[typographical] ~221-~221: Except for inverted sentences, ‘need them’ requires a question mark at the end of the sentence.
Context: ...t need them or want to keep the console clean # Post Configuration Steps It's now t...(MD_PRP_QUESTION_MARK)
236-236
: Add a comma after "By default."A comma is needed after "By default" for clarity.
Rephrase to: "By default,
talawa-admin
runs on port4321
on your system's localhost."Tools
LanguageTool
[uncategorized] ~236-~236: Did you mean: “By default,”?
Context: ...n serve ``` ## Accessing Talawa-Admin By defaulttalawa-admin
runs on port `4321` on y...(BY_DEFAULT_COMMA)
286-286
: Add a verb for clarity.The sentence is missing a verb.
Rephrase to: "You can lint your code files using this command:"
Tools
LanguageTool
[grammar] ~286-~286: The word ‘lint’ is a noun or an adjective. A verb or adverb is missing or misspelled here, or maybe a comma is missing.
Context: ...w.webp) ## Linting code files You can lint your code files using this command: ``...(PRP_MD_NN)
schema.graphql (13)
103-103
: Consider adding a description to scalarAny
.While flexible, a description would clarify its intended use.
173-173
: Consider adding a description to scalarCountryCode
.While flexible, a description would clarify its intended use.
200-200
: Consider adding a description to scalarDate
.While flexible, a description would clarify its intended use.
202-202
: Consider adding a description to scalarDateTime
.While flexible, a description would clarify its intended use.
273-273
: Consider adding a description to scalarEmailAddress
.While flexible, a description would clarify its intended use.
489-489
: Consider adding a description to scalarJSON
.While flexible, a description would clarify its intended use.
512-512
: Consider adding a description to scalarLatitude
.While flexible, a description would clarify its intended use.
519-519
: Consider adding a description to scalarLongitude
.While flexible, a description would clarify its intended use.
924-924
: Consider adding a description to scalarPhoneNumber
.While flexible, a description would clarify its intended use.
954-954
: Consider adding a description to scalarPositiveInt
.While flexible, a description would clarify its intended use.
1163-1163
: Consider adding a description to scalarTime
.While flexible, a description would clarify its intended use.
1182-1182
: Consider adding a description to scalarURL
.While flexible, a description would clarify its intended use.
1336-1336
: Consider adding a description to scalarUpload
.While flexible, a description would clarify its intended use.
public/locales/en/translation.json (10)
6-7
: Correct spelling errors in validation messages.The word "Atleast" should be corrected to "At least" for both messages.
Apply this diff to correct the spelling:
- "atleast_8_char_long": "Atleast 8 Character long", - "atleast_6_char_long": "Atleast 6 Character long", + "atleast_8_char_long": "At least 8 characters long", + "atleast_6_char_long": "At least 6 characters long",
10-10
: Improve clarity in password validation message.The password validation message can be made clearer by specifying "at least" and using consistent punctuation.
Apply this diff to improve clarity:
- "password_invalid": "Password should contain atleast one lowercase letter, one uppercase letter, one numeric value and one special character", + "password_invalid": "Password must contain at least one lowercase letter, one uppercase letter, one numeric value, and one special character.",
11-11
: Clarify email validation message.The email validation message should specify what is invalid about the email.
Apply this diff to clarify the message:
- "email_invalid": "Email should have atleast 8 characters", + "email_invalid": "Email must be at least 8 characters long.",
12-12
: Remove duplicate password mismatch message.The message for password mismatch is duplicated. Consider removing one of them for consistency.
Apply this diff to remove the duplicate:
- "Password_and_Confirm_password_mismatches.": "Password and Confirm password mismatches.",
30-30
: Correct spelling error in validation message.The word "Atleast" should be corrected to "At least."
Apply this diff to correct the spelling:
- "atleast_8_char_long": "Atleast 8 Character long", + "atleast_8_char_long": "At least 8 characters long",
31-31
: Remove duplicate password mismatch message.The message for password mismatch is duplicated. Consider removing one of them for consistency.
Apply this diff to remove the duplicate:
- "Password_and_Confirm_password_mismatches.": "Password and Confirm password mismatches.",
46-46
: Clarify message for no upcoming events.The message for no upcoming events can be made more user-friendly.
Apply this diff to improve clarity:
- "noEvents": "No Upcoming Events" + "noEvents": "There are no upcoming events at the moment."
51-51
: Clarify message for no posts created.The message for no posts created can be made more user-friendly.
Apply this diff to improve clarity:
- "noPostsCreated": "No Posts Created" + "noPostsCreated": "There are no posts created yet."
70-70
: Correct inconsistency in capitalization.The word "Advertisements" should be capitalized consistently.
Apply this diff to correct the capitalization:
- "Advertisement": "Advertisements", + "Advertisement": "Advertisements",
105-105
: Fix typo in manage features info message.The word "enale" should be corrected to "enable."
Apply this diff to fix the typo:
- "manageFeaturesInfo": "Creation Successful ! Please select features that you want to enale for this organization from the plugin store.", + "manageFeaturesInfo": "Creation Successful! Please select features that you want to enable for this organization from the plugin store.",
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (68)
package-lock.json
is excluded by!**/package-lock.json
public/favicon.ico
is excluded by!**/*.ico
public/favicon_palisadoes.ico
is excluded by!**/*.ico
public/images/logo512.png
is excluded by!**/*.png
public/images/svg/angleDown.svg
is excluded by!**/*.svg
public/images/svg/profiledefault.svg
is excluded by!**/*.svg
public/logo192.png
is excluded by!**/*.png
public/markdown/images/install1.png
is excluded by!**/*.png
public/markdown/images/install2.png
is excluded by!**/*.png
src/assets/css/app.css.map
is excluded by!**/*.map
src/assets/images/blank.png
is excluded by!**/*.png
src/assets/images/defaultImg.png
is excluded by!**/*.png
src/assets/images/palisadoes_logo.png
is excluded by!**/*.png
src/assets/images/talawa-logo-200x200.png
is excluded by!**/*.png
src/assets/images/talawa-logo-dark-200x200.png
is excluded by!**/*.png
src/assets/images/talawa-logo-lite-200x200.png
is excluded by!**/*.png
src/assets/svgs/actionItem.svg
is excluded by!**/*.svg
src/assets/svgs/admin.svg
is excluded by!**/*.svg
src/assets/svgs/agenda-category-icon.svg
is excluded by!**/*.svg
src/assets/svgs/agenda-items.svg
is excluded by!**/*.svg
src/assets/svgs/angleLeft.svg
is excluded by!**/*.svg
src/assets/svgs/angleRight.svg
is excluded by!**/*.svg
src/assets/svgs/article.svg
is excluded by!**/*.svg
src/assets/svgs/blockUser.svg
is excluded by!**/*.svg
src/assets/svgs/blockedUser.svg
is excluded by!**/*.svg
src/assets/svgs/cardItemDate.svg
is excluded by!**/*.svg
src/assets/svgs/cardItemEvent.svg
is excluded by!**/*.svg
src/assets/svgs/cardItemLocation.svg
is excluded by!**/*.svg
src/assets/svgs/chat.svg
is excluded by!**/*.svg
src/assets/svgs/checkInRegistrants.svg
is excluded by!**/*.svg
src/assets/svgs/dashboard.svg
is excluded by!**/*.svg
src/assets/svgs/date.svg
is excluded by!**/*.svg
src/assets/svgs/event.svg
is excluded by!**/*.svg
src/assets/svgs/eventDashboard.svg
is excluded by!**/*.svg
src/assets/svgs/eventStats.svg
is excluded by!**/*.svg
src/assets/svgs/events.svg
is excluded by!**/*.svg
src/assets/svgs/flask.svg
is excluded by!**/*.svg
src/assets/svgs/funds.svg
is excluded by!**/*.svg
src/assets/svgs/key.svg
is excluded by!**/*.svg
src/assets/svgs/listEventRegistrants.svg
is excluded by!**/*.svg
src/assets/svgs/location.svg
is excluded by!**/*.svg
src/assets/svgs/logout.svg
is excluded by!**/*.svg
src/assets/svgs/media.svg
is excluded by!**/*.svg
src/assets/svgs/newChat.svg
is excluded by!**/*.svg
src/assets/svgs/organizations.svg
is excluded by!**/*.svg
src/assets/svgs/palisadoes.svg
is excluded by!**/*.svg
src/assets/svgs/people.svg
is excluded by!**/*.svg
src/assets/svgs/plugins.svg
is excluded by!**/*.svg
src/assets/svgs/post.svg
is excluded by!**/*.svg
src/assets/svgs/posts.svg
is excluded by!**/*.svg
src/assets/svgs/requests.svg
is excluded by!**/*.svg
src/assets/svgs/roles.svg
is excluded by!**/*.svg
src/assets/svgs/settings.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Facebook-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Github-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Instagram-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Linkedin-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Reddit-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Slack-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Twitter-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Youtube-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/tags.svg
is excluded by!**/*.svg
src/assets/svgs/talawa.svg
is excluded by!**/*.svg
src/assets/svgs/user.svg
is excluded by!**/*.svg
src/assets/svgs/userEvent.svg
is excluded by!**/*.svg
src/assets/svgs/users.svg
is excluded by!**/*.svg
src/assets/svgs/venues.svg
is excluded by!**/*.svg
src/assets/talawa-logo-lite-200x200.png
is excluded by!**/*.png
Files selected for processing (104)
- .coderabbit.yaml (1 hunks)
- .env.example (1 hunks)
- .eslintignore (1 hunks)
- .eslintrc.json (4 hunks)
- .github/ISSUE_TEMPLATE/bug-report.md (2 hunks)
- .github/ISSUE_TEMPLATE/feature-request.md (2 hunks)
- .github/dependabot.yaml (1 hunks)
- .github/pull_request_template.md (2 hunks)
- .github/workflows/README.md (1 hunks)
- .github/workflows/codeql-codescan.yml (1 hunks)
- .github/workflows/compare_translations.py (1 hunks)
- .github/workflows/countline.py (1 hunks)
- .github/workflows/eslint_disable_check.py (1 hunks)
- .github/workflows/issue.yml (1 hunks)
- .github/workflows/md_mdx_format_adjuster.py (1 hunks)
- .github/workflows/pull-request-target.yml (1 hunks)
- .github/workflows/pull-request.yml (1 hunks)
- .github/workflows/push.yml (1 hunks)
- .github/workflows/stale.yml (1 hunks)
- .gitignore (2 hunks)
- .husky/post-merge (1 hunks)
- .husky/pre-commit (1 hunks)
- .lintstagedrc.json (1 hunks)
- .node-version (1 hunks)
- .prettierignore (1 hunks)
- .prettierrc (1 hunks)
- CODEOWNERS (1 hunks)
- CODE_OF_CONDUCT.md (1 hunks)
- CODE_STYLE.md (1 hunks)
- CONTRIBUTING.md (2 hunks)
- DOCUMENTATION.md (1 hunks)
- INSTALLATION.md (1 hunks)
- ISSUE_GUIDELINES.md (1 hunks)
- PR_GUIDELINES.md (1 hunks)
- README.md (3 hunks)
- jest-preview.config.ts (1 hunks)
- jest.config.js (1 hunks)
- package.json (2 hunks)
- public/index.html (1 hunks)
- public/locales/en/common.json (1 hunks)
- public/locales/en/errors.json (1 hunks)
- public/locales/en/translation.json (1 hunks)
- public/locales/fr/common.json (1 hunks)
- public/locales/fr/errors.json (1 hunks)
- public/locales/fr/translation.json (1 hunks)
- public/locales/hi/common.json (1 hunks)
- public/locales/hi/errors.json (1 hunks)
- public/locales/hi/translation.json (1 hunks)
- public/locales/sp/common.json (1 hunks)
- public/locales/sp/errors.json (1 hunks)
- public/locales/sp/translation.json (1 hunks)
- public/locales/zh/common.json (1 hunks)
- public/locales/zh/errors.json (1 hunks)
- public/locales/zh/translation.json (1 hunks)
- public/manifest.json (1 hunks)
- schema.graphql (1 hunks)
- scripts/mocks/@dicebear/collection.ts (1 hunks)
- scripts/mocks/@dicebear/core.ts (1 hunks)
- scripts/config-overrides/custom_build.js (1 hunks)
- scripts/config-overrides/custom_start.js (1 hunks)
- scripts/config-overrides/index.js (1 hunks)
- scripts/config-overrides/package.json (1 hunks)
- scripts/custom-test-env.js (1 hunks)
- scripts/githooks/check-localstorage-usage.js (1 hunks)
- scripts/githooks/update-toc.js (1 hunks)
- scripts/test.js (1 hunks)
- setup.ts (1 hunks)
- src/App.test.tsx (1 hunks)
- src/App.tsx (1 hunks)
- src/Constant/constant.spec.ts (1 hunks)
- src/Constant/constant.ts (1 hunks)
- src/GraphQl/Mutations/ActionItemCategoryMutations.ts (1 hunks)
- src/GraphQl/Mutations/ActionItemMutations.ts (1 hunks)
- src/GraphQl/Mutations/AgendaCategoryMutations.ts (1 hunks)
- src/GraphQl/Mutations/AgendaItemMutations.ts (1 hunks)
- src/GraphQl/Mutations/CampaignMutation.ts (1 hunks)
- src/GraphQl/Mutations/CommentMutations.ts (1 hunks)
- src/GraphQl/Mutations/EventAttendeeMutations.ts (1 hunks)
- src/GraphQl/Mutations/FundMutation.ts (1 hunks)
- src/GraphQl/Mutations/OrganizationMutations.ts (1 hunks)
- src/GraphQl/Mutations/PledgeMutation.ts (1 hunks)
- src/GraphQl/Mutations/VenueMutations.ts (1 hunks)
- src/GraphQl/Mutations/mutations.ts (1 hunks)
- src/GraphQl/Queries/ActionItemCategoryQueries.ts (1 hunks)
- src/GraphQl/Queries/ActionItemQueries.ts (1 hunks)
- src/GraphQl/Queries/AgendaCategoryQueries.ts (1 hunks)
- src/GraphQl/Queries/AgendaItemQueries.ts (1 hunks)
- src/GraphQl/Queries/OrganizationQueries.ts (1 hunks)
- src/GraphQl/Queries/PlugInQueries.ts (1 hunks)
- src/GraphQl/Queries/Queries.ts (1 hunks)
- src/GraphQl/Queries/fundQueries.ts (1 hunks)
- src/assets/css/scrollStyles.css (1 hunks)
- src/assets/scss/_general.scss (1 hunks)
- src/assets/scss/_talawa.scss (1 hunks)
- src/assets/scss/_variables.scss (1 hunks)
- src/assets/scss/app.scss (1 hunks)
- src/assets/scss/components/_accordion.scss (1 hunks)
- src/assets/scss/components/_alert.scss (1 hunks)
- src/assets/scss/components/_badge.scss (1 hunks)
- src/assets/scss/components/_breadcrumb.scss (1 hunks)
- src/assets/scss/components/_buttons.scss (1 hunks)
- src/assets/scss/components/_card.scss (1 hunks)
- src/assets/scss/components/_carousel.scss (1 hunks)
- src/assets/scss/components/_close.scss (1 hunks)
Files not processed due to max files limit (42)
- src/assets/scss/components/_dropdown.scss
- src/assets/scss/components/_list-group.scss
- src/assets/scss/components/_modal.scss
- src/assets/scss/components/_nav.scss
- src/assets/scss/components/_navbar.scss
- src/assets/scss/components/_offcanvas.scss
- src/assets/scss/components/_pagination.scss
- src/assets/scss/components/_placeholder.scss
- src/assets/scss/components/_progress.scss
- src/assets/scss/components/_spinners.scss
- src/assets/scss/content/_table.scss
- src/assets/scss/content/_typography.scss
- src/assets/scss/forms/_check-radios.scss
- src/assets/scss/forms/_floating-label.scss
- src/assets/scss/forms/_form-control.scss
- src/assets/scss/forms/_input-group.scss
- src/assets/scss/forms/_range.scss
- src/assets/scss/forms/_select.scss
- src/assets/scss/forms/_validation.scss
- src/assets/svgs/social-icons/index.tsx
- src/components/ActionItems/ActionItemsContainer.module.css
- src/components/ActionItems/ActionItemsContainer.test.tsx
- src/components/ActionItems/ActionItemsContainer.tsx
- src/components/ActionItems/ActionItemsContainerMocks.ts
- src/components/ActionItems/ActionItemsContainerProps.ts
- src/components/ActionItems/ActionItemsModal.test.tsx
- src/components/ActionItems/ActionItemsModal.tsx
- src/components/ActionItems/ActionItemsModalBody.tsx
- src/components/ActionItems/ActionItemsWrapper.module.css
- src/components/ActionItems/ActionItemsWrapper.test.tsx
- src/components/ActionItems/ActionItemsWrapper.tsx
- src/components/AddOn/AddOn.test.tsx
- src/components/AddOn/AddOn.tsx
- src/components/AddOn/core/AddOnEntry/AddOnEntry.module.css
- src/components/AddOn/core/AddOnEntry/AddOnEntry.test.tsx
- src/components/AddOn/core/AddOnEntry/AddOnEntry.tsx
- src/components/AddOn/core/AddOnEntry/AddOnEntryMocks.ts
- src/components/AddOn/core/AddOnRegister/AddOnRegister.module.css
- src/components/AddOn/core/AddOnRegister/AddOnRegister.test.tsx
- src/components/AddOn/core/AddOnRegister/AddOnRegister.tsx
- src/components/AddOn/core/AddOnStore/AddOnStore.module.css
- src/components/AddOn/core/AddOnStore/AddOnStore.test.tsx
Files skipped from review due to trivial changes (27)
- .env.example
- .eslintignore
- .github/ISSUE_TEMPLATE/bug-report.md
- .github/ISSUE_TEMPLATE/feature-request.md
- .github/dependabot.yaml
- .github/workflows/README.md
- .husky/pre-commit
- .lintstagedrc.json
- .node-version
- .prettierignore
- CODEOWNERS
- jest-preview.config.ts
- public/locales/en/errors.json
- public/locales/fr/common.json
- public/locales/fr/errors.json
- public/locales/hi/common.json
- public/locales/sp/errors.json
- public/locales/zh/errors.json
- scripts/mocks/@dicebear/collection.ts
- scripts/mocks/@dicebear/core.ts
- scripts/config-overrides/package.json
- src/assets/css/scrollStyles.css
- src/assets/scss/_talawa.scss
- src/assets/scss/_variables.scss
- src/assets/scss/components/_alert.scss
- src/assets/scss/components/_badge.scss
- src/assets/scss/components/_breadcrumb.scss
Additional context used
Learnings (3)
src/GraphQl/Queries/fundQueries.ts (1)
Learnt from: GlenDsza PR: PalisadoesFoundation/talawa-admin#2064 File: src/screens/OrganizationFunds/FundDeleteModal.tsx:1-2 Timestamp: 2024-06-30T21:44:39.912Z Learning: The folder containing mutation queries in the codebase is named `GraphQl`, not `graphql`.
src/GraphQl/Mutations/FundMutation.ts (1)
Learnt from: GlenDsza PR: PalisadoesFoundation/talawa-admin#2064 File: src/screens/OrganizationFunds/FundDeleteModal.tsx:1-2 Timestamp: 2024-06-30T21:44:39.912Z Learning: The folder containing mutation queries in the codebase is named `GraphQl`, not `graphql`.
src/GraphQl/Mutations/CampaignMutation.ts (1)
Learnt from: GlenDsza PR: PalisadoesFoundation/talawa-admin#2064 File: src/screens/OrganizationFundCampaign/CampaignDeleteModal.tsx:4-5 Timestamp: 2024-06-30T21:17:16.481Z Learning: The folder containing mutation queries in the codebase is named `GraphQl`, not `graphql`.
Biome
scripts/test.js
[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.(lint/suspicious/noRedundantUseStrict)
LanguageTool
DOCUMENTATION.md
[grammar] ~25-~25: The modal verb ‘should’ requires the verb’s base form.
Context: ...fdocs.talawa.io
should automatically launched in your browser at http://localhost:300...(MD_BASEFORM)
[grammar] ~26-~26: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...ttp://localhost:3000/ 1. Add/modify the markdown documents to thedocs/
directory of t...(MARKDOWN_NNP)
[uncategorized] ~32-~32: The preposition “to” seems more likely in this position.
Context: ... PLEASE do not add markdown files in this repository. Add them to `talawa-do...(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)
ISSUE_GUIDELINES.md
[uncategorized] ~2-~2: Loose punctuation mark.
Context: # Issue Report Guidelines 👍🎉 First off, thanks for taking t...(UNLIKELY_OPENING_PUNCTUATION)
[style] ~4-~4: Consider a shorter alternative to avoid wordiness.
Context: ...ing the time to contribute! 🎉👍 In order to give everyone a chance to submit a issu...(IN_ORDER_TO_PREMIUM)
[misspelling] ~5-~5: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...der to give everyone a chance to submit a issues reports and contribute to the Ta...(EN_A_VS_AN)
[typographical] ~24-~24: Consider adding a comma here.
Context: ...> ___ ## Issue Management In all cases please use the [GitHub open issue search](http...(PLEASE_COMMA)
[uncategorized] ~27-~27: Possible missing comma found.
Context: ...reported. ### New Issues To create new issues follow these steps: 1. Your issue may ...(AI_HYDRA_LEO_MISSING_COMMA)
[style] ~30-~30: Consider using a different verb for a more formal wording.
Context: .... 1. Verify whether the issue has been fixed by trying to reproduce it using the lat...(FIX_RESOLVE)
[style] ~35-~35: The wording of this phrase can be improved.
Context: ...lcome contributors who find new ways to make the code better. ### Existing Issues You can also be ...(MAKE_STYLE_BETTER)
[grammar] ~44-~44: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...butors to assign it to you in#talawa
slack channel. Working on these types of exi...(ON_SKYPE)
[grammar] ~53-~53: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...ew Issues 1. Join our#talawa-github
slack channel for automatic issue and pull re...(ON_SKYPE)
[grammar] ~57-~57: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...lines 1. Discuss issues in our various slack channels when necessary 2. Please do no...(ON_SKYPE)
[typographical] ~57-~57: Consider adding a comma here.
Context: ...ur various slack channels when necessary 2. Please do not derail or troll issues. 3. Keep...(PLEASE_COMMA)
README.md
[uncategorized] ~56-~56: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...)" videos are extremely helpful for new open source contributors.(EN_COMPOUND_ADJECTIVE_INTERNAL)
PR_GUIDELINES.md
[uncategorized] ~2-~2: Loose punctuation mark.
Context: # Pull Request Guidelines 👍🎉 First off, thanks for taking t...(UNLIKELY_OPENING_PUNCTUATION)
[style] ~4-~4: Consider a shorter alternative to avoid wordiness.
Context: ...ing the time to contribute! 🎉👍 In order to give everyone a chance to submit a pull...(IN_ORDER_TO_PREMIUM)
[style] ~46-~46: Style-wise, it’s not ideal to insert an adverb (‘manually’) in the middle of an infinitive construction (‘to test’). Try moving the adverb to avoid split infinitives.
Context: ..., you'll need to tell us what steps you followed to manually test your changes. 1. Please read our [CONTRIBUTING.md](C...(SPLIT_INFINITIVE)
[style] ~56-~56: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...o be closed. The quality of our code is very important to us. Therefore we make experienced ma...(EN_WEAK_ADJECTIVE)
[uncategorized] ~56-~56: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ...ty of our code is very important to us. Therefore we make experienced maintainers of our ...(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
[style] ~59-~59: Consider using a different verb for a more formal wording.
Context: ...check if all tests are passing; if not, fix the issues and then create a pull reque...(FIX_RESOLVE)
[style] ~64-~64: This expression is wordy and overused. Consider replacing it with a more concise and formal alternative.
Context: ...wer your questions, but we'll get to it sooner or later. @mentioning someone just adds to the p...(SOONER_OR_LATER)
[uncategorized] ~64-~64: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...adds to the pile of notifications we get and it won't make us look at your issue fas...(COMMA_COMPOUND_SENTENCE)
[style] ~65-~65: Consider shortening or rephrasing this to strengthen your wording.
Context: ...ue faster. 1. Do not force push. If you make changes to your pull request, please simply add a ...(MAKE_CHANGES)
CODE_OF_CONDUCT.md
[duplication] ~11-~11: Possible typo: you repeated a word
Context: ...-responsibilities) - Scope - Enforcement - Enforcement Guidelines ...(ENGLISH_WORD_REPEAT_RULE)
CODE_STYLE.md
[style] ~127-~127: Consider removing “of” to be more concise
Context: ...tories ofsrc
assets
- This houses all of the static assets used in the project - `...(ALL_OF_THE)
[style] ~128-~128: Consider removing “of” to be more concise
Context: ... in the project -css
- This houses all of the css files used in the project - `imag...(ALL_OF_THE)
[style] ~129-~129: Consider removing “of” to be more concise
Context: ... the project -images
- This houses all of the images used in the project -scss
-...(ALL_OF_THE)
[style] ~130-~130: Consider removing “of” to be more concise
Context: ...in the project -scss
- This houses all of the scss files used in the project - `c...(ALL_OF_THE)
[grammar] ~134-~134: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ...rms -_talawa.scss
- Partial Sass file for Talawa -_utilities.scss
- Pa...(HE_VERB_AGR)
[grammar] ~135-~135: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... -_utilities.scss
- Partial Sass file for utilities -_variables.scss
-...(HE_VERB_AGR)
[grammar] ~136-~136: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... -_variables.scss
- Partial Sass file for variables -app.scss
- Main S...(HE_VERB_AGR)
[style] ~141-~141: Consider removing “of” to be more concise
Context: ...views/screensConstant
- This houses all of the constants used in the project `GraphQl...(ALL_OF_THE)
[style] ~143-~143: Consider removing “of” to be more concise
Context: ...in the projectGraphQl
- This houses all of the GraphQL queries and mutations used in t...(ALL_OF_THE)
[style] ~145-~145: Consider removing “of” to be more concise
Context: ...in the projectscreens
- This houses all of the views/screens to be navigated through i...(ALL_OF_THE)
[style] ~147-~147: Consider removing “of” to be more concise
Context: ... in Talawa-Adminstate
- This houses all of the state management code for the project ...(ALL_OF_THE)
[uncategorized] ~165-~165: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...following order: - React imports - Third party imports - Local imports If there is...(EN_COMPOUND_ADJECTIVE_INTERNAL)
CONTRIBUTING.md
[style] ~27-~27: This expression usually appears with a “please” in front of it.
Context: ...DUCT.md) to understand what this means. Let us know immediately if you have unacceptable ex...(INSERT_PLEASE)
[uncategorized] ~34-~34: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...)" videos are extremely helpful for new open source contributors. ## Ways to Contribute If...(EN_COMPOUND_ADJECTIVE_INTERNAL)
[grammar] ~61-~61: A determiner may be missing.
Context: ...l Request guidelines](PR_GUIDELINES.md) is best resource to follow to start working on ...(THE_SUPERLATIVE)
[uncategorized] ~67-~67: Loose punctuation mark.
Context: ...ushed to themain
branch: -develop
: For unstable code and bug fixing - `mai...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~68-~68: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...d bug fixing -main
: Where the stable production ready code lies. This is our default branch. ...(EN_COMPOUND_ADJECTIVE_INTERNAL)
[typographical] ~72-~72: Consider adding a comma.
Context: ...ultiple developers are working on issues there is bound to be a conflict of interest (...(IF_THERE_COMMA)
[typographical] ~72-~72: Consider adding a comma after ‘Usually’ for more clarity.
Context: ...licts) among issues, PRs or even ideas. Usually these conflicts are resolved in a **Fir...(RB_LY_COMMA)
[grammar] ~72-~72: Did you mean “served” (as in the idiom ‘first come, first served’)?
Context: ...ts are resolved in a First Come First Serve basis however there are certain excep...(FIRST_SERVED)
[uncategorized] ~72-~72: Possible missing comma found.
Context: ...esolved in a First Come First Serve basis however there are certain exceptions to...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~74-~74: Possible missing comma found.
Context: ... an extension or in conflict with other PRs it is important to ask the author of th...(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~74-~74: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...tant to ask the author of the PR in the slack channel or in their PRs or issues thems...(ON_SKYPE)
[style] ~76-~76: ‘Last but not the least’ might be wordy. Consider a shorter alternative.
Context: ...y and test that function when needed. - Last but not the least, communication is important make sure t...(EN_WORDINESS_PREMIUM_LAST_BUT_NOT_THE_LEAST)
[grammar] ~76-~76: It seems that “to” is missing before the verb.
Context: ...t the least, communication is important make sure to talk to other contributors, in ...(MISSING_TO_BETWEEN_BE_AND_VB)
[grammar] ~76-~76: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ... other contributors, in these cases, in slack channel or in a issue/PR thread. - As a...(ON_SKYPE)
[misspelling] ~76-~76: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ... in these cases, in slack channel or in a issue/PR thread. - As a last resort the...(EN_A_VS_AN)
[typographical] ~77-~77: It appears that a comma is missing.
Context: ...el or in a issue/PR thread. - As a last resort the Admins would be responsible for dec...(DURING_THAT_TIME_COMMA)
[grammar] ~134-~134: The operating system from Apple is written “macOS”.
Context: ...r packages can be found for Windows and MacOS. 6. The currently acceptable c...(MAC_OS)
[uncategorized] ~162-~162: Possible missing comma found.
Context: ...odecov/results.jpg)]() 1. After making changes you can add them to git locally using `...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~164-~164: Possible missing comma found.
Context: ...using:git push origin <branch_name>
.(Here branch name must be name of the branch ...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~164-~164: Possible missing article found.
Context: ...:git push origin <branch_name>
.(Here branch name must be name of the branch you wan...(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~164-~164: Possible missing article found.
Context: ...branch_name>`.(Here branch name must be name of the branch you want to push the chan...(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~166-~166: Possible missing comma found.
Context: ...test suite passes, either locally or on CI once a PR has been created. 1. Review a...(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~177-~177: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...dation/talawa) for the link to join our slack channel. 1. We also have a technical em...(ON_SKYPE)
INSTALLATION.md
[uncategorized] ~3-~3: Possible missing comma found.
Context: ...tructions are written to be followed in sequence so make sure to go through each of them...(AI_HYDRA_LEO_MISSING_COMMA)
[duplication] ~24-~24: Possible typo: you repeated a word
Context: ...](#running-talawa-admin) - Accessing Talawa-Admin - [Talawa-Admin Registration](#talawa-admin-registratio...(ENGLISH_WORD_REPEAT_RULE)
[typographical] ~54-~54: It appears that a comma is missing.
Context: ... that follow. # Prerequisites In this section we'll explain how to set up all the pre...(DURING_THAT_TIME_COMMA)
[uncategorized] ~60-~60: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: .... Basicgit
knowledge is required for open source contribution so make sure you're comfor...(EN_COMPOUND_ADJECTIVE_INTERNAL)
[uncategorized] ~60-~60: Possible missing comma found.
Context: ...` knowledge is required for open source contribution so make sure you're comfortable with it...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~63-~63: Possible missing comma found.
Context: ...ithub. ## Setting up this repository First you need a local copy of
talawa-admin`...(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~66-~66: The word “setup” is a noun. The verb is spelled with a space.
Context: ...avigate to the folder where you want to setup the repository. 2. Open acmd
(Window...(NOUN_VERB_CONFUSION)
[grammar] ~67-~67: The operating system from Apple is written “macOS”.
Context: ...cmd
(Windows) orterminal
(Linux or MacOS) session in this folder. 1. An easy...(MAC_OS)
[uncategorized] ~68-~68: Possible missing article found.
Context: ...to do this is to right-click and choose appropriate option based on your OS. 3. **For Our O...(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~69-~69: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...e option based on your OS. 3. For Our Open Source Contributor Software Developers: ...(EN_COMPOUND_ADJECTIVE_INTERNAL)
[grammar] ~98-~98: The operating system from Apple is written “macOS”.
Context: ...node.js` packages in Windows, Linux and MacOS. 1. For Windows: 1. first install ...(MAC_OS)
[duplication] ~112-~112: Possible typo: you repeated a word
Context: ... 5. Save the document. 6. Exitnotepad
7. Exit PowerShell 8. This will ens...(ENGLISH_WORD_REPEAT_RULE)
[uncategorized] ~114-~114: Possible missing comma found.
Context: ...ou are always using the correct version ofnode.js
2. For Linux and MacOS, use t...(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~115-~115: The operating system from Apple is written “macOS”.
Context: ...t version ofnode.js
2. For Linux and MacOS, use the terminal window. 1. install...(MAC_OS)
[grammar] ~119-~119: The word “setup” is a noun. The verb is spelled with a white space.
Context: ... the respective recommended commands to setup your node environment 3. This ...(NOUN_VERB_CONFUSION)
[uncategorized] ~126-~126: Possible missing comma found.
Context: ...stall TypeScript, you can use thenpm
command which comes withnode.js
: ```bash np...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~154-~154: Possible missing comma found.
Context: ...ions in "setup" can be done manually as well and here's how to do it. - [Creating .e...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~158-~158: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...at runtime. It is not a part of the repo and you will have to create it. For a sampl...(COMMA_COMPOUND_SENTENCE)
[uncategorized] ~158-~158: Possible missing comma found.
Context: ...ve to create it. For a sample of.env
file there is a file named.env.example
in...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~199-~199: Possible missing preposition found.
Context: ... For additional details, please refer theHow to Access the Talawa-API URL
sect...(AI_HYDRA_LEO_MISSING_TO)
[grammar] ~203-~203: The word “setup” is a noun. The verb is spelled with a space.
Context: ...E_KEY in .env file You may not want to setup reCAPTCHA since the project will still ...(NOUN_VERB_CONFUSION)
[grammar] ~207-~207: The word “setup” is a noun. The verb is spelled with a space.
Context: ...ad the following steps. If you want to setup Google reCAPTCHA now, you may refer to ...(NOUN_VERB_CONFUSION)
[uncategorized] ~209-~209: Possible missing comma found.
Context: ... service you set up duringtalawa-api
installation as shown in this screenshot: ![reCAPTC...(AI_HYDRA_LEO_MISSING_COMMA)
[typographical] ~221-~221: Except for inverted sentences, ‘need them’ requires a question mark at the end of the sentence.
Context: ...t need them or want to keep the console clean # Post Configuration Steps It's now t...(MD_PRP_QUESTION_MARK)
[uncategorized] ~236-~236: Did you mean: “By default,”?
Context: ...n serve ``` ## Accessing Talawa-Admin By defaulttalawa-admin
runs on port `4321` on y...(BY_DEFAULT_COMMA)
[uncategorized] ~253-~253: Possible missing comma found.
Context: ... navigate to the running talawa-admin's website you'll land at talawa-admin registratio...(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~286-~286: The word ‘lint’ is a noun or an adjective. A verb or adverb is missing or misspelled here, or maybe a comma is missing.
Context: ...w.webp) ## Linting code files You can lint your code files using this command: ``...(PRP_MD_NN)
Markdownlint
DOCUMENTATION.md
25-25: null
Bare URL used(MD034, no-bare-urls)
PR_GUIDELINES.md
31-31: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
39-39: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
CODE_STYLE.md
128-128: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
129-129: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
130-130: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
131-131: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
132-132: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
133-133: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
134-134: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
135-135: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
136-136: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
137-137: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
164-164: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
165-165: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
166-166: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
57-57: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
73-73: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
75-75: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
92-92: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
190-190: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
230-230: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
58-58: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
65-65: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
78-78: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
95-95: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
158-158: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
173-173: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
181-181: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
239-239: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
245-245: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
251-251: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
CONTRIBUTING.md
103-103: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
112-112: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
127-127: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
138-138: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
142-142: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
157-157: null
No empty links(MD042, no-empty-links)
158-158: null
No empty links(MD042, no-empty-links)
160-160: null
No empty links(MD042, no-empty-links)
INSTALLATION.md
296-296: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time(MD001, heading-increment)
32-32: Expected: 4; Actual: 6
Unordered list indentation(MD007, ul-indent)
33-33: Expected: 4; Actual: 6
Unordered list indentation(MD007, ul-indent)
91-91: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
101-101: null
Bare URL used(MD034, no-bare-urls)
138-138: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
150-150: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
160-160: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
183-183: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
189-189: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
195-195: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
215-215: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
231-231: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
239-239: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
245-245: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
267-267: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
275-275: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
288-288: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
302-302: Expected: fenced; Actual: indented
Code block style(MD046, code-block-style)
310-310: Expected: fenced; Actual: indented
Code block style(MD046, code-block-style)
173-173: Expected: #setting-up-react_app_talawa_url-in-env-file; Actual: #setting-up-REACT_APP_TALAWA_URL-in-env-file
Link fragments should be valid(MD051, link-fragments)
173-173: Expected: #setting-up-react_app_recaptcha_site_key-in-env-file; Actual: #setting-up-REACT_APP_RECAPTCHA_SITE_KEY-in-env-file
Link fragments should be valid(MD051, link-fragments)
actionlint
.github/workflows/push.yml
116-116: shellcheck reported issue in this script: SC2086:info:2:28: Double quote to prevent globbing and word splitting
(shellcheck)
128-128: shellcheck reported issue in this script: SC2046:warning:1:24: Quote this to prevent word splitting
(shellcheck)
128-128: shellcheck reported issue in this script: SC2005:style:1:24: Useless echo? Instead of 'echo $(cmd)', just use 'cmd'
(shellcheck)
128-128: shellcheck reported issue in this script: SC2086:info:1:51: Double quote to prevent globbing and word splitting
(shellcheck)
128-128: shellcheck reported issue in this script: SC2046:warning:2:20: Quote this to prevent word splitting
(shellcheck)
128-128: shellcheck reported issue in this script: SC2005:style:2:20: Useless echo? Instead of 'echo $(cmd)', just use 'cmd'
(shellcheck)
128-128: shellcheck reported issue in this script: SC2086:info:2:52: Double quote to prevent globbing and word splitting
(shellcheck)
128-128: shellcheck reported issue in this script: SC2086:info:2:69: Double quote to prevent globbing and word splitting
(shellcheck)
145-145: the runner of "actions/upload-artifact@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/pull-request.yml
58-58: property "changed_files" is not defined in object type {changed-files: {conclusion: string; outcome: string; outputs: {string => string}}}
(expression)
59-59: shellcheck reported issue in this script: SC2086:info:1:12: Double quote to prevent globbing and word splitting
(shellcheck)
73-73: "github.event.pull_request.head.ref" is potentially untrusted. avoid using it directly in inline scripts. instead, pass it through an environment variable. see https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions for more details
(expression)
190-190: shellcheck reported issue in this script: SC2043:warning:1:13: This loop will only ever run once. Bad quoting or missing glob/expansion?
(shellcheck)
Additional comments not posted (390)
.prettierrc (1)
2-3
: Prettier configuration update approved.The addition of
"endOfLine": "auto"
enhances cross-platform compatibility by automatically handling line endings..husky/post-merge (1)
1-4
: Husky post-merge hook approved.This script ensures that dependencies are updated after a merge if
package.json
has changed, which helps maintain a consistent development environment.scripts/githooks/update-toc.js (1)
14-14
: Script execution feedback approved.The console log provides useful feedback after the script execution, confirming that the table of contents has been updated.
public/locales/hi/errors.json (8)
2-2
: Translation is accurate.The message "तलवा-एपीआई सेवा उपलब्ध नहीं है!" is correctly translated.
3-3
: Translation is accurate.The message "नहीं मिला" is correctly translated.
4-4
: Translation and placeholder are accurate.The message "एक अज्ञात त्रुटि हुई। {{msg}}" is correctly translated and formatted.
5-5
: Translation is accurate.The message "क्षमा मांगना!" is correctly translated.
6-6
: Translation is accurate.The message "मेल भेजने में त्रुटि" is correctly translated.
7-7
: Translation is accurate.The message "ईमेल पंजीकृत नहीं है" is correctly translated.
8-8
: Translation is accurate.The message "उफ़!" is correctly translated.
9-9
: Translation and placeholder are accurate.The message "एक त्रुटि हुई। {{entity}} नहीं बना सके" is correctly translated and formatted.
src/Constant/constant.ts (6)
1-1
: Caution: Storing sensitive information.Ensure that
AUTH_TOKEN
is not used to store sensitive information directly in the codebase.
2-2
: Environment variable usage is correct.
BACKEND_URL
is correctly initialized withprocess.env.REACT_APP_TALAWA_URL
.
3-3
: Environment variable usage is correct.
RECAPTCHA_SITE_KEY
is correctly initialized withprocess.env.REACT_APP_RECAPTCHA_SITE_KEY
.
4-4
: Environment variable usage is correct.
REACT_APP_USE_RECAPTCHA
is correctly initialized withprocess.env.REACT_APP_USE_RECAPTCHA
.
5-5
: Environment variable usage is correct.
REACT_APP_CUSTOM_PORT
is correctly initialized withprocess.env.PORT
.
6-7
: Environment variable usage is correct.
REACT_APP_BACKEND_WEBSOCKET_URL
is correctly initialized with a fallback to an empty string..coderabbit.yaml (5)
2-2
: Language setting is appropriate.The language is set to "en-US".
3-3
: Early access setting is appropriate.The early access is set to false.
4-10
: Review configuration settings are appropriate.The review settings are correctly configured.
11-15
: Auto-review configuration settings are appropriate.The auto-review settings are correctly configured.
16-17
: Chat configuration settings are appropriate.The chat settings are correctly configured.
public/manifest.json (2)
13-13
: Verify the updated image size.The
sizes
attribute forlogo192.png
has been changed to "16x16". Ensure this change aligns with your application's requirements for icon display.
16-16
: Ensure the updated image path is correct.The
src
path forlogo512.png
has been updated to include theimages/
directory. Verify that this path is correct and that the image exists at the specified location..gitignore (5)
3-5
: Ensure lock files are correctly ignored.The addition of
yarn.lock
andpnpm-lock.yaml
entries helps manage dependency lock files. Verify that these entries align with your project's package management strategy.
13-14
: Update testing coverage ignore pattern.The change from
-/coverage
tocoverage/
reflects a more standard ignore pattern for coverage directories. Ensure this aligns with your project's directory structure.
21-21
: Verify environment file ignore entries.The addition of
.env
and related entries helps exclude environment configuration files. Ensure this aligns with your project's configuration management practices.
31-32
: Confirm log file ignore entries.The addition of
debug.log
under express setup helps exclude runtime log files. Verify that this aligns with your project's logging practices.
34-37
: Ensure editor-specific files are ignored.The addition of
.idea
,.vscode
, and*.swp
entries helps exclude IDE-specific files. Verify that these entries align with your team's development environment practices.scripts/config-overrides/custom_build.js (3)
1-1
: Ensure dotenv configuration is necessary.The use of
dotenv
to load environment variables is common. Verify that this is necessary for your project's configuration.
7-8
: Clarify the purpose of custom build command.The comment indicates the use of
react-app-rewired
. Ensure that the purpose of this custom build command is well-documented and aligns with your project's build requirements.
10-16
: Verify the build command logic.The script uses an environment variable
ALLOW_LOGS
to decide which build command to execute. Ensure that this logic aligns with your project's build and logging requirements.src/assets/scss/app.scss (1)
1-14
: SCSS Imports Look Good!The SCSS imports are well-organized and correctly structured. The file imports Bootstrap functions, mixins, variables, and custom overrides in a logical order.
src/GraphQl/Queries/ActionItemCategoryQueries.ts (1)
1-18
: GraphQL Query is Well-Structured!The GraphQL query is well-documented and follows best practices. The use of
gql
fromgraphql-tag
is appropriate, and the query structure is clear and concise.scripts/custom-test-env.js (1)
1-16
: Custom Jest Environment is Correctly Implemented!The custom Jest environment correctly extends
jest-environment-jsdom
and provides a polyfill forTextEncoder
andTextDecoder
. The setup method is appropriately overridden to ensure compatibility during testing.scripts/config-overrides/custom_start.js (2)
1-5
: Environment variable setup looks good.The use of
dotenv
for environment variables and setting a default port is appropriate.
10-18
: Ensure secure handling of environment variables.Using
spawn
withshell: true
can be risky if inputs are not controlled. Ensure thatALLOW_LOGS
is securely set and not influenced by user input.src/GraphQl/Queries/AgendaCategoryQueries.ts (1)
1-23
: GraphQL query and documentation look good.The query is well-structured, and the documentation provides clear information about its purpose and parameters.
src/GraphQl/Mutations/AgendaItemMutations.ts (1)
1-31
: GraphQL mutations are well-defined.The mutations for creating, deleting, and updating agenda items are correctly structured, and the use of input types is appropriate.
src/assets/scss/components/_close.scss (1)
1-12
: SCSS variables for close button styling look good.The SCSS variables are well-organized and follow a consistent naming convention. The use of a data URL for the SVG icon is efficient for small icons.
src/assets/scss/components/_card.scss (1)
1-19
: SCSS variables for card component styling look good.The SCSS variables are well-organized and follow a consistent naming convention. The use of CSS variables for dynamic styling is a good practice.
scripts/config-overrides/index.js (1)
1-29
: Webpack configuration overrides look good.The use of
customize-cra
to add aProgressPlugin
and modify infrastructure logging is well-implemented. The code is clear and follows best practices.src/Constant/constant.spec.ts (1)
1-28
: Tests look good! Verify environment variable setup.The tests correctly verify the constants against expected values and environment variables.
Ensure that the environment variables are correctly set in the test environment to avoid false negatives.
Run the following script to check if the environment variables are set:
src/GraphQl/Mutations/ActionItemCategoryMutations.ts (1)
1-39
: GraphQL mutations are well-defined. Verify server support.The mutations for creating and updating action item categories are correctly defined with necessary parameters.
Ensure that the GraphQL server supports these mutations to avoid runtime errors.
Run the following script to check if the mutations are supported by the server:
src/assets/scss/_general.scss (5)
5-9
: Ensure consistent use of box-sizing property.The universal selector sets
box-sizing: border-box;
, which is a good practice for consistent layout behavior. Ensure this is applied consistently across all components.
11-13
: Verify the necessity of overflow-x: hidden on html.While
overflow-x: hidden;
prevents horizontal scrolling, ensure it doesn't inadvertently hide important content or affect accessibility.
15-17
: Verify the background color variable usage.Ensure that
--bs-body-bg
is defined elsewhere in the codebase to avoid potential issues with undefined variables.
24-26
: Ensure accessibility for scaled checkboxes.Scaling checkboxes can affect accessibility. Verify that they remain accessible and usable across different devices and screen readers.
34-43
: Optimize the shimmer effect for performance.The shimmer effect uses a large background size and infinite animation. Ensure this doesn't impact performance, especially on lower-end devices.
.github/workflows/codeql-codescan.yml (3)
12-20
: Ensure the workflow triggers align with project requirements.The workflow triggers on all branches for both push and pull request events. Verify this aligns with your project's CI/CD strategy.
31-31
: Ensure the checkout action version is up-to-date.The workflow uses
actions/checkout@v4
. Verify that this is the latest stable version to ensure compatibility and security.
33-37
: Verify the necessity of debug mode.Debug mode is enabled for CodeQL initialization. Ensure this is necessary for your analysis needs, as it may produce verbose output.
src/GraphQl/Mutations/AgendaCategoryMutations.ts (3)
9-15
: Ensure input validation and error handling for create mutation.Verify that the backend properly validates the
CreateAgendaCategoryInput
and handles errors gracefully.
23-27
: Ensure proper error handling for delete mutation.Verify that the backend handles errors correctly when deleting an agenda category, especially if the ID does not exist.
36-45
: Ensure input validation and error handling for update mutation.Verify that the backend properly validates the
UpdateAgendaCategoryInput
and handles errors gracefully.src/GraphQl/Mutations/CommentMutations.ts (3)
37-43
: LGTM!The
LIKE_COMMENT
mutation is straightforward and appears correct.
52-58
: LGTM!The
UNLIKE_COMMENT
mutation is straightforward and appears correct.
11-28
: Verify the mutation schema and security.Ensure that the mutation aligns with the GraphQL schema and that sensitive information, such as user email, is handled appropriately.
Run the following script to verify the mutation schema and check for sensitive information exposure:
src/GraphQl/Queries/AgendaItemQueries.ts (2)
3-37
: Verify the query schema and security.Ensure that the query aligns with the GraphQL schema and that sensitive information is handled appropriately.
Run the following script to verify the query schema and check for sensitive information exposure:
39-73
: Verify the query schema and security.Ensure that the query aligns with the GraphQL schema and that sensitive information is handled appropriately.
Run the following script to verify the query schema and check for sensitive information exposure:
.github/workflows/issue.yml (2)
17-26
: Verify the action version and label appropriateness.Ensure that the
auto-label
action versionv2.3.0
is compatible and that the default labels are appropriate for your project.Run the following script to verify the action version and label appropriateness:
27-34
: Verify the greeting message content.Ensure that the greeting message content is appropriate and aligns with the project's guidelines.
Run the following script to verify the message content:
Verification successful
The greeting message content is appropriate and aligns with the project's guidelines. The message successfully guides new contributors to review the contributing and issue reporting guidelines. No changes are necessary.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the greeting message content. # Test: Check the message content. Expect: Appropriateness and alignment with guidelines. rg --type yaml -A 3 $'issue-message: "Congratulations on making your first Issue!'Length of output: 83
Script:
#!/bin/bash # Using ast-grep to search for the issue-message key in YAML files to verify the greeting message content. ast-grep --lang yaml --pattern 'issue-message: $_'Length of output: 161
Script:
#!/bin/bash # Using rg to search for the issue-message key in the specific YAML file to verify the greeting message content. rg 'issue-message:' .github/workflows/issue.yml -A 3Length of output: 491
src/assets/scss/components/_carousel.scss (1)
1-27
: SCSS variables for carousel components are well-structured.The SCSS file is well-organized, with descriptive variable names and efficient use of SVG for icons.
src/GraphQl/Mutations/EventAttendeeMutations.ts (1)
1-49
: GraphQL mutations are well-documented and follow best practices.The mutations for adding, removing, and checking in attendees are clear and well-documented.
.github/pull_request_template.md (1)
Line range hint
1-53
: The pull request template changes look good!The instructions are clear and comprehensive, effectively guiding contributors through the pull request process.
src/GraphQl/Mutations/VenueMutations.ts (1)
67-71
: TheDELETE_VENUE_MUTATION
is correctly defined.The mutation and its documentation comment are accurate.
src/GraphQl/Queries/fundQueries.ts (3)
11-37
: LGTM! TheFUND_LIST
query is well-structured.The query retrieves a list of funds for a specific organization with optional filtering and ordering, which aligns with best practices.
39-56
: LGTM! TheFUND_CAMPAIGN
query is well-structured.The query retrieves campaigns associated with a specific fund, using optional filtering and ordering, which aligns with best practices.
58-81
: LGTM! TheFUND_CAMPAIGN_PLEDGE
query is well-structured.The query retrieves details of a fundraising campaign and its pledges, using ordering, which aligns with best practices.
src/assets/scss/components/_accordion.scss (1)
1-36
: LGTM! The SCSS variables and styles are well-defined.The SCSS variables for the accordion component are well-structured and use CSS custom properties for theming, which aligns with best practices.
.github/workflows/stale.yml (1)
1-43
: LGTM! The GitHub Actions workflow is well-configured.The workflow to mark stale issues and pull requests is well-structured, with appropriate messages, labels, and settings.
jest.config.js (1)
1-67
: Jest configuration looks good.The configuration is comprehensive and aligns with best practices for setting up Jest in a project.
public/locales/zh/common.json (1)
1-86
: Chinese translations are comprehensive and accurate.The translations cover a wide range of terms and appear to be correct.
src/assets/scss/components/_buttons.scss (1)
1-73
: SCSS styling is well-structured and follows best practices.The use of variables and consistent naming conventions enhances maintainability and customization.
src/GraphQl/Mutations/PledgeMutation.ts (3)
14-36
: LGTM! CREATE_PLEDGE mutation is well-structured.The mutation is correctly defined and well-documented.
48-70
: LGTM! UPDATE_PLEDGE mutation supports flexible updates.The mutation is correctly defined and allows for partial updates.
78-84
: LGTM! DELETE_PLEDGE mutation is straightforward and correct.The mutation is correctly defined and well-documented.
src/GraphQl/Mutations/FundMutation.ts (1)
79-85
: LGTM! REMOVE_FUND_MUTATION is straightforward and correct.The mutation is correctly defined and well-documented.
src/GraphQl/Mutations/CampaignMutation.ts (3)
15-37
: LGTM! CREATE_CAMPAIGN_MUTATION is well-structured.The mutation is correctly defined and well-documented.
51-73
: LGTM! UPDATE_CAMPAIGN_MUTATION supports flexible updates.The mutation is correctly defined and allows for partial updates.
81-87
: LGTM! DELETE_CAMPAIGN_MUTATION is straightforward and correct.The mutation is correctly defined and well-documented.
src/GraphQl/Mutations/ActionItemMutations.ts (3)
13-33
: LGTM! TheCREATE_ACTION_ITEM_MUTATION
is well-structured.The mutation correctly includes all necessary fields and types for creating an action item.
47-71
: LGTM! TheUPDATE_ACTION_ITEM_MUTATION
is comprehensive.The mutation correctly includes all necessary fields and types for updating an action item.
79-85
: LGTM! TheDELETE_ACTION_ITEM_MUTATION
is straightforward.The mutation correctly uses the ID to delete an action item.
src/GraphQl/Queries/ActionItemQueries.ts (2)
15-66
: LGTM! TheACTION_ITEM_LIST
query is comprehensive.The query correctly includes filtering and sorting options for retrieving action items by organization.
68-103
: LGTM! TheACTION_ITEM_LIST_BY_EVENTS
query is well-structured.The query correctly retrieves action items associated with a specific event.
public/locales/en/common.json (1)
1-86
: LGTM! The localization strings are well-structured and consistent.All strings are correctly formatted and adhere to typical localization practices.
public/locales/sp/common.json (1)
1-86
: Translations look good!The Spanish translations are consistent and appear correct for the given keys.
scripts/githooks/check-localstorage-usage.js (5)
1-5
: Shebang and imports are appropriate.The shebang line and imported modules are correct for a Node.js script.
10-18
:containsSkipComment
function is well-implemented.The function correctly checks for a skip comment and handles errors.
20-37
:getModifiedFiles
function is well-implemented.The function correctly retrieves files based on the provided flag and handles errors.
43-78
:checkLocalStorageUsage
function is well-implemented.The function correctly checks for localStorage usage and handles errors and non-existent files.
80-95
: Main logic and error handling are well-implemented.The script processes files correctly and provides clear error messages and suggestions.
.github/workflows/md_mdx_format_adjuster.py (4)
1-14
: Shebang, encoding, and docstring are appropriate.The shebang line, encoding specification, and docstring provide a clear overview of the script.
20-44
:escape_mdx_characters
function is well-implemented.The function correctly escapes special characters for MDX compatibility.
46-66
:process_file
function is well-implemented.The function correctly processes files for MDX compatibility and handles file operations.
67-97
: Main function and argument parsing are well-implemented.The main function correctly processes Markdown files and implements argument parsing using argparse.
ISSUE_GUIDELINES.md (2)
8-19
: Table of Contents is well-structured.The table of contents is clear and well-organized.
48-50
: Feature Request Guidelines are clear.The guidelines for submitting feature requests are well-written and concise.
src/App.test.tsx (3)
2-13
: Imports and setup are well-organized.The imports and setup for the test environment are appropriate and comprehensive.
69-94
: Test case for logged-in user is well-structured.The test case effectively verifies the rendering of the
App
component for a logged-in user.
96-110
: Test case for logged-out user is concise.The test case effectively verifies the rendering of the
App
component for a logged-out user..github/workflows/pull-request-target.yml (2)
17-68
: PR-Greeting job is well-defined.The job effectively adds a PR review policy comment to pull requests.
69-73
: Greeting Message to User job is well-implemented.The job sends a welcoming message to users making their first PR.
README.md (4)
3-5
: Community link and logo addition look good.The addition of the Slack invitation link and the logo enhances community engagement and branding.
10-10
: Code coverage badge addition looks good.The addition of the Codecov badge provides valuable insights into code quality.
24-32
: Table of contents addition looks good.The addition of the table of contents enhances document navigation and accessibility.
45-51
: Documentation section restructuring looks good.The restructuring of the documentation section with numbered lists and additional links enhances readability and accessibility.
.github/workflows/eslint_disable_check.py (5)
29-41
:has_eslint_disable
function looks good.The function correctly checks for eslint-disable statements using regex.
43-68
:check_eslint
function looks good.The function effectively checks TypeScript files for eslint-disable statements in the specified directory.
70-84
:arg_parser_resolver
function looks good.The function correctly uses argparse to handle command-line arguments.
86-115
:main
function looks good.The function is well-organized and handles errors appropriately, serving as an effective entry point for the script.
117-118
: Script execution block looks good.The use of the
if __name__ == "__main__":
pattern is a standard practice for executing the main function in Python scripts..eslintrc.json (5)
4-4
: Node.js environment addition looks good.Adding Node.js support enhances the linting process to accommodate server-side JavaScript.
14-16
: Prettier integration in extends section looks good.The integration of Prettier ensures consistent code formatting and resolves potential conflicts with ESLint.
32-39
: Plugins addition looks good.The addition of plugins for import management and TypeScript documentation enhances linting capabilities.
Line range hint
41-140
: Rules section updates look good.The updates to the rules section reflect a move towards stricter linting practices and improved integration with TypeScript and Prettier.
Line range hint
144-150
: React version detection setting looks good.Allowing ESLint to use the React version specified in package.json ensures compatibility with the React version in use.
package.json (5)
2-5
: Metadata updates approved.The changes to the project name, version, and type field are consistent with the PR objectives and align with modern JavaScript practices.
8-59
: Dependencies updates approved.The added dependencies align with contemporary development practices and frameworks, enhancing the project's functionality.
62-76
: Scripts updates approved.The new scripts enhance the development workflow and align with the PR objectives.
97-132
: DevDependencies updates approved.The new devDependencies reflect a modern approach to development and code quality assurance.
134-147
: Additional fields updates approved.The new fields enforce specific versions of dependencies and enhance the project's maintainability.
PR_GUIDELINES.md (4)
7-17
: Table of Contents approved.The Table of Contents is well-structured and enhances document navigation.
19-24
: Pull Requests and Issues guidelines approved.The guidelines are clear and align with best practices for open-source contributions.
25-42
: Linting and Formatting guidelines approved.The guidelines are clear and promote code quality.
Tools
Markdownlint
31-31: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
39-39: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
44-69
: Testing and Pull Request Processing guidelines approved.The guidelines are comprehensive and align with the project's objectives.
Tools
LanguageTool
[style] ~46-~46: Style-wise, it’s not ideal to insert an adverb (‘manually’) in the middle of an infinitive construction (‘to test’). Try moving the adverb to avoid split infinitives.
Context: ..., you'll need to tell us what steps you followed to manually test your changes. 1. Please read our [CONTRIBUTING.md](C...(SPLIT_INFINITIVE)
[style] ~56-~56: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...o be closed. The quality of our code is very important to us. Therefore we make experienced ma...(EN_WEAK_ADJECTIVE)
[uncategorized] ~56-~56: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ...ty of our code is very important to us. Therefore we make experienced maintainers of our ...(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
[style] ~59-~59: Consider using a different verb for a more formal wording.
Context: ...check if all tests are passing; if not, fix the issues and then create a pull reque...(FIX_RESOLVE)
[style] ~64-~64: This expression is wordy and overused. Consider replacing it with a more concise and formal alternative.
Context: ...wer your questions, but we'll get to it sooner or later. @mentioning someone just adds to the p...(SOONER_OR_LATER)
[uncategorized] ~64-~64: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...adds to the pile of notifications we get and it won't make us look at your issue fas...(COMMA_COMPOUND_SENTENCE)
[style] ~65-~65: Consider shortening or rephrasing this to strengthen your wording.
Context: ...ue faster. 1. Do not force push. If you make changes to your pull request, please simply add a ...(MAKE_CHANGES)
CODE_OF_CONDUCT.md (1)
3-19
: Table of Contents addition approved.The addition enhances the document's accessibility and usability.
Tools
LanguageTool
[duplication] ~11-~11: Possible typo: you repeated a word
Context: ...-responsibilities) - Scope - Enforcement - Enforcement Guidelines ...(ENGLISH_WORD_REPEAT_RULE)
setup.ts (3)
1-8
: Imports are appropriate.The imported modules and functions are necessary for the setup process.
172-174
: Success message enhances user experience.The final message informs users of the successful setup completion, which is a good practice.
177-177
: Function invocation is appropriate.Calling
main()
at the end of the file is necessary to execute the setup process..github/workflows/compare_translations.py (4)
1-49
: Comprehensive docstring.The docstring provides a detailed overview of the script's purpose, methodology, and usage, adhering to documentation standards.
50-60
: Imports and named tuple are appropriate.The imported modules and the
FileTranslation
named tuple are necessary for the script's functionality.
92-109
: Functionload_translation
is well-implemented.The function correctly loads a translation from a file and includes appropriate error handling for JSON decoding errors.
159-186
: Functionmain
is well-implemented.The function correctly parses command-line arguments and calls
check_translations
, following best practices for command-line scripts..github/workflows/push.yml (4)
1-20
: Workflow metadata and triggers are appropriate.The workflow is correctly triggered on push events to any branch, and the environment variable for Codecov is appropriately set.
61-143
: Address shellcheck issues in the script.The Generate-Documentation job is well-structured, but there are shellcheck issues that need addressing to prevent potential bugs.
Here's how you might address them:
- echo "commit_id=$(echo $(git rev-parse HEAD))" >> $GITHUB_ENV - echo "email=$(echo $(git log --pretty=format:"%ae" $commit_id))" >> $GITHUB_ENV + commit_id=$(git rev-parse HEAD) + email=$(git log --pretty=format:"%ae" "$commit_id") + echo "commit_id=$commit_id" >> $GITHUB_ENV + echo "email=$email" >> $GITHUB_ENVTools
actionlint
116-116: shellcheck reported issue in this script: SC2086:info:2:28: Double quote to prevent globbing and word splitting
(shellcheck)
128-128: shellcheck reported issue in this script: SC2046:warning:1:24: Quote this to prevent word splitting
(shellcheck)
128-128: shellcheck reported issue in this script: SC2005:style:1:24: Useless echo? Instead of 'echo $(cmd)', just use 'cmd'
(shellcheck)
128-128: shellcheck reported issue in this script: SC2086:info:1:51: Double quote to prevent globbing and word splitting
(shellcheck)
128-128: shellcheck reported issue in this script: SC2046:warning:2:20: Quote this to prevent word splitting
(shellcheck)
128-128: shellcheck reported issue in this script: SC2005:style:2:20: Useless echo? Instead of 'echo $(cmd)', just use 'cmd'
(shellcheck)
128-128: shellcheck reported issue in this script: SC2086:info:2:52: Double quote to prevent globbing and word splitting
(shellcheck)
128-128: shellcheck reported issue in this script: SC2086:info:2:69: Double quote to prevent globbing and word splitting
(shellcheck)
150-168
: Empty-Commit job is correctly implemented.The job creates an empty commit to trigger the documentation workflow, which is appropriate for its purpose.
169-185
: Copy-docs-to-talawa-docs job is correctly implemented.The job copies documentation to another repository, which is appropriate for its purpose.
src/GraphQl/Mutations/OrganizationMutations.ts (17)
12-26
: LGTM!The mutation
UPDATE_USER_ROLE_IN_ORG_MUTATION
is well-defined and documented.
34-38
: LGTM!The mutation
CREATE_SAMPLE_ORGANIZATION_MUTATION
is well-defined and documented.
46-50
: LGTM!The mutation
REMOVE_SAMPLE_ORGANIZATION_MUTATION
is well-defined and documented.
60-76
: LGTM!The mutation
CREATE_GROUP_CHAT
is well-defined and documented.
78-86
: LGTM!The mutation
CREATE_DIRECT_CHAT
is well-defined and documented.
88-107
: LGTM!The mutation
SEND_MESSAGE_TO_DIRECT_CHAT
is well-defined and documented.
109-123
: LGTM!The mutation
SEND_MESSAGE_TO_GROUP_CHAT
is well-defined and documented.
125-141
: LGTM!The mutation
CREATE_MESSAGE_CHAT
is well-defined and documented.
143-165
: LGTM!The subscription
MESSAGE_SENT_TO_DIRECT_CHAT
is well-defined and documented.
167-183
: LGTM!The subscription
MESSAGE_SENT_TO_GROUP_CHAT
is well-defined and documented.
193-202
: LGTM!The subscription
PLUGIN_SUBSCRIPTION
is well-defined and documented.
211-217
: LGTM!The mutation
TOGGLE_PINNED_POST
is well-defined and documented.
228-239
: LGTM!The mutation
ADD_CUSTOM_FIELD
is well-defined and documented.
251-261
: LGTM!The mutation
REMOVE_CUSTOM_FIELD
is well-defined and documented.
263-276
: LGTM!The mutation
SEND_MEMBERSHIP_REQUEST
is well-defined and documented.
278-284
: LGTM!The mutation
JOIN_PUBLIC_ORGANIZATION
is well-defined and documented.
286-292
: LGTM!The mutation
CANCEL_MEMBERSHIP_REQUEST
is well-defined and documented.src/GraphQl/Queries/OrganizationQueries.ts (8)
15-72
: LGTM!The query
ORGANIZATION_POST_LIST
is well-defined and documented.
74-110
: LGTM!The query
ORGANIZATION_ADVERTISEMENT_LIST
is well-defined and documented.
122-169
: LGTM!The query
USER_ORGANIZATION_CONNECTION
is well-defined and documented.
178-207
: LGTM!The query
USER_JOINED_ORGANIZATIONS
is well-defined and documented.
216-245
: LGTM!The query
USER_CREATED_ORGANIZATIONS
is well-defined and documented.
254-267
: LGTM!The query
ORGANIZATION_ADMINS_LIST
is well-defined and documented.
275-289
: LGTM!The query
ORGANIZATION_FUNDS
is well-defined and documented.
297-320
: LGTM!The query
VENUE_LIST
is well-defined and documented.src/GraphQl/Queries/PlugInQueries.ts (10)
9-19
: LGTM!The query
PLUGIN_GET
is well-defined and documented.
27-45
: LGTM!The query
ADVERTISEMENTS_GET
is well-defined and documented.
59-100
: LGTM!The query
ORGANIZATION_EVENTS_CONNECTION
is well-defined and documented.
111-133
: LGTM!The query
DIRECT_CHAT_MESSAGES_BY_CHAT_ID
is well-defined and documented.
135-167
: LGTM!The query
DIRECT_CHAT_BY_ID
is well-defined and documented.
169-196
: LGTM!The query
GROUP_CHAT_BY_ID
is well-defined and documented.
222-262
: LGTM!The query
DIRECT_CHATS_LIST
is well-defined and documented.
264-299
: LGTM!The query
GROUP_CHAT_LIST
is well-defined and documented.
307-311
: LGTM!The query
IS_SAMPLE_ORGANIZATION_QUERY
is well-defined and documented.
320-328
: LGTM!The query
ORGANIZATION_CUSTOM_FIELDS
is well-defined and documented.src/App.tsx (3)
51-90
: Verify use ofuseQuery
hook.Ensure that the
useQuery
hook is correctly implemented and that theCHECK_AUTH
query is defined and imported correctly.Run the following script to verify the
CHECK_AUTH
query:Verification successful
Verified:
CHECK_AUTH
query is correctly implemented and imported.The
CHECK_AUTH
query is defined insrc/GraphQl/Queries/Queries.ts
and is correctly imported and used insrc/App.tsx
and other relevant files. No issues found with its implementation or usage.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the `CHECK_AUTH` query implementation. # Test: Search for the `CHECK_AUTH` query in the codebase. Expect: Query should be defined and imported. rg --type graphql --type ts --type tsx 'CHECK_AUTH'Length of output: 83
Script:
#!/bin/bash # Description: Verify the `CHECK_AUTH` query implementation. # Test: Search for the `CHECK_AUTH` query in the codebase. Expect: Query should be defined and imported. rg --type ts --type tsx 'CHECK_AUTH'Length of output: 64
Script:
#!/bin/bash # Description: Verify the `CHECK_AUTH` query implementation. # Test: Search for the `CHECK_AUTH` query in the codebase. Expect: Query should be defined and imported. rg 'CHECK_AUTH'Length of output: 790
114-185
: Validate routing logic.Ensure that the routing logic is correctly implemented and that all paths are valid and lead to the correct components.
Run the following script to verify routing paths:
92-112
: Ensure dynamic routes are correctly implemented.Verify that the dynamic routes for plugins are correctly set up and that the components are available.
Run the following script to check dynamic route components:
Verification successful
Dynamic routes for plugins are correctly implemented.
The components
DummyPlugin
andDummyPlugin2
are available and properly referenced in the codebase. They are imported and exported in the plugins index file, and there are associated test files, indicating correct setup and usage.
src/components/plugins/index.ts
imports and exportsDummyPlugin
andDummyPlugin2
.- Test files exist for both components, confirming their presence and usage.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of dynamic route components. # Test: Check if all dynamic route components exist. Expect: All components should be valid. fd --type f --exec echo "Component exists: {}" || echo "Component not found: {}"Length of output: 67462
Script:
#!/bin/bash # Searching for the DummyPlugin component in the codebase rg 'DummyPlugin' --type tsx # Searching for the DummyPlugin2 component in the codebase rg 'DummyPlugin2' --type tsxLength of output: 112
Script:
#!/bin/bash # Searching for the DummyPlugin component in all files with context rg 'DummyPlugin' -A 3 # Searching for the DummyPlugin2 component in all files with context rg 'DummyPlugin2' -A 3Length of output: 11064
CODE_STYLE.md (1)
53-53
: Clarify the guideline on return fragments.The guideline about closing return fragments in empty tags is unclear.
Ensure that this guideline is necessary and clarify its purpose. If it's a React-specific guideline, consider rephrasing to: "Wrap return fragments in empty tags when necessary."
src/GraphQl/Queries/Queries.ts (16)
5-29
: Ensure proper error handling forCHECK_AUTH
query.The
CHECK_AUTH
query retrieves sensitive user information. Ensure that proper error handling and access control mechanisms are in place when this query is used in the application.
63-103
: Verify filter and sort options inORGANIZATION_CONNECTION_LIST
.Ensure that the filter and sort options are correctly implemented and tested in the application to provide accurate and expected results.
105-201
: Ensure input validation forUSER_LIST
query.The
USER_LIST
query accepts several input parameters. Ensure that input validation is implemented to prevent potential injection attacks.
222-263
: Ensure input validation forUSER_LIST_REQUEST
query.Similar to
USER_LIST
, ensure that input validation is implemented forUSER_LIST_REQUEST
to prevent potential injection attacks.
265-290
: Ensure proper error handling forEVENT_DETAILS
query.The
EVENT_DETAILS
query retrieves event information. Ensure that proper error handling and access control mechanisms are in place when this query is used.
304-322
: Ensure proper error handling forEVENT_CHECKINS
query.The
EVENT_CHECKINS
query retrieves check-in status. Ensure that proper error handling and access control mechanisms are in place when this query is used.
324-336
: Ensure proper error handling forEVENT_FEEDBACKS
query.The
EVENT_FEEDBACKS
query retrieves feedback information. Ensure that proper error handling and access control mechanisms are in place when this query is used.
414-438
: Ensure input validation forBLOCK_PAGE_MEMBER_LIST
query.The
BLOCK_PAGE_MEMBER_LIST
query accepts several input parameters. Ensure that input validation is implemented to prevent potential injection attacks.
470-482
: Ensure proper error handling forUSER_ORGANIZATION_LIST
query.The
USER_ORGANIZATION_LIST
query retrieves organizations joined by a user. Ensure that proper error handling and access control mechanisms are in place when this query is used.
484-539
: Ensure proper error handling forUSER_DETAILS
query.The
USER_DETAILS
query retrieves detailed user information. Ensure that proper error handling and access control mechanisms are in place when this query is used.
561-604
: Ensure input validation forORGANIZATION_EVENT_CONNECTION_LIST
query.The
ORGANIZATION_EVENT_CONNECTION_LIST
query accepts several input parameters. Ensure that input validation is implemented to prevent potential injection attacks.
606-624
: Ensure input validation forORGANIZATION_DONATION_CONNECTION_LIST
query.The
ORGANIZATION_DONATION_CONNECTION_LIST
query accepts several input parameters. Ensure that input validation is implemented to prevent potential injection attacks.
643-668
: Ensure input validation forMEMBERSHIP_REQUEST
query.The
MEMBERSHIP_REQUEST
query accepts several input parameters. Ensure that input validation is implemented to prevent potential injection attacks.
670-757
: Ensure input validation forUSERS_CONNECTION_LIST
query.The
USERS_CONNECTION_LIST
query accepts several input parameters. Ensure that input validation is implemented to prevent potential injection attacks.
759-778
: Ensure proper error handling forGET_COMMUNITY_DATA
query.The
GET_COMMUNITY_DATA
query retrieves community data. Ensure that proper error handling and access control mechanisms are in place when this query is used.
780-813
: Ensure proper import paths for exported queries.Ensure that the import paths for the exported queries are correct and the files exist in the specified locations.
src/GraphQl/Mutations/mutations.ts (40)
3-9
: Ensure proper error handling forUNBLOCK_USER_MUTATION
.The
UNBLOCK_USER_MUTATION
mutation modifies user access. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
13-19
: Ensure proper error handling forBLOCK_USER_MUTATION
.The
BLOCK_USER_MUTATION
mutation modifies user access. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
23-29
: Ensure proper error handling forREJECT_ORGANIZATION_REQUEST_MUTATION
.The
REJECT_ORGANIZATION_REQUEST_MUTATION
mutation modifies membership requests. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
33-39
: Ensure proper error handling forACCEPT_ORGANIZATION_REQUEST_MUTATION
.The
ACCEPT_ORGANIZATION_REQUEST_MUTATION
mutation modifies membership requests. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
43-67
: Ensure proper error handling forUPDATE_ORGANIZATION_MUTATION
.The
UPDATE_ORGANIZATION_MUTATION
mutation modifies organization details. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
69-81
: Ensure proper usage ofADDRESS_DETAILS_FRAGMENT
.The
ADDRESS_DETAILS_FRAGMENT
defines an address input type. Ensure that it is used correctly in the application and that the fragment is included where necessary.
85-121
: Ensure proper error handling forUPDATE_USER_MUTATION
.The
UPDATE_USER_MUTATION
mutation modifies user details. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
125-143
: Ensure proper error handling forUPDATE_USER_PASSWORD_MUTATION
.The
UPDATE_USER_PASSWORD_MUTATION
mutation modifies user passwords. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
147-171
: Ensure proper error handling forSIGNUP_MUTATION
.The
SIGNUP_MUTATION
mutation handles user registration. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
175-196
: Ensure proper error handling forLOGIN_MUTATION
.The
LOGIN_MUTATION
mutation handles user login. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
200-207
: Ensure proper error handling forREFRESH_TOKEN_MUTATION
.The
REFRESH_TOKEN_MUTATION
mutation handles token refresh. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
211-215
: Ensure proper error handling forREVOKE_REFRESH_TOKEN
.The
REVOKE_REFRESH_TOKEN
mutation handles token revocation. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
219-223
: Ensure proper error handling forRECAPTCHA_MUTATION
.The
RECAPTCHA_MUTATION
mutation handles reCAPTCHA verification. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
227-249
: Ensure proper error handling forCREATE_ORGANIZATION_MUTATION
.The
CREATE_ORGANIZATION_MUTATION
mutation handles organization creation. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
253-261
: Ensure proper error handling forDELETE_ORGANIZATION_MUTATION
.The
DELETE_ORGANIZATION_MUTATION
mutation handles organization deletion. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
265-315
: Ensure proper error handling forCREATE_EVENT_MUTATION
.The
CREATE_EVENT_MUTATION
mutation handles event creation. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
319-328
: Ensure proper error handling forDELETE_EVENT_MUTATION
.The
DELETE_EVENT_MUTATION
mutation handles event deletion. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
331-337
: Ensure proper error handling forREMOVE_ADMIN_MUTATION
.The
REMOVE_ADMIN_MUTATION
mutation handles admin removal. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
339-346
: Ensure proper error handling forREMOVE_MEMBER_MUTATION
.The
REMOVE_MEMBER_MUTATION
mutation handles member removal. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
349-357
: Ensure proper error handling forADD_ADMIN_MUTATION
.The
ADD_ADMIN_MUTATION
mutation handles admin addition. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
359-367
: Ensure proper error handling forADD_MEMBER_MUTATION
.The
ADD_MEMBER_MUTATION
mutation handles member addition. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
369-393
: Ensure proper error handling forCREATE_POST_MUTATION
.The
CREATE_POST_MUTATION
mutation handles post creation. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
395-401
: Ensure proper error handling forDELETE_POST_MUTATION
.The
DELETE_POST_MUTATION
mutation handles post deletion. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
403-409
: Ensure proper error handling forGENERATE_OTP_MUTATION
.The
GENERATE_OTP_MUTATION
mutation handles OTP generation. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
411-425
: Ensure proper error handling forFORGOT_PASSWORD_MUTATION
.The
FORGOT_PASSWORD_MUTATION
mutation handles password reset. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
427-442
: Ensure proper error handling forUPDATE_INSTALL_STATUS_PLUGIN_MUTATION
.The
UPDATE_INSTALL_STATUS_PLUGIN_MUTATION
mutation modifies plugin status. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
444-459
: Ensure proper error handling forUPDATE_ORG_STATUS_PLUGIN_MUTATION
.The
UPDATE_ORG_STATUS_PLUGIN_MUTATION
mutation modifies plugin status. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
461-483
: Ensure proper error handling forADD_PLUGIN_MUTATION
.The
ADD_PLUGIN_MUTATION
mutation handles plugin creation. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
484-508
: Ensure proper error handling forADD_ADVERTISEMENT_MUTATION
.The
ADD_ADVERTISEMENT_MUTATION
mutation handles advertisement creation. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
509-533
: Ensure proper error handling forUPDATE_ADVERTISEMENT_MUTATION
.The
UPDATE_ADVERTISEMENT_MUTATION
mutation handles advertisement updates. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
534-542
: Ensure proper error handling forDELETE_ADVERTISEMENT_BY_ID
.The
DELETE_ADVERTISEMENT_BY_ID
mutation handles advertisement deletion. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
543-563
: Ensure proper error handling forUPDATE_POST_MUTATION
.The
UPDATE_POST_MUTATION
mutation handles post updates. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
565-617
: Ensure proper error handling forUPDATE_EVENT_MUTATION
.The
UPDATE_EVENT_MUTATION
mutation handles event updates. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
619-625
: Ensure proper error handling forLIKE_POST
.The
LIKE_POST
mutation handles post likes. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
627-633
: Ensure proper error handling forUNLIKE_POST
.The
UNLIKE_POST
mutation handles post unlikes. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
635-641
: Ensure proper error handling forREGISTER_EVENT
.The
REGISTER_EVENT
mutation handles event registration. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
643-647
: Ensure proper error handling forUPDATE_COMMUNITY
.The
UPDATE_COMMUNITY
mutation handles community updates. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
649-653
: Ensure proper error handling forRESET_COMMUNITY
.The
RESET_COMMUNITY
mutation handles community reset. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
655-678
: Ensure proper error handling forDONATE_TO_ORGANIZATION
.The
DONATE_TO_ORGANIZATION
mutation handles donations. Ensure that proper error handling and access control mechanisms are in place when this mutation is used.
680-737
: Ensure proper import paths for exported mutations.Ensure that the import paths for the exported mutations are correct and the files exist in the specified locations.
public/locales/zh/translation.json (9)
27-41
: Translations foruserLoginPage
are consistent and correct.The translations are consistent with the
loginPage
section and appear accurate.
43-46
: Translations forlatestEvents
are correct and contextually appropriate.The translations accurately reflect the intended meaning for event-related strings.
48-51
: Translations forlatestPosts
are correct and contextually appropriate.The translations accurately reflect the intended meaning for post-related strings.
53-54
: Translation forlistNavbar
is correct.The translation for "roles" is accurate and contextually appropriate.
56-59
: Translations forleftDrawer
are correct and contextually appropriate.The translations accurately reflect the intended meaning for navigation items.
61-78
: Translations forleftDrawerOrg
are correct and contextually appropriate.The translations accurately reflect the intended meaning for organization-related navigation items.
80-108
: Translations fororgList
are correct and contextually appropriate.The translations accurately reflect the intended meaning for organization list-related strings.
110-112
: Translations fororgListCard
are correct and contextually appropriate.The translations accurately reflect the intended meaning for organization card-related strings.
114-116
: Translations forpaginationList
are correct and contextually appropriate.The translations accurately reflect the intended meaning for pagination-related strings.
schema.graphql (114)
1-3
: Directives look good.The directives
@auth
and@role
are correctly defined for use onFIELD_DEFINITION
.
5-20
: TypeActionItem
is well-structured.The fields are appropriately defined for an action item, with correct data types.
22-30
: TypeActionItemCategory
is well-defined.The fields align well with the concept of an action item category.
32-41
: TypeAddress
is comprehensive.The fields cover essential components of an address.
43-52
: InputAddressInput
is correctly structured.It mirrors the
Address
type, allowing for input of address components.
54-65
: TypeAdvertisement
is well-structured.The fields align well with the concept of an advertisement.
67-71
: EnumAdvertisementType
is appropriate.The values are suitable for categorizing advertisement types.
73-76
: TypeAdvertisementEdge
is correctly structured.The fields are suitable for use in pagination.
78-82
: TypeAdvertisementsConnection
is well-structured.The fields are suitable for managing paginated advertisement data.
84-93
: TypeAgendaCategory
is well-defined.The fields align well with the concept of an agenda category.
95-97
: TypeAggregatePost
is correctly defined.The
count
field is suitable for aggregating post data.
99-101
: TypeAggregateUser
is correctly defined.The
count
field is suitable for aggregating user data.
105-115
: TypeAppUserProfile
is well-structured.The fields align well with the concept of a user profile in an app.
117-121
: TypeAuthData
is well-defined.The fields are suitable for authentication data.
124-134
: TypeCheckIn
is well-structured.The fields align well with the concept of a check-in.
136-141
: InputCheckInInput
is correctly structured.It is suitable for accepting check-in data.
143-147
: TypeCheckInStatus
is well-defined.The fields are suitable for representing the status of a check-in.
149-157
: TypeComment
is well-structured.The fields align well with the concept of a comment.
160-162
: InputCommentInput
is correctly defined.The
text
field is suitable for creating a comment.
164-164
: UnionConnectionError
is correctly defined.The union is suitable for handling connection errors.
166-170
: TypeConnectionPageInfo
is well-structured.The fields are suitable for pagination information.
175-180
: InputCreateActionItemInput
is correctly structured.It is suitable for creating an action item.
182-186
: InputCreateAgendaCategoryInput
is correctly structured.It is suitable for creating an agenda category.
188-192
: InputCreateUserTagInput
is correctly structured.It is suitable for creating a user tag.
194-198
: InputCursorPaginationInput
is well-structured.It is suitable for cursor-based pagination.
204-206
: TypeDeletePayload
is correctly defined.The
success
field is suitable for representing the result of a delete operation.
208-214
: TypeDirectChat
is well-structured.The fields align well with the concept of a direct chat.
217-225
: TypeDirectChatMessage
is well-structured.The fields align well with the concept of a direct chat message.
227-237
: TypeDonation
is well-structured.The fields align well with the concept of a donation.
239-252
: InputDonationWhereInput
is well-structured.It is suitable for filtering donation data.
254-271
: EnumEducationGrade
is comprehensive.The values are suitable for categorizing education grades.
275-279
: EnumEmploymentStatus
is appropriate.The values are suitable for categorizing employment status.
281-283
: InterfaceError
is correctly defined.The
message
field is suitable for error handling.
285-311
: TypeEvent
is well-structured.The fields align well with the concept of an event.
314-317
: InputEventAttendeeInput
is correctly structured.It is suitable for adding an event attendee.
319-334
: InputEventInput
is well-structured.It is suitable for creating or updating an event.
337-357
: EnumEventOrderByInput
is comprehensive.The values are suitable for ordering events.
360-369
: TypeEventVolunteer
is well-structured.The fields align well with the concept of an event volunteer.
372-375
: InputEventVolunteerInput
is correctly structured.It is suitable for adding an event volunteer.
377-380
: EnumEventVolunteerResponse
is appropriate.The values are suitable for capturing volunteer responses.
382-408
: InputEventWhereInput
is well-structured.It is suitable for filtering event data.
410-413
: TypeExtendSession
is correctly defined.The fields are suitable for session extension.
415-421
: TypeFeedback
is well-structured.The fields align well with the concept of feedback.
424-428
: InputFeedbackInput
is correctly structured.It is suitable for submitting feedback.
430-433
: InterfaceFieldError
is correctly defined.The fields are suitable for field-specific error handling.
435-438
: InputForgotPasswordData
is correctly structured.It is suitable for handling forgot password functionality.
441-445
: EnumFrequency
is appropriate.The values are suitable for categorizing frequency.
448-452
: EnumGender
is appropriate.The values are suitable for categorizing gender.
454-462
: TypeGroup
is well-structured.The fields align well with the concept of a group.
464-473
: TypeGroupChat
is well-structured.The fields align well with the concept of a group chat.
475-481
: TypeGroupChatMessage
is well-structured.The fields align well with the concept of a group chat message.
484-487
: TypeInvalidCursor
is correctly defined.The fields are suitable for handling invalid cursor errors.
491-496
: TypeLanguage
is well-structured.The fields align well with the concept of a language.
498-502
: InputLanguageInput
is correctly structured.It is suitable for adding language translations.
504-510
: TypeLanguageModel
is well-structured.The fields align well with the concept of a language model.
514-517
: InputLoginInput
is correctly structured.It is suitable for login functionality.
521-527
: EnumMaritalStatus
is comprehensive.The values are suitable for categorizing marital status.
530-533
: TypeMaximumLengthError
is correctly defined.The fields are suitable for handling maximum length errors.
535-539
: TypeMaximumValueError
is correctly defined.The fields are suitable for handling maximum value errors.
541-545
: TypeMembershipRequest
is well-structured.The fields align well with the concept of a membership request.
547-554
: TypeMessage
is well-structured.The fields align well with the concept of a message.
557-564
: TypeMessageChat
is well-structured.The fields align well with the concept of a message chat.
567-570
: InputMessageChatInput
is correctly structured.It is suitable for sending a message in a chat.
572-576
: TypeMinimumLengthError
is correctly defined.The fields are suitable for handling minimum length errors.
578-581
: TypeMinimumValueError
is correctly defined.The fields are suitable for handling minimum value errors.
589-596
: InputCreateAdvertisementInput
is well-structured.It is suitable for creating an advertisement.
598-600
: TypeCreateAdvertisementPayload
is correctly defined.The
advertisement
field is suitable for the result of creating an advertisement.
602-608
: InputEditVenueInput
is well-structured.It is suitable for editing a venue.
610-782
: TypeMutation
is comprehensive.The fields cover a wide range of mutation operations.
784-786
: InputOTPInput
is correctly structured.The
788-815
: TypeOrganization
is well-structured.The fields align well with the concept of an organization.
831-839
: TypeOrganizationInfoNode
is well-structured.The fields align well with the concept of an organization info node.
842-850
: InputOrganizationInput
is well-structured.It is suitable for creating or updating an organization.
853-863
: EnumOrganizationOrderByInput
is comprehensive.The values are suitable for ordering organizations.
866-892
: InputOrganizationWhereInput
is well-structured.It is suitable for filtering organization data.
895-897
: TypeOtpData
is correctly defined.The
otpToken
field is suitable for OTP data.
902-916
: TypePageInfo
is well-structured.The fields are suitable for pagination information.
919-922
: EnumPaginationDirection
is appropriate.The values are suitable for specifying pagination direction.
926-931
: TypePlugin
is well-structured.The fields align well with the concept of a plugin.
934-939
: TypePluginField
is well-structured.The fields align well with the concept of a plugin field.
941-944
: InputPluginFieldInput
is correctly structured.It is suitable for plugin field data.
946-951
: InputPluginInput
is well-structured.It is suitable for creating or updating a plugin.
956-970
: TypePost
is well-structured.The fields align well with the concept of a post.
976-987
: TypePostConnection
is well-structured.The fields are suitable for managing paginated post data.
990-997
: InputPostInput
is well-structured.It is suitable for creating or updating a post.
1000-1016
: EnumPostOrderByInput
is comprehensive.The values are suitable for ordering posts.
1019-1023
: InputPostUpdateInput
is well-structured.It is suitable for updating a post.
1026-1044
: InputPostWhereInput
is well-structured.It is suitable for filtering post data.
1047-1129
: TypeQuery
is comprehensive.The fields cover a wide range of query operations.
1132-1134
: InputRecaptchaVerification
is correctly structured.The
recaptchaToken
field is suitable for reCAPTCHA verification.
1136-1141
: EnumRecurrance
is comprehensive.The values are suitable for categorizing recurrence.
1144-1148
: InputRecurrenceRuleInput
is well-structured.It is suitable for defining recurrence rules.
1150-1154
: EnumStatus
is appropriate.The values are suitable for categorizing status.
1156-1160
: TypeSubscription
is well-structured.The fields are suitable for subscription operations.
1165-1168
: InputToggleUserTagAssignInput
is correctly structured.It is suitable for toggling user tag assignments.
1170-1174
: TypeTranslation
is well-structured.The fields align well with the concept of a translation.
1177-1180
: EnumType
is appropriate.The values are suitable for categorizing types.
1184-1186
: TypeUnauthenticatedError
is correctly defined.The
message
field is suitable for handling unauthenticated errors.
1188-1190
: TypeUnauthorizedError
is correctly defined.The
message
field is suitable for handling unauthorized errors.
1192-1195
: InputUpdateActionItemCategoryInput
is correctly structured.It is suitable for updating an action item category.
1197-1204
: InputUpdateActionItemInput
is well-structured.It is suitable for updating an action item.
1206-1213
: InputUpdateAdvertisementInput
is well-structured.It is suitable for updating an advertisement.
1215-1217
: TypeUpdateAdvertisementPayload
is correctly defined.The
advertisement
field is suitable for the result of updating an advertisement.
1219-1222
: InputUpdateAgendaCategoryInput
is correctly structured.It is suitable for updating an agenda category.
1224-1238
: InputUpdateEventInput
is well-structured.It is suitable for updating an event.
1241-1245
: InputUpdateEventVolunteerInput
is well-structured.It is suitable for updating an event volunteer.
1248-1253
: InputUpdateOrganizationInput
is well-structured.It is suitable for updating an organization.
1307-1318
: InputUpdateUserInput
is well-structured.It is suitable for updating a user.
1320-1323
: InputUpdateUserPasswordInput
is correctly structured.It is suitable for updating a user password.
1326-1329
: InputUpdateUserTagInput
is correctly structured.It is suitable for updating a user tag.
1331-1334
: InputUpdateUserTypeInput
is correctly structured.It is suitable for updating a user type.
1338-1366
: TypeUser
is well-structured.The fields align well with the concept of a user.
1368-1379
: TypeFund
is well-structured.The fields align well with the concept of a fund.
1382-1384
: InputFundWhereInput
is correctly structured.The
name_contains
field is suitable for filtering fund data.public/locales/en/translation.json (4)
54-54
: LGTM!The string for roles is clear and concise.
57-59
: LGTM!The strings for the left drawer menu are clear and concise.
111-112
: LGTM!The strings for the organization list card are clear and concise.
115-116
: LGTM!The strings for pagination are clear and concise.
public/locales/hi/translation.json (9)
27-41
: Translations look good.The translations in this section are consistent and accurate.
43-46
: Translations look good.The translations in this section are consistent and accurate.
48-51
: Translations look good.The translations in this section are consistent and accurate.
53-54
: Translations look good.The translations in this section are consistent and accurate.
56-59
: Translations look good.The translations in this section are consistent and accurate.
61-78
: Translations look good.The translations in this section are consistent and accurate.
80-108
: Translations look good.The translations in this section are consistent and accurate.
110-112
: Translations look good.The translations in this section are consistent and accurate.
114-116
: Translations look good.The translations in this section are consistent and accurate.
public/locales/fr/translation.json (10)
2-25
: Translations forloginPage
are consistent and complete.The translations for the login page are well-structured and consistent with the intended meaning.
27-41
: Translations foruserLoginPage
are consistent and complete.The translations for the user login page are well-structured and consistent with the intended meaning.
43-46
: Translations forlatestEvents
are consistent and complete.The translations for the latest events are well-structured and consistent with the intended meaning.
48-51
: Translations forlatestPosts
are consistent and complete.The translations for the latest posts are well-structured and consistent with the intended meaning.
53-54
: Translations forlistNavbar
are consistent and complete.The translations for the list navbar are well-structured and consistent with the intended meaning.
56-59
: Translations forleftDrawer
are consistent and complete.The translations for the left drawer are well-structured and consistent with the intended meaning.
61-78
: Translations forleftDrawerOrg
are consistent and complete.The translations for the organizational drawer are well-structured and consistent with the intended meaning.
80-108
: Translations fororgList
are consistent and complete.The translations for the organization list are well-structured and consistent with the intended meaning.
110-112
: Translations fororgListCard
are consistent and complete.The translations for the organization list card are well-structured and consistent with the intended meaning.
114-116
: Translations forpaginationList
are consistent and complete.The translations for the pagination list are well-structured and consistent with the intended meaning.
public/locales/sp/translation.json (10)
2-43
: Translations forloginPage
look good.The translations are accurate and contextually appropriate for a login page.
45-75
: Translations foruserLoginPage
look good.The translations are accurate and contextually appropriate for a user login page.
77-80
: Translations forlatestEvents
look good.The translations are accurate and contextually appropriate for event-related content.
82-85
: Translations forlatestPosts
look good.The translations are accurate and contextually appropriate for post-related content.
87-91
: Translations forlistNavbar
look good.The translations are accurate and contextually appropriate for navigation-related content.
93-100
: Translations forleftDrawer
look good.The translations are accurate and contextually appropriate for sidebar-related content.
102-125
: Translations forleftDrawerOrg
look good.The translations are accurate and contextually appropriate for organization sidebar-related content.
126-162
: Translations fororgList
look good.The translations are accurate and contextually appropriate for organization list-related content.
164-168
: Translations fororgListCard
look good.The translations are accurate and contextually appropriate for organization card-related content.
170-172
: Translations forpaginationList
look good.The translations are accurate and contextually appropriate for pagination-related content.
import fs from 'fs'; | ||
import { execSync } from 'child_process'; | ||
|
||
const markdownFiles = fs | ||
.readdirSync('./') | ||
.filter((file) => file.endsWith('.md')); | ||
|
||
markdownFiles.forEach((file) => { | ||
const command = `markdown-toc -i "${file}" --bullets "-"`; | ||
execSync(command, { stdio: 'inherit' }); | ||
|
||
}); | ||
|
||
console.log('Table of contents updated successfully.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a local installation of markdown-toc
.
The script currently assumes that markdown-toc
is installed globally. Consider using a local installation to ensure consistency across different environments.
const command = `npx markdown-toc -i "${file}" --bullets "-"`;
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
import fs from 'fs'; | |
import { execSync } from 'child_process'; | |
const markdownFiles = fs | |
.readdirSync('./') | |
.filter((file) => file.endsWith('.md')); | |
markdownFiles.forEach((file) => { | |
const command = `markdown-toc -i "${file}" --bullets "-"`; | |
execSync(command, { stdio: 'inherit' }); | |
}); | |
console.log('Table of contents updated successfully.'); | |
import fs from 'fs'; | |
import { execSync } from 'child_process'; | |
const markdownFiles = fs | |
.readdirSync('./') | |
.filter((file) => file.endsWith('.md')); | |
markdownFiles.forEach((file) => { | |
const command = `npx markdown-toc -i "${file}" --bullets "-"`; | |
execSync(command, { stdio: 'inherit' }); | |
}); | |
console.log('Table of contents updated successfully.'); |
function isInGitRepository() { | ||
try { | ||
execSync('git rev-parse --is-inside-work-tree', { stdio: 'ignore' }); | ||
return true; | ||
} catch (e) { | ||
return false; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using asynchronous methods for checking version control systems.
Using execSync
blocks the event loop, which can be inefficient. Consider using asynchronous methods to improve performance.
@@ -0,0 +1,52 @@ | |||
'use strict'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove redundant 'use strict' directive.
The 'use strict' directive is unnecessary in ES6 modules as they are in strict mode by default.
Apply this diff to remove the directive:
-'use strict';
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
'use strict'; |
Tools
Biome
[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.(lint/suspicious/noRedundantUseStrict)
## Other information | ||
***PLEASE*** do not add markdown files in this repository. Add them to `talawa-docs`! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the grammatical error in the other information section.
The preposition "in" should be replaced with "to" for grammatical correctness.
Apply this diff for correction:
***PLEASE*** do not add markdown files in this repository. Add them to `talawa-docs`!
+***PLEASE*** do not add markdown files to this repository. Add them to `talawa-docs`!
Committable suggestion was skipped due to low confidence.
Tools
LanguageTool
[uncategorized] ~32-~32: The preposition “to” seems more likely in this position.
Context: ... PLEASE do not add markdown files in this repository. Add them to `talawa-do...(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)
## How to use Docusaurus | ||
The process in easy: | ||
1. Install `talawa-docs` on your system | ||
1. Launch docusaurus on your system according to the `talawa-docs`documentation. | ||
- A local version of `docs.talawa.io` should automatically launched in your browser at http://localhost:3000/ | ||
1. Add/modify the markdown documents to the `docs/` directory of the `talawa-docs` repository | ||
1. If adding a file, then you will also need to edit the `sidebars.js` which is used to generate the [docs.talawa.io](https://docs.talawa.io/) menus. | ||
1. Always monitor the local website in your brower to make sure the changes are acceptable. | ||
- You'll be able to see errors that you can use for troubleshooting in the CLI window you used to launch the local website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct grammatical errors and replace the bare URL.
Fix the grammatical errors and replace the bare URL with a proper link.
Apply this diff for corrections:
The process is easy:
1. Install `talawa-docs` on your system
-1. Launch docusaurus on your system according to the `talawa-docs`documentation.
- - A local version of `docs.talawa.io` should automatically launched in your browser at http://localhost:3000/
+1. Launch Docusaurus on your system according to the `talawa-docs` documentation.
+ - A local version of `docs.talawa.io` should automatically be launched in your browser at [http://localhost:3000](http://localhost:3000)
1. Add/modify the Markdown documents to the `docs/` directory of the `talawa-docs` repository
1. If adding a file, then you will also need to edit the `sidebars.js` which is used to generate the [docs.talawa.io](https://docs.talawa.io/) menus.
-1. Always monitor the local website in your brower to make sure the changes are acceptable.
+1. Always monitor the local website in your browser to make sure the changes are acceptable.
- You'll be able to see errors that you can use for troubleshooting in the CLI window you used to launch the local website.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
## How to use Docusaurus | |
The process in easy: | |
1. Install `talawa-docs` on your system | |
1. Launch docusaurus on your system according to the `talawa-docs`documentation. | |
- A local version of `docs.talawa.io` should automatically launched in your browser at http://localhost:3000/ | |
1. Add/modify the markdown documents to the `docs/` directory of the `talawa-docs` repository | |
1. If adding a file, then you will also need to edit the `sidebars.js` which is used to generate the [docs.talawa.io](https://docs.talawa.io/) menus. | |
1. Always monitor the local website in your brower to make sure the changes are acceptable. | |
- You'll be able to see errors that you can use for troubleshooting in the CLI window you used to launch the local website. | |
## How to use Docusaurus | |
The process is easy: | |
1. Install `talawa-docs` on your system | |
1. Launch Docusaurus on your system according to the `talawa-docs` documentation. | |
- A local version of `docs.talawa.io` should automatically be launched in your browser at [http://localhost:3000](http://localhost:3000) | |
1. Add/modify the Markdown documents to the `docs/` directory of the `talawa-docs` repository | |
1. If adding a file, then you will also need to edit the `sidebars.js` which is used to generate the [docs.talawa.io](https://docs.talawa.io/) menus. | |
1. Always monitor the local website in your browser to make sure the changes are acceptable. | |
- You'll be able to see errors that you can use for troubleshooting in the CLI window you used to launch the local website. |
Tools
LanguageTool
[grammar] ~25-~25: The modal verb ‘should’ requires the verb’s base form.
Context: ...fdocs.talawa.io
should automatically launched in your browser at http://localhost:300...(MD_BASEFORM)
[grammar] ~26-~26: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...ttp://localhost:3000/ 1. Add/modify the markdown documents to thedocs/
directory of t...(MARKDOWN_NNP)
Markdownlint
25-25: null
Bare URL used(MD034, no-bare-urls)
enum EducationGrade { | ||
GRADE_1 | ||
GRADE_2 | ||
GRADE_3 | ||
GRADE_4 | ||
GRADE_5 | ||
GRADE_6 | ||
GRADE_7 | ||
GRADE_8 | ||
GRADE_9 | ||
GRADE_10 | ||
GRADE_11 | ||
GRADE_12 | ||
GRADUATE | ||
KG | ||
NO_GRADE | ||
PRE_KG | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid duplication of enum EducationGrade
.
The enum is defined twice in the schema. Consider removing the duplicate to prevent confusion.
enum EmploymentStatus { | ||
FULL_TIME | ||
PART_TIME | ||
UNEMPLOYED | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid duplication of enum EmploymentStatus
.
The enum is defined twice in the schema. Consider removing the duplicate to prevent confusion.
enum Gender { | ||
FEMALE | ||
MALE | ||
OTHER | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid duplication of enum Gender
.
The enum is defined twice in the schema. Consider removing the duplicate to prevent confusion.
enum MaritalStatus { | ||
DIVORCED | ||
ENGAGED | ||
MARRIED | ||
SEPERATED | ||
SINGLE | ||
WIDOWED | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid duplication of enum MaritalStatus
.
The enum is defined twice in the schema. Consider removing the duplicate to prevent confusion.
"lastName_invalid": "अंतिम नाम में केवल छोटे और बड़े अक्षर होने चाहिए", | ||
"password_invalid": "पासवर्ड में कम से कम एक लोअरकेस अक्षर, एक अपरकेस अक्षर, एक संख्यात्मक मान और एक विशेष अक्षर होना चाहिए", | ||
"email_invalid": "ईमेल में कम से कम 8 अक्षर होने चाहिए", | ||
"Password_and_Confirm_password_mismatches.": "पासवर्ड और पासवर्ड बेमेल होने की पुष्टि करें।", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove duplicate translation entries.
The entries for "Password_and_Confirm_password_mismatches." and "successfullyRegistered" are duplicated.
Consider removing the duplicates to avoid redundancy.
Also applies to: 17-17, 19-19, 25-25
What kind of change does this PR introduce?
This PR introduces a dependency upgrade.
Issue Number:
Fixes #2135
Did you add tests for your changes?
Yes, existing tests were run to ensure compatibility.
Snapshots/Videos:
NA
If relevant, did you update the documentation?
NA
Summary
This PR upgrades the eslint-plugin-jest package from version 25.7.0 to 28.6.0. The rationale for this upgrade was to resolve issues caused by outdated dependencies, as the previous PR by Dependabot (#2129) failed due to these issues. The upgrade required multiple dependency updates and code refactoring to align with the new syntax, functions, and methods introduced in the newer version of eslint-plugin-jest.
Unused or unnecessary dependencies were also reviewed and removed where applicable to streamline the codebase and improve maintainability.
Does this PR introduce a breaking change?
No, this PR does not introduce a breaking change, but the codebase has been updated to ensure compatibility with the new version of eslint-plugin-jest.
Other information
This upgrade resolves the dependency conflict and ensures that the codebase is up to date with the latest features and improvements from eslint-plugin-jest. All tests have been rerun to verify that the upgrade does not introduce any regressions.
Have you read the contributing guide?
Yes
Summary by CodeRabbit
New Features
Documentation
Localization
Style
Bug Fixes
Chores
.gitignore
entries for better file management.