Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Twitter links to X links #2148

Closed
wants to merge 1 commit into from
Closed

Updated Twitter links to X links #2148

wants to merge 1 commit into from

Conversation

BishalJena
Copy link

@BishalJena BishalJena commented Aug 1, 2024

What kind of change does this PR introduce?

This PR introduces a visual update to replace the Twitter link with the new X link.

Issue Number:

Fixes #2147

Did you add tests for your changes?

No

Snapshots/Videos:

If relevant, did you update the documentation?

Not applicable

Summary

This pull request updates the Twitter links to the new X links.

Does this PR introduce a breaking change?

No

Other information

Have you read the contributing guide?

Yes

Summary by CodeRabbit

  • New Features

    • Updated the representation of social media links to reflect the rebranding of Twitter as "X," including new logos and links.
  • Bug Fixes

    • Adjusted test cases and components to ensure the application correctly processes and displays the newly named social media references.
  • Documentation

    • Enhanced clarity and accuracy in social media handling throughout the application after the branding update.

Copy link
Contributor

coderabbitai bot commented Aug 1, 2024

Walkthrough

The recent changes primarily involve updating the application's references from "Twitter" to "X," reflecting the platform's rebranding. This includes alterations in GraphQL queries, social media icon imports, and test cases. By ensuring consistency across the codebase, these changes enhance the integration of the updated platform while maintaining existing functionalities.

Changes

Files Change Summary
src/GraphQl/Queries/Queries.ts Replaced twitter field with x in the GET_COMMUNITY_DATA query.
src/assets/svgs/social-icons/index.tsx Replaced TwitterLogo with XLogo in imports and exports reflecting rebranding.
src/constants.ts Updated social media links to reflect X instead of Twitter in constants.
src/screens/CommunityProfile/*.tsx Changed references from twitter to x in the CommunityProfile component and its tests.
src/screens/LoginPage/LoginPage.test.tsx Updated mock data in tests to replace twitter key with x.

Assessment against linked issues

Objective Addressed Explanation
Change Twitter to X links (#2147)
Update social media links in footer (#2147)

🐰 In fields so bright, I hop with glee,
"X" shines now, as "Twitter" used to be.
Icons and links, all fresh and new,
In code we trust, our path is true!
Let’s celebrate change, with a joyful cheer,
For connections we make, bring us all near! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Aug 1, 2024

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5010350 and 607ad74.

Files selected for processing (6)
  • src/GraphQl/Queries/Queries.ts (1 hunks)
  • src/assets/svgs/social-icons/index.tsx (2 hunks)
  • src/constants.ts (2 hunks)
  • src/screens/CommunityProfile/CommunityProfile.test.tsx (10 hunks)
  • src/screens/CommunityProfile/CommunityProfile.tsx (7 hunks)
  • src/screens/LoginPage/LoginPage.test.tsx (1 hunks)
Additional comments not posted (22)
src/assets/svgs/social-icons/index.tsx (2)

6-6: Update import statement to reflect rebranding.

The import statement has been correctly updated to reflect the rebranding of Twitter to X.


16-16: Update export statement to reflect rebranding.

The export statement has been correctly updated to reflect the rebranding of Twitter to X.

src/constants.ts (2)

7-7: Update import statement to reflect rebranding.

The import statement has been correctly updated to reflect the rebranding of Twitter to X.


19-21: Update social media link entry to reflect rebranding.

The social media link entry has been correctly updated to reflect the rebranding of Twitter to X.

src/screens/CommunityProfile/CommunityProfile.test.tsx (9)

39-39: Update mock data to reflect rebranding.

The mock data has been correctly updated to reflect the rebranding of Twitter to X.


77-77: Update mock data to reflect rebranding.

The mock data has been correctly updated to reflect the rebranding of Twitter to X.


118-118: Update mock data to reflect rebranding.

The mock data has been correctly updated to reflect the rebranding of Twitter to X.


191-191: Update test assertion to reflect rebranding.

The test assertion has been correctly updated to reflect the rebranding of Twitter to X.


223-223: Update test assertion to reflect rebranding.

The test assertion has been correctly updated to reflect the rebranding of Twitter to X.


236-236: Update test assertion to reflect rebranding.

The test assertion has been correctly updated to reflect the rebranding of Twitter to X.


279-279: Update test assertion to reflect rebranding.

The test assertion has been correctly updated to reflect the rebranding of Twitter to X.


305-305: Update test assertion to reflect rebranding.

The test assertion has been correctly updated to reflect the rebranding of Twitter to X.


327-327: Update test assertion to reflect rebranding.

The test assertion has been correctly updated to reflect the rebranding of Twitter to X.

src/screens/CommunityProfile/CommunityProfile.tsx (7)

13-13: LGTM! Import statement updated correctly.

The import statement for TwitterLogo is replaced with XLogo, which aligns with the rebranding.


40-40: LGTM! Type definition updated correctly.

The socialMediaUrls object now includes x instead of twitter, aligning with the rebranding.


55-55: LGTM! State initialization updated correctly.

The profileVariable state now includes x instead of twitter, ensuring consistency with the updated type definition.


77-77: LGTM! useEffect hook updated correctly.

The useEffect hook now sets the profileVariable state with x instead of twitter, ensuring consistency with the updated data structure.


107-107: LGTM! Form handling updated correctly.

The handleOnSubmit function now handles x instead of twitter, ensuring consistency with the updated data structure.


134-134: LGTM! Reset function updated correctly.

The resetData function now resets the profileVariable state with x instead of twitter, ensuring consistency with the updated state initialization.


269-276: LGTM! Form input fields updated correctly.

The form input fields now handle x instead of twitter, ensuring consistency with the updated data structure.

src/GraphQl/Queries/Queries.ts (1)

770-770: LGTM! GraphQL query updated correctly.

The GET_COMMUNITY_DATA query now retrieves the x field instead of twitter, ensuring consistency with the updated data structure.

src/screens/LoginPage/LoginPage.test.tsx (1)

117-117: LGTM! Mock data updated correctly.

The mock data in the MOCKS2 array now includes x instead of twitter, ensuring consistency with the updated data structure.

@BishalJena
Copy link
Author

@palisadoes kindly check this PR and merge if passes review.

@Cioppolo14
Copy link
Contributor

We have a policy of unassigning contributors who close PRs without getting validation from our reviewer team. This is because:

  1. We start looking for people to review PRs when you submit them.
  2. We often contact them and link to the PR. If the PR is closed the whole effort is wasted.
  3. The historical thread of reviewer comments is broken when the work is spread across multiple PRs. The quality of our code is affected negatively.

Please be considerate of our volunteers' limited time and our desire to improve our code base.

This policy is stated as a pinned post in all our Talawa repositories. Our YouTube videos explain why this practice is not acceptable to our Community.

@Cioppolo14 Cioppolo14 closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Twitter to X links
2 participants