-
-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Twitter links to X links #2148
Updated Twitter links to X links #2148
Conversation
WalkthroughThe recent changes primarily involve updating the application's references from "Twitter" to "X," reflecting the platform's rebranding. This includes alterations in GraphQL queries, social media icon imports, and test cases. By ensuring consistency across the codebase, these changes enhance the integration of the updated platform while maintaining existing functionalities. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (6)
- src/GraphQl/Queries/Queries.ts (1 hunks)
- src/assets/svgs/social-icons/index.tsx (2 hunks)
- src/constants.ts (2 hunks)
- src/screens/CommunityProfile/CommunityProfile.test.tsx (10 hunks)
- src/screens/CommunityProfile/CommunityProfile.tsx (7 hunks)
- src/screens/LoginPage/LoginPage.test.tsx (1 hunks)
Additional comments not posted (22)
src/assets/svgs/social-icons/index.tsx (2)
6-6
: Update import statement to reflect rebranding.The import statement has been correctly updated to reflect the rebranding of Twitter to X.
16-16
: Update export statement to reflect rebranding.The export statement has been correctly updated to reflect the rebranding of Twitter to X.
src/constants.ts (2)
7-7
: Update import statement to reflect rebranding.The import statement has been correctly updated to reflect the rebranding of Twitter to X.
19-21
: Update social media link entry to reflect rebranding.The social media link entry has been correctly updated to reflect the rebranding of Twitter to X.
src/screens/CommunityProfile/CommunityProfile.test.tsx (9)
39-39
: Update mock data to reflect rebranding.The mock data has been correctly updated to reflect the rebranding of Twitter to X.
77-77
: Update mock data to reflect rebranding.The mock data has been correctly updated to reflect the rebranding of Twitter to X.
118-118
: Update mock data to reflect rebranding.The mock data has been correctly updated to reflect the rebranding of Twitter to X.
191-191
: Update test assertion to reflect rebranding.The test assertion has been correctly updated to reflect the rebranding of Twitter to X.
223-223
: Update test assertion to reflect rebranding.The test assertion has been correctly updated to reflect the rebranding of Twitter to X.
236-236
: Update test assertion to reflect rebranding.The test assertion has been correctly updated to reflect the rebranding of Twitter to X.
279-279
: Update test assertion to reflect rebranding.The test assertion has been correctly updated to reflect the rebranding of Twitter to X.
305-305
: Update test assertion to reflect rebranding.The test assertion has been correctly updated to reflect the rebranding of Twitter to X.
327-327
: Update test assertion to reflect rebranding.The test assertion has been correctly updated to reflect the rebranding of Twitter to X.
src/screens/CommunityProfile/CommunityProfile.tsx (7)
13-13
: LGTM! Import statement updated correctly.The import statement for
TwitterLogo
is replaced withXLogo
, which aligns with the rebranding.
40-40
: LGTM! Type definition updated correctly.The
socialMediaUrls
object now includesx
instead of
55-55
: LGTM! State initialization updated correctly.The
profileVariable
state now includesx
instead of
77-77
: LGTM! useEffect hook updated correctly.The
useEffect
hook now sets theprofileVariable
state withx
instead of
107-107
: LGTM! Form handling updated correctly.The
handleOnSubmit
function now handlesx
instead of
134-134
: LGTM! Reset function updated correctly.The
resetData
function now resets theprofileVariable
state withx
instead of
269-276
: LGTM! Form input fields updated correctly.The form input fields now handle
x
instead ofsrc/GraphQl/Queries/Queries.ts (1)
770-770
: LGTM! GraphQL query updated correctly.The
GET_COMMUNITY_DATA
query now retrieves thex
field instead ofsrc/screens/LoginPage/LoginPage.test.tsx (1)
117-117
: LGTM! Mock data updated correctly.The mock data in the
MOCKS2
array now includesx
instead of
@palisadoes kindly check this PR and merge if passes review. |
We have a policy of unassigning contributors who close PRs without getting validation from our reviewer team. This is because:
Please be considerate of our volunteers' limited time and our desire to improve our code base. This policy is stated as a pinned post in all our Talawa repositories. Our YouTube videos explain why this practice is not acceptable to our Community. |
What kind of change does this PR introduce?
This PR introduces a visual update to replace the Twitter link with the new X link.
Issue Number:
Fixes #2147
Did you add tests for your changes?
No
Snapshots/Videos:
If relevant, did you update the documentation?
Not applicable
Summary
This pull request updates the Twitter links to the new X links.
Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
Yes
Summary by CodeRabbit
New Features
Bug Fixes
Documentation