Marital status dropdown settings.separated translation - updated #2124
Conversation
… into mahakj-2115_marital_status_separated
WalkthroughThe recent changes focus on correcting spelling errors in various translation files across multiple languages, specifically the term "separated." Additionally, a new constant related to marital status options has been introduced in the test suite for the User Portal's Settings component, enhancing the testing of dropdown functionality. These adjustments aim to improve accuracy in translations and ensure robust testing coverage. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Dropdown
participant Translations
User->>Dropdown: Clicks marital status dropdown
Dropdown->>Translations: Fetch options
Translations-->>Dropdown: Return ["Single", "Married", "Separated", "Divorced", ...]
Dropdown-->>User: Display options
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? |
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (6)
- public/locales/en/translation.json (1 hunks)
- public/locales/fr/translation.json (1 hunks)
- public/locales/hi/translation.json (1 hunks)
- public/locales/sp/translation.json (1 hunks)
- public/locales/zh/translation.json (1 hunks)
- src/screens/UserPortal/Settings/Settings.test.tsx (2 hunks)
Files skipped from review due to trivial changes (5)
- public/locales/en/translation.json
- public/locales/fr/translation.json
- public/locales/hi/translation.json
- public/locales/sp/translation.json
- public/locales/zh/translation.json
Additional comments not posted (2)
src/screens/UserPortal/Settings/Settings.test.tsx (2)
110-135: LGTM! The new constantmockMaritalStatusEnumis well-defined.This improves readability and maintainability by centralizing the marital status options.
398-508: LGTM! The new test caseMarital Status dropdown value verificationis comprehensive.This test case ensures that the dropdown functionality works as expected and enhances the clarity of the test by using
mockMaritalStatusEnum.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2124 +/- ##
===========================================
+ Coverage 97.46% 97.48% +0.01%
===========================================
Files 233 233
Lines 6551 6551
Branches 1919 1919
===========================================
+ Hits 6385 6386 +1
+ Misses 151 150 -1
Partials 15 15 ☔ View full report in Codecov by Sentry. |
What kind of change does this PR introduce?
Bugfix
Issue Number:
Fixes #2115 by @mahak-juriani
Did you add tests for your changes?
Yes
Snapshots/Videos:
Talawa.-.Settings.-.Separated.translation.resolved.mp4
Summary
Under Settings page, when Marital status of the user is edited - the label for Separated is shown as settings.separated instead of SEPARATED.
The issue is resolved in this Pull Request
Resolves #2115
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes
Summary by CodeRabbit
Bug Fixes
Tests