-
-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: Tsdoc comments in whole codebase #2113
Documentation: Tsdoc comments in whole codebase #2113
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 106 files out of 158 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
@palisadoes I wrote comments in those files that have eslint errors already because of |
I disabled them because I couldn't commit changes without doing so. |
I won't be able to remove |
@palisadoes So what should I do? |
@palisadoes any suggestions? |
We merged some updated packages recently. That may be the cause. |
The error explains what is wrong. We need to make sure the linting in those files is fixed. |
@palisadoes I can try to fix, but mostly can't be fixed |
@palisadoes I need to disable some linting errors, so what should I do? |
Do what you can. We shouldn't disable linting. I'll see if I can force merge when you are done. |
Please fix the conflicting files. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2113 +/- ##
========================================
Coverage 97.48% 97.48%
========================================
Files 233 233
Lines 6551 6559 +8
Branches 1919 1926 +7
========================================
+ Hits 6386 6394 +8
Misses 150 150
Partials 15 15 ☔ View full report in Codecov by Sentry. |
@palisadoes we can merge this PR now. |
01f4785
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Issue Number:
Fixes #2114
Did you add tests for your changes?
No
Snapshots/Videos:
Have you read the contributing guide?