[Translation] Fix post id bug and side translations #2074
Conversation
WalkthroughThe changes include updates to localization files in multiple languages (English, French, Hindi, Spanish, and Chinese), adding new keys for "Donate" and post-related actions. There are also updates to the Changes
Assessment against linked issues
PoemThank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
Files selected for processing (14)
- public/locales/en/common.json (1 hunks)
- public/locales/en/translation.json (1 hunks)
- public/locales/fr/common.json (1 hunks)
- public/locales/fr/translation.json (1 hunks)
- public/locales/hi/common.json (1 hunks)
- public/locales/hi/translation.json (1 hunks)
- public/locales/sp/common.json (1 hunks)
- public/locales/sp/translation.json (1 hunks)
- public/locales/zh/common.json (1 hunks)
- public/locales/zh/translation.json (1 hunks)
- src/components/UserPortal/PostCard/PostCard.test.tsx (2 hunks)
- src/components/UserPortal/PostCard/PostCard.tsx (6 hunks)
- src/components/UserPortal/UserSidebarOrg/UserSidebarOrg.tsx (1 hunks)
- src/utils/interfaces.ts (1 hunks)
Files skipped from review due to trivial changes (4)
- public/locales/en/common.json
- public/locales/fr/common.json
- public/locales/hi/common.json
- public/locales/hi/translation.json
Additional comments not posted (21)
public/locales/zh/common.json (1)
79-80: LGTM!The new translations for "none" and "Donate" are consistent with the existing translations.
public/locales/sp/common.json (1)
79-80: LGTM!The new translations for "none" and "Donate" are consistent with the existing translations.
src/components/UserPortal/UserSidebarOrg/UserSidebarOrg.tsx (1)
153-153: LGTM!The change to use
tCommon(name)for localization is correct and necessary.src/utils/interfaces.ts (1)
406-406: LGTM!The change from
_idtoidfor consistency is correct and necessary.src/components/UserPortal/PostCard/PostCard.tsx (7)
183-183: Change type toInterfaceCommentCardProps.The type of
newCommenthas been changed fromanytoInterfaceCommentCardProps, which improves type safety.
186-186: Ensure consistency withidproperty.The
idproperty is correctly used here instead of_id, aligning with the updated interface.
290-290: Integrate translation forpostedOn.The
postedOntext is now translated using thetfunction, which improves localization.
305-305: Integrate translation forviewPost.The
viewPosttext is now translated using thetfunction, which enhances localization.
342-342: Remove redundant type annotations.The type annotations for
commentandindexare removed, relying on TypeScript's type inference.
418-418: Integrate translation foreditPost.The
editPosttext is now translated using thetfunction, which improves localization.
442-442: Integrate translation foreditPost.The
editPosttext is now translated using thetfunction, enhancing localization.src/components/UserPortal/PostCard/PostCard.test.tsx (2)
188-188: Updateidproperty in test data.The
idproperty is correctly used here instead of_id, aligning with the updated interface.
202-202: Updateidproperty in test data.The
idproperty is correctly used here instead of_id, aligning with the updated interface.public/locales/zh/translation.json (3)
700-700: Add translation forviewPost.The translation for
viewPostis correctly added.
701-701: Add translation foreditPost.The translation for
editPostis correctly added.
702-702: Add translation forpostedOn.The translation for
postedOnis correctly added, including the date placeholder.public/locales/en/translation.json (1)
697-699: Ensure consistency in translation keys and values.The new translations for "viewPost", "editPost", and "postedOn" are consistent with the existing format and values in the file.
public/locales/fr/translation.json (3)
701-701: Translation Approved: "viewPost".The translation "Voir le message" is correct and consistent with the context.
702-702: Translation Approved: "editPost".The translation "Modifier le message" is correct and consistent with the context.
703-703: Translation Approved: "postedOn".The translation "Publié le {{date}}" is correct and consistent with the context.
public/locales/sp/translation.json (1)
911-911: LGTM! The translation for "Donate" is correct.The translation of "Donate" to "Donar" is accurate and contextually appropriate.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2074 +/- ##
========================================
Coverage 97.92% 97.92%
========================================
Files 232 232
Lines 6208 6208
Branches 1793 1791 -2
========================================
Hits 6079 6079
Misses 118 118
Partials 11 11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
Files selected for processing (6)
- public/locales/en/translation.json (1 hunks)
- public/locales/fr/translation.json (1 hunks)
- public/locales/hi/translation.json (1 hunks)
- public/locales/sp/translation.json (1 hunks)
- public/locales/zh/translation.json (1 hunks)
- src/utils/interfaces.ts (1 hunks)
Files skipped from review as they are similar to previous changes (5)
- public/locales/en/translation.json
- public/locales/fr/translation.json
- public/locales/hi/translation.json
- public/locales/zh/translation.json
- src/utils/interfaces.ts
Additional comments not posted (3)
public/locales/sp/translation.json (3)
947-947: Ensure Consistency in Translation KeysThe translation key "viewPost" has been added correctly. Verify that this key is used consistently across the application.
948-948: Ensure Consistency in Translation KeysThe translation key "editPost" has been added correctly. Verify that this key is used consistently across the application.
949-949: Ensure Consistency in Translation KeysThe translation key "postedOn" has been added correctly. Verify that this key is used consistently across the application.
Those got updated automatically with the latest versions, it's not required. |
What kind of change does this PR introduce?
Translation and Bug fix
Issue Number:
Fixes #2073
Did you add tests for your changes?
N/A
Snapshots/Videos:
If relevant, did you update the documentation?
N/A
Summary
Does this PR introduce a breaking change?
No>
Other information
Have you read the contributing guide?
Summary by CodeRabbit
New Features
Refactor
PostCardandPostCardtests for better consistency and readability.UserSidebarOrg.Tests
PostCardcomponent to align with updated property names.