Plugin and advertisement screen revamp

.eslintrc.json

@@ -55,6 +55,7 @@
     "import/no-duplicates": "error",
     "tsdoc/syntax": "error",
     "@typescript-eslint/ban-ts-comment": "error",
+    "@typescript-eslint/no-unused-vars": "error",
     "@typescript-eslint/no-explicit-any": "error",
     "@typescript-eslint/no-inferrable-types": "error",
     "@typescript-eslint/no-non-null-asserted-optional-chain": "error",

.github/pull_request_template.md

@@ -9,6 +9,7 @@ We employ the following branching strategy to simplify the development process a
 NOTE!!!
 
 ONLY SUBMIT PRS AGAINST OUR `DEVELOP` BRANCH. THE DEFAULT IS `MAIN`, SO YOU WILL HAVE TO MODIFY THIS BEFORE SUBMITTING YOUR PR FOR REVIEW. PRS MADE AGAINST `MAIN` WILL BE CLOSED.
+
 -->
 
 <!--
@@ -23,10 +24,6 @@ Thanks for submitting a pull request! Please provide enough information so that
 
 Fixes #<!--Add related issue number here.-->
 
-**Did you add tests for your changes?**
-
-<!--Yes or No. Note: Add unit tests or automation tests for your code.-->
-
 **Snapshots/Videos:**
 
 <!--Add snapshots or videos wherever possible.-->
@@ -44,10 +41,23 @@ Fixes #<!--Add related issue number here.-->
 
 <!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->
 
+## Checklist
+
+### CodeRabbit AI Review
+- [ ] I have reviewed and addressed all critical issues flagged by CodeRabbit AI
+- [ ] I have implemented or provided justification for each non-critical suggestion
+- [ ] I have documented my reasoning in the PR comments where CodeRabbit AI suggestions were not implemented
+
+### Test Coverage
+- [ ] I have written tests for all new changes/features
+- [ ] I have verified that test coverage meets or exceeds 95%
+- [ ] I have run the test suite locally and all tests pass
+
+
 **Other information**
 
 <!--Add extra information about this PR here-->
 
 **Have you read the [contributing guide](https://github.com/PalisadoesFoundation/talawa-admin/blob/master/CONTRIBUTING.md)?**
 
-<!--Yes or No-->
+<!--Yes or No-->

.github/workflows/pull-request.yml

@@ -58,7 +58,7 @@ jobs:
       - name: Check for linting errors in modified files
         if: steps.changed-files.outputs.only_changed != 'true'
         env:
-          CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }}
+          CHANGED_FILES: ${{ steps.changed_files.outputs.all_changed_files }}
         run: npx eslint ${CHANGED_FILES} && python .github/workflows/eslint_disable_check.py
 
       - name: Check for TSDoc comments
@@ -124,12 +124,6 @@ jobs:
             ISSUE_GUIDELINES.md
             PR_GUIDELINES.md
             README.md
-            *.pem
-            *.key
-            *.cert
-            *.password
-            *.secret
-            *.credentials
 
       - name: List all changed unauthorized files
         if: steps.changed-unauth-files.outputs.any_changed == 'true' || steps.changed-unauth-files.outputs.any_deleted == 'true'
@@ -204,7 +198,7 @@ jobs:
 
       - name: Get changed TypeScript files
         id: changed-files
-        uses: tj-actions/changed-files@v45
+        uses: tj-actions/changed-files@v40
 
       - name: Run tests
         if: steps.changed-files.outputs.only_changed != 'true'

public/locales/en/translation.json

@@ -923,7 +923,7 @@
     "register": "register"
   },
   "addOnStore": {
-    "title": "Add On Store",
+    "title": "Plugin Store",
     "searchName": "Ex: Donations",
     "search": "Search",
     "enable": "Enabled",
@@ -1227,7 +1227,7 @@
     "RstartDate": "Select Start Date",
     "RendDate": "Select End Date",
     "RClose": "Close the window",
-    "addNew": "Create new advertisement",
+    "addNew": "Create",
     "EXname": "Ex. Cookie Shop",
     "EXlink": "Ex. http://yourwebsite.com/photo",
     "createAdvertisement": "Create Advertisement",

src/components/AddOn/core/AddOnEntry/AddOnEntry.module.css

@@ -7,8 +7,12 @@
   margin-left: auto;
   display: flex !important;
   align-items: center;
+  background-color: transparent;
+  color: #31bb6b;
+}
+.card {
+  border: 4px solid green;
 }
-
 .entryaction i {
   margin-right: 8px;
 }

src/components/AddOn/core/AddOnEntry/AddOnEntry.tsx

@@ -19,7 +19,7 @@ interface InterfaceAddOnEntryProps {
   component?: string; // Optional props
   modified?: any; // Optional props
   uninstalledOrgs: string[];
-  getInstalledPlugins: () => any;
+  getInstalledPlugins: () => void;
 }
 
 /**
@@ -59,6 +59,7 @@ function addOnEntry({
 
   // Getting orgId from URL parameters
   const { orgId: currentOrg } = useParams();
+  // console.log(currentOrg);
   if (!currentOrg) {
     // If orgId is not present in the URL, navigate to the org list page
     return <Navigate to={'/orglist'} />;
@@ -101,7 +102,10 @@ function addOnEntry({
 
   return (
     <>
-      <Card data-testid="AddOnEntry">
+      <Card
+        data-testid="AddOnEntry"
+        style={{ border: '1px solid #31BB6B', borderRadius: '10px' }}
+      >
         {/* {uninstalledOrgs.includes(currentOrg) && (
           <Form.Check
             type="switch"
@@ -114,7 +118,7 @@ function addOnEntry({
           />
         )} */}
         <Card.Body>
-          <Card.Title>{title}</Card.Title>
+          <Card.Title style={{ fontWeight: '800' }}>{title}</Card.Title>
           <Card.Subtitle className="mb-2 text-muted author">
             {createdBy}
           </Card.Subtitle>
@@ -134,7 +138,7 @@ function addOnEntry({
               <Spinner animation="grow" />
             ) : (
               <i
-                className={!isInstalledLocal ? 'fa fa-trash' : 'fa fa-cubes'}
+                className={!isInstalledLocal ? 'fa fa-trash' : 'fa fa-plus'}
               ></i>
             )}
             {/* {installed ? 'Remove' : configurable ? 'Installed' : 'Install'} */}

src/components/AddOn/core/AddOnStore/AddOnStore.module.css

@@ -11,8 +11,12 @@
   border-bottom: 3px solid #31bb6b;
   width: 15%;
 }
-
-.actioninput {
+.input {
+  display: flex;
+  position: relative;
+  width: 560px;
+}
+/* .actioninput {
   text-decoration: none;
   margin-bottom: 50px;
   border-color: #e8e5e5;
@@ -23,9 +27,46 @@
   padding-right: 10px;
   padding-left: 10px;
   box-shadow: none;
+} */
+.actioninput {
+  margin-top: 10px;
+  margin-bottom: 10px;
+  background-color: white;
+  box-shadow: 0 1px 1px #31bb6b;
+}
+.inputField > button {
+  padding-top: 10px;
+  padding-bottom: 10px;
 }
 
 .actionradio input {
   width: fit-content;
   margin: inherit;
 }
+.cardGridItem {
+  width: 38vw;
+}
+.justifysp {
+  display: grid;
+  width: 100%;
+  justify-content: space-between;
+  align-items: baseline;
+  grid-template-rows: auto;
+  grid-template-columns: repeat(2, 1fr);
+  grid-gap: 0.8rem 0.4rem;
+}
+
+@media screen and (max-width: 600px) {
+  .cardGridItem {
+    width: 100%;
+  }
+  .justifysp {
+    display: grid;
+    width: 100%;
+    justify-content: center;
+    align-items: start;
+    grid-template-rows: auto;
+    grid-template-columns: 1fr;
+    grid-gap: 0.8rem 0.4rem;
+  }
+}

src/components/AddOn/core/AddOnStore/AddOnStore.test.tsx

@@ -22,7 +22,11 @@ import useLocalStorage from 'utils/useLocalstorage';
 import { MockedProvider } from '@apollo/react-testing';
 
 const { getItem } = useLocalStorage();
-
+interface InterfacePlugin {
+  enabled: boolean;
+  pluginName: string;
+  component: string;
+}
 jest.mock('components/AddOn/support/services/Plugin.helper', () => ({
   __esModule: true,
   default: jest.fn().mockImplementation(() => ({
@@ -60,16 +64,18 @@ jest.mock('components/AddOn/support/services/Plugin.helper', () => ({
       },
       // Add more mock data as needed
     ]),
-    generateLinks: jest.fn().mockImplementation((plugins) => {
-      return plugins
-        .filter((plugin: { enabled: any }) => plugin.enabled)
-        .map((installedPlugin: { pluginName: any; component: string }) => {
-          return {
-            name: installedPlugin.pluginName,
-            url: `/plugin/${installedPlugin.component.toLowerCase()}`,
-          };
-        });
-    }),
+    generateLinks: jest
+      .fn()
+      .mockImplementation((plugins: InterfacePlugin[]) => {
+        return plugins
+          .filter((plugin) => plugin.enabled)
+          .map((installedPlugin) => {
+            return {
+              name: installedPlugin.pluginName,
+              url: `/plugin/${installedPlugin.component.toLowerCase()}`,
+            };
+          });
+      }),
   })),
 }));
 
@@ -301,77 +307,6 @@ describe('Testing AddOnStore Component', () => {
     expect(message.length).toBeGreaterThanOrEqual(1);
   });
 
-  test('check filters enabled and disabled under Installed tab', async () => {
-    const mocks = [ORGANIZATIONS_LIST_MOCK, PLUGIN_GET_MOCK];
-    render(
-      <ApolloProvider client={client}>
-        <Provider store={store}>
-          <BrowserRouter>
-            <I18nextProvider i18n={i18nForTest}>
-              <MockedProvider mocks={mocks} addTypename={false}>
-                <AddOnStore />
-              </MockedProvider>
-            </I18nextProvider>
-          </BrowserRouter>
-        </Provider>
-      </ApolloProvider>,
-    );
-
-    await wait();
-    userEvent.click(screen.getByText('Installed'));
-
-    expect(screen.getByText('Filters')).toBeInTheDocument();
-    expect(screen.getByLabelText('Enabled')).toBeInTheDocument();
-    expect(screen.getByLabelText('Disabled')).toBeInTheDocument();
-
-    fireEvent.click(screen.getByLabelText('Enabled'));
-    expect(screen.getByLabelText('Enabled')).toBeChecked();
-    fireEvent.click(screen.getByLabelText('Disabled'));
-    expect(screen.getByLabelText('Disabled')).toBeChecked();
-  });
-
-  test('check the working search bar when on Installed tab', async () => {
-    const mocks = [ORGANIZATIONS_LIST_MOCK, PLUGIN_GET_MOCK];
-
-    const { container } = render(
-      <ApolloProvider client={client}>
-        <Provider store={store}>
-          <BrowserRouter>
-            <I18nextProvider i18n={i18nForTest}>
-              <MockedProvider mocks={mocks} addTypename={false}>
-                <AddOnStore />
-              </MockedProvider>
-            </I18nextProvider>
-          </BrowserRouter>
-        </Provider>
-      </ApolloProvider>,
-    );
-    await wait();
-    userEvent.click(screen.getByText('Installed'));
-
-    await wait();
-    let searchText = '';
-    fireEvent.change(screen.getByPlaceholderText('Ex: Donations'), {
-      target: { value: searchText },
-    });
-    expect(container).toHaveTextContent('Plugin 1');
-    expect(container).toHaveTextContent('Plugin 3');
-
-    searchText = 'Plugin 1';
-    fireEvent.change(screen.getByPlaceholderText('Ex: Donations'), {
-      target: { value: searchText },
-    });
-    const plugin1Elements = screen.queryAllByText('Plugin 1');
-    expect(plugin1Elements.length).toBeGreaterThan(1);
-
-    searchText = 'Test Plugin';
-    fireEvent.change(screen.getByPlaceholderText('Ex: Donations'), {
-      target: { value: searchText },
-    });
-    const message = screen.getAllByText('Plugin does not exists');
-    expect(message.length).toBeGreaterThanOrEqual(1);
-  });
-
   test('AddOnStore loading test', async () => {
     expect(true).toBe(true);
     const mocks = [ORGANIZATIONS_LIST_MOCK, PLUGIN_LOADING_MOCK];