Usertype removal - part 1

[pranshugupta54]

Ref #1827

• OrgMemberConnection - this needs some fix, it has appUserProfileId field which returns null always.
• Added // eslint-disable-line to some lines which should be fixed separately (userType changes require me to fix lint in that file which is not relevant to this issue)

Files:

• public/locales/en.json - can skip translations
• public/locales/fr.json - can skip translations
• public/locales/hi.json - can skip translations
• public/locales/sp.json - can skip translations
• public/locales/zh.json - can skip translations
• schema.graphql - [userTypeFix] Remove updateUserType mutation talawa-api#2139
• src/App.test.tsx
• src/components/DeleteOrg/DeleteOrg.test.tsx
• src/components/DeleteOrg/DeleteOrg.tsx
• src/components/LeftDrawerEvent/LeftDrawerEvent.test.tsx -> Event Dashboard: Multiple Layout Issues (March 2024) #1853
• src/components/LeftDrawerEvent/LeftDrawerEvent.tsx -> Event Dashboard: Multiple Layout Issues (March 2024) #1853
• src/components/LeftDrawer/LeftDrawer.test.tsx
• src/components/LeftDrawer/LeftDrawer.tsx
• src/components/LeftDrawerOrg/LeftDrawerOrg.test.tsx
• src/components/OrgAdminListCard/OrgAdminListCard.tsx -> Admin - Org - People filters don't work #1852
• src/components/OrganizationScreen/OrganizationScreen.test.tsx
• src/components/ProfileDropdown/profileDropdown.tsx
• src/components/RequestsTableItem/RequestsTableItem.test.tsx
• src/components/SuperAdminScreen/SuperAdminScreen.test.tsx
• src/components/UserPortal/Login/Login.test.tsx
• src/components/UserPortal/OrganizationSidebar/OrganizationSidebar.test.tsx - OrgMemberConnection
• src/components/UserPortal/StartPostModal/StartPostModal.test.tsx
• src/GraphQl/Mutations/mutations.ts - only 1 mutation - [userTypeFix] Remove updateUserType mutation talawa-api#2139
• src/GraphQl/Queries/Queries.ts
• src/screens/MemberDetail/MemberDetail.test.tsx
• src/screens/OrganizationDashboard/OrganizationDashboard.test.tsx - eslint issue
• src/screens/OrganizationEvents/OrganizationEvents.tsx
• src/screens/OrganizationPeople/OrganizationPeople.test.tsx - OrgMemberConnection
• src/screens/OrgList/OrganizationModal.tsx - not userType - it's InterfaceUserType
• src/screens/OrgList/OrgListMocks.ts - not userType - it's InterfaceUserType
• src/screens/OrgList/OrgList.tsx - not userType - it's InterfaceUserType
• src/screens/OrgSettings/OrgSettings.test.tsx
• src/screens/Requests/Requests.test.tsx
• src/screens/Requests/Requests.tsx - eslint issue
• src/screens/UserPortal/Chat/Chat.test.tsx - OrgMemberConnection
• src/screens/UserPortal/Events/Events.tsx - eslint issue
• src/screens/UserPortal/People/People.test.tsx - OrgMemberConnection
• src/screens/UserPortal/People/People.tsx - OrgMemberConnection
• src/screens/UserPortal/Settings/Settings.test.tsx
• src/screens/Users/Users.tsx - eslint issue
• src/utils/interfaces.ts - removed unused InterfaceQueryRequestListItem and leaving InterfaceUserType as it is
• src/utils/memberFields.ts

[github-actions]

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

1. The overall code coverage drops below the target threshold of the repository
2. Any file in the pull request has code coverage levels below the repository threshold
3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

1. comments in this PR or
2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

1. arbitrators of future discussions with other contributors about the validity of your changes
2. point of contact for evaluating the validity of your work
3. person who verifies matching issues by others that should be closed.
4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

1. PRs with issues not assigned to you will be closed by the reviewer
2. Fix the first comment in the PR so that each issue listed automatically closes

Other

1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
2. Read the CONTRIBUTING.md file make

[dhanagopu]

@pranshugupta54 Please fix the failing tests

[pranshugupta54]

• Introspection is irrelevant
• Added // eslint-disable-line to some lines which should be fixed separately (userType changes require me to fix lint in that file which is not relevant to this issue)

[palisadoes]

The lint check is too ensure we have consistent coffee quality.

It is therefore relevant to the PR

[pranshugupta54]

@palisadoes, we should take it separately. I haven't touched the functions which had linting issues, but fixed userType in those files. These eslint issues are there in the codebase for so long and should be taken in different issue or should be fixed by users working on the file. It's also going to take one person very long to understand each function of each file to fix those types.

[Anubhav-2003]

• Introspection is irrelevant

  • Added // eslint-disable-line to some lines which should be fixed separately (userType changes require me to fix lint in that file which is not relevant to this issue)

Hey can you please tell me why is the introspection failing? Because it was fixed, and now it is the duty of all new future PR's to ensure that it passes, otherwise it would nullify the entire point of having it in the workflow. Thank You.

[Anubhav-2003]

@palisadoes, we should take it separately. I haven't touched the functions which had linting issues, but fixed userType in those files. These eslint issues are there in the codebase for so long and should be taken in different issue or should be fixed by users working on the file. It's also going to take one person very long to understand each function of each file to fix those types.

Yes I agree with you on this point. Because the codebase has a lot of existing lint issues, and all of them cannot be solved trivially as one has to understand the context of each line to replace the 'any' types. I don't think having the eslint disable workflow as a blocker for the testing is the right choice. It should be there to notify the reviewers about its usage, but should not block the tests from running. Thank you.

[pranshugupta54]

Hey can you please tell me why is the introspection failing? Because it was fixed, and now it is the duty of all new future PR's to ensure that it passes, otherwise it would nullify the entire point of having it in the workflow. Thank You.
@Anubhav-2003, I don't think it's related to this PR.

Haven't changed mutation or schema

[palisadoes]

The application tests won't be completed until the linting is done.

This has been in place in this repo for months

[pranshugupta54]

@palisadoes, I've reverted 4 files to fix eslint issue. We can take those files later. Everything is passing well, except irrelevant introspection test.