-
-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx #1834
Added tests for src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx #1834
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1834 +/- ##
===========================================
+ Coverage 98.03% 98.09% +0.05%
===========================================
Files 199 199
Lines 4997 4991 -6
Branches 1447 1441 -6
===========================================
- Hits 4899 4896 -3
+ Misses 92 90 -2
+ Partials 6 5 -1 ☔ View full report in Codecov by Sentry. |
Do we need to have a new file for this? How are the current tests implemented for this file? Is it done in some other component? This file had 17/20 code coverage, how did 17 got covered without test file? Also this PR has some indirect changes, please fix them - https://app.codecov.io/gh/PalisadoesFoundation/talawa-admin/pull/1834/indirect-changes |
There is already an issue created for this file (link). |
Ohk, the indirect change is in a file which does not have a test file itself |
@tasneemkoushar @beingnoble03 Can you review this PR? |
b249d2f
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Added tests for src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx
Issue Number:
Fixes #1783
Did you add tests for your changes?
NA
Snapshots/Videos:
NA
If relevant, did you update the documentation?
NA
Summary
Added tests for src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx
Does this PR introduce a breaking change?
NA
Other information
NA
Have you read the contributing guide?
Yes