Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx #1834

Merged
merged 2 commits into from
Mar 30, 2024

Conversation

aarishshahmohsin
Copy link
Contributor

What kind of change does this PR introduce?

Added tests for src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx

Issue Number:

Fixes #1783

Did you add tests for your changes?

NA

Snapshots/Videos:

NA

If relevant, did you update the documentation?

NA

Summary

Added tests for src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx

Does this PR introduce a breaking change?

NA

Other information

NA

Have you read the contributing guide?

Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.09%. Comparing base (b9c5f79) to head (0d5af76).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1834      +/-   ##
===========================================
+ Coverage    98.03%   98.09%   +0.05%     
===========================================
  Files          199      199              
  Lines         4997     4991       -6     
  Branches      1447     1441       -6     
===========================================
- Hits          4899     4896       -3     
+ Misses          92       90       -2     
+ Partials         6        5       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pranshugupta54
Copy link
Member

Do we need to have a new file for this? How are the current tests implemented for this file? Is it done in some other component? This file had 17/20 code coverage, how did 17 got covered without test file?

Also this PR has some indirect changes, please fix them - https://app.codecov.io/gh/PalisadoesFoundation/talawa-admin/pull/1834/indirect-changes

@aarishshahmohsin
Copy link
Contributor Author

@pranshugupta54

Do we need to have a new file for this? How are the current tests implemented for this file? Is it done in some other component? This file had 17/20 code coverage, how did 17 got covered without test file?

hello
There are no tests for this file right now in the develop branch. It is a recently created file and it is recommended to have separate testing files for different components.

Also this PR has some indirect changes, please fix them - app.codecov.io/gh/PalisadoesFoundation/talawa-admin/pull/1834/indirect-changes

There is already an issue created for this file (link).
Making separate tests for it would not make other tests impact its coverage.

@pranshugupta54
Copy link
Member

There is already an issue created for this file (link). Making separate tests for it would not make other tests impact its coverage.

Ohk, the indirect change is in a file which does not have a test file itself src/screens/OrgList/OrganizationModal.tsx and relies on parent component

@Cioppolo14
Copy link
Contributor

@tasneemkoushar @beingnoble03 Can you review this PR?

@palisadoes palisadoes merged commit b249d2f into PalisadoesFoundation:develop Mar 30, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants