-
-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1514 redesign the Posts screen for the talawa user portal #1731
Fixes #1514 redesign the Posts screen for the talawa user portal #1731
Conversation
…awa user portal
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1731 +/- ##
===========================================
- Coverage 97.94% 97.79% -0.16%
===========================================
Files 178 178
Lines 4382 4345 -37
Branches 1259 1241 -18
===========================================
- Hits 4292 4249 -43
- Misses 87 93 +6
Partials 3 3 ☔ View full report in Codecov by Sentry. |
…awa user portal
I am not able to figureout why the graphql test is not passing. it is working locally in my system. I have also fetch the lastest change of the backend. |
@gauravsingh94 Can you fix the failing codecov checks? |
@Cioppolo14 I have added the tests. |
@gauravsingh94 The test application check is still failing. Can you fix it? |
@aashimawadhwa @rishav-jha-mech In redesigning the User Portal, Are we removing the comment functionality on posts? Can clarify this? |
This is an update on the PR merging freeze:
We decided to do this at the beginning of the weekend to give us all time to adjust PR code and create bug fixes that may arise. Update your code at or after midnight GMT on the morning of March 23, 2024. (5:30am IST). If your PRs have already been approved, request a re-review after fixing the conflicts and refactoring to the new |
The PR merging freeze is lifted.
Background:
|
@gauravsingh94 Please fix the conflicting files and failed tests. |
This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work. |
Closing as potentially abandoned. We can reopen it if requested. |
What kind of change does this PR introduce?
Issue Number:
Fixes #1514
Did you add tests for your changes?
Yes
Snapshots/Videos:
Screenrecod.webm
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
Yes