-
-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade: add sass instead of node-sass #1665
upgrade: add sass instead of node-sass #1665
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1665 +/- ##
===========================================
- Coverage 97.48% 97.39% -0.09%
===========================================
Files 157 168 +11
Lines 3854 4148 +294
Branches 1140 1206 +66
===========================================
+ Hits 3757 4040 +283
- Misses 93 105 +12
+ Partials 4 3 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Update the documentation about how to use this package
- Revert any unnecessary changes you make to Markdown files
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/assets/css/app.css.map
Add the documentation for debugging for this file too
52fefa1
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
dependency upgrade
Issue Number:
Fixes #1503
Did you add tests for your changes?
not needed
If relevant, did you update the documentation?
CODE_STYLE.md updated
Summary
node-sass is deprecated and is causing build errors. We should use sass instead.
Does this PR introduce a breaking change?
no
Have you read the contributing guide?
yes