-
-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed all eslint-disable lines and added workflow for checking. #1617
Removed all eslint-disable lines and added workflow for checking. #1617
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1617 +/- ##
===========================================
- Coverage 98.09% 98.09% -0.01%
===========================================
Files 138 138
Lines 3681 3673 -8
Branches 1132 1130 -2
===========================================
- Hits 3611 3603 -8
Misses 64 64
Partials 6 6 ☔ View full report in Codecov by Sentry. |
@aarishshahmohsin Please fix the failing code patch test. |
@palisadoes @Cioppolo14 The test for src/components/AddOn/core/AddOnStore/AddOnStore.tsx is not complete. It only has a temporary test. Link |
@palisadoes @Cioppolo14 Is there any update? |
Please rectify it |
@palisadoes I have made the necessary changes. |
@palisadoes, please review the submitted PR or close it. |
edd3337
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
This PR does 2 things:
Issue Number:
Fixes #1460
Did you add tests for your changes?
Yes
Snapshots/Videos:
NA
If relevant, did you update the documentation?
NA
Summary
Eslint-disable statements are used for ignoring the below violations of the linting rules. This PR ensures that the tests fail if there is an eslint-disable statement.
Does this PR introduce a breaking change?
No
Other information
NA
Have you read the contributing guide?
Yes