Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed all eslint-disable lines and added workflow for checking. #1617

Merged
merged 8 commits into from
Feb 29, 2024

Conversation

aarishshahmohsin
Copy link
Contributor

What kind of change does this PR introduce?

This PR does 2 things:

  1. Removes all eslint-disable lines and fixes the underlying errors that were causing the placement of these lines.
  2. Adds a github workflow to check if any new PR contains an eslint-disable comment.

Issue Number:

Fixes #1460

Did you add tests for your changes?

Yes

Snapshots/Videos:

NA

If relevant, did you update the documentation?

NA

Summary

Eslint-disable statements are used for ignoring the below violations of the linting rules. This PR ensures that the tests fail if there is an eslint-disable statement.

Does this PR introduce a breaking change?
No

Other information

NA

Have you read the contributing guide?

Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.09%. Comparing base (092b9f6) to head (de4a2a9).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1617      +/-   ##
===========================================
- Coverage    98.09%   98.09%   -0.01%     
===========================================
  Files          138      138              
  Lines         3681     3673       -8     
  Branches      1132     1130       -2     
===========================================
- Hits          3611     3603       -8     
  Misses          64       64              
  Partials         6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Aarish Shah Mohsin added 2 commits February 25, 2024 17:29
@Cioppolo14 Cioppolo14 removed the request for review from palisadoes February 25, 2024 13:59
@Cioppolo14
Copy link
Contributor

@aarishshahmohsin Please fix the failing code patch test.

@aarishshahmohsin
Copy link
Contributor Author

aarishshahmohsin commented Feb 26, 2024

@aarishshahmohsin Please fix the failing code patch test.

@palisadoes @Cioppolo14 The test for src/components/AddOn/core/AddOnStore/AddOnStore.tsx is not complete. It only has a temporary test. Link
I will have to make a complete test on my own. Should I do it?

@aarishshahmohsin
Copy link
Contributor Author

@palisadoes @Cioppolo14 Is there any update?

@palisadoes
Copy link
Contributor

@aarishshahmohsin Please fix the failing code patch test.

@palisadoes @Cioppolo14 The test for src/components/AddOn/core/AddOnStore/AddOnStore.tsx is not complete. It only has a temporary test. Link
I will have to make a complete test on my own. Should I do it?

Please rectify it

@aarishshahmohsin
Copy link
Contributor Author

@palisadoes I have made the necessary changes.

@aarishshahmohsin
Copy link
Contributor Author

@palisadoes, please review the submitted PR or close it.

@palisadoes palisadoes merged commit edd3337 into PalisadoesFoundation:develop Feb 29, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants