-
-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed jest-enzyme and enzyme-react-adapter-17 #1541
Removed jest-enzyme and enzyme-react-adapter-17 #1541
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1541 +/- ##
========================================
Coverage 96.50% 96.50%
========================================
Files 134 134
Lines 3522 3522
Branches 1092 1092
========================================
Hits 3399 3399
Misses 118 118
Partials 5 5 ☔ View full report in Codecov by Sentry. |
@aarishshahmohsin Can you please fix the failing introspection test? We are working on a fix to this issue for future Prs. |
this is because the UpdateUserInput schema in talawa admin is
while in talawa api it is
the schema that is being used in talawa admin for the form input and will require changing the UserUpdate and Settings component or changing the api. There might be some past PR that might have caused it. |
@Cioppolo14 furthermore is applangcode and id to be added in the api schema. should an issue be raised in the talawa-api repository? |
@aarishshahmohsin I will assign reviewers. I believe there is an issue out there to fix this, but let me confirm. |
@aarishshahmohsin There is an issue for this, no new issue is needed. Thank you. |
@Cioppolo14 @palisadoes this is gtg 👍🏼 |
66ecb91
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
This PR removed jest-enzyme and enzyme-adapter-react-17 and refactored the code.
Issue Number:
Fixes #1536
Did you add tests for your changes?
NA
Snapshots/Videos:
NA
If relevant, did you update the documentation?
Yes
Summary
jest-enzyme does not support React 17 and above and is supported by the use of an unofficial adapter. This PR removes the package.
Does this PR introduce a breaking change?
No
Other information
Should there be a disclaimer in the installation.md file for only using react-testing-library?
Have you read the contributing guide?
Yes