Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed jest-enzyme and enzyme-react-adapter-17 #1541

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

aarishshahmohsin
Copy link
Contributor

What kind of change does this PR introduce?

This PR removed jest-enzyme and enzyme-adapter-react-17 and refactored the code.

Issue Number:

Fixes #1536

Did you add tests for your changes?
NA

Snapshots/Videos:
NA

If relevant, did you update the documentation?

Yes

Summary
jest-enzyme does not support React 17 and above and is supported by the use of an unofficial adapter. This PR removes the package.

Does this PR introduce a breaking change?
No

Other information
Should there be a disclaimer in the installation.md file for only using react-testing-library?

Have you read the contributing guide?
Yes

Copy link

github-actions bot commented Feb 4, 2024

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (01a8c9f) 96.50% compared to head (ab02fbd) 96.50%.
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1541   +/-   ##
========================================
  Coverage    96.50%   96.50%           
========================================
  Files          134      134           
  Lines         3522     3522           
  Branches      1092     1092           
========================================
  Hits          3399     3399           
  Misses         118      118           
  Partials         5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cioppolo14
Copy link
Contributor

@aarishshahmohsin Can you please fix the failing introspection test? We are working on a fix to this issue for future Prs.

@aarishshahmohsin
Copy link
Contributor Author

@aarishshahmohsin Can you please fix the failing introspection test? We are working on a fix to this issue for future Prs.

this is because the UpdateUserInput schema in talawa admin is

input UpdateUserInput {
  id: ID
  email: EmailAddress
  firstName: String
  lastName: String
  applangcode: String
}

while in talawa api it is

input UpdateUserInput {
  address: AddressInput
  birthDate: Date
  educationGrade: EducationGrade
  email: EmailAddress
  employmentStatus: EmploymentStatus
  firstName: String
  gender: Gender
  lastName: String
  maritalStatus: MaritalStatus
  phone: UserPhoneInput
}

the schema that is being used in talawa admin for the form input and will require changing the UserUpdate and Settings component or changing the api. There might be some past PR that might have caused it.

@aarishshahmohsin
Copy link
Contributor Author

@aarishshahmohsin Can you please fix the failing introspection test? We are working on a fix to this issue for future Prs.

this is because the UpdateUserInput schema in talawa admin is

input UpdateUserInput {
  id: ID
  email: EmailAddress
  firstName: String
  lastName: String
  applangcode: String
}

while in talawa api it is

input UpdateUserInput {
  address: AddressInput
  birthDate: Date
  educationGrade: EducationGrade
  email: EmailAddress
  employmentStatus: EmploymentStatus
  firstName: String
  gender: Gender
  lastName: String
  maritalStatus: MaritalStatus
  phone: UserPhoneInput
}

the schema that is being used in talawa admin for the form input and will require changing the UserUpdate and Settings component or changing the api. There might be some past PR that might have caused it.

@Cioppolo14 furthermore is applangcode and id to be added in the api schema. should an issue be raised in the talawa-api repository?

@Cioppolo14
Copy link
Contributor

@aarishshahmohsin I will assign reviewers. I believe there is an issue out there to fix this, but let me confirm.

@Cioppolo14
Copy link
Contributor

@aarishshahmohsin There is an issue for this, no new issue is needed. Thank you.

@aashimawadhwa
Copy link
Member

aashimawadhwa commented Feb 6, 2024

@Cioppolo14 @palisadoes this is gtg 👍🏼

@palisadoes palisadoes merged commit 66ecb91 into PalisadoesFoundation:develop Feb 6, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants