Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed custom field submission on Enter key press #1524

Conversation

akhilender-bongirwar
Copy link
Contributor

What kind of change does this PR introduce?
BugFix: - Resolves an issue where pressing the "Enter" key while adding a custom field in the settings was triggering an error.

Issue Number:

Fixes #1395

Did you add tests for your changes?
Yes

Snapshots/Videos:

2024-01-31.16-25-12.mp4

If relevant, did you update the documentation?
No

Summary

  • Modified the handling of form submission to ensure that the custom field is added successfully whether the "Submit" button is clicked or the "Enter" key is pressed.
  • Ensured all the modified lines are covered by tests and no other functionality is affected.

Does this PR introduce a breaking change?
No

Other information

Have you read the contributing guide?
Yes

- Resolves an issue where pressing the "Enter" key while adding a custom field in the settings was triggering an error.
- Modified the handling of form submission to ensure that the custom field is added successfully whether the "Submit" button
  is clicked or the "Enter" key is pressed.
- Ensured all the modified lines are covered by tests and no other functionality is affected.

Signed-off-by: Akhilender <[email protected]>
Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c756a73) 96.23% compared to head (66c614e) 96.24%.
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1524   +/-   ##
========================================
  Coverage    96.23%   96.24%           
========================================
  Files          133      133           
  Lines         3404     3408    +4     
  Branches      1031     1032    +1     
========================================
+ Hits          3276     3280    +4     
  Misses         123      123           
  Partials         5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cioppolo14
Copy link
Contributor

@akhilender-bongirwar Please fix the failing test.

@Cioppolo14
Copy link
Contributor

@akhilender-bongirwar We are working on a fix, for now can you update the schema file to address UpdateUserInput.

@akhilender-bongirwar
Copy link
Contributor Author

@Cioppolo14 , the failing GraphQL schema introspection workflow is due to the merged #1499 where applang and id was added to the UpdateUserInput input in the schema intalawa- admin portal. However, there are no corresponding changes in talawa-api, which is causing the workflow to fail.

@akhilender-bongirwar
Copy link
Contributor Author

akhilender-bongirwar commented Feb 1, 2024

@akhilender-bongirwar We are working on a fix, for now can you update the schema file to address UpdateUserInput.

Ma'am, there is no need to change the schema in talawa-admin as it has already been added in schema. We need to add it to talawa-api instead, which is being fixed in PR #1762

@Cioppolo14
Copy link
Contributor

@akhilender-bongirwar I understand. Thanks for being patient with this.

@Cioppolo14
Copy link
Contributor

@Kevoniat @tasneemkoushar Can you review this PR?

Copy link
Member

@noman2002 noman2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@palisadoes palisadoes merged commit 13be298 into PalisadoesFoundation:develop Feb 3, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants