-
-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixed custom field submission on Enter key press #1524
fix: Fixed custom field submission on Enter key press #1524
Conversation
- Resolves an issue where pressing the "Enter" key while adding a custom field in the settings was triggering an error. - Modified the handling of form submission to ensure that the custom field is added successfully whether the "Submit" button is clicked or the "Enter" key is pressed. - Ensured all the modified lines are covered by tests and no other functionality is affected. Signed-off-by: Akhilender <[email protected]>
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1524 +/- ##
========================================
Coverage 96.23% 96.24%
========================================
Files 133 133
Lines 3404 3408 +4
Branches 1031 1032 +1
========================================
+ Hits 3276 3280 +4
Misses 123 123
Partials 5 5 ☔ View full report in Codecov by Sentry. |
@akhilender-bongirwar Please fix the failing test. |
@akhilender-bongirwar We are working on a fix, for now can you update the schema file to address UpdateUserInput. |
@Cioppolo14 , the failing GraphQL schema introspection workflow is due to the merged #1499 where |
Ma'am, there is no need to change the schema in |
@akhilender-bongirwar I understand. Thanks for being patient with this. |
@Kevoniat @tasneemkoushar Can you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
13be298
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
BugFix: - Resolves an issue where pressing the "Enter" key while adding a custom field in the settings was triggering an error.
Issue Number:
Fixes #1395
Did you add tests for your changes?
Yes
Snapshots/Videos:
2024-01-31.16-25-12.mp4
If relevant, did you update the documentation?
No
Summary
Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
Yes