-
-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added validation for links in advertisement #1516
feat: added validation for links in advertisement #1516
Conversation
- Implemented validation for the `formState.link` field to ensure that it represents a valid URL. - Proper The validation checks have been added to prevent users from submitting arbitrary or invalid strings when creating a new advertisement. - Added tests for the modified code. - Ensured no other functionality or tests fail after the changes. Signed-off-by: Akhilender <[email protected]>
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1516 +/- ##
===========================================
+ Coverage 96.23% 96.25% +0.01%
===========================================
Files 133 134 +1
Lines 3404 3420 +16
Branches 1031 1037 +6
===========================================
+ Hits 3276 3292 +16
Misses 123 123
Partials 5 5 ☔ View full report in Codecov by Sentry. |
@akhilender-bongirwar Please fix the failing test. |
The failing tests are not a result of the changes I made. However, the error message |
@akhilender-bongirwar Ok, we need to get to the cause of the error, to make sure API & Admin work together. I will ask for help. |
@akhilender-bongirwar UsertoReturn is in the API code base, probably from a recent merge. Please add a reference to it in the src/GraphQl directory tree of the Admin code. See if that clears the error. |
188a8cc
to
ea0b261
Compare
d8ca512
to
5a89447
Compare
@Cioppolo14 , the failing GraphQL schema introspection workflow is due to the merged PR #1499, where |
@Cioppolo14 , please add reviewers even for this PR. |
@palisadoes please review. |
@noman2002 @SiddheshKukade , Kindly review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
85c5534
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
This PR introduces validation of link in the advertisements screen.
Issue Number:
Fixes #1479
Did you add tests for your changes?
Yes
Snapshots/Videos:
2024-01-29.15-36-03.mp4
If relevant, did you update the documentation?
Not relevant
Summary
formState.link
field to ensure that it represents a valid URL.Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
Yes