Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected placeholder text, added missing inputs(video,images) and their tests to edit post feature present in Admin role. #1483

Merged
merged 14 commits into from
Jan 28, 2024

Conversation

Anvita0305
Copy link
Contributor

What kind of change does this PR introduce?
Bugfix

Issue Number:

Fixes #1477

Did you add tests for your changes?

Yes

Snapshots/Videos:

Screencast.from.23-01-24.07.39.47.PM.IST.webm

Summary

  1. Initially the placeholder values were OrgPostCard.postTitle1 and OrgPostCard.information respectively. Corrected those in all the languages.
  2. Initially there was no option for editing image and video after the post was created, add it.
  3. Added relevant testing code

Does this PR introduce a breaking change?

No

Other information

Have you read the contributing guide?
Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@Anvita0305 Anvita0305 changed the title Correct placeholder text, added missing inputs(video,images) and their tests to edit post feature present in Admin role. Corrected placeholder text, added missing inputs(video,images) and their tests to edit post feature present in Admin role. Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (83b1234) 97.10% compared to head (a741d4c) 96.25%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1483      +/-   ##
===========================================
- Coverage    97.10%   96.25%   -0.85%     
===========================================
  Files          133      133              
  Lines         3422     3422              
  Branches      1041     1041              
===========================================
- Hits          3323     3294      -29     
- Misses          94      123      +29     
  Partials         5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cioppolo14
Copy link
Contributor

@noman2002 @tasneemkoushar Can you review this PR?

Copy link
Member

@noman2002 noman2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks fine to me. Merge the latest code into this.

@palisadoes
Copy link
Contributor

Please merge the latest upstream into this PR.

The tests should then all pass

@Anvita0305
Copy link
Contributor Author

Hello @noman2002 @palisadoes I have merged the latest upstream in this PR. Can you please review it? Thanks!

@Anvita0305 Anvita0305 requested a review from noman2002 January 28, 2024 06:25
@palisadoes palisadoes merged commit 8d34a8b into PalisadoesFoundation:develop Jan 28, 2024
9 of 10 checks passed
@Anvita0305 Anvita0305 deleted the develop3 branch January 28, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants