-
-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected placeholder text, added missing inputs(video,images) and their tests to edit post feature present in Admin role. #1483
Corrected placeholder text, added missing inputs(video,images) and their tests to edit post feature present in Admin role. #1483
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1483 +/- ##
===========================================
- Coverage 97.10% 96.25% -0.85%
===========================================
Files 133 133
Lines 3422 3422
Branches 1041 1041
===========================================
- Hits 3323 3294 -29
- Misses 94 123 +29
Partials 5 5 ☔ View full report in Codecov by Sentry. |
@noman2002 @tasneemkoushar Can you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks fine to me. Merge the latest code into this.
Please merge the latest upstream into this PR. The tests should then all pass |
Hello @noman2002 @palisadoes I have merged the latest upstream in this PR. Can you please review it? Thanks! |
8d34a8b
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Bugfix
Issue Number:
Fixes #1477
Did you add tests for your changes?
Yes
Snapshots/Videos:
Screencast.from.23-01-24.07.39.47.PM.IST.webm
Summary
Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
Yes