-
-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed event date and time picker #1475
Changed event date and time picker #1475
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1475 +/- ##
========================================
Coverage 97.20% 97.20%
========================================
Files 133 133
Lines 3396 3399 +3
Branches 1038 1038
========================================
+ Hits 3301 3304 +3
Misses 90 90
Partials 5 5 ☔ View full report in Codecov by Sentry. |
@rishav-jha-mech @aashimawadhwa Please take a look at this PR. |
@rishav-jha-mech @aashimawadhwa Is there any update? |
@Cioppolo14 Is there any update with regards to the PR. I am not able to move on to other issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. thanks @aarishshahmohsin
c647157
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
This PR changes the event Time Picker and Date Picker to Material UI ones.
Issue Number:
Fixes #1239
Did you add tests for your changes?
Yes
Snapshots/Videos:
2024-01-22.17-25-44.mp4
If relevant, did you update the documentation?
Summary
This PR modernizes and makes the Date Picker and Time Picker more user friendly.
Does this PR introduce a breaking change?
No
Other information
I have added a global Material UI Theme in the index.ts file as well
Have you read the contributing guide?
Yes