-
-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: setup script for .env configuration file #1461
feat: setup script for .env configuration file #1461
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Please take a look at this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1461 +/- ##
===========================================
- Coverage 97.39% 97.20% -0.19%
===========================================
Files 143 133 -10
Lines 3640 3396 -244
Branches 1073 1038 -35
===========================================
- Hits 3545 3301 -244
Misses 90 90
Partials 5 5 ☔ View full report in Codecov by Sentry. |
Please refer to this comment #1459 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
Please make the suggested changes and let's get this PR merged. |
The reason for the files being submitted was that you hadn't synced your branch with the latest upstream that had applied all those changes already. |
What kind of change does this PR introduce?
Issue Number:
Fixes #1233
Did you add tests for your changes?
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?