Preventing default action when pressing Enter key to add custom fields in Settings - Fixes #1395

[karthxk07]

What kind of change does this PR introduce?

Bugfix

Issue Number:

Fixes #1395

Did you add tests for your changes?

Yes

Snapshots/Videos:

Screencast.from.2024-01-10.23-25-28.webm

If relevant, did you update the documentation?

No, No documentation changes were needed

Summary

This pull request addresses an issue where an error was triggered when clicking "Enter" instead of the submit button for adding new custom fields in the settings page. The root cause was that the form was being submitted when pressing "Enter," resulting in unexpected behavior. To fix this, I added a preventDefault action to the form submission and then called the handleSave function.

Does this PR introduce a breaking change?

No, this PR does not introduce any breaking changes.

Other information

[x] I've tested this fix thoroughly on various browsers to ensure compatibility.
[x] The code follows the coding standards and guidelines outlined in the contributing guide.
[x] This change has been made against the develop branch.

Have you read the contributing guide?

Yes

[github-actions]

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

1. The overall code coverage drops below the target threshold of the repository
2. Any file in the pull request has code coverage levels below the repository threshold
3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

1. comments in this PR or
2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

1. arbitrators of future discussions with other contributors about the validity of your changes
2. point of contact for evaluating the validity of your work
3. person who verifies matching issues by others that should be closed.
4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

1. PRs with issues not assigned to you will be closed by the reviewer
2. Fix the first comment in the PR so that each issue listed automatically closes

Other

1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
2. Read the CONTRIBUTING.md file make

[aashimawadhwa]

src/components/OrgProfileFieldSettings/OrgProfileFieldSettings.tsx can you run prettier and check why the PR workflow is failing.

[karthxk07]

@aashimawadhwa umm, ok

[karthxk07]

@aashimawadhwa I have updated the file in question, can you please review this now

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (59dae2c) 97.35% compared to head (db02a37) 97.27%.

Files	Patch %	Lines
...rgProfileFieldSettings/OrgProfileFieldSettings.tsx	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1417      +/-   ##
===========================================
- Coverage    97.35%   97.27%   -0.09%     
===========================================
  Files          136      136              
  Lines         3560     3563       +3     
  Branches      1036     1036              
===========================================
  Hits          3466     3466              
- Misses          89       92       +3     
  Partials         5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[karthxk07]

@aashimawadhwa How do i get codecov to pass, Do i have to add any tests anywhere?