-
-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Inconsistent Use of Icons to Minimize Left Column Navbar in Event Management Screen #1403
Fixed Inconsistent Use of Icons to Minimize Left Column Navbar in Event Management Screen #1403
Conversation
- Implemented the same minimization method used in the main organization pages, ensuring a consistent user experience throughout the application. Signed-off-by: Akhilender <[email protected]>
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1403 +/- ##
========================================
Coverage 97.44% 97.45%
========================================
Files 138 138
Lines 3683 3690 +7
Branches 1076 1079 +3
========================================
+ Hits 3589 3596 +7
Misses 89 89
Partials 5 5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@palisadoes according to the solution stated in the issue, I have implemented the same method for opening and closing the sidebar as used in the remaining main organization pages to maintain consistency throughout the application. Please check the video below. 2024-01-09.14-31-08.mp4 |
We'll need to open another issue specifically for the modification for consistency |
What kind of change does this PR introduce?
Issue Number:
Fixes #1240
Did you add tests for your changes?
Yes
Snapshots/Videos:
2024-01-07.23-45-07.mp4
If relevant, did you update the documentation?
No
Summary
Now there is consistency in minimization of the left column navbar in event mangement screen.
Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
Yes