Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Inconsistent Use of Icons to Minimize Left Column Navbar in Event Management Screen #1403

Conversation

akhilender-bongirwar
Copy link
Contributor

What kind of change does this PR introduce?

  • Implemented the same minimization method used in the main organization pages, ensuring a consistent user experience throughout the application.

Issue Number:

Fixes #1240

Did you add tests for your changes?
Yes

Snapshots/Videos:

2024-01-07.23-45-07.mp4

If relevant, did you update the documentation?
No

Summary
Now there is consistency in minimization of the left column navbar in event mangement screen.

Does this PR introduce a breaking change?
No

Other information

Have you read the contributing guide?

Yes

- Implemented the same minimization method used in the main organization pages,
  ensuring a consistent user experience throughout the application.

Signed-off-by: Akhilender <[email protected]>
Copy link

github-actions bot commented Jan 7, 2024

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (628b3f5) 97.44% compared to head (5fff5b5) 97.45%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1403   +/-   ##
========================================
  Coverage    97.44%   97.45%           
========================================
  Files          138      138           
  Lines         3683     3690    +7     
  Branches      1076     1079    +3     
========================================
+ Hits          3589     3596    +7     
  Misses          89       89           
  Partials         5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@EshaanAgg EshaanAgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention was for there to be a single way to expand and retract the left drawer. We still have two ways which is not intuitive.

  1. The expectation that this would be the sole methodology of expanding the drawer
    image
  2. And that this way would be the only way to retract it.
    image

In all cases on this screen

@akhilender-bongirwar
Copy link
Contributor Author

@palisadoes according to the solution stated in the issue, I have implemented the same method for opening and closing the sidebar as used in the remaining main organization pages to maintain consistency throughout the application. Please check the video below.

2024-01-09.14-31-08.mp4

@palisadoes palisadoes merged commit 100ce7a into PalisadoesFoundation:develop Jan 9, 2024
9 checks passed
@palisadoes
Copy link
Contributor

We'll need to open another issue specifically for the modification for consistency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants