Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed more button disappearing on calendar on small screens #1401

Merged
merged 6 commits into from
Jan 15, 2024

Conversation

pateldivyesh1323
Copy link
Contributor

What kind of change does this PR introduce?

Fixed disappearing of more button on events calendar page on small screens if there are less than or equal to 2 events.

Issue Number:

Fixes #1389

Did you add tests for your changes?

No

Snapshots/Videos:

Talawa.Events.-.Google.Chrome.2024-01-07.22-28-49.mp4

If relevant, did you update the documentation?

No

Does this PR introduce a breaking change?

No

Have you read the contributing guide?

Yes

Copy link

github-actions bot commented Jan 7, 2024

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (59dae2c) 97.35% compared to head (f6fcc31) 97.45%.

❗ Current head f6fcc31 differs from pull request most recent head 1e7be93. Consider uploading reports for the commit 1e7be93 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1401      +/-   ##
===========================================
+ Coverage    97.35%   97.45%   +0.09%     
===========================================
  Files          136      138       +2     
  Lines         3560     3690     +130     
  Branches      1036     1077      +41     
===========================================
+ Hits          3466     3596     +130     
  Misses          89       89              
  Partials         5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rishav-jha-mech
Copy link
Contributor

@pateldivyesh1323 the text should not be "More", instead put View All over there and also highlight that date

@pateldivyesh1323
Copy link
Contributor Author

@rishav-jha-mech Which date should I highlight, all dates with events or the date with expanded events?

@aashimawadhwa
Copy link
Member

@pateldivyesh1323 all the dates which have events created in them.

@pateldivyesh1323
Copy link
Contributor Author

@aashimawadhwa @rishav-jha-mech
I have made the changes.

image

image

Copy link
Member

@aashimawadhwa aashimawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@palisadoes palisadoes merged commit 642fc3a into PalisadoesFoundation:develop Jan 15, 2024
7 checks passed
@pateldivyesh1323 pateldivyesh1323 deleted the 1389 branch January 23, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants