-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixed more button disappearing on calendar on small screens #1401
fix: Fixed more button disappearing on calendar on small screens #1401
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1401 +/- ##
===========================================
+ Coverage 97.35% 97.45% +0.09%
===========================================
Files 136 138 +2
Lines 3560 3690 +130
Branches 1036 1077 +41
===========================================
+ Hits 3466 3596 +130
Misses 89 89
Partials 5 5 ☔ View full report in Codecov by Sentry. |
@pateldivyesh1323 the text should not be "More", instead put View All over there and also highlight that date |
@rishav-jha-mech Which date should I highlight, all dates with events or the date with expanded events? |
@pateldivyesh1323 all the dates which have events created in them. |
@aashimawadhwa @rishav-jha-mech |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What kind of change does this PR introduce?
Fixed disappearing of
more
button on events calendar page on small screens if there are less than or equal to 2 events.Issue Number:
Fixes #1389
Did you add tests for your changes?
No
Snapshots/Videos:
Talawa.Events.-.Google.Chrome.2024-01-07.22-28-49.mp4
If relevant, did you update the documentation?
No
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes