Manage Button UI Fixed

[duplixx]

What kind of change does this PR introduce?

Bugfix

Issue Number:

Fixes #1374

Did you add tests for your changes?

No

Snapshots/Videos:

Recording.2024-01-06.190918.mp4

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?

[github-actions]

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

1. The overall code coverage drops below the target threshold of the repository
2. Any file in the pull request has code coverage levels below the repository threshold
3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

1. comments in this PR or
2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

1. arbitrators of future discussions with other contributors about the validity of your changes
2. point of contact for evaluating the validity of your work
3. person who verifies matching issues by others that should be closed.
4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

1. PRs with issues not assigned to you will be closed by the reviewer
2. Fix the first comment in the PR so that each issue listed automatically closes

Other

1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
2. Read the CONTRIBUTING.md file make

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (655b6b3) 92.77% compared to head (175b578) 97.45%.
Report is 91 commits behind head on develop.

Files	Patch %	Lines
...rgProfileFieldSettings/OrgProfileFieldSettings.tsx	90.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1388      +/-   ##
===========================================
+ Coverage    92.77%   97.45%   +4.67%     
===========================================
  Files          134      138       +4     
  Lines         3238     3690     +452     
  Branches       904     1079     +175     
===========================================
+ Hits          3004     3596     +592     
+ Misses         225       89     -136     
+ Partials         9        5       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rishav-jha-mech]

@duplixx if i am not wrong, creating sample organization is just for Testing purposes, that is why it had a Flask icon, you should fix the Manage Button layout without removing the flask icon

[duplixx]

@duplixx if i am not wrong, creating sample organization is just for Testing purposes, that is why it had a Flask icon, you should fix the Manage Button layout without removing the flask icon

yeah @rishav-jha-mech previous implementation using conditional rendering
<Button onClick={handleClick} data-testid="manageBtn" className={styles.manageBtn} > {data && data?.isSampleOrganization && ( <FlaskIcon fill="var(--bs-white)" width={20} title={t('sampleOrganization')} /> )} {' '} {t('manage')} </Button>

If you insist on fixing the styling by adding the Flask icon, I can proceed with this approach. Should I proceed this way?

[rishav-jha-mech]

@duplixx yes you have to add that flask icon, or it will be difficult for the developers to differentiate b/w sample organizations and the ones created by them

[duplixx]

@rishav-jha-mech Yeah, totally agreed! Thanks. I'll make the changes.

[duplixx]

@rishav-jha-mech does this layout looks good??

[duplixx]

Talawa.Organizations.-.Google.Chrome.2024-01-07.01-05-43.mp4

here is the final preview @rishav-jha-mech

[rishav-jha-mech]

@duplixx the flask icon should be almost the same size of manage text, and on smaller screens the button should be of full width

[duplixx]

@rishav-jha-mech have a look !!

[rishav-jha-mech]

@duplixx push the changes for code review

[duplixx]

@rishav-jha-mech added changes !!

[duplixx]

issues resolved @rishav-jha-mech !!