Fixes Organization not found error in LeftDrawerOrg #1385
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
| @@ -18,19 +19,29 @@ import Loader from 'components/Loader/Loader'; | |||
|
|
|||
| type MemberDetailProps = { | |||
| id: string; // This is the userId | |||
| from?: string; | |||
| }; | |||
| type LocationStateProps = { | |||
There was a problem hiding this comment.
You could have used MemberDetailProps here, why create LocationStateProps which have similar keys ?, this is redundant
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| <img src={userImage} alt={`profile picture`} /> | ||
| ) : ( | ||
| <img | ||
| src={`https://api.dicebear.com/5.x/initials/svg?seed=${firstName}%20${lastName}`} |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
There was a problem hiding this comment.
Please fix this security vulnterability
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1385 +/- ##
===========================================
+ Coverage 96.23% 96.31% +0.07%
===========================================
Files 133 133
Lines 3404 3416 +12
Branches 1031 1045 +14
===========================================
+ Hits 3276 3290 +14
+ Misses 123 122 -1
+ Partials 5 4 -1 ☔ View full report in Codecov by Sentry. |
|
This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work. |
github-actions
bot
added
no-pr-activity
|
Closing due to inactivity |
|
|
@rishav-jha-mech removed the merge conflict, please review |
|
@noman2002 The introspection tests will fail for a few days as the API has new functionality that is not reflected in Admin. |
|
|
@palisadoes it's not fixed yet. To reproduce the error, login to talawa-admin and directly click on leftDrawer username (without opening any other page) Here is the video just after login. video1.mp4But, if we open any organization and then go back to homescreen then it will work because the URL doesn't get full changed (which it should be changed back to "/orglist" and not "/orglist/id=6776343783475434") video2.mp4 |
|
| <img src={userImage} alt={`profile picture`} /> | ||
| ) : ( | ||
| <img | ||
| src={`https://api.dicebear.com/5.x/initials/svg?seed=${firstName} ${lastName}`} |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
|
Please fix the failing tests
|
| @@ -133,7 +133,7 @@ | |||
| <img src={userImage} alt={`Profile Picture`} /> | |||
| ) : ( | |||
| <img | |||
| src={`https://api.dicebear.com/5.x/initials/svg?seed=${firstName}%20${lastName}`} | |||
| src={`https://api.dicebear.com/5.x/initials/svg?seed=${firstName} ${lastName}`} | |||
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
|
Closing due to inactivity. |
What kind of change does this PR introduce?
Bugfix
Fixes #1333
Did you add tests for your changes?
Yes
Snapshots/Videos:
leftdrawer.mp4
Does this PR introduce a breaking change?
No
Summary
When user profile is opened through the orglist page, an error is shown on the member page and redirected back to orglist page. I fixed the issue by conditionally renderingthe MemberDetails component.
Have you read the contributing guide?
Yes