feat: Removed Requests Screen from Superadmin Panel #1378
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
| @@ -5,7 +5,6 @@ import { useHistory } from 'react-router-dom'; | |||
| import { ReactComponent as AngleRightIcon } from 'assets/svgs/angleRight.svg'; | |||
| import { ReactComponent as LogoutIcon } from 'assets/svgs/logout.svg'; | |||
| import { ReactComponent as OrganizationsIcon } from 'assets/svgs/organizations.svg'; | |||
| import { ReactComponent as RequestsIcon } from 'assets/svgs/requests.svg'; | |||
There was a problem hiding this comment.
Check whether this icon is used somewhere else or not, if not then remove this svg file too
There was a problem hiding this comment.
Ok, I'll do that.
|
@KshitijTodkar48 you need to remove the test for Requests from LeftDrawer.test.ts too |
|
Please fix the conflicting files |
|
@rishav-jha-mech @palisadoes I am opening a new PR for this issue. |
|
Please reopen this PR. There is no reason to close it
Please be considerate of our volunteers time Do not open another one. Reopen this one. |
|
@palisadoes , Very sorry for the inconvenience, but I have already opened a new PR for this. While solving the conflicts, I messed up some git-workflow. So just to be on safer side, I deleted that branch completely. I'll take care to not repeat such an action in the future. Please let it go this time. |
What kind of change does this PR introduce?
Feature.
Issue Number:
Fixes #1375
Did you add tests for your changes?
No.
Snapshots/Videos:
Summary
This PR solves the issue #1375 by removing the request screen from Super-admin Panel along with its specific corresponding assets.
Does this PR introduce a breaking change?
No.
Have you read the contributing guide?
Yes.