Setup script for .env configuration file #1350

disha1202 · 2024-01-02T06:37:14Z

What kind of change does this PR introduce?

Issue Number:

Fixes #1233

Did you add tests for your changes?

No

Snapshots/Videos:

Screen.Recording.2024-01-02.at.12.18.53.PM.mov

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?

github-actions · 2024-01-02T06:37:42Z

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

The overall code coverage drops below the target threshold of the repository
Any file in the pull request has code coverage levels below the repository threshold
Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

comments in this PR or
our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

arbitrators of future discussions with other contributors about the validity of your changes
point of contact for evaluating the validity of your work
person who verifies matching issues by others that should be closed.
person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

PRs with issues not assigned to you will be closed by the reviewer
Fix the first comment in the PR so that each issue listed automatically closes

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
Read the CONTRIBUTING.md file make

into setup-script

codecov · 2024-01-02T06:52:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45920a7) 97.39% compared to head (49069c3) 96.99%.

❗ Current head 49069c3 differs from pull request most recent head cb73e16. Consider uploading reports for the commit cb73e16 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1350      +/-   ##
===========================================
- Coverage    97.39%   96.99%   -0.40%     
===========================================
  Files          143      137       -6     
  Lines         3640     3426     -214     
  Branches      1073      963     -110     
===========================================
- Hits          3545     3323     -222     
- Misses          90       98       +8     
  Partials         5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SiddheshKukade · 2024-01-02T08:52:05Z

Will check it thoroughly and confirm later.

palisadoes · 2024-01-05T22:52:13Z

@SiddheshKukade Please remember your review. It's been some time

SiddheshKukade · 2024-01-06T08:01:12Z

Looks good. I tried a few combinations

palisadoes

@disha1202

You have not updated INSTALLATION.md to make people know that the setup script exists
Use the one in the API repo as a guide

…awa-admin into setup-script

disha1202 · 2024-01-08T07:06:53Z

@palisadoes

I have updated the installation guide.
Please take a look.

palisadoes

@disha1202

The script does not check to see whether the API is actually running
The script assumes any character that is not N is yes. This is not valid
If you make any edits to the .env file in the script then any pre-existing comments already existing in the .env file are removed
If you make any edits to the .env file in the script and then hit CTRL-C then any pre-existing comments already existing in the .env file are removed
The script must assume a default of Y, if a pre-existing configuration parameter exists
If any value in the .env file is commented out but the rest are valid, the script fails telling you Please copy the contents of .env.example to .env file This is not valid. The script should automatically insert missing values

Please test the script more thoroughly

palisadoes

Please fix the failing test

…igurations exists, default Y is assumed, automatically insert missing values

disha1202 · 2024-01-11T11:54:15Z

Hi @palisadoes

I have made all the requested changes and also tested the script.

The tests are failing because of type errors in src/screens/OrgPost/OrgPost.tsx
which is not related to the changes in this PR.

…awa-admin into setup-script

palisadoes

@disha1202

I can't test. It hangs when testing the API URL when the URL is valid.

disha1202 · 2024-01-14T14:01:46Z

@disha1202

I can't test. It hangs when testing the API URL when the URL is valid.

It takes a little bit of time because we are making an API call to test whether the server is running or not.

Screen.Recording.2024-01-14.at.7.21.57.PM-2.mov

This reverts commit 7a31c8e.

disha1202 · 2024-01-18T07:08:04Z

@palisadoes
Fixed the failing tests which were related to this PR.

palisadoes · 2024-01-18T13:53:17Z

The tests are still failing. Please merge your code with the latest upstream

…awa-admin into setup-script

disha1202 · 2024-01-18T14:01:11Z

Updated the PR with the latest upstream.

The tests are still failing.

palisadoes · 2024-01-18T16:49:35Z

Tests are still failing

palisadoes · 2024-01-19T14:22:03Z

@disha1202

Merge your code with the latest upstream that may fix the failing Test Application tests.
The introspection one is being fixed elsewhere.

…awa-admin into setup-script

disha1202 · 2024-01-19T14:57:14Z

@disha1202

Merge your code with the latest upstream that may fix the failing Test Application tests.

The introspection one is being fixed elsewhere.

@palisadoes

I have updated the PR with the latest changes but the tests are still failing.

palisadoes · 2024-01-19T15:22:04Z

This file shouldn't be a part of this PR. That may be the cause

src/screens/OrgPost/OrgPost.tsx

disha1202 · 2024-01-19T16:11:52Z

This file shouldn't be a part of this PR. That may be the cause

src/screens/OrgPost/OrgPost.tsx

I updated src/screens/OrgPost/OrgPost.tsx to fix the type errors.

palisadoes · 2024-01-19T17:20:08Z

That file isn't required in this PR. It must not need included.

palisadoes · 2024-01-19T19:31:21Z

@disha1202

If this file is no longer in the PR, why is it being linted in the tests? Please make a minor commit to see whether it triggers the correct action

src/screens/OrgPost/OrgPost.tsx

palisadoes · 2024-01-19T20:00:45Z

@disha1202

We need this completed soon.
We have other PRs depending on updating the setup script. Like this one:
- Added Docker support for Talawa Admin repository #1453

…awa-admin into setup-script

disha1202 · 2024-01-20T08:34:04Z

@disha1202

If this file is no longer in the PR, why is it being linted in the tests? Please make a minor commit to see whether it triggers the correct action

src/screens/OrgPost/OrgPost.tsx

The tests are still failing for src/screens/OrgPost/OrgPost.tsx.

Should I try creating a new PR?

palisadoes · 2024-01-20T15:25:28Z

Yes. Please create a new one.

Closing

Setup script for .env configuration file

fd30f4c

disha1202 added 4 commits January 2, 2024 12:07

Merge branch 'develop' into setup-script

c452980

fix: typo

64f3632

Merge branch 'setup-script' of https://github.com/disha1202/talawa-admin

f50fe86

into setup-script

fix: error in package.json

49069c3

SiddheshKukade requested review from DMills27, AdityaBirangal, anwersayeed, SiddheshKukade, aashimawadhwa and Ayush0Chaudhary January 2, 2024 08:51

SiddheshKukade previously approved these changes Jan 6, 2024

View reviewed changes

palisadoes requested changes Jan 6, 2024

View reviewed changes

Updated installation guide

68134ac

disha1202 dismissed SiddheshKukade’s stale review via 68134ac January 8, 2024 06:52

Merge branch 'develop' of https://github.com/PalisadoesFoundation/tal…

b85dff5

…awa-admin into setup-script

disha1202 requested a review from palisadoes January 8, 2024 07:07

palisadoes requested changes Jan 8, 2024

View reviewed changes

fix: check api is running, existing comments are not removed, if conf…

3f30d8d

…igurations exists, default Y is assumed, automatically insert missing values

Merge branch 'develop' of https://github.com/PalisadoesFoundation/tal…

8fc561a

…awa-admin into setup-script

palisadoes requested changes Jan 13, 2024

View reviewed changes

disha1202 added 4 commits January 18, 2024 12:11

fix: failing tests

d0c419f

fix: formatting issues

7a31c8e

Revert "fix: formatting issues"

5ed7f45

This reverts commit 7a31c8e.

fix: formatting issues

42a3318

palisadoes previously approved these changes Jan 18, 2024

View reviewed changes

Merge branch 'develop' of https://github.com/PalisadoesFoundation/tal…

2464e86

…awa-admin into setup-script

fix: failing tests

78499de

disha1202 dismissed palisadoes’s stale review via 78499de January 18, 2024 14:22

disha1202 added 2 commits January 18, 2024 20:19

fix: type errors

58aee4e

fix: removed unused variables

6fd570b

Devesh326 mentioned this pull request Jan 19, 2024

Added Docker support for Talawa Admin repository #1453

Closed

Merge branch 'develop' of https://github.com/PalisadoesFoundation/tal…

6428cab

…awa-admin into setup-script

Added comments

35eabf1

revert: unwanted changes

31cda90

Merge branch 'develop' of https://github.com/PalisadoesFoundation/tal…

cb73e16

…awa-admin into setup-script

palisadoes closed this Jan 20, 2024

disha1202 mentioned this pull request Feb 6, 2024

feat: implemented support to upload media while creating and updating advertisements #1529

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setup script for .env configuration file #1350

Setup script for .env configuration file #1350

disha1202 commented Jan 2, 2024 •

edited

Loading

github-actions bot commented Jan 2, 2024

codecov bot commented Jan 2, 2024 •

edited

Loading

SiddheshKukade commented Jan 2, 2024

palisadoes commented Jan 5, 2024

SiddheshKukade commented Jan 6, 2024

palisadoes left a comment

disha1202 commented Jan 8, 2024

palisadoes left a comment

palisadoes left a comment

disha1202 commented Jan 11, 2024 •

edited

Loading

palisadoes left a comment

disha1202 commented Jan 14, 2024 •

edited

Loading

disha1202 commented Jan 18, 2024

palisadoes commented Jan 18, 2024

disha1202 commented Jan 18, 2024

palisadoes commented Jan 18, 2024

palisadoes commented Jan 19, 2024

disha1202 commented Jan 19, 2024

palisadoes commented Jan 19, 2024

disha1202 commented Jan 19, 2024

palisadoes commented Jan 19, 2024

palisadoes commented Jan 19, 2024

palisadoes commented Jan 19, 2024 •

edited

Loading

disha1202 commented Jan 20, 2024 •

edited

Loading

palisadoes commented Jan 20, 2024

Setup script for .env configuration file #1350

Setup script for .env configuration file #1350

Conversation

disha1202 commented Jan 2, 2024 • edited Loading

github-actions bot commented Jan 2, 2024

Our Pull Request Approval Process

Testing Your Code

Reviewers

Reviewing Your Code

CONTRIBUTING.md

Other

codecov bot commented Jan 2, 2024 • edited Loading

Codecov Report

SiddheshKukade commented Jan 2, 2024

palisadoes commented Jan 5, 2024

SiddheshKukade commented Jan 6, 2024

palisadoes left a comment

Choose a reason for hiding this comment

disha1202 commented Jan 8, 2024

palisadoes left a comment

Choose a reason for hiding this comment

palisadoes left a comment

Choose a reason for hiding this comment

disha1202 commented Jan 11, 2024 • edited Loading

palisadoes left a comment

Choose a reason for hiding this comment

disha1202 commented Jan 14, 2024 • edited Loading

disha1202 commented Jan 18, 2024

palisadoes commented Jan 18, 2024

disha1202 commented Jan 18, 2024

palisadoes commented Jan 18, 2024

palisadoes commented Jan 19, 2024

disha1202 commented Jan 19, 2024

palisadoes commented Jan 19, 2024

disha1202 commented Jan 19, 2024

palisadoes commented Jan 19, 2024

palisadoes commented Jan 19, 2024

palisadoes commented Jan 19, 2024 • edited Loading

disha1202 commented Jan 20, 2024 • edited Loading

palisadoes commented Jan 20, 2024

disha1202 commented Jan 2, 2024 •

edited

Loading

codecov bot commented Jan 2, 2024 •

edited

Loading

disha1202 commented Jan 11, 2024 •

edited

Loading

disha1202 commented Jan 14, 2024 •

edited

Loading

palisadoes commented Jan 19, 2024 •

edited

Loading

disha1202 commented Jan 20, 2024 •

edited

Loading