Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Linting Only to Files Updated in git #1318

Closed
wants to merge 0 commits into from
Closed

Apply Linting Only to Files Updated in git #1318

wants to merge 0 commits into from

Conversation

Shubh152
Copy link
Contributor

What kind of change does this PR introduce?

feature-request

Issue Number:

Fixes #1270

Did you add tests for your changes?

Snapshots/Videos:

If relevant, did you update the documentation?

Summary
Checks linting rules only for files that are staged for commit, will work with any changes to eslint or prettier configuration.
Uses lint-staged package with existing git hooks

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?

Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a7e4663) 96.30% compared to head (6890a74) 96.30%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1318   +/-   ##
========================================
  Coverage    96.30%   96.30%           
========================================
  Files          137      137           
  Lines         3387     3387           
  Branches       949      949           
========================================
  Hits          3262     3262           
  Misses         119      119           
  Partials         6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package.json Outdated
Comment on lines 76 to 80
"lint:check": "eslint \"**/*.{ts,tsx}\" --max-warnings=0",
"lint:fix": "eslint \"**/*.{ts,tsx}\" --fix",
"format:fix": "prettier --write \"**/*.{ts,tsx,json,scss,css}\"",
"lint:fix": "eslint --fix",
"format:fix": "prettier --write",
"format:check": "prettier --check \"**/*.{ts,tsx,json,scss,css}\"",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these changes are required ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because lint-staged provides the staged files based on glob patterns specified in .lintstagedrc.json to these commands, So the glob patterns hard-coded in the commands need to be removed.

Image from lint-staged npm page:-
Screenshot from 2023-12-30 19-18-04

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thank you.

@Shubh152 Shubh152 requested a review from noman2002 December 31, 2023 04:13
@noman2002
Copy link
Member

@Shubh152 Please fix the conflicting files. Rest looks good to me.

@Shubh152 Shubh152 closed this Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants