-
-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply Linting Only to Files Updated in git #1318
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1318 +/- ##
========================================
Coverage 96.30% 96.30%
========================================
Files 137 137
Lines 3387 3387
Branches 949 949
========================================
Hits 3262 3262
Misses 119 119
Partials 6 6 ☔ View full report in Codecov by Sentry. |
package.json
Outdated
"lint:check": "eslint \"**/*.{ts,tsx}\" --max-warnings=0", | ||
"lint:fix": "eslint \"**/*.{ts,tsx}\" --fix", | ||
"format:fix": "prettier --write \"**/*.{ts,tsx,json,scss,css}\"", | ||
"lint:fix": "eslint --fix", | ||
"format:fix": "prettier --write", | ||
"format:check": "prettier --check \"**/*.{ts,tsx,json,scss,css}\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these changes are required ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thank you.
@Shubh152 Please fix the conflicting files. Rest looks good to me. |
What kind of change does this PR introduce?
feature-request
Issue Number:
Fixes #1270
Did you add tests for your changes?
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Checks linting rules only for files that are staged for commit, will work with any changes to eslint or prettier configuration.
Uses lint-staged package with existing git hooks
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?
Yes